[jira] [Commented] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023007#comment-16023007
 ] 

ASF GitHub Bot commented on FLINK-5376:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3948


> Misleading log statements in UnorderedStreamElementQueue
> 
>
> Key: FLINK-5376
> URL: https://issues.apache.org/jira/browse/FLINK-5376
> Project: Flink
>  Issue Type: Bug
>  Components: DataStream API
>Reporter: Ted Yu
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> The following are two examples where ordered stream element queue is 
> mentioned:
> {code}
> LOG.debug("Put element into ordered stream element queue. New filling 
> degree " +
>   "({}/{}).", numberEntries, capacity);
> return true;
>   } else {
> LOG.debug("Failed to put element into ordered stream element queue 
> because it " +
> {code}
> I guess OrderedStreamElementQueue was coded first.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022668#comment-16022668
 ] 

ASF GitHub Bot commented on FLINK-5376:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3948
  
merging.


> Misleading log statements in UnorderedStreamElementQueue
> 
>
> Key: FLINK-5376
> URL: https://issues.apache.org/jira/browse/FLINK-5376
> Project: Flink
>  Issue Type: Bug
>  Components: DataStream API
>Reporter: Ted Yu
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The following are two examples where ordered stream element queue is 
> mentioned:
> {code}
> LOG.debug("Put element into ordered stream element queue. New filling 
> degree " +
>   "({}/{}).", numberEntries, capacity);
> return true;
>   } else {
> LOG.debug("Failed to put element into ordered stream element queue 
> because it " +
> {code}
> I guess OrderedStreamElementQueue was coded first.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021149#comment-16021149
 ] 

ASF GitHub Bot commented on FLINK-5376:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/3948
  
+1 to merge.


> Misleading log statements in UnorderedStreamElementQueue
> 
>
> Key: FLINK-5376
> URL: https://issues.apache.org/jira/browse/FLINK-5376
> Project: Flink
>  Issue Type: Bug
>  Components: DataStream API
>Reporter: Ted Yu
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The following are two examples where ordered stream element queue is 
> mentioned:
> {code}
> LOG.debug("Put element into ordered stream element queue. New filling 
> degree " +
>   "({}/{}).", numberEntries, capacity);
> return true;
>   } else {
> LOG.debug("Failed to put element into ordered stream element queue 
> because it " +
> {code}
> I guess OrderedStreamElementQueue was coded first.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017331#comment-16017331
 ] 

ASF GitHub Bot commented on FLINK-5376:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/3948

[FLINK-5376] Fix log statement in UnorderedStreamElementQueue



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 5376_log_element

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3948


commit a90c11835d729c0769518f61818aa2afa98bb5a8
Author: zentol 
Date:   2017-05-19T12:33:18Z

[FLINK-5376] Fix log statement in UnorderedStreamElementQueue




> Misleading log statements in UnorderedStreamElementQueue
> 
>
> Key: FLINK-5376
> URL: https://issues.apache.org/jira/browse/FLINK-5376
> Project: Flink
>  Issue Type: Bug
>  Components: DataStream API
>Reporter: Ted Yu
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The following are two examples where ordered stream element queue is 
> mentioned:
> {code}
> LOG.debug("Put element into ordered stream element queue. New filling 
> degree " +
>   "({}/{}).", numberEntries, capacity);
> return true;
>   } else {
> LOG.debug("Failed to put element into ordered stream element queue 
> because it " +
> {code}
> I guess OrderedStreamElementQueue was coded first.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)