[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901566#comment-15901566
 ] 

ASF GitHub Bot commented on FLINK-5983:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3489


> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Fabian Hueske
> Fix For: 1.3.0
>
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901545#comment-15901545
 ] 

ASF GitHub Bot commented on FLINK-5983:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3489
  
Thanks @fhueske. I could not find anything suspicious. I will rebase and 
merge this...


> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Fabian Hueske
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900213#comment-15900213
 ] 

ASF GitHub Bot commented on FLINK-5983:
---

GitHub user fhueske opened a pull request:

https://github.com/apache/flink/pull/3489

[FLINK-5983] [table] Convert FOR into WHILE loops for aggregation functions.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fhueske/flink tableForToWhile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3489


commit ed336b3970acbfb6b71345745945070ec384442d
Author: Fabian Hueske 
Date:   2017-03-07T21:17:54Z

[FLINK-5983] [table] Convert FOR into WHILE loops for aggregation functions.




> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Fabian Hueske
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[Shaoxuan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899620#comment-15899620
 ] 

Shaoxuan Wang commented on FLINK-5983:
--

ok, the plan sounds good to me. The runtime processing function for aggregate 
will be codeGened, and it is user's call to use java or scala user defined 
aggregate functions  and if it is written in scala the user is responsible 
for the performance.

> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[Shaoxuan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899619#comment-15899619
 ] 

Shaoxuan Wang commented on FLINK-5983:
--

ok, the plan sounds good to me. The runtime processing function for aggregate 
will be codeGened, and it is user's call to use java or scala user defined 
aggregate functions  and if it is written in scala the user is responsible 
for the performance.

> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[Timo Walther (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899606#comment-15899606
 ] 

Timo Walther commented on FLINK-5983:
-

We thought about that multiple times, but the consensus was to let the Table 
API be implemented entirely in Scala (no mixture of different languages). In a 
long-term perspective we will code generate the content of the functions 
anyway, so there will be only Java code executed during runtime and only some 
Scala code in the open() functions.

> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[Shaoxuan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899594#comment-15899594
 ] 

Shaoxuan Wang commented on FLINK-5983:
--

Can we consider implementing the runtime code and even the built-in aggregate 
functions in Java

> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5983) Replace for/foreach/map in aggregates by while loops

[Shaoxuan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899577#comment-15899577
 ] 

Shaoxuan Wang commented on FLINK-5983:
--

 I love this proposal to replace scala for loops by while loops in the runtime 
functions. Thanks [~twalthr].

> Replace for/foreach/map in aggregates by while loops
> 
>
> Key: FLINK-5983
> URL: https://issues.apache.org/jira/browse/FLINK-5983
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Right now there is a mixture of different kinds of loops within aggregate 
> functions. Although performance is not the main goal at the moment, we should 
> focus on performant execution especially in this runtime functions.
> e.g. {{DataSetTumbleCountWindowAggReduceGroupFunction}}
> We should replace loops, maps etc. by primitive while loops.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)