[jira] [Commented] (FLINK-5984) Add resetAccumulator method for AggregateFunction
[
https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902889#comment-15902889
]
ASF GitHub Bot commented on FLINK-5984:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3496
> Add resetAccumulator method for AggregateFunction
> -
>
> Key: FLINK-5984
> URL: https://issues.apache.org/jira/browse/FLINK-5984
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Shaoxuan Wang
> Fix For: 1.3.0
>
>
> Right now we have to create a new accumulator object if we just want to reset
> it. We should allow passing the old one as a {{reuse}} object to
> {{AggregateFunction#createAccumulator}}. The aggregate function then can
> decide if it wants to create a new object or reset the old one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5984) Add resetAccumulator method for AggregateFunction
[
https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902861#comment-15902861
]
ASF GitHub Bot commented on FLINK-5984:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3496
@fhueske and @shaoxuan-wang. I will rebase and merge this.
> Add resetAccumulator method for AggregateFunction
> -
>
> Key: FLINK-5984
> URL: https://issues.apache.org/jira/browse/FLINK-5984
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Shaoxuan Wang
>
> Right now we have to create a new accumulator object if we just want to reset
> it. We should allow passing the old one as a {{reuse}} object to
> {{AggregateFunction#createAccumulator}}. The aggregate function then can
> decide if it wants to create a new object or reset the old one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5984) Add resetAccumulator method for AggregateFunction
[
https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901574#comment-15901574
]
ASF GitHub Bot commented on FLINK-5984:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3496
Thanks @shaoxuan-wang. The PR looks good.
FLINK-5983 has been merged and FLINK-5963 will be merged soon.
It would be great if you could rebase your code on the master once that was
done.
Thanks, Fabian
> Add resetAccumulator method for AggregateFunction
> -
>
> Key: FLINK-5984
> URL: https://issues.apache.org/jira/browse/FLINK-5984
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Shaoxuan Wang
>
> Right now we have to create a new accumulator object if we just want to reset
> it. We should allow passing the old one as a {{reuse}} object to
> {{AggregateFunction#createAccumulator}}. The aggregate function then can
> decide if it wants to create a new object or reset the old one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5984) Add resetAccumulator method for AggregateFunction
[
https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901423#comment-15901423
]
ASF GitHub Bot commented on FLINK-5984:
---
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3496
@fhueske , do you have plan to merge FLINK-5983 and FLINK-5963 very soon?
This PR probably need rebase once your two PRs are merged, as changes are
overlapped.
> Add resetAccumulator method for AggregateFunction
> -
>
> Key: FLINK-5984
> URL: https://issues.apache.org/jira/browse/FLINK-5984
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Shaoxuan Wang
>
> Right now we have to create a new accumulator object if we just want to reset
> it. We should allow passing the old one as a {{reuse}} object to
> {{AggregateFunction#createAccumulator}}. The aggregate function then can
> decide if it wants to create a new object or reset the old one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5984) Add resetAccumulator method for AggregateFunction
[
https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901405#comment-15901405
]
ASF GitHub Bot commented on FLINK-5984:
---
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3496
[FLINK-5984] [table] add resetAccumulator method for AggregateFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaoxuan-wang/flink F5984-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3496
commit d60ef3e67736c6cf366a486d0c57b13874c381bd
Author: shaoxuan-wang
Date: 2017-03-08T15:10:28Z
[FLINK-5984] [table] add resetAccumulator method for AggregateFunction
> Add resetAccumulator method for AggregateFunction
> -
>
> Key: FLINK-5984
> URL: https://issues.apache.org/jira/browse/FLINK-5984
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Shaoxuan Wang
>
> Right now we have to create a new accumulator object if we just want to reset
> it. We should allow passing the old one as a {{reuse}} object to
> {{AggregateFunction#createAccumulator}}. The aggregate function then can
> decide if it wants to create a new object or reset the old one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
