[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-10-14 Thread Stephan Ewen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204703#comment-16204703
 ] 

Stephan Ewen commented on FLINK-5989:
-

This issue should be solved through the the Akka upgrade in FLINK-7810

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
> Fix For: 1.4.0
>
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-04-01 Thread Wenlong Lyu (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952094#comment-15952094
 ] 

Wenlong Lyu commented on FLINK-5989:


hi, [~rmetzger], have you ever try add a module like flink-shade-akka-remote to 
solve the problem
{code}
http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>

4.0.0


org.apache.flink
flink-parent
1.3-blink-1.1-SNAPSHOT
..


flink-shaded-akka-remote
flink-shaded-akka-remote

jar



com.data-artisans

flakka-remote_${scala.binary.version}
${akka.version}








org.apache.maven.plugins
maven-shade-plugin



shade-flink
none


shade-akka
package

shade



false

true

${project.basedir}/target/dependency-reduced-pom.xml

true








com.google.protobuf:*





com.google

org.apache.flink.akka.shaded.com.google



com.google.inject.**












{/code}

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-24 Thread Robert Metzger (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940291#comment-15940291
 ] 

Robert Metzger commented on FLINK-5989:
---

Yes, I've tried doing this some time ago, but without success.
We can only solve this issue once we move to a newer Akka version (this also 
means requiring Java8): 
https://issues.apache.org/jira/browse/FLINK-3211?focusedCommentId=15274018=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15274018
 

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-24 Thread Robert Metzger (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940292#comment-15940292
 ] 

Robert Metzger commented on FLINK-5989:
---

Yes, I've tried doing this some time ago, but without success.
We can only solve this issue once we move to a newer Akka version (this also 
means requiring Java8): 
https://issues.apache.org/jira/browse/FLINK-3211?focusedCommentId=15274018=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15274018
 

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-23 Thread Aljoscha Krettek (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938467#comment-15938467
 ] 

Aljoscha Krettek commented on FLINK-5989:
-

[~rmetzger] could you maybe have a look at this? I think you know best how the 
rest of our shading works.

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-07 Thread Wenlong Lyu (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900651#comment-15900651
 ] 

Wenlong Lyu commented on FLINK-5989:


[~mxm] I found that you change the dependency on akka to a data-artisan custom 
version. Can you add shade setting in the custom akka project？Or we need to add 
a flink-shaded-akka module?

> Protobuf in akka needs to be shaded
> ---
>
> Key: FLINK-5989
> URL: https://issues.apache.org/jira/browse/FLINK-5989
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Wenlong Lyu
>
> Currently akka introduces dependency on protobuf, which is a common jar used 
> in many systems, I think we need to use a shaded akka like what we do in 
> dependency on hadoop to avoid version conflicts with user code.
> {code}
> [INFO] +- com.data-artisans:flakka-actor_2.10:jar:2.3-custom:compile
> [INFO] |  \- com.typesafe:config:jar:1.2.1:compile
> [INFO] +- com.data-artisans:flakka-remote_2.10:jar:2.3-custom:compile
> [INFO] |  +- io.netty:netty:jar:3.8.0.Final:compile
> [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> [INFO] |  \- org.uncommons.maths:uncommons-maths:jar:1.2.2a:compile
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)