[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083312#comment-16083312
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel closed the pull request at:

https://github.com/apache/flink/pull/3921


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083311#comment-16083311
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3921
  
Thank you for merging it @aljoscha 


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081957#comment-16081957
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3921
  
Thanks!  I merged this, could you please close the PR?


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080061#comment-16080061
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3921
  
I have fixed it, thanks @aljoscha 


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078090#comment-16078090
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3921
  
@zjureel It seems `CliFrontendRunTest` fails because the expected 
parallelism is not `-1` anymore 
https://travis-ci.org/apache/flink/jobs/251014376. After fixing this, let's see 
if any other tests fail.


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077518#comment-16077518
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3921
  
I have updated the code according to your suggestion, please have a look 
when you are free, thanks :)


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077495#comment-16077495
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3921
  
@aljoscha Sorry for replying late, your suggestion sounds good to me. In 
fact, I was hesitating to add `getDefaultParallelism()` in `ContextEnvironment` 
and `ClusterClient` for there have been `getParallelism()` in 
`ContextEnvironment`. Thank you for your suggestion, I will fix it as you 
suggested soon :)


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-06-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069967#comment-16069967
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3921
  
I think we can get by without changing `ClusterClient` and 
`ContextEnvironment` by only reading the parallelism from the global config in 
`CliFrontend` when trying to read the user parallelism from the parameters, 
i.e. in `run()` and `info()`. In the example of `run()` we could change this 
code:
```
int userParallelism = options.getParallelism();
LOG.debug("User parallelism is set to {}", userParallelism);
if (client.getMaxSlots() != -1 && userParallelism == -1) {
logAndSysout("Using the parallelism provided by the remote cluster ("
+ client.getMaxSlots() + "). "
+ "To use another parallelism, set it at the ./bin/flink 
client.");
userParallelism = client.getMaxSlots();
}
return executeProgram(program, client, userParallelism);
```
to this
```
int parallelism = options.getParallelism();
LOG.debug("User parallelism is set to {}", parallelism);
if (client.getMaxSlots() != -1 && parallelism == -1) {
logAndSysout("Using the parallelism provided by the remote cluster ("
+ client.getMaxSlots() + "). "
+ "To use another parallelism, set it at the ./bin/flink 
client.");
parallelism = client.getMaxSlots();
} else if (parallelism == ExecutionConfig.PARALLELISM_DEFAULT) {
parallelism = GlobalConfiguration.loadConfiguration().getInteger(
ConfigConstants.DEFAULT_PARALLELISM_KEY,
ConfigConstants.DEFAULT_PARALLELISM);
}

return executeProgram(program, client, parallelism);
```
with this change `StreamContextEnvironment` would simply need this:
```
if (ctx.getParallelism() > 0) {
setParallelism(ctx.getParallelism());
}
```
because the environment will have the default parallelism set (in 
`ContextEnvironmentFactory` 
https://github.com/apache/flink/blob/c793ea41d88fe84fa97d825728ad95f35e27ef82/flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironmentFactory.java#L52-L52)

What do you think?



> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-06-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059070#comment-16059070
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3921
  
@zentol Thank you for your comment, I have fixed the problem you metioned. 
Could you please review the new commit when you are free? Thanks


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-05-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019464#comment-16019464
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3921
  
According to the JIRA neither environment should access the global 
configuration, but instead either pass it through a setter or constructor 
argument.


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012126#comment-16012126
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

GitHub user zjureel opened a pull request:

https://github.com/apache/flink/pull/3921

[FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [ ] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjureel/flink FLINK-6058

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3921


commit 808f252f64ac96569a16ba3d0a020ad978983513
Author: zjureel 
Date:   2017-05-16T07:58:10Z

fix read DEFAULT_PARALLELISM from ContextEnvironment




> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-05-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010297#comment-16010297
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user fanyon closed the pull request at:

https://github.com/apache/flink/pull/3561


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-03-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932591#comment-15932591
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3561
  
Thanks for reminding, @uce  Already had this on my list.

The only code that reads the DEFAULT_PARALLELISM from the config should be 
in this piece of code in `CliFrontend`: 
https://github.com/apache/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java#L250.
 Here, we should check whether the user directly specified a parallelism and if 
not read the one from the config. From there the parameter is already passed to 
`ClusterClient.run()` where a a `ContextEnvironmentFactory` is being created. 
In `ContextEnvironmentFactory.createExecutionEnvironment()` we would thus have 
this parallelism.

The question now is whether to keep the 
`lastEnvCreated.setParallelism(defaultParallelism)` or pass the default 
parallelism to the `ContextEnvironment` so that the 
`StreamExecutionEnvironment` can pick it up from there in the constructor. The 
problem with calling `env.setParallelism()` is that the default parallelism 
will be "forgotten" if the user calls `env.setParallelism(PARALLELISM_DEFAULT)` 
where `ExecutionConfig.PARALLELISM_DEFAULT == -1`. If we manually store the 
default parallelism in an extra field we would keep it. This seems to be the 
nicer solution.


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.3.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-03-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932410#comment-15932410
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/3561
  
@aljoscha Could you have a brief look at this?


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.3.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929719#comment-15929719
 ] 

ASF GitHub Bot commented on FLINK-6058:
---

GitHub user fanyon opened a pull request:

https://github.com/apache/flink/pull/3561

[FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment

fix read DEFAULT_PARALLELISM from ContextEnvironment

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fanyon/flink FLINK-6058

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3561


commit 446cec49e1aa75c4258c07994d0c5ae18ea0c128
Author: mengji.fy 
Date:   2017-03-17T10:33:34Z

[FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment




> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.3.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-03-16 Thread fang yong (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927578#comment-15927578
 ] 

fang yong commented on FLINK-6058:
--

Read default parallelism from ContextEnviroment sounds good. But what makes me 
contradictory is whether there should be a method such as setDefaultParallelism 
and the client can set the value manually?

> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> ---
>
> Key: FLINK-6058
> URL: https://issues.apache.org/jira/browse/FLINK-6058
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.3.0
>
>
> In the constructor of {{StreamContextEnvironment}} we read the 
> {{DEFAULT_PARALLELISM}} from the {{GlobalConfiguration}}. This assumes that 
> the environment variables are correctly set and can lead to problems. We 
> should read the default parallelism in the client and set it in the 
> {{ContextEnvironment}} that it creates. This can then be read by the 
> {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)