[jira] [Commented] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
[
https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943318#comment-15943318
]
ASF GitHub Bot commented on FLINK-6169:
---
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/3608
> yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
> --
>
> Key: FLINK-6169
> URL: https://issues.apache.org/jira/browse/FLINK-6169
> Project: Flink
> Issue Type: Bug
> Components: YARN
>Reporter: Ted Yu
>Priority: Minor
>
> Here is one example:
> {code}
> if(jobManagerMemoryMb > maxRes.getMemory() ) {
> failSessionDuringDeployment(yarnClient, yarnApplication);
> throw new YarnDeploymentException("The cluster does not have the
> requested resources for the JobManager available!\n"
> + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " +
> jobManagerMemoryMb + "MB. " + NOTE);
> }
> {code}
> yarnClient should be stopped when deployment fails.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
[
https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943248#comment-15943248
]
ASF GitHub Bot commented on FLINK-6169:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3608#discussion_r108166257
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -507,12 +507,14 @@ protected YarnClusterClient deployInternal() throws
Exception {
final String NOTE = "Please check the
'yarn.scheduler.maximum-allocation-mb' and the
'yarn.nodemanager.resource.memory-mb' configuration values\n";
if(jobManagerMemoryMb > maxRes.getMemory() ) {
failSessionDuringDeployment(yarnClient,
yarnApplication);
+ yarnClient.stop();
--- End diff --
This is already called in `failSessionDuringDeployment`.
> yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
> --
>
> Key: FLINK-6169
> URL: https://issues.apache.org/jira/browse/FLINK-6169
> Project: Flink
> Issue Type: Bug
> Components: YARN
>Reporter: Ted Yu
>Priority: Minor
>
> Here is one example:
> {code}
> if(jobManagerMemoryMb > maxRes.getMemory() ) {
> failSessionDuringDeployment(yarnClient, yarnApplication);
> throw new YarnDeploymentException("The cluster does not have the
> requested resources for the JobManager available!\n"
> + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " +
> jobManagerMemoryMb + "MB. " + NOTE);
> }
> {code}
> yarnClient should be stopped when deployment fails.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
[
https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940669#comment-15940669
]
ASF GitHub Bot commented on FLINK-6169:
---
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/3608
FLINK-6169 yarnClient should be stopped in AbstractYarnClusterDescriptor in
case of error
Stop yarnClient before throwing exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3608
commit f0528de9cc03f603b77d6adcd222ff085967b614
Author: tedyu
Date: 2017-03-24T16:30:31Z
FLINK-6169 yarnClient should be stopped in AbstractYarnClusterDescriptor in
case of error
> yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
> --
>
> Key: FLINK-6169
> URL: https://issues.apache.org/jira/browse/FLINK-6169
> Project: Flink
> Issue Type: Bug
> Components: YARN
>Reporter: Ted Yu
>Priority: Minor
>
> Here is one example:
> {code}
> if(jobManagerMemoryMb > maxRes.getMemory() ) {
> failSessionDuringDeployment(yarnClient, yarnApplication);
> throw new YarnDeploymentException("The cluster does not have the
> requested resources for the JobManager available!\n"
> + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " +
> jobManagerMemoryMb + "MB. " + NOTE);
> }
> {code}
> yarnClient should be stopped when deployment fails.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
[
https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940609#comment-15940609
]
Till Rohrmann commented on FLINK-6169:
--
Good point [~te...@apache.org]. Do you wanna take a stab at it?
> yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error
> --
>
> Key: FLINK-6169
> URL: https://issues.apache.org/jira/browse/FLINK-6169
> Project: Flink
> Issue Type: Bug
> Components: YARN
>Reporter: Ted Yu
>Priority: Minor
>
> Here is one example:
> {code}
> if(jobManagerMemoryMb > maxRes.getMemory() ) {
> failSessionDuringDeployment(yarnClient, yarnApplication);
> throw new YarnDeploymentException("The cluster does not have the
> requested resources for the JobManager available!\n"
> + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " +
> jobManagerMemoryMb + "MB. " + NOTE);
> }
> {code}
> yarnClient should be stopped when deployment fails.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
