[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020070#comment-16020070
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user zentol closed the pull request at:

https://github.com/apache/flink/pull/3946


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019708#comment-16019708
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3946#discussion_r117775543
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade 
---
@@ -28,10 +28,10 @@ split
 a(ui-sref=".subtasks({nodeid: nodeid})") Subtasks
 
   li(ui-sref-active='active')
-a(ui-sref=".taskmanagers({nodeid: nodeid})") TaskManagers
+a(ui-sref=".taskmanagers({nodeid: nodeid})") Subtasks by 
TaskManager
--- End diff --

OK. I'll merge the PR for both versions and create a follow-up JIRA.


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019706#comment-16019706
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/3946#discussion_r117775128
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade 
---
@@ -28,10 +28,10 @@ split
 a(ui-sref=".subtasks({nodeid: nodeid})") Subtasks
 
   li(ui-sref-active='active')
-a(ui-sref=".taskmanagers({nodeid: nodeid})") TaskManagers
+a(ui-sref=".taskmanagers({nodeid: nodeid})") Subtasks by 
TaskManager
--- End diff --

@zentol that would be a nice improvement for the next release. I think this 
PR is good to merge for 1.3 and master.


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019638#comment-16019638
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3946#discussion_r117760655
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade 
---
@@ -28,10 +28,10 @@ split
 a(ui-sref=".subtasks({nodeid: nodeid})") Subtasks
 
   li(ui-sref-active='active')
-a(ui-sref=".taskmanagers({nodeid: nodeid})") TaskManagers
+a(ui-sref=".taskmanagers({nodeid: nodeid})") Subtasks by 
TaskManager
--- End diff --

How about merging the two tabs, and adding a checkbox to "aggregate by 
TaskManager"?


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018822#comment-16018822
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/3946#discussion_r117632701
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade 
---
@@ -28,10 +28,10 @@ split
 a(ui-sref=".subtasks({nodeid: nodeid})") Subtasks
 
   li(ui-sref-active='active')
-a(ui-sref=".taskmanagers({nodeid: nodeid})") TaskManagers
+a(ui-sref=".taskmanagers({nodeid: nodeid})") Subtasks by 
TaskManager
--- End diff --

@greghogan Hmmm, how should we call them? I have been asked a lot of times 
what the "TaskManagers" tab means. Especially, because when running one slot 
TaskManagers (which is super common), it is identical to the "Subtasks" view.

I am just looking for a name that solves that confusion.


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017514#comment-16017514
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/3946#discussion_r117504104
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade 
---
@@ -28,10 +28,10 @@ split
 a(ui-sref=".subtasks({nodeid: nodeid})") Subtasks
 
   li(ui-sref-active='active')
-a(ui-sref=".taskmanagers({nodeid: nodeid})") TaskManagers
+a(ui-sref=".taskmanagers({nodeid: nodeid})") Subtasks by 
TaskManager
--- End diff --

The subtask statistics are aggregated by TaskManager so I'm not sure this 
is an improvement. @StephanEwen?


> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6446) Various improvements to the Web Frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017324#comment-16017324
 ] 

ASF GitHub Bot commented on FLINK-6446:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/3946

[FLINK-6446] Fix some small issues in the web UI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6446_web_ui

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3946


commit 52dc839a7ef4a41a5738637342347fbc2070800b
Author: zentol 
Date:   2017-05-19T10:03:45Z

[FLINK-6450][web] Rename "TaskManagers" tab to "Subtasks by Taskmanager"

commit 2587b45309384693c67e29b05b374f5dd047ab9a
Author: zentol 
Date:   2017-05-19T10:04:21Z

[FLINK-6451][web] Rename "Metrics" tab to "Task Metrics"

commit 601aca0a80271a2bbcb4c4900798401d80c0d40a
Author: zentol 
Date:   2017-05-19T10:05:10Z

[FLINK-6448][web] Rename "Free Memory" field to "JVM Heap Size"

commit b5d16f3af2e7f5079f921266e185ba6fc9792238
Author: zentol 
Date:   2017-05-19T10:10:07Z

Rebuild webUI




> Various improvements to the Web Frontend
> 
>
> Key: FLINK-6446
> URL: https://issues.apache.org/jira/browse/FLINK-6446
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Stephan Ewen
>
> This is the umbrella issue for various improvements to the web frontend,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)