[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021252#comment-16021252
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3898


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021109#comment-16021109
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/3898
  
ah ... yes indeed, thanks for reminding me. I'll merge this to master and 
1.3; it should be ok if it ends up missing in the 1.3.0 release.


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021101#comment-16021101
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3898
  
@tzulitai Did you forget about this PR? :)


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016905#comment-16016905
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/3898
  
Hi, @huafengw Welcome also.


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016895#comment-16016895
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user huafengw commented on the issue:

https://github.com/apache/flink/pull/3898
  
Thank you guys :)


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016877#comment-16016877
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user gallenvara commented on the issue:

https://github.com/apache/flink/pull/3898
  
Hi, @huafengw . Welcome to Flink family. Thanks for your PR and the changes 
look good to me. :)


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016874#comment-16016874
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/3898
  
Hi @huafengw, thanks for the fixes! I'll probably merge this along with 
#3937 as there are some overlapping changes here and there.


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016774#comment-16016774
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user huafengw commented on the issue:

https://github.com/apache/flink/pull/3898
  
Hi @tzulitai, I'm new to Flink and would you mind taking a look at this one?


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012399#comment-16012399
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

Github user huafengw commented on the issue:

https://github.com/apache/flink/pull/3898
  
Can anyone take a look at this one?


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010127#comment-16010127
 ] 

ASF GitHub Bot commented on FLINK-6492:
---

GitHub user huafengw opened a pull request:

https://github.com/apache/flink/pull/3898

[FLINK-6492] Fix unclosed DataOutputViewStream usage

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [ ] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huafengw/flink fix6492

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3898.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3898


commit 3a2e981efd5fffd25d551331af5b422a0812e802
Author: huafengw 
Date:   2017-05-15T07:56:19Z

[FLINK-6492] Fix unclosed DataOutputViewStream usage




> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-14 Thread Huafeng Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010006#comment-16010006
 ] 

Huafeng Wang commented on FLINK-6492:
-

If nobody is woking on this, I'd like to take this one.

> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -
>
> Key: FLINK-6492
> URL: https://issues.apache.org/jira/browse/FLINK-6492
> Project: Flink
>  Issue Type: Bug
>  Components: State Backends, Checkpointing
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
>InstantiationUtil.serializeObject(new DataOutputViewStream(out), 
> componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)