[jira] [Commented] (FLINK-6576) Allow ConfigOptions to validate the configured value

2017-05-19 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017507#comment-16017507
 ] 

Chesnay Schepler commented on FLINK-6576:
-

[~greghogan] wrong issue? :) Think you're looking for FLINK-6628.

> Allow ConfigOptions to validate the configured value
> 
>
> Key: FLINK-6576
> URL: https://issues.apache.org/jira/browse/FLINK-6576
> Project: Flink
>  Issue Type: Wish
>  Components: Configuration
>Reporter: Chesnay Schepler
>Priority: Trivial
>
> It is not unusual for a config parameter to only accept certain values. Ports 
> may not be negative, modes way essentially be enums, and file paths must not 
> be gibberish.
> Currently these validations happen manually after the value was extracted 
> from the {{Configuration}}.
> I want to start a discussion on whether we want to move this validation into 
> the ConfigOption itself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6576) Allow ConfigOptions to validate the configured value

2017-05-19 Thread Greg Hogan (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017493#comment-16017493
 ] 

Greg Hogan commented on FLINK-6576:
---

I happend to also look at this and in addition to {{taskmanager.sh}} the 
{{flink-daemon.sh}} log rotation needs escaping: {{rotateLogFilesWithPrefix 
"$FLINK_LOG_DIR" "$FLINK_LOG_PREFIX"}}.

> Allow ConfigOptions to validate the configured value
> 
>
> Key: FLINK-6576
> URL: https://issues.apache.org/jira/browse/FLINK-6576
> Project: Flink
>  Issue Type: Wish
>  Components: Configuration
>Reporter: Chesnay Schepler
>Priority: Trivial
>
> It is not unusual for a config parameter to only accept certain values. Ports 
> may not be negative, modes way essentially be enums, and file paths must not 
> be gibberish.
> Currently these validations happen manually after the value was extracted 
> from the {{Configuration}}.
> I want to start a discussion on whether we want to move this validation into 
> the ConfigOption itself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)