[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028165#comment-16028165
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user zentol closed the pull request at:

https://github.com/apache/flink/pull/4005


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028162#comment-16028162
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4005
  
merging.


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027950#comment-16027950
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4005
  
+1 failing test is unrelated. Thanks for correcting this @zentol!


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027895#comment-16027895
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4005

[FLINK-6699] Add checkstyle plugin to flink-yarn-tests pom

Adds the checkstyle plugin to the `flink-yarn-tests` pom and fixes 
remaining issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6699csyt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4005


commit 93d2b2b6f610a72fe45d3b7c8ead24865dd8d2b7
Author: zentol 
Date:   2017-05-28T18:14:50Z

[FLINK-6699] Add checkstyle plugin to flink-yarn-tests pom




> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027882#comment-16027882
 ] 

Greg Hogan commented on FLINK-6699:
---

[~Zentol] it looks like we forgot to activate the checkstyle in this module 
({{CliFrontendYarnAddressConfigurationTest}} has import errors).

> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024551#comment-16024551
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3985


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024421#comment-16024421
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3985
  
merging.


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023645#comment-16023645
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3985
  
+1 with green from Travis


> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6699) Activate strict-checkstyle in flink-yarn-tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023602#comment-16023602
 ] 

ASF GitHub Bot commented on FLINK-6699:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/3985

[FLINK-6699] Activate strict checkstyle for flink-yarn-tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6699_checkstyle_yarnt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3985.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3985


commit 1c377d1b82047a17d1dfb903d0a6b033b88b7f64
Author: zentol 
Date:   2017-05-24T10:42:28Z

[FLINK-6699] Activate strict checkstyle for flink-yarn-tests




> Activate strict-checkstyle in flink-yarn-tests
> --
>
> Key: FLINK-6699
> URL: https://issues.apache.org/jira/browse/FLINK-6699
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests, YARN
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)