[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069756#comment-16069756
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user zentol closed the pull request at:

https://github.com/apache/flink/pull/3984


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028399#comment-16028399
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3984
  
Yes, a generic JsonInputFormat would be a nice addition.


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028319#comment-16028319
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3984
  
Then let's replace it with a generic JsonInputFormat that supports even 
more use-cases without 1900 lines of bloat.


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028297#comment-16028297
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3984
  
Maybe we should discuss this on the ML. I know at least one user that used 
it for fast prototyping a Flink demo application. Maybe it adds not much value 
but allows for quickly showing a nice streaming demo. 


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023584#comment-16023584
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3984
  
sure. no problem.


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023571#comment-16023571
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/3984
  
+1 to remove it (however, please merge this only after at least one other 
PMC member also +1ed and after some time passed. I don't want to cause any 
discussions afterwards)


> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023548#comment-16023548
 ] 

ASF GitHub Bot commented on FLINK-6710:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/3984

[FLINK-6710] Remove Twitter-InputFormat

This PR removes the twitter InputFormat as it doesn't provide any 
significant functionality.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6710_dead_bird

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3984


commit da74f9173d4280785a62abed84ee756963049602
Author: zentol 
Date:   2017-05-24T19:48:31Z

[FLINK-6710] Remove Twitter-InputFormat




> Remove twitter-inputformat
> --
>
> Key: FLINK-6710
> URL: https://issues.apache.org/jira/browse/FLINK-6710
> Project: Flink
>  Issue Type: Improvement
>  Components: Batch Connectors and Input/Output Formats
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.4.0
>
>
> I propose removing the twitter-inputformat under flink-contrib.
> It provides no interesting properties in terms of accessing tweets (since it 
> just reads them from a file) in contrast to the streaming {{TwitterSource}}, 
> nor provides any significant functionality that cannot be achieved using the 
> jackson databind API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)