[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073335#comment-16073335 ] ASF GitHub Bot commented on FLINK-6773: --- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4130 Merged in 5171513a3c. > Use compression (e.g. snappy) for full check/savepoints > --- > > Key: FLINK-6773 > URL: https://issues.apache.org/jira/browse/FLINK-6773 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing >Reporter: Stefan Richter >Assignee: Stefan Richter > > We could use compression (e.g. snappy stream compression) to decrease the > size of our full checkpoints and savepoints. From some initial experiments, I > think there is great potential to achieve compression rates around 30-50%. > Given those numbers, I think this is very low hanging fruit to implement. > One point to consider in the implementation is that compression blocks should > respect key-groups, i.e. typically it should make sense to compress per > key-group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073334#comment-16073334 ] ASF GitHub Bot commented on FLINK-6773: --- Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/4130 > Use compression (e.g. snappy) for full check/savepoints > --- > > Key: FLINK-6773 > URL: https://issues.apache.org/jira/browse/FLINK-6773 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing >Reporter: Stefan Richter >Assignee: Stefan Richter > > We could use compression (e.g. snappy stream compression) to decrease the > size of our full checkpoints and savepoints. From some initial experiments, I > think there is great potential to achieve compression rates around 30-50%. > Given those numbers, I think this is very low hanging fruit to implement. > One point to consider in the implementation is that compression blocks should > respect key-groups, i.e. typically it should make sense to compress per > key-group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073331#comment-16073331 ] ASF GitHub Bot commented on FLINK-6773: --- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4130 Thanks for the review @tillrohrmann! I will address your comments and proceed with merging. > Use compression (e.g. snappy) for full check/savepoints > --- > > Key: FLINK-6773 > URL: https://issues.apache.org/jira/browse/FLINK-6773 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing >Reporter: Stefan Richter >Assignee: Stefan Richter > > We could use compression (e.g. snappy stream compression) to decrease the > size of our full checkpoints and savepoints. From some initial experiments, I > think there is great potential to achieve compression rates around 30-50%. > Given those numbers, I think this is very low hanging fruit to implement. > One point to consider in the implementation is that compression blocks should > respect key-groups, i.e. typically it should make sense to compress per > key-group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071289#comment-16071289
]
ASF GitHub Bot commented on FLINK-6773:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4130#discussion_r125163526
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateSnapshotCompressionTest.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.state;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.base.StringSerializer;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.query.TaskKvStateRegistry;
+import org.apache.flink.runtime.state.heap.HeapKeyedStateBackend;
+import org.apache.flink.runtime.state.heap.HeapReducingStateTest;
+import org.apache.flink.runtime.state.internal.InternalValueState;
+import org.apache.flink.runtime.state.memory.MemCheckpointStreamFactory;
+
+import org.apache.commons.io.IOUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.concurrent.RunnableFuture;
+
+import static org.mockito.Mockito.mock;
+
+public class StateSnapshotCompressionTest {
--- End diff --
Good to let the `StateSnapshotCompressionTest` extend the `TestLogger`.
> Use compression (e.g. snappy) for full check/savepoints
> ---
>
> Key: FLINK-6773
> URL: https://issues.apache.org/jira/browse/FLINK-6773
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
>Reporter: Stefan Richter
>Assignee: Stefan Richter
>
> We could use compression (e.g. snappy stream compression) to decrease the
> size of our full checkpoints and savepoints. From some initial experiments, I
> think there is great potential to achieve compression rates around 30-50%.
> Given those numbers, I think this is very low hanging fruit to implement.
> One point to consider in the implementation is that compression blocks should
> respect key-groups, i.e. typically it should make sense to compress per
> key-group.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050508#comment-16050508
]
ASF GitHub Bot commented on FLINK-6773:
---
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4130
[FLINK-6773] [checkpoint] Introduce compression (snappy) for keyed st…
This PR introduce optional snappy compression for the keyed state in full
checkpoints and savepoints. This feature can be activated through a flag in
{{ExecutionConfig}}.
For the future, we can also support user-defined compression schemes, which
will also require a upgrade and compatibility feature, as described in
FLINK-6931.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink compressedKeyGroups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4130
> Use compression (e.g. snappy) for full check/savepoints
> ---
>
> Key: FLINK-6773
> URL: https://issues.apache.org/jira/browse/FLINK-6773
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
>Reporter: Stefan Richter
>Assignee: Stefan Richter
>
> We could use compression (e.g. snappy stream compression) to decrease the
> size of our full checkpoints and savepoints. From some initial experiments, I
> think there is great potential to achieve compression rates around 30-50%.
> Given those numbers, I think this is very low hanging fruit to implement.
> One point to consider in the implementation is that compression blocks should
> respect key-groups, i.e. typically it should make sense to compress per
> key-group.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050513#comment-16050513 ] ASF GitHub Bot commented on FLINK-6773: --- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4130 CC @tillrohrmann > Use compression (e.g. snappy) for full check/savepoints > --- > > Key: FLINK-6773 > URL: https://issues.apache.org/jira/browse/FLINK-6773 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing >Reporter: Stefan Richter >Assignee: Stefan Richter > > We could use compression (e.g. snappy stream compression) to decrease the > size of our full checkpoints and savepoints. From some initial experiments, I > think there is great potential to achieve compression rates around 30-50%. > Given those numbers, I think this is very low hanging fruit to implement. > One point to consider in the implementation is that compression blocks should > respect key-groups, i.e. typically it should make sense to compress per > key-group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6773) Use compression (e.g. snappy) for full check/savepoints
[ https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046669#comment-16046669 ] mingleizhang commented on FLINK-6773: - +1 :) > Use compression (e.g. snappy) for full check/savepoints > --- > > Key: FLINK-6773 > URL: https://issues.apache.org/jira/browse/FLINK-6773 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing >Reporter: Stefan Richter > > We could use compression (e.g. snappy stream compression) to decrease the > size of our full checkpoints and savepoints. From some initial experiments, I > think there is great potential to achieve compression rates around 30-50%. > Given those numbers, I think this is very low hanging fruit to implement. > One point to consider in the implementation is that compression blocks should > respect key-groups, i.e. typically it should make sense to compress per > key-group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
