[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121487#comment-16121487
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4494


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119747#comment-16119747
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4494
  
merging.


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119633#comment-16119633
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/4494
  
@zentol I think it should be safe to remove that asm relocation (for 
Kinesis, as far as I'm aware of).


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119631#comment-16119631
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4494
  
Thank your for the review @greghogan . I made 2 more changes to the 
kinesis/shaded-curator poms; they were including/relocating asm in their 
shade-plugin configuration even though neither appears to have a dependency on 
asm.


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119032#comment-16119032
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4494
  
+1 LGTM


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117010#comment-16117010
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4494

[FLINK-7026] Introduce flink-shaded-asm-5

## What is the purpose of the change

This PR integrates the shaded asm dependency from flink-shaded. Basically, 
replace all usages of asm with the shaded asm dependeny and remove all traces 
of the original dependency.

## Brief change log

  - replace all asm dependencies with flink-shaded-asm
  - replace all asm imports
  - modify illegal import checkstyle rule to forbid unshaded asm imports
  - add check in travis watchdog that no unshaded asm classes are present 
in flink-dist

## Verifying this change

- check that compilation works
- check artifacts for inclusion of shaded asm
- check artifacts for exclusion of unshaded asm
- check that we are not exposing a vanilla asm dependency with maven
- start a cluster and run some examples
- check that the web interface still works

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 7026

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4494


commit 89083883e83d1cc5c558fda35e87ceeca9607104
Author: zentol 
Date:   2017-06-28T11:23:53Z

[FLINK-7026] Introduce flink-shaded-asm-5




> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067120#comment-16067120
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink-shaded/pull/5


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066817#comment-16066817
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink-shaded/pull/5
  
+1 to merge


> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066387#comment-16066387
 ] 

ASF GitHub Bot commented on FLINK-7026:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink-shaded/pull/5

[FLINK-7026] Add flink-shaded-asm-5 module



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink-shaded 7026

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink-shaded/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 2bae90ea80f335cb55cddc754aeeb33168430937
Author: zentol 
Date:   2017-06-28T11:13:34Z

[FLINK-7026] Add flink-shaded-asm-5 module




> Add shaded asm dependency
> -
>
> Key: FLINK-7026
> URL: https://issues.apache.org/jira/browse/FLINK-7026
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)