[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[ https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086710#comment-16086710 ] ASF GitHub Bot commented on FLINK-7173: --- Github user sunjincheng121 closed the pull request at: https://github.com/apache/flink/pull/4322 > Fix the illustration of tumbling window. > > > Key: FLINK-7173 > URL: https://issues.apache.org/jira/browse/FLINK-7173 > Project: Flink > Issue Type: Bug > Components: DataStream API, Documentation >Reporter: sunjincheng >Assignee: sunjincheng > Fix For: 1.4.0 > > Attachments: screenshot-1.png, screenshot-2.png > > > !screenshot-1.png! > Change it to : > !screenshot-2.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[ https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086711#comment-16086711 ] ASF GitHub Bot commented on FLINK-7173: --- Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4322 Sure! :) > Fix the illustration of tumbling window. > > > Key: FLINK-7173 > URL: https://issues.apache.org/jira/browse/FLINK-7173 > Project: Flink > Issue Type: Bug > Components: DataStream API, Documentation >Reporter: sunjincheng >Assignee: sunjincheng > Fix For: 1.4.0 > > Attachments: screenshot-1.png, screenshot-2.png > > > !screenshot-1.png! > Change it to : > !screenshot-2.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[ https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085870#comment-16085870 ] ASF GitHub Bot commented on FLINK-7173: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4322 @sunjincheng121 Thanks a lot! I merged, could you please close this PR? > Fix the illustration of tumbling window. > > > Key: FLINK-7173 > URL: https://issues.apache.org/jira/browse/FLINK-7173 > Project: Flink > Issue Type: Bug > Components: DataStream API, Documentation >Reporter: sunjincheng >Assignee: sunjincheng > Fix For: 1.4.0 > > Attachments: screenshot-1.png, screenshot-2.png > > > !screenshot-1.png! > Change it to : > !screenshot-2.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[ https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085668#comment-16085668 ] ASF GitHub Bot commented on FLINK-7173: --- Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4322 Yes @aljoscha I agree with you. I have updated the PR. -:) Thanks, Jincheng > Fix the illustration of tumbling window. > > > Key: FLINK-7173 > URL: https://issues.apache.org/jira/browse/FLINK-7173 > Project: Flink > Issue Type: Bug > Components: DataStream API, Documentation >Reporter: sunjincheng >Assignee: sunjincheng > Attachments: screenshot-1.png, screenshot-2.png > > > !screenshot-1.png! > Change it to : > !screenshot-2.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[ https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085642#comment-16085642 ] ASF GitHub Bot commented on FLINK-7173: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4322 While on this, I think it would also make sense to fix the picture for sliding windows, what do you think? > Fix the illustration of tumbling window. > > > Key: FLINK-7173 > URL: https://issues.apache.org/jira/browse/FLINK-7173 > Project: Flink > Issue Type: Bug > Components: DataStream API, Documentation >Reporter: sunjincheng >Assignee: sunjincheng > Attachments: screenshot-1.png, screenshot-2.png > > > !screenshot-1.png! > Change it to : > !screenshot-2.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7173) Fix the illustration of tumbling window.
[
https://issues.apache.org/jira/browse/FLINK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085609#comment-16085609
]
ASF GitHub Bot commented on FLINK-7173:
---
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4322
[FLINK-7173][doc]Change the illustration of tumbling window.
Change the illustration of tumbling window.
- [ ] General
- The pull request references the related JIRA issue
("[FLINK-7173][doc]Change the illustration of tumbling window.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-7173-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4322
commit fc1f954389010d9f7192f989c20d8b8b87c80244
Author: sunjincheng121
Date: 2017-07-13T12:04:00Z
[FLINK-7173][doc]Change the illustration of tumbling window.
> Fix the illustration of tumbling window.
>
>
> Key: FLINK-7173
> URL: https://issues.apache.org/jira/browse/FLINK-7173
> Project: Flink
> Issue Type: Bug
> Components: DataStream API, Documentation
>Reporter: sunjincheng
>Assignee: sunjincheng
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> !screenshot-1.png!
> Change it to :
> !screenshot-2.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
