[jira] [Commented] (FLINK-7191) Activate checkstyle flink-java/operators/translation

2017-07-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107531#comment-16107531
 ] 

ASF GitHub Bot commented on FLINK-7191:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4334


> Activate checkstyle flink-java/operators/translation
> 
>
> Key: FLINK-7191
> URL: https://issues.apache.org/jira/browse/FLINK-7191
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7191) Activate checkstyle flink-java/operators/translation

2017-07-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107379#comment-16107379
 ] 

ASF GitHub Bot commented on FLINK-7191:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4334
  
Will address the comment while merging.


> Activate checkstyle flink-java/operators/translation
> 
>
> Key: FLINK-7191
> URL: https://issues.apache.org/jira/browse/FLINK-7191
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7191) Activate checkstyle flink-java/operators/translation

2017-07-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107007#comment-16107007
 ] 

ASF GitHub Bot commented on FLINK-7191:
---

Github user NicoK commented on a diff in the pull request:

https://github.com/apache/flink/pull/4334#discussion_r130292761
  
--- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/operators/translation/PlanProjectOperator.java
 ---
@@ -27,30 +27,32 @@
 import org.apache.flink.api.common.typeinfo.TypeInformation;
 import org.apache.flink.api.java.tuple.Tuple;
 
+/**
+ *
+ * @param 
+ * @param 
+ */
--- End diff --

this should be filled will real content, if possible


> Activate checkstyle flink-java/operators/translation
> 
>
> Key: FLINK-7191
> URL: https://issues.apache.org/jira/browse/FLINK-7191
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7191) Activate checkstyle flink-java/operators/translation

2017-07-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087079#comment-16087079
 ] 

ASF GitHub Bot commented on FLINK-7191:
---

GitHub user dawidwys opened a pull request:

https://github.com/apache/flink/pull/4334

[FLINK-7191] Activate checkstyle flink-java/operators/translation

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [ ] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dawidwys/flink 
checkstyle-java-operators-translation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4334


commit eafb67b6b1a2775ef18f74f3114008a7715ab5ec
Author: Dawid Wysakowicz 
Date:   2017-07-14T08:42:57Z

[FLINK-7191] Activate checkstyle flink-java/operators/translation




> Activate checkstyle flink-java/operators/translation
> 
>
> Key: FLINK-7191
> URL: https://issues.apache.org/jira/browse/FLINK-7191
> Project: Flink
>  Issue Type: Improvement
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)