[jira] [Commented] (FLINK-7296) Validate commit messages in git pre-receive hook
[ https://issues.apache.org/jira/browse/FLINK-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105217#comment-16105217 ] Greg Hogan commented on FLINK-7296: --- [~uce] I'm trying to think through where this should run. On the client side committers may not have (pre-push?) hook configured on a repo so changes could slip through. GitHub doesn't allow server-side hooks (instead sending out webhooks notifications). Apache Infra may allow a server-side hook but would require a ticket to update (and if ever switching to GitBox would require committers to continue pushing to the Apache-hosted repo). > Validate commit messages in git pre-receive hook > > > Key: FLINK-7296 > URL: https://issues.apache.org/jira/browse/FLINK-7296 > Project: Flink > Issue Type: Improvement >Reporter: Greg Hogan >Assignee: Greg Hogan >Priority: Minor > > Would like to investigate a pre-receive (server-side) hook analyzing the > commit message incoming revisions on the {{master}} branch for the standard > JIRA format ({{\[FLINK-\] \[component\] ...}} or {{\[hotfix\] > \[component\] ...}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7296) Validate commit messages in git pre-receive hook
[ https://issues.apache.org/jira/browse/FLINK-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105161#comment-16105161 ] Greg Hogan commented on FLINK-7296: --- Yes, I will update the description. > Validate commit messages in git pre-receive hook > > > Key: FLINK-7296 > URL: https://issues.apache.org/jira/browse/FLINK-7296 > Project: Flink > Issue Type: Improvement >Reporter: Greg Hogan >Assignee: Greg Hogan >Priority: Minor > > Would like to investigate a pre-receive (server-side) hook analyzing the > commit message incoming revisions on the {{master}} branch for the standard > JIRA format ({{\[FLINK-\] \[module\] ...}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7296) Validate commit messages in git pre-receive hook
[ https://issues.apache.org/jira/browse/FLINK-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105155#comment-16105155 ] Ufuk Celebi commented on FLINK-7296: Thanks for looking into this. We should also allow messages like {{\[hotfiix\] ...}}. I think we allow them in the contrib guide. > Validate commit messages in git pre-receive hook > > > Key: FLINK-7296 > URL: https://issues.apache.org/jira/browse/FLINK-7296 > Project: Flink > Issue Type: Improvement >Reporter: Greg Hogan >Assignee: Greg Hogan >Priority: Minor > > Would like to investigate a pre-receive (server-side) hook analyzing the > commit message incoming revisions on the {{master}} branch for the standard > JIRA format ({{\[FLINK-\] \[module\] ...}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)