[jira] [Commented] (FLINK-7335) Remove Flink's own future implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112618#comment-16112618
 ] 

ASF GitHub Bot commented on FLINK-7335:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4463


> Remove Flink's own future implementation
> 
>
> Key: FLINK-7335
> URL: https://issues.apache.org/jira/browse/FLINK-7335
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
> Delete Flink's own future implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7335) Remove Flink's own future implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112616#comment-16112616
 ] 

ASF GitHub Bot commented on FLINK-7335:
---

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/4463#discussion_r131120916
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
@@ -21,7 +21,7 @@ package org.apache.flink.runtime.jobmanager
 import java.io.IOException
 import java.net._
 import java.util.UUID
-import java.util.concurrent.{Future => JavaFuture, _}
+import java.util.concurrent.{TimeUnit, Future => _, TimeoutException => _, 
_}
--- End diff --

Exclude `Future` from being imported.


> Remove Flink's own future implementation
> 
>
> Key: FLINK-7335
> URL: https://issues.apache.org/jira/browse/FLINK-7335
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
> Delete Flink's own future implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7335) Remove Flink's own future implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112605#comment-16112605
 ] 

ASF GitHub Bot commented on FLINK-7335:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4463
  
Thanks for the review @zentol. Merging this PR after merging #4462.


> Remove Flink's own future implementation
> 
>
> Key: FLINK-7335
> URL: https://issues.apache.org/jira/browse/FLINK-7335
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
> Delete Flink's own future implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7335) Remove Flink's own future implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110838#comment-16110838
 ] 

ASF GitHub Bot commented on FLINK-7335:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/4463#discussion_r130866931
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
@@ -21,7 +21,7 @@ package org.apache.flink.runtime.jobmanager
 import java.io.IOException
 import java.net._
 import java.util.UUID
-import java.util.concurrent.{Future => JavaFuture, _}
+import java.util.concurrent.{TimeUnit, Future => _, TimeoutException => _, 
_}
--- End diff --

What is `Future => _` doing?


> Remove Flink's own future implementation
> 
>
> Key: FLINK-7335
> URL: https://issues.apache.org/jira/browse/FLINK-7335
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
> Delete Flink's own future implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7335) Remove Flink's own future implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110817#comment-16110817
 ] 

ASF GitHub Bot commented on FLINK-7335:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/4463

[FLINK-7335] [futures] Remove Flink's own Future implementation

## What is the purpose of the change

Remove Flink's own Future implementation in favour of Java 8's 
`CompletableFuture`.

This PR is based on #4462.

## Brief change log

- Delete unused interface and class files

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink removeFutures

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4463


commit 0e497367d8666a580d033848977b0639b037e554
Author: Till Rohrmann 
Date:   2017-08-01T09:33:48Z

[FLINK-7334] [futures] Replace Flink's futures with Java 8's 
CompletableFuture in RpcEndpoint, RpcGateways and RpcService

Remove Futures from RpcGateways

Remove Future usage

commit 2302fbe2e201a8c871521a8f2cc970ffc9dbf0f0
Author: Till Rohrmann 
Date:   2017-08-02T12:40:36Z

[FLINK-7335] [futures] Remove Flink's own Future implementation




> Remove Flink's own future implementation
> 
>
> Key: FLINK-7335
> URL: https://issues.apache.org/jira/browse/FLINK-7335
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
> Delete Flink's own future implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)