[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136210#comment-16136210
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dianfu commented on the issue:

https://github.com/apache/flink/pull/4563
  
@dawidwys Have updated the PR according to your comments.


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134985#comment-16134985
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dianfu commented on the issue:

https://github.com/apache/flink/pull/4563
  
Thanks @dawidwys for the suggestion. I will update the PR accordingly.


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134836#comment-16134836
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157928
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -372,7 +375,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @return The same pattern with the number of times range applied
 * @throws MalformedPatternException if the quantifier is not 
applicable to this pattern.
 */
-  def times(from: Int, to: Int): Pattern[T, F] = {
+  def times(from: Int, to: Int) = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134841#comment-16134841
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157941
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -390,7 +393,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @return The same pattern with the updated quantifier.
 * @throws MalformedPatternException if the quantifier is not 
applicable to this pattern.
 */
-  def allowCombinations(): Pattern[T, F] = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134831#comment-16134831
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157893
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -347,7 +350,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @return The same pattern with a [[Quantifier.oneOrMore()]] 
quantifier applied.
 * @throws MalformedPatternException if the quantifier is not 
applicable to this pattern.
 */
-  def oneOrMore: Pattern[T, F] = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134839#comment-16134839
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157969
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -426,7 +429,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param pattern the pattern to append
 * @return A new pattern which is appended to this one
 */
-  def followedBy(pattern: Pattern[T, F]): GroupPattern[T, F] =
+  def followedBy(pattern: Pattern[T, F]) =
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134830#comment-16134830
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157821
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -292,9 +301,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param name Name of the new pattern
 * @return A new pattern which is appended to this one
 */
-  def followedBy(name: String): Pattern[T, T] = {
-Pattern[T, T](jPattern.followedBy(name))
-  }
+  def followedBy(name: String) = Pattern[T, T](jPattern.followedBy(name))
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134835#comment-16134835
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157831
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -305,9 +312,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param name Name of the new pattern
 * @return A new pattern which is appended to this one
 */
-  def notFollowedBy(name : String): Pattern[T, T] = {
-Pattern[T, T](jPattern.notFollowedBy(name))
-  }
+  def notFollowedBy(name : String) = Pattern[T, 
T](jPattern.notFollowedBy(name))
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134833#comment-16134833
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157868
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -329,7 +332,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @return The same pattern as optional.
 * @throws MalformedPatternException if the quantifier is not 
applicable to this pattern.
 */
-  def optional: Pattern[T, F] = {
+  def optional = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134829#comment-16134829
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157798
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -269,9 +282,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param name Name of the new pattern
 * @return A new pattern which is appended to this one
 */
-  def next(name: String): Pattern[T, T] = {
-Pattern[T, T](jPattern.next(name))
-  }
+  def next(name: String) = Pattern[T, T](jPattern.next(name))
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134838#comment-16134838
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134158000
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -449,7 +452,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param pattern the pattern to append
 * @return A new pattern which is appended to this one
 */
-  def next(pattern: Pattern[T, F]): GroupPattern[T, F] =
+  def next(pattern: Pattern[T, F]) =
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134837#comment-16134837
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157958
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -413,7 +416,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * By default a relaxed continuity is applied.
 * @return pattern with continuity changed to strict
 */
-  def consecutive(): Pattern[T, F] = {
+  def consecutive() = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134834#comment-16134834
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157916
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -359,7 +362,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @return The same pattern with number of times applied
 * @throws MalformedPatternException if the quantifier is not 
applicable to this pattern.
 */
-  def times(times: Int): Pattern[T, F] = {
+  def times(times: Int) = {
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134832#comment-16134832
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157849
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -317,9 +322,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param name Name of the new pattern
 * @return A new pattern which is appended to this one
 */
-  def followedByAny(name: String): Pattern[T, T] = {
-Pattern[T, T](jPattern.followedByAny(name))
-  }
+  def followedByAny(name: String) = Pattern[T, 
T](jPattern.followedByAny(name))
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134842#comment-16134842
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157991
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -437,7 +440,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param pattern the pattern to append
 * @return A new pattern which is appended to this one
 */
-  def followedByAny(pattern: Pattern[T, F]): GroupPattern[T, F] =
+  def followedByAny(pattern: Pattern[T, F]) =
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134840#comment-16134840
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4563#discussion_r134157810
  
--- Diff: 
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
 ---
@@ -280,9 +291,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
 * @param name Name of the new pattern
 * @return A new pattern which is appended to this one
 */
-  def notNext(name: String): Pattern[T, T] = {
-Pattern[T, T](jPattern.notNext(name))
-  }
+  def notNext(name: String) = Pattern[T, T](jPattern.notNext(name))
--- End diff --

Unrelated change


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[Dian Fu (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133888#comment-16133888
 ] 

Dian Fu commented on FLINK-7479:


Hi [~kkl0u], 
{quote}
Before opening a PR for a feature, we first have to discuss iff we want to 
include that feature in the library. 
If we do not go like this, then the only thing that will happen is that we pile 
up PRs that we do not know how to handle at the end.
{quote}
Agree. I will create the PR until we agree on the feature next time. Thanks for 
remind. :)

{quote}
I have not looked at the code itself, but from the topic, this just seems to 
just be syntactic sugar on top of the existing APIs.
{quote}
I don't think so. The tests in the PR can show that it's not able to achieve 
this functionality on top of the existing APIs.

{quote}
Until users start using the library and ask for features, and given that this 
is a first iteration of the CEP/SQL integration, 
I would suggest to keep it to a minimal and avoid stuff that only contribute 
"facilitation methods" for already existing functionality.
{quote}
Totally agree. I will try to keep the CEP/SQL integration feature a minimal and 
only adding features when required.  For the {{PREV}} clause, I think it should 
be included in the minimal feature as it's one important building block for 
pattern defination.

> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

[Kostas Kloudas (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133628#comment-16133628
 ] 

Kostas Kloudas commented on FLINK-7479:
---

Hi [~dian.fu], 

Before opening a PR for a feature, we first have to discuss iff we want to 
include that feature in the library. 
If we do not go like this, then the only thing that will happen is that we pile 
up PRs that we do not know how to handle at the end. 

I have not looked at the code itself, but from the topic, this just seems to 
just be syntactic sugar on top of the existing APIs.
It may be necessary for completeness, as it is in the SQL specification, but a 
specification is just a specification until users start using it
or asking for it. Until users start using the library and ask for features, and 
given that this is a first iteration of the CEP/SQL integration, 
I would suggest to keep it to a minimal and avoid stuff that only contribute 
"facilitation methods" for already existing functionality.


> Support to retrieve the past event by physical offset 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by an offset

[Dian Fu (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133007#comment-16133007
 ] 

Dian Fu commented on FLINK-7479:


This is to support the {{PREV}} clause in {{MATCH_RECOGNIZE}}. As described in 
the [doc|https://docs.oracle.com/database/121/DWHSG/pattern.htm#DWHSG8996], 
{{PREV}} defines an expression using a previous row by physical offset. This 
means that in the {{filter}} method of {{IterativeCondition}}, we may also need 
to access the past events by physical offset and the accessed events may be not 
matched by any pattern.

> Support to retrieve the past event by an offset 
> 
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by an offset

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132141#comment-16132141
 ] 

ASF GitHub Bot commented on FLINK-7479:
---

GitHub user dianfu opened a pull request:

https://github.com/apache/flink/pull/4563

[FLINK-7479] [cep] Support to retrieve the past event by an offset

## What is the purpose of the change

*Currently, it's already able to retrieve events matched to the specifed 
pattern in IterativeCondition.Context. While there are also requirements to 
retrieve events by an physical offset. The retrieved events may not be matched 
to any pattern.*


## Brief change log

  - *Add API retain() in Pattern*
  - *Buffer the past events in NFA.process*
  - *Access the past events by the newly added API getEventByOffset in 
IterativeCondition.Context*


## Verifying this change

This change added tests and can be verified as follows:

  - *Added test in IterativeConditionsITCase*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (yes)
  - If yes, how is the feature documented? (docs / JavaDocs)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dianfu/flink FLINK-7479

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4563


commit e9feb55e6c2f7d32ec6266049be0ea9bbff967b2
Author: Dian Fu 
Date:   2017-08-18T12:50:25Z

[FLINK-7479] [cep] Support to retrieve the past event by an offset




> Support to retrieve the past event by an offset 
> 
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: CEP, Table API & SQL
>Reporter: Dian Fu
>Assignee: Dian Fu
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)