[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183415#comment-16183415
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4700


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182827#comment-16182827
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4700
  
Thanks for the review @zentol. Rebasing onto the latest #4697 version.


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182560#comment-16182560
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4700
  
+1, feel free to merge once we concluded our discussions in #4697 :)


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182396#comment-16182396
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4700
  
I've reverted the changes to the `JobCancellationHandler` and instead 
created a new `JobTerminationHandler` directly extending `AbstractRestHandler`.


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182341#comment-16182341
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4700
  
Thanks for the review @zentol. You are right, that I should rather add a 
new JobTerminationHandler subsuming the functionality of the 
`JobCancellationHandler` and the `JobStoppingHandler`. Will change the PR 
accordingly.


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182340#comment-16182340
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/4700#discussion_r141304918
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
 ---
@@ -26,9 +26,10 @@
  *
  * A job related REST handler always requires a {@link 
JobPathParameter}.
  */
-public class JobMessageParameters extends MessageParameters {
+public class JobTerminationMessageParameters extends MessageParameters {
--- End diff --

If need should arise, then we can add a `JobIdMessageParameters` class 
again. But right now it's not needed.


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181158#comment-16181158
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/4700#discussion_r141121095
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
 ---
@@ -26,9 +26,10 @@
  *
  * A job related REST handler always requires a {@link 
JobPathParameter}.
  */
-public class JobMessageParameters extends MessageParameters {
+public class JobTerminationMessageParameters extends MessageParameters {
--- End diff --

did you intentionally modify an existing class? Will this class not be used 
by several other handler sin the future as well?


> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175080#comment-16175080
 ] 

ASF GitHub Bot commented on FLINK-7649:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/4700

[FLINK-7649] [flip6] Extend JobTerminationHandler to support stop

## What is the purpose of the change

Rename the JobCancellationHandler into JobTerminationHandler which is now 
responsible
for terminating jobs. Moreover, this commits adds two termination modes, 
cancel and stop,
which are specified by providing a query parameter.

## Brief change log

- Rename `JobCancellationHandler` into `JobTerminationHandler` being now 
responsible for the job termination (cancelling and stopping so far)
- Introduce a `TerminationModeQueryParameter` which allows to specify the 
termination mode (`stop` and `cancel`)
- Add `stopJob` to `DispatcherGateway` and `stop` to `JobMasterGateway`
- Adapt `JobTerminationHandler` to either call `cancelJob` or `stopJob` on 
the `Dispatcher` depending on the mode (default is `cancel`)

## Verifying this change

Tested manual that the right termination call is executed.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink portJobStoppingHandler

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4700


commit afa456f68a865ca5cf4aa1f60c2f1d43ff471e1b
Author: Till Rohrmann 
Date:   2017-09-21T08:53:24Z

[FLINK-7650] [flip6] Port JobCancellationHandler to new REST endpoint

Let the JobCancellationHandler implement the LegacyRestHandler interface. 
Moreover,
this commit adds the DELETE method to HttpMethodWrapper and the
RestServerEndpoint#registerHandler method.

commit a8f695607a1aa48d2af9175c47ed26dd965d9c05
Author: Till Rohrmann 
Date:   2017-09-21T14:47:18Z

[FLINK-7649] [flip6] Extend JobTerminationHandler to support stop

Rename the JobCancellationHandler into JobTerminationHandler which is now 
responsible
for terminating jobs. Moreover, this commits adds two termination modes, 
cancel and stop,
which are specified by providing a query parameter.




> Port JobStoppingHandler to new REST endpoint
> 
>
> Key: FLINK-7649
> URL: https://issues.apache.org/jira/browse/FLINK-7649
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST, Webfrontend
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Till Rohrmann
>  Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobStoppingHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)