[jira] [Commented] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-28 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184011#comment-16184011
 ] 

Chesnay Schepler commented on FLINK-7659:
-

1.4: 1b71040384785623fcd9369dae1241914bb5b7b1

> Unprotected access to inProgress in 
> JobCancellationWithSavepointHandlers#handleNewRequest
> -
>
> Key: FLINK-7659
> URL: https://issues.apache.org/jira/browse/FLINK-7659
> Project: Flink
>  Issue Type: Bug
>  Components: REST
>Reporter: Ted Yu
>Assignee: Bowen Li
>
> Here is related code:
> {code}
>   } finally {
> inProgress.remove(jobId);
>   }
> {code}
> A little lower, in another finally block, there is:
> {code}
>   synchronized (lock) {
> if (!success) {
>   inProgress.remove(jobId);
> {code}
> which is correct.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184005#comment-16184005
 ] 

ASF GitHub Bot commented on FLINK-7659:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4703


> Unprotected access to inProgress in 
> JobCancellationWithSavepointHandlers#handleNewRequest
> -
>
> Key: FLINK-7659
> URL: https://issues.apache.org/jira/browse/FLINK-7659
> Project: Flink
>  Issue Type: Bug
>  Components: REST
>Reporter: Ted Yu
>Assignee: Bowen Li
>
> Here is related code:
> {code}
>   } finally {
> inProgress.remove(jobId);
>   }
> {code}
> A little lower, in another finally block, there is:
> {code}
>   synchronized (lock) {
> if (!success) {
>   inProgress.remove(jobId);
> {code}
> which is correct.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175942#comment-16175942
 ] 

ASF GitHub Bot commented on FLINK-7659:
---

GitHub user bowenli86 opened a pull request:

https://github.com/apache/flink/pull/4703

[FLINK-7659][REST] Unprotected access to inProgress in 
JobCancellationWithSavepointHandlers#handleNewRequest

## What is the purpose of the change

There's a thread accessing `inProgress` without proper synchronization

## Brief change log

Add synchronization to access `inProgress` 

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

## Documentation

  - Does this pull request introduce a new feature? (no)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bowenli86/flink FLINK-7659

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4703.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4703


commit 6b7904bcfe809542216e12e4b48933fcb47d2d1d
Author: Bowen Li 
Date:   2017-09-22T05:33:17Z

FLINK-7659 Unprotected access to inProgress in 
JobCancellationWithSavepointHandlers#handleNewRequest




> Unprotected access to inProgress in 
> JobCancellationWithSavepointHandlers#handleNewRequest
> -
>
> Key: FLINK-7659
> URL: https://issues.apache.org/jira/browse/FLINK-7659
> Project: Flink
>  Issue Type: Bug
>  Components: REST
>Reporter: Ted Yu
>Assignee: Bowen Li
>
> Here is related code:
> {code}
>   } finally {
> inProgress.remove(jobId);
>   }
> {code}
> A little lower, in another finally block, there is:
> {code}
>   synchronized (lock) {
> if (!success) {
>   inProgress.remove(jobId);
> {code}
> which is correct.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)