[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377468#comment-16377468
]
ASF GitHub Bot commented on FLINK-8596:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5543
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376713#comment-16376713
]
ASF GitHub Bot commented on FLINK-8596:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5543
merging.
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374348#comment-16374348
]
ASF GitHub Bot commented on FLINK-8596:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5543
There's also a `ClassNotFoundException` in the logs, which is not ignored.
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372533#comment-16372533
]
ASF GitHub Bot commented on FLINK-8596:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5543
E2E test isn't fully working yet, debugging...
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371420#comment-16371420
]
ASF GitHub Bot commented on FLINK-8596:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5543
+1 to merge
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8596) Custom command line code does not correctly catch errors
[
https://issues.apache.org/jira/browse/FLINK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371396#comment-16371396
]
ASF GitHub Bot commented on FLINK-8596:
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5543
[FLINK-8596][CLI] Also catch NoClassDefFoundErrors
## What is the purpose of the change
This PR modifies the CliFrontend to also catch `NoClassDefFoundErrors` when
loading the YARN CLI, as otherwise the entire CLI would crash if hadoop wasn't
on the classpath.
## Verifying this change
This change added tests an end-to-end test that is run on travis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5543.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5543
commit 58438220d550c9dd6e0471a6971484c587e142b4
Author: zentol
Date: 2018-02-20T12:40:43Z
[FLINK-8596][CLI] Also catch NoClassDefFoundErrors
> Custom command line code does not correctly catch errors
>
>
> Key: FLINK-8596
> URL: https://issues.apache.org/jira/browse/FLINK-8596
> Project: Flink
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The code that is trying to load the YARN CLI is catching {{Exception}} but if
> the YARN CLI cannot be loaded a {{java.lang.NoClassDefFoundError}} is thrown:
> https://github.com/apache/flink/blob/0e20b613087e1b326e05674e3d532ea4aa444bc3/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L1067
> This means that Flink does not work in Hadoop-free mode. We should fix this
> and also add an end-to-end test that verifies that Hadoop-free mode works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
