[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378217#comment-16378217
 ] 

ASF GitHub Bot commented on FLINK-8733:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5549


> SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled 
> bytes anymore
> -
>
> Key: FLINK-8733
> URL: https://issues.apache.org/jira/browse/FLINK-8733
> Project: Flink
>  Issue Type: Sub-task
>  Components: Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Fix For: 1.5.0
>
>
> With FLINK-8583, {{SpillableSubpartition}} lost the counting of spilled bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374459#comment-16374459
 ] 

ASF GitHub Bot commented on FLINK-8733:
---

Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/5549
  
alright, there you go...
but with your definition of dead code, I could easily remove some hundred 
lines of code :P


> SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled 
> bytes anymore
> -
>
> Key: FLINK-8733
> URL: https://issues.apache.org/jira/browse/FLINK-8733
> Project: Flink
>  Issue Type: Sub-task
>  Components: Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Fix For: 1.5.0
>
>
> With FLINK-8583, {{SpillableSubpartition}} lost the counting of spilled bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374135#comment-16374135
 ] 

ASF GitHub Bot commented on FLINK-8733:
---

Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/5549
  
In that case please remove the dead code :( If it's not covered by tests 
because => it's not important => dead code.  Someone in the future will again 
brake this and some other guy will try to use it in some meaningful way and you 
have gigantic "wtf". Especially that test should be trivial.


> SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled 
> bytes anymore
> -
>
> Key: FLINK-8733
> URL: https://issues.apache.org/jira/browse/FLINK-8733
> Project: Flink
>  Issue Type: Sub-task
>  Components: Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Fix For: 1.5.0
>
>
> With FLINK-8583, {{SpillableSubpartition}} lost the counting of spilled bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373103#comment-16373103
 ] 

ASF GitHub Bot commented on FLINK-8733:
---

Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/5549
  
I would actually like to not implement a test since the value itself is 
only printed to the log anyway and not exposed in any other way.


> SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled 
> bytes anymore
> -
>
> Key: FLINK-8733
> URL: https://issues.apache.org/jira/browse/FLINK-8733
> Project: Flink
>  Issue Type: Sub-task
>  Components: Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Fix For: 1.5.0
>
>
> With FLINK-8583, {{SpillableSubpartition}} lost the counting of spilled bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371706#comment-16371706
 ] 

ASF GitHub Bot commented on FLINK-8733:
---

GitHub user NicoK opened a pull request:

https://github.com/apache/flink/pull/5549

[FLINK-8733][network] fix 
SpillableSubpartition#spillFinishedBufferConsumers() not counting spilled bytes

## What is the purpose of the change

With [FLINK-8583], `SpillableSubpartition` lost the counting of spilled 
bytes which is added again by this PR.

## Brief change log

- count spilled bytes in `SpillableSubpartition`

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): **no**
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
  - The serializers: **no**
  - The runtime per-record code paths (performance sensitive): **no**
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
  - The S3 file system connector: **no**

## Documentation

  - Does this pull request introduce a new feature? **no**
  - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NicoK/flink flink-8733

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5549


commit 580a447a1515b4c8134b1daad402b32f4ad3b04c
Author: Nico Kruber 
Date:   2018-02-20T17:04:12Z

[FLINK-8733][network] fix 
SpillableSubpartition#spillFinishedBufferConsumers() not counting spilled bytes




> SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled 
> bytes anymore
> -
>
> Key: FLINK-8733
> URL: https://issues.apache.org/jira/browse/FLINK-8733
> Project: Flink
>  Issue Type: Sub-task
>  Components: Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Fix For: 1.5.0
>
>
> With FLINK-8583, {{SpillableSubpartition}} lost the counting of spilled bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)