[jira] [Commented] (FLINK-9409) Remove flink-avro and flink-json from /opt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490350#comment-16490350
 ] 

ASF GitHub Bot commented on FLINK-9409:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6070


> Remove flink-avro and flink-json from /opt
> --
>
> Key: FLINK-9409
> URL: https://issues.apache.org/jira/browse/FLINK-9409
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Nico Kruber
>Assignee: Timo Walther
>Priority: Major
>
> Building Flink via {{mvn clean install -pl flink-dist -am}} currently fails 
> because {{flink-json}} is not defined as a dependency in 
> {{flink-dist/pom.xml}} although being used in the assembly.
> The same is true for {{flink-avro}} but this seems to be built due to some 
> indirect dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9409) Remove flink-avro and flink-json from /opt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490339#comment-16490339
 ] 

ASF GitHub Bot commented on FLINK-9409:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6070
  
Thank you @NicoK. I will merge this...


> Remove flink-avro and flink-json from /opt
> --
>
> Key: FLINK-9409
> URL: https://issues.apache.org/jira/browse/FLINK-9409
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Nico Kruber
>Assignee: Timo Walther
>Priority: Major
>
> Building Flink via {{mvn clean install -pl flink-dist -am}} currently fails 
> because {{flink-json}} is not defined as a dependency in 
> {{flink-dist/pom.xml}} although being used in the assembly.
> The same is true for {{flink-avro}} but this seems to be built due to some 
> indirect dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9409) Remove flink-avro and flink-json from /opt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488753#comment-16488753
 ] 

ASF GitHub Bot commented on FLINK-9409:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6070
  
@NicoK can you verify the change?


> Remove flink-avro and flink-json from /opt
> --
>
> Key: FLINK-9409
> URL: https://issues.apache.org/jira/browse/FLINK-9409
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Nico Kruber
>Assignee: Timo Walther
>Priority: Major
>
> Building Flink via {{mvn clean install -pl flink-dist -am}} currently fails 
> because {{flink-json}} is not defined as a dependency in 
> {{flink-dist/pom.xml}} although being used in the assembly.
> The same is true for {{flink-avro}} but this seems to be built due to some 
> indirect dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9409) Remove flink-avro and flink-json from /opt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488751#comment-16488751
 ] 

ASF GitHub Bot commented on FLINK-9409:
---

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/6070

[FLINK-9409] [formats] Remove flink-avro and flink-json from /opt

## What is the purpose of the change

Both flink-json and flink-avro were added to the /opt directory in order to 
use them as jars for the SQL Client. However, they are not required anymore 
because we added dedicated SQL jars later that are distributed through Maven 
central (see FLINK-8831).

`mvn clean install -pl flink-dist -am` is working again

## Brief change log

Remove all formats from /opt

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): yes
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation

  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-9409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6070.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6070


commit c567b48e67a7c1cde74e9cea74b36ebdd52751da
Author: Timo Walther 
Date:   2018-05-24T10:09:54Z

[FLINK-9409] [formats] Remove flink-avro and flink-json from /opt




> Remove flink-avro and flink-json from /opt
> --
>
> Key: FLINK-9409
> URL: https://issues.apache.org/jira/browse/FLINK-9409
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Nico Kruber
>Assignee: Timo Walther
>Priority: Major
>
> Building Flink via {{mvn clean install -pl flink-dist -am}} currently fails 
> because {{flink-json}} is not defined as a dependency in 
> {{flink-dist/pom.xml}} although being used in the assembly.
> The same is true for {{flink-avro}} but this seems to be built due to some 
> indirect dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)