[jira] [Commented] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-08-06 Thread Thomas Weise (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570207#comment-16570207
 ] 

Thomas Weise commented on FLINK-9691:
-

This was fixed, just the JIRA wasn't resolved.

> Modify run loop in Kinesis ShardConsumer to not sleep for a fixed 
> fetchIntervalMillis
> -
>
> Key: FLINK-9691
> URL: https://issues.apache.org/jira/browse/FLINK-9691
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.5.0, 1.4.2
>Reporter: Lakshmi Rao
>Assignee: Jamie Grier
>Priority: Major
> Fix For: 1.5.3, 1.6.0
>
>
> Currently the ShardConsumer in the Kinesis connector sleeps for a fixed 
> [fetchIntervalMillis|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L210]
>  resulting in the shard consumer sleeping for more time than necessary and 
> not optimally reading from Kinesis. It should only be sleeping for 
> (fetchIntervalMillis - time taken to process records) before making the 
> subsequent getRecords call. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-07-11 Thread Thomas Weise (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540453#comment-16540453
 ] 

Thomas Weise commented on FLINK-9691:
-

Should this be fixed in 1.4.x and 1.5.x also?

> Modify run loop in Kinesis ShardConsumer to not sleep for a fixed 
> fetchIntervalMillis
> -
>
> Key: FLINK-9691
> URL: https://issues.apache.org/jira/browse/FLINK-9691
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.5.0, 1.4.2
>Reporter: Lakshmi Rao
>Assignee: Jamie Grier
>Priority: Major
>
> Currently the ShardConsumer in the Kinesis connector sleeps for a fixed 
> [fetchIntervalMillis|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L210]
>  resulting in the shard consumer sleeping for more time than necessary and 
> not optimally reading from Kinesis. It should only be sleeping for 
> (fetchIntervalMillis - time taken to process records) before making the 
> subsequent getRecords call. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-07-09 Thread Jamie Grier (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537834#comment-16537834
 ] 

Jamie Grier commented on FLINK-9691:


https://github.com/apache/flink/pull/6290

> Modify run loop in Kinesis ShardConsumer to not sleep for a fixed 
> fetchIntervalMillis
> -
>
> Key: FLINK-9691
> URL: https://issues.apache.org/jira/browse/FLINK-9691
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.5.0, 1.4.2
>Reporter: Lakshmi Rao
>Assignee: Jamie Grier
>Priority: Major
>
> Currently the ShardConsumer in the Kinesis connector sleeps for a fixed 
> [fetchIntervalMillis|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L210]
>  resulting in the shard consumer sleeping for more time than necessary and 
> not optimally reading from Kinesis. It should only be sleeping for 
> (fetchIntervalMillis - time taken to process records) before making the 
> subsequent getRecords call. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)