[jira] [Commented] (FLINK-9919) Remove unit from fullRestarts metric docs
[ https://issues.apache.org/jira/browse/FLINK-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577912#comment-16577912 ] ASF GitHub Bot commented on FLINK-9919: --- zentol closed pull request #6543: [FLINK-9919] Remove unit from fullRestarts metric docs URL: https://github.com/apache/flink/pull/6543 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/monitoring/metrics.md b/docs/monitoring/metrics.md index 554e1c5b1f2..05427379ada 100644 --- a/docs/monitoring/metrics.md +++ b/docs/monitoring/metrics.md @@ -1133,7 +1133,7 @@ Thus, in order to infer the metric identifier: fullRestarts - The total number of full restarts since this job was submitted (in milliseconds). + The total number of full restarts since this job was submitted. Gauge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unit from fullRestarts metric docs > - > > Key: FLINK-9919 > URL: https://issues.apache.org/jira/browse/FLINK-9919 > Project: Flink > Issue Type: Improvement > Components: Documentation, Metrics >Affects Versions: 1.4.0, 1.5.0, 1.6.0 >Reporter: Chesnay Schepler >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > The > [fullRestarts](https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#availability) > metric documentation says that the unit for the metric is milliseconds, yet > it is a simple count. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9919) Remove unit from fullRestarts metric docs
[ https://issues.apache.org/jira/browse/FLINK-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577471#comment-16577471 ] ASF GitHub Bot commented on FLINK-9919: --- yanghua commented on issue #6543: [FLINK-9919] Remove unit from fullRestarts metric docs URL: https://github.com/apache/flink/pull/6543#issuecomment-412329313 cc @zentol little fix~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unit from fullRestarts metric docs > - > > Key: FLINK-9919 > URL: https://issues.apache.org/jira/browse/FLINK-9919 > Project: Flink > Issue Type: Improvement > Components: Documentation, Metrics >Affects Versions: 1.4.0, 1.5.0, 1.6.0 >Reporter: Chesnay Schepler >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > The > [fullRestarts](https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#availability) > metric documentation says that the unit for the metric is milliseconds, yet > it is a simple count. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9919) Remove unit from fullRestarts metric docs
[ https://issues.apache.org/jira/browse/FLINK-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577470#comment-16577470 ] ASF GitHub Bot commented on FLINK-9919: --- yanghua opened a new pull request #6543: [FLINK-9919] Remove unit from fullRestarts metric docs URL: https://github.com/apache/flink/pull/6543 ## What is the purpose of the change *This pull request remove unit from fullRestarts metric docs* ## Brief change log - *Remove unit from fullRestarts metric docs* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unit from fullRestarts metric docs > - > > Key: FLINK-9919 > URL: https://issues.apache.org/jira/browse/FLINK-9919 > Project: Flink > Issue Type: Improvement > Components: Documentation, Metrics >Affects Versions: 1.4.0, 1.5.0, 1.6.0 >Reporter: Chesnay Schepler >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > The > [fullRestarts](https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#availability) > metric documentation says that the unit for the metric is milliseconds, yet > it is a simple count. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
