[jira] [Updated] (FLINK-13764) Pass the counter of numRecordsIn into the constructors of StreamOne/TwoInputProcessor
[ https://issues.apache.org/jira/browse/FLINK-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-13764: - Description: Currently the counter of numRecordsIn is setup while processing input in processor. In order to integrate the processing logic based on StreamTaskInput#emitNext(Output) later, we need to pass the counter into output functions then. So there are three reasons to do this: * It is the precondition of following integration work. * We could make the counter as final fields in StreamInputProcessor and StreamTwoInputSelectableProcessor. * We could reuse the counter setup logic for all the input processors. There should be no side effects if we make the counter setup a bit earlier than the previous way. was: Currently the counter of numRecordsIn is setup while processing input in processor. In order to integrate the processing logic based on StreamTaskInput#emitNext(Output) later, we need to pass the counter into output functions then. So this refactoring is the precondition of following works, and it could get additional benefits. One is that we could make the counter as final field in StreamInputProcessor. Another is that we could reuse the counter setup logic for both StreamOne/TwoInputProcessors. There should be no side effects if we make the counter setup a bit earlier than the previous way. > Pass the counter of numRecordsIn into the constructors of > StreamOne/TwoInputProcessor > - > > Key: FLINK-13764 > URL: https://issues.apache.org/jira/browse/FLINK-13764 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Metrics, Runtime / Task >Reporter: zhijiang >Assignee: zhijiang >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently the counter of numRecordsIn is setup while processing input in > processor. In order to integrate the processing logic based on > StreamTaskInput#emitNext(Output) later, we need to pass the counter into > output functions then. So there are three reasons to do this: > * It is the precondition of following integration work. > * We could make the counter as final fields in StreamInputProcessor and > StreamTwoInputSelectableProcessor. > * We could reuse the counter setup logic for all the input processors. > There should be no side effects if we make the counter setup a bit earlier > than the previous way. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13764) Pass the counter of numRecordsIn into the constructors of StreamOne/TwoInputProcessor
[ https://issues.apache.org/jira/browse/FLINK-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13764: --- Labels: pull-request-available (was: ) > Pass the counter of numRecordsIn into the constructors of > StreamOne/TwoInputProcessor > - > > Key: FLINK-13764 > URL: https://issues.apache.org/jira/browse/FLINK-13764 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Metrics, Runtime / Task >Reporter: zhijiang >Assignee: zhijiang >Priority: Minor > Labels: pull-request-available > > Currently the counter of numRecordsIn is setup while processing input in > processor. In order to integrate the processing logic based on > StreamTaskInput#emitNext(Output) later, we need to pass the counter into > output functions then. > So this refactoring is the precondition of following works, and it could get > additional benefits. One is that we could make the counter as final field in > StreamInputProcessor. Another is that we could reuse the counter setup logic > for both StreamOne/TwoInputProcessors. > There should be no side effects if we make the counter setup a bit earlier > than the previous way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (FLINK-13764) Pass the counter of numRecordsIn into the constructors of StreamOne/TwoInputProcessor
[ https://issues.apache.org/jira/browse/FLINK-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-13764: - Component/s: Runtime / Metrics > Pass the counter of numRecordsIn into the constructors of > StreamOne/TwoInputProcessor > - > > Key: FLINK-13764 > URL: https://issues.apache.org/jira/browse/FLINK-13764 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Metrics, Runtime / Task >Reporter: zhijiang >Assignee: zhijiang >Priority: Minor > > Currently the counter of numRecordsIn is setup while processing input in > processor. In order to integrate the processing logic based on > StreamTaskInput#emitNext(Output) later, we need to pass the counter into > output functions then. > So this refactoring is the precondition of following works, and it could get > additional benefits. One is that we could make the counter as final field in > StreamInputProcessor. Another is that we could reuse the counter setup logic > for both StreamOne/TwoInputProcessors. > There should be no side effects if we make the counter setup a bit earlier > than the previous way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
