[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-15585: - Parent: FLINK-25217 Issue Type: Sub-task (was: Improvement) > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: Timo Walther >Priority: Major > Labels: auto-deprioritized-major, auto-unassigned, > pull-request-available > Fix For: 1.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-15585: - Fix Version/s: (was: 1.14.0) 1.15.0 > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Priority: Major > Labels: auto-deprioritized-major, auto-unassigned, > pull-request-available > Fix For: 1.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-15585: - Priority: Major (was: Minor) > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Priority: Major > Labels: auto-deprioritized-major, auto-unassigned, > pull-request-available > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15585: --- Labels: auto-deprioritized-major auto-unassigned pull-request-available (was: auto-unassigned pull-request-available stale-major) Priority: Minor (was: Major) This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Priority: Minor > Labels: auto-deprioritized-major, auto-unassigned, > pull-request-available > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15585: --- Labels: auto-unassigned pull-request-available stale-major (was: auto-unassigned pull-request-available) I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Major but is unassigned and neither itself nor its Sub-Tasks have been updated for 30 days. I have gone ahead and added a "stale-major" to the issue". If this ticket is a Major, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized. > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Priority: Major > Labels: auto-unassigned, pull-request-available, stale-major > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15585: --- Labels: auto-unassigned pull-request-available (was: pull-request-available stale-assigned) > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: auto-unassigned, pull-request-available > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15585: --- Labels: pull-request-available stale-assigned (was: pull-request-available) > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: pull-request-available, stale-assigned > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-15585: Fix Version/s: (was: 1.13.0) 1.14.0 > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-15585: --- Fix Version/s: (was: 1.12.0) 1.13.0 > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-15585: --- Fix Version/s: (was: 1.11.0) 1.12.0 > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15585: --- Labels: pull-request-available (was: ) > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Labels: pull-request-available > Fix For: 1.11.0 > > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15585) Improve function identifier string in plan digest
[ https://issues.apache.org/jira/browse/FLINK-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-15585: - Fix Version/s: 1.11.0 > Improve function identifier string in plan digest > - > > Key: FLINK-15585 > URL: https://issues.apache.org/jira/browse/FLINK-15585 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Major > Fix For: 1.11.0 > > > Currently, we are using {{UserDefinedFunction#functionIdentifier}} as the > identifier string of UDFs in plan digest, for example: > {code:java} > LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$8050927803993624f40152a838c98018($2)], > rowType=...) > {code} > However, the result of {{UserDefinedFunction#functionIdentifier}} will change > if we just add a method in UserDefinedFunction, because it uses Java > serialization. Then we have to update 60 plan tests which is very annoying. > In the other hand, displaying the function identifier string in operator name > in Web UI is verbose to users. > In order to improve this situation, there are something we can do: > 1) If the UDF has a catalog function name, we can just use the catalog name > as the digest. Otherwise, fallback to (2). > 2) If the UDF doesn't contain fields, we just use the full calss name as the > digest. Otherwise, fallback to (3). > 3) Use identifier string which will do the full serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)