[
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tatu Saloranta updated FLINK-3866:
--
Description:
Looking at default `TypeSerializer` instances I noticed what looks like a minor
flaw, unless I am missing something.
Whereas all other array serializers indicate that type is not immutable (since
in Java, arrays are not immutable), `StringArraySerializer` has:
```
@Override
public boolean isImmutableType() {
return true;
}
```
and I think it should instead return `false`. I could create a PR, but seems
like a small enough thing that issue report makes more sense.
I tried looking for deps to see if there's a test for this, but couldn't find
one; otherwise could submit a test fix.
was:
Looking at default `TypeSerializer` instances I noticed what looks like a minor
flaw, unless I am missing something.
Whereas all other array serializers indicate that type is not immutable (since
in Java, arrays are not immutable), `StringArraySerializer` has:
```
@Override
public boolean isImmutableType() {
return true;
}
```
and I think it should instead return `false`.
> StringArraySerializer claims type is immutable; shouldn't
> -
>
> Key: FLINK-3866
> URL: https://issues.apache.org/jira/browse/FLINK-3866
> Project: Flink
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.0.3
>Reporter: Tatu Saloranta
>Priority: Minor
>
> Looking at default `TypeSerializer` instances I noticed what looks like a
> minor flaw, unless I am missing something.
> Whereas all other array serializers indicate that type is not immutable
> (since in Java, arrays are not immutable), `StringArraySerializer` has:
> ```
> @Override
> public boolean isImmutableType() {
> return true;
> }
> ```
> and I think it should instead return `false`. I could create a PR, but seems
> like a small enough thing that issue report makes more sense.
> I tried looking for deps to see if there's a test for this, but couldn't find
> one; otherwise could submit a test fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
