Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
zentol merged PR #23594: URL: https://github.com/apache/flink/pull/23594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
zentol commented on PR #23594: URL: https://github.com/apache/flink/pull/23594#issuecomment-1784893428 oh god what happened... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
zentol commented on code in PR #23594: URL: https://github.com/apache/flink/pull/23594#discussion_r1374342821 ## README.md: ## @@ -69,7 +69,7 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we recommend version 3.8.6 and require at least 3.1.1) +* Maven (we require at least version 3.8.6) Review Comment: moved the 3.8.6 enforcement to #3609 and fixed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
snuyanzin commented on PR #23594: URL: https://github.com/apache/flink/pull/23594#issuecomment-1780028957 shouldn't enforcer also be updated? Right now it still allows to use 3.1.1 if it is used not for `release` profile https://github.com/apache/flink/blob/4de0f76d0bcfc4953d2aef1f06ae490e46b03d37/pom.xml#L1801-L1802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
snuyanzin commented on code in PR #23594: URL: https://github.com/apache/flink/pull/23594#discussion_r1372306100 ## README.md: ## @@ -69,7 +69,7 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we recommend version 3.8.6 and require at least 3.1.1) +* Maven (we require at least version 3.8.6) Review Comment: 10 lines below there is a note about requirements of 3.1.1 and possibility to build with 3.3.x, shouldn't it be updated as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
snuyanzin commented on code in PR #23594: URL: https://github.com/apache/flink/pull/23594#discussion_r1372306100 ## README.md: ## @@ -69,7 +69,7 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we recommend version 3.8.6 and require at least 3.1.1) +* Maven (we require at least version 3.8.6) Review Comment: 10 lines below there is a note about requirements of 3.1.1 possibility to build with 3.3.x, shouldn't it be updated as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32182][build] Use original japicmp plugin [flink]
flinkbot commented on PR #23594: URL: https://github.com/apache/flink/pull/23594#issuecomment-1779397197 ## CI report: * 4cf02092b50aa8a0511edf8568f1f71050e60bb5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
