Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
caicancai commented on PR #24217: URL: https://github.com/apache/flink/pull/24217#issuecomment-2119819886 @snuyanzin PATL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
caicancai commented on code in PR #24217:
URL: https://github.com/apache/flink/pull/24217#discussion_r1603120533
##
docs/content.zh/docs/dev/table/types.md:
##
@@ -1516,7 +1516,7 @@ COALESCE(TRY_CAST('non-number' AS INT), 0) --- 结果返回数字 0 的
INT 格
| `INTEGER` | Y
|N | Y | Y | Y
| Y | Y |Y |Y|Y | N| N|
N² | N²| Y⁵ |N| N | N | N
| N | N |
| `BIGINT` | Y
|N | Y | Y | Y
| Y | Y |Y |Y|Y | N| N|
N² | N²| Y⁶ |N| N | N | N
| N | N |
| `FLOAT`| Y
|N | N | Y | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
-| `DOUBLE` | Y
|N | N | Y | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
+| `DOUBLE` | Y
|N | N | ! | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
Review Comment:
Thank you. Sorry for the late reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
snuyanzin commented on code in PR #24217:
URL: https://github.com/apache/flink/pull/24217#discussion_r1599571602
##
docs/content.zh/docs/dev/table/types.md:
##
@@ -1516,7 +1516,7 @@ COALESCE(TRY_CAST('non-number' AS INT), 0) --- 结果返回数字 0 的
INT 格
| `INTEGER` | Y
|N | Y | Y | Y
| Y | Y |Y |Y|Y | N| N|
N² | N²| Y⁵ |N| N | N | N
| N | N |
| `BIGINT` | Y
|N | Y | Y | Y
| Y | Y |Y |Y|Y | N| N|
N² | N²| Y⁶ |N| N | N | N
| N | N |
| `FLOAT`| Y
|N | N | Y | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
-| `DOUBLE` | Y
|N | N | Y | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
+| `DOUBLE` | Y
|N | N | ! | Y
| Y | Y |Y |Y|Y | N| N|
N |N| N |N| N | N | N
| N | N |
Review Comment:
I don't think putting here `!` highlighting the fact that it may fail will
help to understand the issue...
As you can see below there is a list of notes and I would suggest to keep it
as supported however to add a note that iff the value is not infinity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
caicancai commented on PR #24217: URL: https://github.com/apache/flink/pull/24217#issuecomment-1916187788 @libenchao Hello, if you have time, can you help look at it? Thank you. This part of conversion is also reported wrong by default in calcite, which I have tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
flinkbot commented on PR #24217: URL: https://github.com/apache/flink/pull/24217#issuecomment-1914641033 ## CI report: * 79155ebdfa1ab54b6971532c8ba8256430f21c0c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34263] Converting double to decimal may fail [flink]
caicancai commented on PR #24217: URL: https://github.com/apache/flink/pull/24217#issuecomment-1914633586 @1996fanrui @RocMarshal If you have time, can you help me take a look at this PR? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
