Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
flinkbot commented on PR #24362: URL: https://github.com/apache/flink/pull/24362#issuecomment-1956693550 ## CI report: * 75374e85405a03ac08ae1d9cdd227b52d3e0f9ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
XComp commented on PR #24347: URL: https://github.com/apache/flink/pull/24347#issuecomment-1956693303 Closing this PR in favor of PR #24362 which is backed by a branch in the Apache repo which enables the CI run and helps testing the changes before merging them to `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
XComp closed pull request #24347: [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner URL: https://github.com/apache/flink/pull/24347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
XComp commented on PR #24347: URL: https://github.com/apache/flink/pull/24347#issuecomment-1956670454 Thanks for the review. I went ahead and merged the 1.18 backport as a first try (see [related workflow run](https://github.com/apache/flink/actions/runs/7989772037) and [1.18 baseline run](https://github.com/apache/flink/actions/runs/7985097005) for comparison). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
XComp commented on code in PR #24347: URL: https://github.com/apache/flink/pull/24347#discussion_r1497112175 ## .github/workflows/template.workflow-init.yml: ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Workflow Review Comment: Good point - I guess I wanted to add a comment but didn't follow up on it. But you're right. The workflow name should be descriptive enough. I'm gonna remove it :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
XComp commented on code in PR #24347:
URL: https://github.com/apache/flink/pull/24347#discussion_r1497109980
##
.github/workflows/template.workflow-init.yml:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Workflow
+
+name: "Apache Flink Workflow Initialization"
+
+on:
+ workflow_call:
+outputs:
+ runner_config:
+description: "The runs-on configuration that can be used in the
runs-on parameter."
+value: ${{ jobs.workflow_init.outputs.runner_config }}
+
+permissions: read-all
+
+jobs:
+ workflow_init:
+name: "Initialize Workflow"
+# no need to fix a specific ubuntu version here
Review Comment:
hm, not sure how we should document that. Generally, we're using fixed VM
labels (i.e. `ubuntu-22.04` right now) in all other locations. This is a
location where I didn't do that.
If we decide to upgrade the VM image, the most natural way (IMHO) would be
to look for the term `ubuntu-22.04`. I added the comment here to clarify that
we're not requiring a fixed version here (to have less maintenance effort)
because we're not really rely on any dependency (except for some basic shell
scripts).
I will add more reasoning to the comment, though, to clarify why we don't
need the fixed version here :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
snuyanzin commented on code in PR #24347: URL: https://github.com/apache/flink/pull/24347#discussion_r1496405112 ## .github/workflows/template.workflow-init.yml: ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Workflow Review Comment: should we have it? It seems `name` var is self explainable isn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
snuyanzin commented on code in PR #24347:
URL: https://github.com/apache/flink/pull/24347#discussion_r1496403718
##
.github/workflows/template.workflow-init.yml:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Workflow
+
+name: "Apache Flink Workflow Initialization"
+
+on:
+ workflow_call:
+outputs:
+ runner_config:
+description: "The runs-on configuration that can be used in the
runs-on parameter."
+value: ${{ jobs.workflow_init.outputs.runner_config }}
+
+permissions: read-all
+
+jobs:
+ workflow_init:
+name: "Initialize Workflow"
+# no need to fix a specific ubuntu version here
Review Comment:
should we have some more clarifying comments where version should be changed
in case of upgrade?
May be extract it into a dedicated var?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]
flinkbot commented on PR #24347: URL: https://github.com/apache/flink/pull/24347#issuecomment-1954007681 ## CI report: * 5e74caa6cb1b7c95a56012559fa2418b59dbf096 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
