Re: [PR] [FLINK-35116] Bump operator sdk version to 4.8.3 [flink-kubernetes-operator]
mbalassi merged PR #816: URL: https://github.com/apache/flink-kubernetes-operator/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35116] Bump operator sdk version to 4.8.3 [flink-kubernetes-operator]
csviri commented on PR #816: URL: https://github.com/apache/flink-kubernetes-operator/pull/816#issuecomment-2061189575 > Together with the version bump, this workaround can also be removed I believe: [726e484](https://github.com/apache/flink-kubernetes-operator/commit/726e484c6a9b4121563829bc094b3eebeb8ddcf3) (cc @csviri ) yes, that is true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35116] Bump operator sdk version to 4.8.3 [flink-kubernetes-operator]
gyfora commented on PR #816: URL: https://github.com/apache/flink-kubernetes-operator/pull/816#issuecomment-2059797010 Together with the version bump, this workaround can also be removed I believe: https://github.com/apache/flink-kubernetes-operator/commit/726e484c6a9b4121563829bc094b3eebeb8ddcf3 (cc @csviri ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35116] Bump operator sdk version to 4.8.3 [flink-kubernetes-operator]
csviri commented on code in PR #816:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/816#discussion_r1567338233
##
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/validation/CrdCompatibilityChecker.java:
##
@@ -93,7 +93,10 @@ protected static void checkObjectCompatibility(
// This field was removed from Kubernetes ObjectMeta v1 in
1.25 as it was unused
// for a long time. If set for any reason (very unlikely
as it does nothing),
// the property will be dropped / ignored by the api
server.
-if (!fieldPath.endsWith(".metadata.clusterName")) {
+if (!fieldPath.endsWith(".metadata.clusterName")
+// This field was removed from the pod templates
when upgrading
+// from crd-generator 6.8 to 6.11, needs further
assessment
+&&
!fieldPath.contains(".volumeClaimTemplate.spec.resources.claims")) {
Review Comment:
This field was removed from Kubernetes API:
https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2620-L2625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35116] Bump operator sdk version to 4.8.3 [flink-kubernetes-operator]
mbalassi commented on PR #816: URL: https://github.com/apache/flink-kubernetes-operator/pull/816#issuecomment-2059011676 I will take a look at the test failure later, it is a timeout in `AbstractFlinkServiceTest#testBlockingDeploymentDeletion`. I managed to reproduce it locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
