Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]
JingGe merged PR #23805: URL: https://github.com/apache/flink/pull/23805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826798523 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826797827 Thanks @snuyanzin for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]
snuyanzin commented on code in PR #23805:
URL: https://github.com/apache/flink/pull/23805#discussion_r1405381059
##
docs/content/docs/dev/table/functions/udfs.md:
##
@@ -227,6 +227,20 @@ env.from("MyTable").select(call(classOf[MyConcatFunction],
$"a", $"b", $"c"));
{{< /tab >}}
{{< /tabs >}}
+{{< hint info >}}
+`TableEnvironment` provides two overload methods to create temporary system
function with an `UserDefinedFunction`:
+
+- *createTemporarySystemFunction(
+ String name, Class functionClass)*
+- *createTemporarySystemFunction(String name, UserDefinedFunction
functionInstance)*
+
+It is recommended to use `functionClass` over `functionInstance` as far as you
can,
Review Comment:
May be it would make sense to mention that in case of `functionClass` it
requires the ability to invoke constructor with no args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]
flinkbot commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826474593 ## CI report: * cb036179d46abe0da3440617b8af78b9392d6e43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
