Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


JingGe merged PR #23786:
URL: https://github.com/apache/flink/pull/23786


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


JingGe commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826886399

   Thanks @snuyanzin for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405469301


##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -240,6 +232,16 @@ void testBatchResult() {
 assertThat(collectResult.closed).isFalse();
 }
 
+@NotNull
+private TestChangelogResult createTestChangelogResult() {

Review Comment:
   nit: it's better to put private/utils methods below all the tests 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


JingGe commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826828710

   good catch! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


snuyanzin commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826815890

   Thanks for driving this
   i would suggest to replace 2 more same occurrences e.g. at
   
https://github.com/apache/flink/blob/0c724f5597a1654d83682d5c39c7ee0ef2959cca/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java#L374-L378
   
   and 
   
https://github.com/apache/flink/blob/0c724f5597a1654d83682d5c39c7ee0ef2959cca/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java#L225-L229


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421318


##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
 // adjust the max column width for printing
 testConfig.set(DISPLAY_MAX_COLUMN_WIDTH, 80);
 
-collectResult =
+TestChangelogResult collectResult =

Review Comment:
   I guess this also should be replaced as
   ```java
   TestChangelogResult collectResult = createTestChangelogResult();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199


##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
 // adjust the max column width for printing
 testConfig.set(DISPLAY_MAX_COLUMN_WIDTH, 80);
 
-collectResult =

Review Comment:
   I guess this also should be replaced as
   ```java
   TestChangelogResult collectResult = createTestChangelogResult();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub 


snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199


##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
 // adjust the max column width for printing
 testConfig.set(DISPLAY_MAX_COLUMN_WIDTH, 80);
 
-collectResult =

Review Comment:
   I guess this also should be replaced as
   ```java
   TestChangelogResult collectResult = createTestChangelogResult();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-23 Thread via GitHub 


flinkbot commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1825056837

   
   ## CI report:
   
   * 0c724f5597a1654d83682d5c39c7ee0ef2959cca UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org