Re: [PR] Add flink-shaded 18.0 release [flink-web]
snuyanzin merged PR #701: URL: https://github.com/apache/flink-web/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
snuyanzin commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1410699644 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: thanks for the feedback, I added 17.0 back to the site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
TanYuxin-tyx commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1410580484 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: +1, maybe it is a good choice to keep 16.2, 17.0, and 18.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
1996fanrui commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1410193976 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: I see the `pre-bundled-hadoop-` has 4 versions in this yml, so should we keep 16, 17 and 18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
snuyanzin commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1409991523 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: That's actually a good question the only thing making me stopping before removal that is that it was released just a couple of weeks ago... However I think you are right and probably we should not stick to it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
1996fanrui commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1408983785 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: Keep `18.0` and `16.2` isn't a good idea here. Should we just keep the 17.0 and 18.0(The latest 2 versions)? Or keep all versions here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add flink-shaded 18.0 release [flink-web]
1996fanrui commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1408983785 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.asc; source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-parent-1.0.0/flink-connector-parent-1.0.0-src.tgz.sha512; -flink-shaded-17.0: - name: "Apache Flink-shaded 17.0 Source Release" - source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz; - source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.asc; - source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flink-shaded-17.0-src.tgz.sha512; +flink-shaded-18.0: + name: "Apache Flink-shaded 18.0 Source Release" + source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz; + source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.asc; + source_release_sha512_url: "https://downloads.apache.org/flink/flink-shaded-18.0/flink-shaded-18.0-src.tgz.sha512; flink-shaded-16.2: Review Comment: Keep `18.0` and `16.2` isn't a good idea here. Should we keep the 17.0 and 18.0? And remove the 16.2? Or keep all versions here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org