[jira] [Commented] (GEODE-1122) Dependency on environment variable GEMFIRE needs to be removed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679452#comment-15679452
 ] 

ASF GitHub Bot commented on GEODE-1122:
---

Github user davinash commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/291#discussion_r88781685
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -1493,6 +1495,7 @@ public Result startServer(
   help = CliStrings.START_SERVER__PASSWORD__HELP) String 
passwordToUse)
   // NOTICE: keep the parameters in alphabetical order based on their 
CliStrings.START_SERVER_* text
   {
+System.out.println("GEODE_HOME = " + GEODE_HOME);
--- End diff --

Fixed.


> Dependency on environment variable GEMFIRE needs to be removed
> --
>
> Key: GEODE-1122
> URL: https://issues.apache.org/jira/browse/GEODE-1122
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Udo Kohlmeyer
>Assignee: Avinash Dongre
>
> There is still a strong dependency on the environment variable GEMFIRE within 
> GEODE. This should be replaced with GEODE_HOME or removed completely from the 
> system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (GEODE-1970) Oplog flush methods no longer need to catch ClosedChannelException

[Avinash Dongre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avinash Dongre reassigned GEODE-1970:
-

Assignee: Avinash Dongre

> Oplog flush methods no longer need to catch ClosedChannelException
> --
>
> Key: GEODE-1970
> URL: https://issues.apache.org/jira/browse/GEODE-1970
> Project: Geode
>  Issue Type: Improvement
>  Components: persistence
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The flush methods in Oplog.java catch ClosedChannelException and say:
>   // It is possible for a channel to be closed when our code does not
>   // explicitly call channel.close (when we will set RAFclosed).
>   // This can happen when a thread is doing an io op and is interrupted.
>   // That thread will see ClosedByInterruptException but it will also
>   // close the channel and then we will see ClosedChannelException.
> However the channel is now implemented by UninterruptibleFileChannel and that 
> implementation reopens the channel if it is closed do to interrupt so this 
> code no longer needs to catch ClosedChannelException.
> Note that similar code in OverflowOplog.java does still need to catch it 
> because it does not use UninterruptibleFileChannel.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)