[jira] [Resolved] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey resolved GEODE-3522.

   Resolution: Fixed
Fix Version/s: 1.3.0

{noformat}
commit 755f636240b901e3039527e6c968445c06f03c24
Author: Lynn Hughes-Godfrey 
Date:   Fri Aug 25 14:46:17 2017 -0700

GEODE-3522: create via load needs to add event to AEQ under same lock as 
update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

This closes #744

{noformat}

> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
> Fix For: 1.3.0
>
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142493#comment-16142493
 ] 

ASF subversion and git services commented on GEODE-3522:


Commit 755f636240b901e3039527e6c968445c06f03c24 in geode's branch 
refs/heads/develop from [~lhughesgodfrey]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=755f636 ]

GEODE-3522: create via load needs to add event to AEQ under same lock as update 
to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, which 
allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

This closes #744


> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142494#comment-16142494
 ] 

ASF GitHub Bot commented on GEODE-3522:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/744


> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3512) Remove gfsh encrypt reference page

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-3512.

   Resolution: Fixed
Fix Version/s: 1.3.0

> Remove gfsh encrypt reference page
> --
>
> Key: GEODE-3512
> URL: https://issues.apache.org/jira/browse/GEODE-3512
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> GEODE-1958 removed gfsh encrypt from the code base.  This ticket exists to 
> remove the gfsh encrypt command reference page from the documentation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3512) Remove gfsh encrypt reference page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142440#comment-16142440
 ] 

ASF subversion and git services commented on GEODE-3512:


Commit 5ab519768745a3466c1d356d34aa1bc215cba0b2 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5ab5197 ]

GEODE-3512 Doc removal of gfsh encrypt password

This revises the documentation to go with GEODE-1958.

This closes #741


> Remove gfsh encrypt reference page
> --
>
> Key: GEODE-3512
> URL: https://issues.apache.org/jira/browse/GEODE-3512
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> GEODE-1958 removed gfsh encrypt from the code base.  This ticket exists to 
> remove the gfsh encrypt command reference page from the documentation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3512) Remove gfsh encrypt reference page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142442#comment-16142442
 ] 

ASF GitHub Bot commented on GEODE-3512:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/741


> Remove gfsh encrypt reference page
> --
>
> Key: GEODE-3512
> URL: https://issues.apache.org/jira/browse/GEODE-3512
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> GEODE-1958 removed gfsh encrypt from the code base.  This ticket exists to 
> remove the gfsh encrypt command reference page from the documentation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1958) Remove PasswordUtil

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142441#comment-16142441
 ] 

ASF subversion and git services commented on GEODE-1958:


Commit 5ab519768745a3466c1d356d34aa1bc215cba0b2 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5ab5197 ]

GEODE-3512 Doc removal of gfsh encrypt password

This revises the documentation to go with GEODE-1958.

This closes #741


> Remove PasswordUtil 
> 
>
> Key: GEODE-1958
> URL: https://issues.apache.org/jira/browse/GEODE-1958
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Diane Hardman
>Assignee: Emily Yeh
>Priority: Minor
>
> PasswordUtil was used to encrypt a password to be stored in cache.xml. This 
> was not secure since anyone could copy the "encrypted" string to another 
> cache.xml to gain access. Therefore this utility was not particularly useful 
> and should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3164) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails intermittently with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142401#comment-16142401
 ] 

ASF subversion and git services commented on GEODE-3164:


Commit 6212dd563f71272e83e62062be07301371bf572f in geode's branch 
refs/heads/develop from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6212dd5 ]

GEODE-3164 Initialized  clientIds after verfication.


> ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails 
> intermittently with AssertionError
> --
>
> Key: GEODE-3164
> URL: https://issues.apache.org/jira/browse/GEODE-3164
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, management, tests
>Reporter: Hitesh Khamesra
>Assignee: Hitesh Khamesra
>  Labels: DistributedTest, Flaky
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_SubscriptionDisabled FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$33/1335405829.run
>  in VM 0 running on Host 57af4a2e6a1a with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled(ClientHealthStatsDUnitTest.java:136)
> Caused by:
> java.lang.AssertionError: 
> Expected size:<2> but was:<1> in:
> <["172.17.0.4(197:loner):57014:0e60d6fc"]>
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:314)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_SubscriptionDisabled$1db6af62$1(ClientHealthStatsDUnitTest.java:136)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3523) AutoConnectionSourceDUnitTest: testDynamicallyFindLocators failed with Unable to connect to any locators in the list

[Hitesh Khamesra (JIRA)]

Hitesh Khamesra created GEODE-3523:
--

 Summary: AutoConnectionSourceDUnitTest: 
testDynamicallyFindLocators failed with Unable to connect to any locators in 
the list
 Key: GEODE-3523
 URL: https://issues.apache.org/jira/browse/GEODE-3523
 Project: Geode
  Issue Type: Bug
  Components: locator
Reporter: Hitesh Khamesra



org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest > 
testDynamicallyFindLocators FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest$3.call in 
VM 2 running on Host 97e556d10832 with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
at org.apache.geode.test.dunit.VM.invoke(VM.java:325)
at 
org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest.putInVM(AutoConnectionSourceDUnitTest.java:470)
at 
org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest.putAndWaitForSuccess(AutoConnectionSourceDUnitTest.java:448)
at 
org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest.testDynamicallyFindLocators(AutoConnectionSourceDUnitTest.java:199)

Caused by:
org.apache.geode.cache.client.NoAvailableLocatorsException: Unable to 
connect to any locators in the list [LocatorAddress 
[socketInetAddress=97e556d10832/172.17.0.4:26078, hostname=97e556d10832, 
isIpString=false], LocatorAddress 
[socketInetAddress=97e556d10832/172.17.0.4:29796, hostname=172.17.0.4, 
isIpString=true]]




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3471) NPE in MBeanProxyFactory

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-3471:
-
Component/s: management

> NPE in MBeanProxyFactory
> 
>
> Key: GEODE-3471
> URL: https://issues.apache.org/jira/browse/GEODE-3471
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.2.0
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.3.0
>
>
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createProxy(MBeanProxyFactory.java:86)
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createAllProxies(MBeanProxyFactory.java:138)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:457)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:341)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3510) GfshRule loses output from standard error

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142389#comment-16142389
 ] 

ASF subversion and git services commented on GEODE-3510:


Commit 79d249497576deaa3a8f21f475f5ce03f8847040 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=79d2494 ]

GEODE-3510: GfshRule displays output from StdError


> GfshRule loses output from standard error
> -
>
> Key: GEODE-3510
> URL: https://issues.apache.org/jira/browse/GEODE-3510
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Jared Stewart
>
> There is a bug in GfshRule that causes output to only show up from standard 
> out, but not from standard error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2842) Remove unnecessary @CliOption arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142379#comment-16142379
 ] 

ASF GitHub Bot commented on GEODE-2842:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/731


> Remove unnecessary @CliOption arguments
> ---
>
> Key: GEODE-2842
> URL: https://issues.apache.org/jira/browse/GEODE-2842
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> The {{@CliOption}} annotation specifies default values for some of its fields 
> (like {{mandatory}} and {{unspecifiedDefaultValue}}).  Yet, we often 
> explicitly set those fields to the default value.  For example,
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME, 
> mandatory = false,
>   unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> could simply read   
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> Removing these redundant/unnecessary arguments will make the code a lot more 
> readable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3506) LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently with IllegalStateException: Failed to read status file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142378#comment-16142378
 ] 

ASF GitHub Bot commented on GEODE-3506:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/738


> LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails 
> intermittently with IllegalStateException: Failed to read status file
> --
>
> Key: GEODE-3506
> URL: https://issues.apache.org/jira/browse/GEODE-3506
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > 
> startDeletesStaleControlFiles FAILED
> java.lang.IllegalStateException: Failed to read status file
> {noformat}
> Full stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to read status file
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at 
> org.apache.geode.distributed.LocatorLauncher.statusWithWorkingDirectory(LocatorLauncher.java:940)
> at 
> org.apache.geode.distributed.LocatorLauncher.status(LocatorLauncher.java:868)
> at 
> org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(LocatorLauncherRemoteIntegrationTestCase.java:196)
> at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
> at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3506) LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently with IllegalStateException: Failed to read status file

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142376#comment-16142376
 ] 

ASF subversion and git services commented on GEODE-3506:


Commit a2ab230d685b8ac897a7e155474f797608f711fa in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a2ab230 ]

GEODE-3506: improve validation/error checking for process file control

This closes #738


> LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails 
> intermittently with IllegalStateException: Failed to read status file
> --
>
> Key: GEODE-3506
> URL: https://issues.apache.org/jira/browse/GEODE-3506
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > 
> startDeletesStaleControlFiles FAILED
> java.lang.IllegalStateException: Failed to read status file
> {noformat}
> Full stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to read status file
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at 
> org.apache.geode.distributed.LocatorLauncher.statusWithWorkingDirectory(LocatorLauncher.java:940)
> at 
> org.apache.geode.distributed.LocatorLauncher.status(LocatorLauncher.java:868)
> at 
> org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(LocatorLauncherRemoteIntegrationTestCase.java:196)
> at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
> at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2842) Remove unnecessary @CliOption arguments

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142377#comment-16142377
 ] 

ASF subversion and git services commented on GEODE-2842:


Commit 0af313241b9e6125443468752bd18d2104acc627 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0af3132 ]

GEODE-2842: Removed redundant default annotation parameter values.

This closes #731


> Remove unnecessary @CliOption arguments
> ---
>
> Key: GEODE-2842
> URL: https://issues.apache.org/jira/browse/GEODE-2842
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> The {{@CliOption}} annotation specifies default values for some of its fields 
> (like {{mandatory}} and {{unspecifiedDefaultValue}}).  Yet, we often 
> explicitly set those fields to the default value.  For example,
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME, 
> mandatory = false,
>   unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> could simply read   
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> Removing these redundant/unnecessary arguments will make the code a lot more 
> readable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142291#comment-16142291
 ] 

ASF GitHub Bot commented on GEODE-3522:
---

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/744

GEODE-3522: create via load needs to add event to AEQ under same lock…

… as update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

@upthewaterspout, @boglesby

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #744


commit afbfd708185cc7ed82490699c033c40263e4aa76
Author: Lynn Hughes-Godfrey 
Date:   2017-08-25T21:46:17Z

GEODE-3522: create via load needs to add event to AEQ under same lock as 
update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.




> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2719) The total-max-memory region attribute does not appear to do anything

[Fred Krone (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142239#comment-16142239
 ] 

Fred Krone commented on GEODE-2719:
---

Let's deprecate it.

> The total-max-memory region attribute does not appear to do anything
> 
>
> Key: GEODE-2719
> URL: https://issues.apache.org/jira/browse/GEODE-2719
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, regions
>Reporter: Darrel Schneider
>Assignee: Amey Barve
>  Labels: storage_3
>
> I could not find that the "total-max-memory" region partitioned attribute 
> does anything. If this is correct then it should be deprecated and removed in 
> a future release. A user read the geode docs and expected it cause LRU 
> eviction since this docs say this about it:
> {quote}
> Maximum combined megabytes of memory to be used by all processes hosting this 
> region for all copies, primary and redundant.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142195#comment-16142195
 ] 

ASF GitHub Bot commented on GEODE-3447:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/719
  
I'm not suggesting changing the protobuf message.  That seems ok to me.

Since the `StreamAuthenticator` is part of protobuf messaging I think it 
should remain in the `geode-protobuf` module.  Putting it in a public API 
package for RBAC seems like we're leaking abstractions into other parts of the 
codebase.

Am I missing something?



> Implement client authorization for the new protocol
> ---
>
> Key: GEODE-3447
> URL: https://issues.apache.org/jira/browse/GEODE-3447
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients 
> using the protocol to access my grid are authorized to perform each operation 
> they attempt.
> Implement client authorization for operations in new protocol based on 
> existing authorization configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3385) Change GetAllRequest to return list of errors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142184#comment-16142184
 ] 

ASF GitHub Bot commented on GEODE-3385:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/739#discussion_r135351811
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 ---
@@ -50,26 +53,52 @@
   .makeErrorResponse(ProtocolErrorCode.REGION_NOT_FOUND.codeValue, 
"Region not found"));
 }
 
-try {
-  Set keys = new HashSet<>();
-  for (BasicTypes.EncodedValue key : request.getKeyList()) {
-keys.add(ProtobufUtilities.decodeValue(serializationService, key));
-  }
-  Map results = region.getAll(keys);
-  Set entries = new HashSet<>();
-  for (Map.Entry entry : results.entrySet()) {
-entries.add(
-ProtobufUtilities.createEntry(serializationService, 
entry.getKey(), entry.getValue()));
-  }
-  return 
Success.of(RegionAPI.GetAllResponse.newBuilder().addAllEntries(entries).build());
-} catch (UnsupportedEncodingTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue, "Encoding not 
supported."));
-} catch (CodecNotRegisteredForTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue,
-  "Codec error in protobuf deserialization."));
+Map resultsCollection = 
request.getKeyList().stream()
+.map((key) -> processOneMessage(serializationService, region, key))
+.collect(Collectors.partitioningBy(x -> x instanceof 
BasicTypes.Entry));
+RegionAPI.GetAllResponse.Builder responseBuilder = 
RegionAPI.GetAllResponse.newBuilder();
+
+for (Object entry : resultsCollection.get(true)) {
+  responseBuilder.addEntries((BasicTypes.Entry) entry);
+}
+
+for (Object entry : resultsCollection.get(false)) {
+  responseBuilder.addFailures((BasicTypes.KeyedError) entry);
 }
+
+return Success.of(responseBuilder.build());
   }
 
+  private Object processOneMessage(SerializationService 
serializationService, Region region,
+  BasicTypes.EncodedValue key) {
+try {
+  Object decodedKey = 
ProtobufUtilities.decodeValue(serializationService, key);
+  Object value = region.get(decodedKey);
+  return ProtobufUtilities.createEntry(serializationService, 
decodedKey, value);
+} catch (CodecNotRegisteredForTypeException | 
UnsupportedEncodingTypeException ex) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue)
+  .setMessage("Encoding not supported."))
+  .build();
+} catch (org.apache.geode.distributed.LeaseExpiredException | 
TimeoutException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.OPERATION_TIMEOUT.codeValue)
+  .setMessage("Operation timed out: " + e.getMessage()))
+  .build();
+} catch (CacheLoaderException | PartitionedRegionStorageException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.DATA_UNREACHABLE.codeValue)
+  .setMessage("Data unreachable: " + e.getMessage()))
+  .build();
+} catch (NullPointerException | IllegalArgumentException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.CONSTRAINT_VIOLATION.codeValue)
+  .setMessage("Invalid input: " + e.getMessage()))
+  .build();
--- End diff --

 I think we should do this as part of a bigger refactor commit. Most of 
the message handlers build manually rather than using 
`ProtobufResponseUtilities.createAndLogErrorResponse`.


> Change GetAllRequest to return list of errors
> -
>
> Key: GEODE-3385
> URL: https://issues.apache.org/jira/browse/GEODE-3385
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> GetAllRequest currently returns a 

[jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142167#comment-16142167
 ] 

ASF GitHub Bot commented on GEODE-3447:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/719
  
@metatype We need the `StreamAuthenticator` to receive and send 
(Protobuf-encoded) messages containing the credentials that get passed to the 
`SecurityManager`. I would think that ideally it's nothing more than this.

I wonder if it would be better to send a hash that gets put into the 
Properties that SecurityManager uses, rather than having a message that 
explicitly contains username and password.


> Implement client authorization for the new protocol
> ---
>
> Key: GEODE-3447
> URL: https://issues.apache.org/jira/browse/GEODE-3447
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients 
> using the protocol to access my grid are authorized to perform each operation 
> they attempt.
> Implement client authorization for operations in new protocol based on 
> existing authorization configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[Shelley Lynn Hughes-Godfrey (JIRA)]

Shelley Lynn Hughes-Godfrey created GEODE-3522:
--

 Summary: puts via a load need to update AEQ and data region under 
a single lock (to prevent bucket movement during processing)
 Key: GEODE-3522
 URL: https://issues.apache.org/jira/browse/GEODE-3522
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: Shelley Lynn Hughes-Godfrey


New entries created via a loader can miss creating their lucene index if the 
primary is moved between adding the entry to the AEQ and into the localRegion.

handleWANEvent needs to be executed under the same lock held for putting a new 
entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey reassigned GEODE-3522:
--

Assignee: Shelley Lynn Hughes-Godfrey

> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-3522:
---
Affects Version/s: 1.2.1
   1.3.0
   1.2.0

> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3521) Update DiscoverJTA

[Fred Krone (JIRA)]

Fred Krone created GEODE-3521:
-

 Summary: Update DiscoverJTA
 Key: GEODE-3521
 URL: https://issues.apache.org/jira/browse/GEODE-3521
 Project: Geode
  Issue Type: Improvement
  Components: transactions
Reporter: Fred Krone


In order to reduce confusion on user experience we opt to have discover jta 
invoked during UserTransaction.begin -- rather than having to call discoverJTA 
directly.

AC:
1) discover JTA during UserTransaction.begin
2) provide a GemFire property (boolean) to opt out of this behavior for 
backwards compatibility
3) update unit tests notes accordingly





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141939#comment-16141939
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 92bf7fa2150b49b4d041e8ecf31009acc5070ad4 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=92bf7fa ]

GEODE-3503: fixing the build by correcting the formatting


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3464) If multiple MessageHandlers are found user should see exception

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3464:


Assignee: Udo Kohlmeyer

> If multiple MessageHandlers are found user should see exception
> ---
>
> Key: GEODE-3464
> URL: https://issues.apache.org/jira/browse/GEODE-3464
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Alexander Murmann
>Assignee: Udo Kohlmeyer
>
> Currently the system will use the first MessageHandler it finds. If there are 
> multiple it's unclear which one will be used, resulting in potentially 
> nondeterministic behavior. Instead a exception should be thrown if multiple 
> handlers are present. That behavior is still not ideal, but at least it's 
> deterministic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3461) BlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed fails intermittently with ConditionTimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141916#comment-16141916
 ] 

ASF subversion and git services commented on GEODE-3461:


Commit 4ea83c373ac618bb4e6c248ada559e46426e8b99 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4ea83c3 ]

GEODE-3461: GEODE-3505: mark test with FlakyTest category

* also increase timeout to wait for process to die


> BlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed 
> fails intermittently with ConditionTimeoutException
> -
>
> Key: GEODE-3461
> URL: https://issues.apache.org/jira/browse/GEODE-3461
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: CI, Flaky
>
> {noformat}
> org.awaitility.core.ConditionTimeoutException: Condition defined as a lambda 
> expression in 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest 
> expected:<[fals]e> but was:<[tru]e> within 2 milliseconds.
> at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
> at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
> at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
> at 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest.waitUntilProcessStops(AbstractProcessStreamReaderIntegrationTest.java:169)
> at 
> org.apache.geode.internal.process.BaseProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed(BaseProcessStreamReaderIntegrationTest.java:48)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown 

[jira] [Commented] (GEODE-3505) NonBlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed fails intermittently with ConditionTimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141917#comment-16141917
 ] 

ASF subversion and git services commented on GEODE-3505:


Commit 4ea83c373ac618bb4e6c248ada559e46426e8b99 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4ea83c3 ]

GEODE-3461: GEODE-3505: mark test with FlakyTest category

* also increase timeout to wait for process to die


> NonBlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed 
> fails intermittently with ConditionTimeoutException
> 
>
> Key: GEODE-3505
> URL: https://issues.apache.org/jira/browse/GEODE-3505
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
>
> {noformat}
> org.apache.geode.internal.process.NonBlockingProcessStreamReaderIntegrationTest
>  > processTerminatesWhenDestroyed FAILED
> org.awaitility.core.ConditionTimeoutException: Condition defined as a 
> lambda expression in 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest 
> expected:<[fals]e> but was:<[tru]e> within 2 milliseconds.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141898#comment-16141898
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit d775dfb3b68e1f800bcfe7f92af048b26a1fb1a5 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d775dfb ]

GEODE-3503: Removal of Codec classes left behind. This closes #737
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141899#comment-16141899
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/737


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141897#comment-16141897
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit cbe51bd1a0ed32a7ea33f18d181e73bbb8a157fa in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cbe51bd ]

GEODE-3503: fixed tests and reverted change to region_API.proto


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141896#comment-16141896
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 51338e4764e3708e184c30cd90ac1ad359279aa7 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=51338e4 ]

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3408) Flood of EOF warnings

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141884#comment-16141884
 ] 

ASF subversion and git services commented on GEODE-3408:


Commit 6eb8611d3f29ffc8514ac8bda5edc4e914c2e94d in geode's branch 
refs/heads/feature/GEODE-3503 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6eb8611 ]

GEODE-3408 Flood of EOF warnings

Modified the message handler to catch EOFException and effect shutdown
of the connection & server thread.  I also fixed the handling of
IOException.

The methods invoked are the same as for the old protocol's handling
of EOFException and IOException


> Flood of EOF warnings
> -
>
> Key: GEODE-3408
> URL: https://issues.apache.org/jira/browse/GEODE-3408
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Augustus Lidaka
> Fix For: 1.3.0
>
>
> Experimenting with the protobuf changes in the {{develop}} branch around 
> commit {{cea8312}}, after running a client scenario for a while I'm seeing a 
> flood of messages like the following. There appears to be one for each new 
> message sent from the client.
> {code}
> [warning 2017/08/07 11:15:16.628 PDT gbp-server  40404 Thread 9> tid=0x61] java.io.EOFException: Tried to deserialize protobuf 
> message at EOF
> {code}
> The log spam doesn't happen on initial connection and interaction, but for 
> example a loop like the following begins triggering it within 100 iterations 
> (possibly less):
> {code}
> for (var i = 0;; i++)
> {
> var region = ...; // connect to localhost, single-node server, get region
> region.Put(i, i);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3164) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails intermittently with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141882#comment-16141882
 ] 

ASF subversion and git services commented on GEODE-3164:


Commit e96281ee87b513c673a970968ae7524ef25d2fd7 in geode's branch 
refs/heads/feature/GEODE-3503 from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e96281e ]

GEODE-3164 Now while waiting we evaluate the condition again.


> ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails 
> intermittently with AssertionError
> --
>
> Key: GEODE-3164
> URL: https://issues.apache.org/jira/browse/GEODE-3164
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, management, tests
>Reporter: Hitesh Khamesra
>Assignee: Hitesh Khamesra
>  Labels: DistributedTest, Flaky
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_SubscriptionDisabled FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$33/1335405829.run
>  in VM 0 running on Host 57af4a2e6a1a with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled(ClientHealthStatsDUnitTest.java:136)
> Caused by:
> java.lang.AssertionError: 
> Expected size:<2> but was:<1> in:
> <["172.17.0.4(197:loner):57014:0e60d6fc"]>
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:314)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_SubscriptionDisabled$1db6af62$1(ClientHealthStatsDUnitTest.java:136)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3131) CI Failure: org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141885#comment-16141885
 ] 

ASF subversion and git services commented on GEODE-3131:


Commit 8309d44edf376db67ff7356616830677c1bacad5 in geode's branch 
refs/heads/feature/GEODE-3503 from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8309d44 ]

GEODE-3131: Increasing the time

* Increasing the time elapsed before the dispatchers are started.
* All validations must be done before the dispatcher start dispatching.

This closes #743


> CI Failure: 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut
> --
>
> Key: GEODE-3131
> URL: https://issues.apache.org/jira/browse/GEODE-3131
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.1.0
>Reporter: Jason Huynh
> Fix For: 1.3.0
>
>
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest > 
> testRefCountForNormalAndGIIPut FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest$$Lambda$95/1198712296.run
>  in VM 1 running on Host 893875957fbb with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut(HARQueueNewImplDUnitTest.java:383)
> Caused by:
> java.lang.AssertionError: expected:<3> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.verifyQueueData(HARQueueNewImplDUnitTest.java:1061)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.lambda$testRefCountForNormalAndGIIPut$bb17a952$11(HARQueueNewImplDUnitTest.java:383)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141888#comment-16141888
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit cbe51bd1a0ed32a7ea33f18d181e73bbb8a157fa in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cbe51bd ]

GEODE-3503: fixed tests and reverted change to region_API.proto


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3409) Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141881#comment-16141881
 ] 

ASF subversion and git services commented on GEODE-3409:


Commit 20fddb5cc346b604bd611bb857a14b8843a42306 in geode's branch 
refs/heads/feature/GEODE-3503 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=20fddb5 ]

GEODE-3409 Client Can't Connect Once Connection Limit Has Been Reached

ServerConnection cleanup was not decrementing the Acceptor's client
connection count when the protobuf communications mode was in effect.


> Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even 
> After Connections Closed
> ---
>
> Key: GEODE-3409
> URL: https://issues.apache.org/jira/browse/GEODE-3409
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Michael Martell
> Fix For: 1.3.0
>
> Attachments: Program.cs, sockclient.java
>
>
> We have a C# sample application (see attached) that connects to geode used 
> the new binary protocol. It floods the server continually with socket 
> connections and quickly reaches the default maximum connections of 800. When 
> the client app closes, all 800 connections appear to be closed by the server 
> (indeed 800 "Closed connection" messages appear in the server log). Running 
> the application again, the server immediately rejects even the first 
> connection request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3473) Change new protocol package to use *internal* naming convention

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141886#comment-16141886
 ] 

ASF subversion and git services commented on GEODE-3473:


Commit 174fe1bd35ac183a0a8661bc16bbd37ca560c4f5 in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=174fe1b ]

GEODE-3473: Initial commit of the internal package renaming refactor, starting 
with proto file package location.
Changing the protobuf file refactor first.


> Change new protocol package to use *internal* naming convention
> ---
>
> Key: GEODE-3473
> URL: https://issues.apache.org/jira/browse/GEODE-3473
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>
> New protocol needs to follow established conventions for Geode APIs.
> Change new protocol package to use *internal* naming convention.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141887#comment-16141887
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 51338e4764e3708e184c30cd90ac1ad359279aa7 in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=51338e4 ]

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141880#comment-16141880
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 92db0a6ac622c25924a7e615c6a9923593f716d4 in geode's branch 
refs/heads/feature/GEODE-3503 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=92db0a6 ]

GEODE-3395 Variable-ize product version and name in user guide - Cluster config


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.3.0
>
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3520) IndexMaintenanceExceptions should not affect a put

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-3520:
--

 Summary: IndexMaintenanceExceptions should not affect a put
 Key: GEODE-3520
 URL: https://issues.apache.org/jira/browse/GEODE-3520
 Project: Geode
  Issue Type: Bug
  Components: querying
Reporter: Jason Huynh


Currently if a put thread hits an Index Maintenance issue, the exception is 
returned back to the putter and the cache and any indexes updated up to that 
point are left in a bad state.   Any callbacks that occur after index 
maintenance are not fired.

Instead we should probably log the exception and mark the index as invalid.  
This will require us to provide a user a way to determine which indexes are 
valid/invalid (maybe a new column in GFSH to describe index).  The query engine 
would need to avoid using indexes marked as invalid.






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3520) IndexMaintenanceExceptions should not affect a put

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-3520:
--

Assignee: Jason Huynh

> IndexMaintenanceExceptions should not affect a put
> --
>
> Key: GEODE-3520
> URL: https://issues.apache.org/jira/browse/GEODE-3520
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Currently if a put thread hits an Index Maintenance issue, the exception is 
> returned back to the putter and the cache and any indexes updated up to that 
> point are left in a bad state.   Any callbacks that occur after index 
> maintenance are not fired.
> Instead we should probably log the exception and mark the index as invalid.  
> This will require us to provide a user a way to determine which indexes are 
> valid/invalid (maybe a new column in GFSH to describe index).  The query 
> engine would need to avoid using indexes marked as invalid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3473) Change new protocol package to use *internal* naming convention

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141814#comment-16141814
 ] 

ASF GitHub Bot commented on GEODE-3473:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/742


> Change new protocol package to use *internal* naming convention
> ---
>
> Key: GEODE-3473
> URL: https://issues.apache.org/jira/browse/GEODE-3473
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>
> New protocol needs to follow established conventions for Geode APIs.
> Change new protocol package to use *internal* naming convention.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3473) Change new protocol package to use *internal* naming convention

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141812#comment-16141812
 ] 

ASF subversion and git services commented on GEODE-3473:


Commit 174fe1bd35ac183a0a8661bc16bbd37ca560c4f5 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=174fe1b ]

GEODE-3473: Initial commit of the internal package renaming refactor, starting 
with proto file package location.
Changing the protobuf file refactor first.


> Change new protocol package to use *internal* naming convention
> ---
>
> Key: GEODE-3473
> URL: https://issues.apache.org/jira/browse/GEODE-3473
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>
> New protocol needs to follow established conventions for Geode APIs.
> Change new protocol package to use *internal* naming convention.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141739#comment-16141739
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 1bb1cae34814bdca298e476f8b88d19e4bc0dd51 in geode's branch 
refs/heads/release/1.2.1 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1bb1cae ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735

(cherry picked from commit d83ba36e8143054f8ce1fab4eec08641de8384f5)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3247) Improve OQL expression execution

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-3247:
-
Fix Version/s: (was: 1.2.1)

> Improve OQL expression execution
> 
>
> Key: GEODE-3247
> URL: https://issues.apache.org/jira/browse/GEODE-3247
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Anthony Baker
>Assignee: Jason Huynh
>
> We should validate an OQL expression before attempting to invoke it to 
> prevent undesirable behavior.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)