[jira] [Commented] (GEODE-2668) Add gfsh command to destroy gateway receiver
[ https://issues.apache.org/jira/browse/GEODE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279753#comment-16279753 ] ASF GitHub Bot commented on GEODE-2668: --- jinmeiliao opened a new pull request #1127: GEODE-2668: build tabular command result from a list of function results URL: https://github.com/apache/geode/pull/1127 This includes 2 commits, one is general refactor to reduce code duplicates, one is to udpate cluster config when destroy gateway sender. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add gfsh command to destroy gateway receiver > > > Key: GEODE-2668 > URL: https://issues.apache.org/jira/browse/GEODE-2668 > Project: Geode > Issue Type: Sub-task > Components: docs, gfsh >Reporter: Swapnil Bawaskar > > Currently, there is a {{create gateway-receiver}} command, but no > corresponding destroy command. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279738#comment-16279738 ] ASF subversion and git services commented on GEODE-3806: Commit 64fa53c10fdf05622c5a30b723564ae1996f605d in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=64fa53c ] Revert " GEODE-3806: Updated to Xerces-C 3.2.0. (#163)" This reverts commit fec16323b4f601b9a722c4cb6f27ec48055944a6. > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://issues.apache.org/jira/browse/GEODE-3806 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Rolls up lots of fixes in the 3.1 branch and add CMake build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-3806. --- > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://issues.apache.org/jira/browse/GEODE-3806 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Rolls up lots of fixes in the 3.1 branch and add CMake build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-3806. - Resolution: Fixed > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://issues.apache.org/jira/browse/GEODE-3806 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Rolls up lots of fixes in the 3.1 branch and add CMake build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279696#comment-16279696 ] ASF subversion and git services commented on GEODE-3806: Commit fec16323b4f601b9a722c4cb6f27ec48055944a6 in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=fec1632 ] GEODE-3806: Updated to Xerces-C 3.2.0. (#163) - Convert to CMake build process. > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://issues.apache.org/jira/browse/GEODE-3806 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Rolls up lots of fixes in the 3.1 branch and add CMake build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279695#comment-16279695 ] ASF GitHub Bot commented on GEODE-3806: --- pivotal-jbarrett closed pull request #163: GEODE-3806: Updated to Xerces-C 3.2.0. URL: https://github.com/apache/geode-native/pull/163 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dependencies/xerces-c/CMakeLists.txt b/dependencies/xerces-c/CMakeLists.txt index dc29d7ab..af59de5b 100644 --- a/dependencies/xerces-c/CMakeLists.txt +++ b/dependencies/xerces-c/CMakeLists.txt @@ -12,55 +12,24 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -cmake_minimum_required( VERSION 3.3 ) + project( xerces-c ) -set( ${PROJECT_NAME}_VERSION 3.1.4 ) -set( ${PROJECT_NAME}_SHA265 c98eedac4cf8a73b09366ad349cb3ef30640e7a3089d360d40a3dde93f66ecf6 ) +set( ${PROJECT_NAME}_VERSION 3.2.0 ) +set( ${PROJECT_NAME}_SHA265 d3162910ada85612f5b8cc89cdab84d0ad9a852a49577691e54bc7e9fc304e15 ) set( ${PROJECT_NAME}_URL "http://archive.apache.org/dist/xerces/c/3/sources/xerces-c-${${PROJECT_NAME}_VERSION}.tar.gz"; ) set( ${PROJECT_NAME}_EXTERN ${PROJECT_NAME}-extern ) set ( ${PROJECT_NAME}_CFLAGS "${${PROJECT_NAME}_CFLAGS} ${CFLAGS_ARCH}" ) set ( ${PROJECT_NAME}_CXXFLAGS "${${PROJECT_NAME}_CXXFLAGS} ${CXXFLAGS_ARCH} ${CXXFLAGS_C++}" ) - - if (MSVC_VERSION GREATER 14) -# Only have project files for VS14 and older -set(MSVC_VERSION 14) - endiF() - -if (WIN32) - if (64 EQUAL ${BUILD_BITS}) -set( _PLATFORM x64 ) -set( _BUILD_DIR Build/Win64/VC${MSVC_VERSION}/${_DEBUG_OR_RELEASE} ) - else() -set( _PLATFORM win32 ) -set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION}/${_DEBUG_OR_RELEASE} ) - endif() - - set ( _CONFIGURE_COMMAND "" ) - set ( _BUILD_COMMAND ${MSBUILD} projects\\Win32\\VC${MSVC_VERSION}\\xerces-all\\xerces-all.sln /m /p:Configuration=${_DEBUG_OR_RELEASE} /p:Platform=${_PLATFORM} ) - set ( _INSTALL_COMMAND ${CMAKE_COMMAND} -E copy ${_BUILD_DIR}/xerces-c_3_1$<$:D>.dll /bin/xerces-c_3_1$<$:D>.dll - COMMAND ${CMAKE_COMMAND} -E copy ${_BUILD_DIR}/xerces-c_3$<$:D>.lib /lib/xerces-c_3$<$:D>.lib - #TODO cleanup includes? - COMMAND ${CMAKE_COMMAND} -E copy_directory src /include ) -else() - set ( _CONFIGURE_COMMAND ${CONFIGURE} $<$:--with-debug> --libdir=/lib --without-curl --with-pic "CFLAGS=${${PROJECT_NAME}_CFLAGS}" "CXXFLAGS=${${PROJECT_NAME}_CXXFLAGS}" "MAKE=$(MAKE)" ) - set ( _BUILD_COMMAND $(MAKE) all ) - set ( _INSTALL_COMMAND $(MAKE) install ) -endif() - include(ExternalProject) ExternalProject_Add( ${${PROJECT_NAME}_EXTERN} URL ${${PROJECT_NAME}_URL} URL_HASH SHA256=${${PROJECT_NAME}_SHA265} - #TODO prefix - directory length too long for windows UPDATE_COMMAND "" - BUILD_IN_SOURCE 1 - CONFIGURE_COMMAND "${_CONFIGURE_COMMAND}" - BUILD_COMMAND "${_BUILD_COMMAND}" - INSTALL_COMMAND "${_INSTALL_COMMAND}" + CMAKE_ARGS -DCMAKE_C_FLAGS=-m64 -DCMAKE_CXX_FLAGS=-m64 -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX= ) ExternalProject_Get_Property( ${${PROJECT_NAME}_EXTERN} SOURCE_DIR ) @@ -69,9 +38,15 @@ ExternalProject_Get_Property( ${${PROJECT_NAME}_EXTERN} INSTALL_DIR ) set( ${PROJECT_NAME}_INSTALL_DIR ${INSTALL_DIR} ) set( DEPENDENCIES_${PROJECT_NAME}_DIR ${${PROJECT_NAME}_INSTALL_DIR} PARENT_SCOPE) +if (${WIN32}) + set(LIBRARY_NAME xerces-c_3$<$:D>) +else() + set(LIBRARY_NAME xerces-c-3.2) +endif() + if (${WIN32}) #TODO find better way to handle import lib on windows - set(CMAKE_SHARED_LIBRARY_SUFFIX _3$<$:D>.lib) + set(CMAKE_SHARED_LIBRARY_SUFFIX .lib) endif() add_library(${PROJECT_NAME} INTERFACE) @@ -79,7 +54,7 @@ target_include_directories(${PROJECT_NAME} INTERFACE $ ) target_link_libraries(${PROJECT_NAME} INTERFACE - ${${PROJECT_NAME}_INSTALL_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}xerces-c${CMAKE_SHARED_LIBRARY_SUFFIX} + ${${PROJECT_NAME}_INSTALL_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}${LIBRARY_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX} ) add_dependencies(${PROJECT_NAME} ${${PROJECT_NAME}_EXTERN}) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://iss
[jira] [Commented] (GEODE-4057) [CI Failure] PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution
[ https://issues.apache.org/jira/browse/GEODE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279501#comment-16279501 ] ASF GitHub Bot commented on GEODE-4057: --- nabarunnag opened a new pull request #1126: GEODE-4057: Cleaning up previous cache. URL: https://github.com/apache/geode/pull/1126 * Adding a helper function to clean up any cache left behind by previously executed tests. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CI Failure] > PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution > - > > Key: GEODE-4057 > URL: https://issues.apache.org/jira/browse/GEODE-4057 > Project: Geode > Issue Type: Bug > Components: cq >Reporter: nabarun > > *+Failure+*: Apache Geode Concourse CI Distributed Test RunID#7 > *+More logs can be found in+* : > http://files.apachegeode-ci.info/builds/1.4.0-build.150/test-results/distributedTest/ > +*Stacktrace*+ : > {noformat} > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest$10.run > in VM 1 running on Host cf0c71b42eff with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:393) > at org.apache.geode.test.dunit.VM.invoke(VM.java:363) > at org.apache.geode.test.dunit.VM.invoke(VM.java:308) > at > org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.createClient(PartitionedRegionCqQueryDUnitTest.java:1272) > at > org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.createClient(PartitionedRegionCqQueryDUnitTest.java:1234) > at > org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution(PartitionedRegionCqQueryOptimizedExecuteDUnitTest.java:79) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunn
[jira] [Commented] (GEODE-4020) Implement list jdbc-connection command
[ https://issues.apache.org/jira/browse/GEODE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279493#comment-16279493 ] ASF subversion and git services commented on GEODE-4020: Commit cffa2f4da02b7267b76f576ce7f6aa40a3298fcc in geode's branch refs/heads/feature/GEODE-3781 from lgallinat [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cffa2f4 ] Feature/geode 4020 (#1122) GEODE-4020 Add list connection command > Implement list jdbc-connection command > -- > > Key: GEODE-4020 > URL: https://issues.apache.org/jira/browse/GEODE-4020 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Kirk Lund >Assignee: Kirk Lund > > Need to be able to list all existing JDBC connections via GFSH. > {noformat} > NAME > list jdbc-connection > SYNOPSIS > Display jdbc connections for all members. > SYNTAX > list jdbc-connection > PARAMETERS > none > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4020) Implement list jdbc-connection command
[ https://issues.apache.org/jira/browse/GEODE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279489#comment-16279489 ] ASF subversion and git services commented on GEODE-4020: Commit 64a7913747ca7400ef37f553e8e696bc89bc37df in geode's branch refs/heads/feature/GEODE-4020 from [~lgallinat] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=64a7913 ] GEODE-4020 Review changes and spotless formatting > Implement list jdbc-connection command > -- > > Key: GEODE-4020 > URL: https://issues.apache.org/jira/browse/GEODE-4020 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Kirk Lund >Assignee: Kirk Lund > > Need to be able to list all existing JDBC connections via GFSH. > {noformat} > NAME > list jdbc-connection > SYNOPSIS > Display jdbc connections for all members. > SYNTAX > list jdbc-connection > PARAMETERS > none > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
[ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279460#comment-16279460 ] ASF GitHub Bot commented on GEODE-4052: --- PurelyApplied opened a new pull request #1125: GEODE-4052: Expand GfshExitCodeStatusCommandsTest to multiple... URL: https://github.com/apache/geode/pull/1125 ... acceptance tests for better cohesion and failure reporting. --- Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expand GfshExitCodeStatusCommandTest into multiple classes for more > meaningful failure reporting > > > Key: GEODE-4052 > URL: https://issues.apache.org/jira/browse/GEODE-4052 > Project: Geode > Issue Type: Test > Components: gfsh, tests >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg > > Occasionally, the majority of this class's tests will fail due to being > unable to start the cluster. Such a failure is beyond the scope of the test > and should be reported quickly. > This class should be divided into two classes, one containing those tests > that require the cluster's server to be running and one that does not. The > cluster start-up in both cases should be delegated to a {{@BeforeClass}} > method so that failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
[ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279454#comment-16279454 ] ASF GitHub Bot commented on GEODE-4052: --- PurelyApplied commented on issue #1124: GEODE-4052: Expand GfshExitodeStatusCommandstest to multiple classes... URL: https://github.com/apache/geode/pull/1124#issuecomment-349491168 Requested against wrong branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expand GfshExitCodeStatusCommandTest into multiple classes for more > meaningful failure reporting > > > Key: GEODE-4052 > URL: https://issues.apache.org/jira/browse/GEODE-4052 > Project: Geode > Issue Type: Test > Components: gfsh, tests >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg > > Occasionally, the majority of this class's tests will fail due to being > unable to start the cluster. Such a failure is beyond the scope of the test > and should be reported quickly. > This class should be divided into two classes, one containing those tests > that require the cluster's server to be running and one that does not. The > cluster start-up in both cases should be delegated to a {{@BeforeClass}} > method so that failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
[ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279453#comment-16279453 ] ASF GitHub Bot commented on GEODE-4052: --- PurelyApplied opened a new pull request #1124: GEODE-4052: Expand GfshExitodeStatusCommandstest to multiple classes... URL: https://github.com/apache/geode/pull/1124 ... for better cohesion and error reporting. - Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expand GfshExitCodeStatusCommandTest into multiple classes for more > meaningful failure reporting > > > Key: GEODE-4052 > URL: https://issues.apache.org/jira/browse/GEODE-4052 > Project: Geode > Issue Type: Test > Components: gfsh, tests >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg > > Occasionally, the majority of this class's tests will fail due to being > unable to start the cluster. Such a failure is beyond the scope of the test > and should be reported quickly. > This class should be divided into two classes, one containing those tests > that require the cluster's server to be running and one that does not. The > cluster start-up in both cases should be delegated to a {{@BeforeClass}} > method so that failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4058) Need to clean up disk files in JUnit4TestCase tearDown
[ https://issues.apache.org/jira/browse/GEODE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279423#comment-16279423 ] ASF GitHub Bot commented on GEODE-4058: --- upthewaterspout opened a new pull request #1123: GEODE-4058: Always delete disk files after every test runs URL: https://github.com/apache/geode/pull/1123 Avoid hangs due to leftover disk files by making sure that all tests that use JUnit4DistributedCase have their disk files cleaned up after the test, including a locators ConfigDiskDir_ Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Need to clean up disk files in JUnit4TestCase tearDown > -- > > Key: GEODE-4058 > URL: https://issues.apache.org/jira/browse/GEODE-4058 > Project: Geode > Issue Type: Bug > Components: tests >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.4.0 > > > We've been seeing some tests hang in precheckin. > I tracked down one of the hangs to running RollingUpgrade2DUnitTest followed > by FixedPRSinglehopDUnitTest. What both tests cases are doing is starting a > locator in vm-2 that uses a ConfigDiskDir_directory. The disk files left by > RollingUpgrade2DunitTest are causing FixedPRSindleHopDUnitTest to wait for > other members to start up. > We should make sure we always clean up these files after the test finishes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4008) InvalidClassException when deserializing FunctionAdapter from pre Geode clients
[ https://issues.apache.org/jira/browse/GEODE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279401#comment-16279401 ] ASF GitHub Bot commented on GEODE-4008: --- pivotal-jbarrett commented on a change in pull request #1119: GEODE-4008: Add serialVersionUID of older clients to FunctionAdapter URL: https://github.com/apache/geode/pull/1119#discussion_r155112748 ## File path: geode-core/src/test/java/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.java ## @@ -16,15 +16,26 @@ import static org.junit.Assert.*; +import java.io.DataInputStream; +import java.io.DataOutputStream; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.Serializable; + import org.junit.Before; import org.junit.Test; import org.junit.experimental.categories.Category; +import org.apache.geode.internal.InternalDataSerializer; +import org.apache.geode.internal.Version; +import org.apache.geode.internal.VersionedDataInputStream; import org.apache.geode.test.junit.categories.UnitTest; +import org.apache.geode.util.test.TestUtil; @Category(UnitTest.class) -public class FunctionAdapterJUnitTest { +public class FunctionAdapterJUnitTest implements Serializable { Review comment: Is the test class only `Serializable` to serialize the anonymous inner class? Seems cleaner to have a static inner class and not make the test class `Serializable`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InvalidClassException when deserializing FunctionAdapter from pre Geode > clients > --- > > Key: GEODE-4008 > URL: https://issues.apache.org/jira/browse/GEODE-4008 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Jason Huynh >Assignee: Jason Huynh > > There was a change to deprecate FunctionAdapter in Geode, and this removed > the method signatures of the class. This causes Java to assign a new > serialVersionUID to the class. However we have clients pre Geode that when > they attempt to execute a function by serializing the function across (not > using a function id), the FunctionAdapter class is unable to deserialize > properly. > The proposed fix is to assign a serialVersionUID to the class that matches > that of the pre Geode FunctionAdapter. This will cause any Geode 1.0-1.3 > clients to run into this same error. However FunctionAdapter has been > deprecated and it would be easy enough to just change the classes to > implement Function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-4058) Need to clean up disk files in JUnit4TestCase tearDown
[ https://issues.apache.org/jira/browse/GEODE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-4058: - Fix Version/s: 1.4.0 > Need to clean up disk files in JUnit4TestCase tearDown > -- > > Key: GEODE-4058 > URL: https://issues.apache.org/jira/browse/GEODE-4058 > Project: Geode > Issue Type: Bug > Components: tests >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.4.0 > > > We've been seeing some tests hang in precheckin. > I tracked down one of the hangs to running RollingUpgrade2DUnitTest followed > by FixedPRSinglehopDUnitTest. What both tests cases are doing is starting a > locator in vm-2 that uses a ConfigDiskDir_directory. The disk files left by > RollingUpgrade2DunitTest are causing FixedPRSindleHopDUnitTest to wait for > other members to start up. > We should make sure we always clean up these files after the test finishes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-4058) Need to clean up disk files in JUnit4TestCase tearDown
[ https://issues.apache.org/jira/browse/GEODE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith reassigned GEODE-4058: Assignee: Dan Smith > Need to clean up disk files in JUnit4TestCase tearDown > -- > > Key: GEODE-4058 > URL: https://issues.apache.org/jira/browse/GEODE-4058 > Project: Geode > Issue Type: Bug > Components: tests >Reporter: Dan Smith >Assignee: Dan Smith > > We've been seeing some tests hang in precheckin. > I tracked down one of the hangs to running RollingUpgrade2DUnitTest followed > by FixedPRSinglehopDUnitTest. What both tests cases are doing is starting a > locator in vm-2 that uses a ConfigDiskDir_directory. The disk files left by > RollingUpgrade2DunitTest are causing FixedPRSindleHopDUnitTest to wait for > other members to start up. > We should make sure we always clean up these files after the test finishes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4058) Need to clean up disk files in JUnit4TestCase tearDown
Dan Smith created GEODE-4058: Summary: Need to clean up disk files in JUnit4TestCase tearDown Key: GEODE-4058 URL: https://issues.apache.org/jira/browse/GEODE-4058 Project: Geode Issue Type: Bug Components: tests Reporter: Dan Smith We've been seeing some tests hang in precheckin. I tracked down one of the hangs to running RollingUpgrade2DUnitTest followed by FixedPRSinglehopDUnitTest. What both tests cases are doing is starting a locator in vm-2 that uses a ConfigDiskDir_directory. The disk files left by RollingUpgrade2DunitTest are causing FixedPRSindleHopDUnitTest to wait for other members to start up. We should make sure we always clean up these files after the test finishes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4020) Implement list jdbc-connection command
[ https://issues.apache.org/jira/browse/GEODE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279387#comment-16279387 ] ASF subversion and git services commented on GEODE-4020: Commit 3ff633690af22280680e184cfb938584c59b9797 in geode's branch refs/heads/feature/GEODE-4020 from [~lgallinat] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3ff6336 ] GEODE-4020 Fill in dunit tests for list connection command and send gfsh command to only one member > Implement list jdbc-connection command > -- > > Key: GEODE-4020 > URL: https://issues.apache.org/jira/browse/GEODE-4020 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Kirk Lund >Assignee: Kirk Lund > > Need to be able to list all existing JDBC connections via GFSH. > {noformat} > NAME > list jdbc-connection > SYNOPSIS > Display jdbc connections for all members. > SYNTAX > list jdbc-connection > PARAMETERS > none > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3683) CacheConnectionTimeoutJUnitTest failing intermittently in CI.
[ https://issues.apache.org/jira/browse/GEODE-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279374#comment-16279374 ] ASF subversion and git services commented on GEODE-3683: Commit 5c9caf441ee35621ed7fb948149547cf85cfee40 in geode's branch refs/heads/develop from [~bschuchardt] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5c9caf4 ] GEODE-3683 CacheConnectionTimeoutJUnitTest failing intermittently in CI Increased the maximumTimeBetweenPings from 100ms to 2000ms. Tests on a mac with Intellij showed a minimum of 19ms between finishing the setup method and commencing the actual test method. Adding a short sleep at the beginning of the test method caused it to fail repeatedly with the lower setting. A 2 second timeout period allowed the test to succeed in 200 consecutive runs. ' > CacheConnectionTimeoutJUnitTest failing intermittently in CI. > - > > Key: GEODE-3683 > URL: https://issues.apache.org/jira/browse/GEODE-3683 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Galen O'Sullivan >Assignee: Bruce Schuchardt > Fix For: 1.4.0 > > > The `testUnresponsiveClientsGetDisconnected` test is failing. I think this is > because the Awaitility condition is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3683) CacheConnectionTimeoutJUnitTest failing intermittently in CI.
[ https://issues.apache.org/jira/browse/GEODE-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-3683. - Resolution: Fixed Fix Version/s: 1.4.0 > CacheConnectionTimeoutJUnitTest failing intermittently in CI. > - > > Key: GEODE-3683 > URL: https://issues.apache.org/jira/browse/GEODE-3683 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Galen O'Sullivan >Assignee: Bruce Schuchardt > Fix For: 1.4.0 > > > The `testUnresponsiveClientsGetDisconnected` test is failing. I think this is > because the Awaitility condition is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3683) CacheConnectionTimeoutJUnitTest failing intermittently in CI.
[ https://issues.apache.org/jira/browse/GEODE-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt reassigned GEODE-3683: --- Assignee: Bruce Schuchardt > CacheConnectionTimeoutJUnitTest failing intermittently in CI. > - > > Key: GEODE-3683 > URL: https://issues.apache.org/jira/browse/GEODE-3683 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Galen O'Sullivan >Assignee: Bruce Schuchardt > > The `testUnresponsiveClientsGetDisconnected` test is failing. I think this is > because the Awaitility condition is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3683) CacheConnectionTimeoutJUnitTest failing intermittently in CI.
[ https://issues.apache.org/jira/browse/GEODE-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279358#comment-16279358 ] Bruce Schuchardt commented on GEODE-3683: - This failure was in the initial use of the connection. I think the maximumTimeBetweenPings was set too low, causing the connection created in setup() to be closed before the test got to the point of using it. > CacheConnectionTimeoutJUnitTest failing intermittently in CI. > - > > Key: GEODE-3683 > URL: https://issues.apache.org/jira/browse/GEODE-3683 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Galen O'Sullivan > > The `testUnresponsiveClientsGetDisconnected` test is failing. I think this is > because the Awaitility condition is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-4013) shutdown of a cache server with ServerLauncher causes JVM to exit before completing shutdown
[ https://issues.apache.org/jira/browse/GEODE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt updated GEODE-4013: Affects Version/s: 1.3.0 > shutdown of a cache server with ServerLauncher causes JVM to exit before > completing shutdown > > > Key: GEODE-4013 > URL: https://issues.apache.org/jira/browse/GEODE-4013 > Project: Geode > Issue Type: Bug > Components: management >Affects Versions: 1.3.0 >Reporter: Bruce Schuchardt > > Also see GEODE-1236, concerning the same behavior with GFSH. > A server launched via ServerLauncher is kept alive by its AcceptorImpl > thread. That is the only non-daemon thread in the JVM. If you shutdown that > server with ServerLauncher it will invoke cache.close() which midway through > closing will terminate the AcceptorImpl thread and cause the JVM to exit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3923) Provide whitelist/blacklist capability for java serialization
[ https://issues.apache.org/jira/browse/GEODE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-3923. - Resolution: Fixed > Provide whitelist/blacklist capability for java serialization > - > > Key: GEODE-3923 > URL: https://issues.apache.org/jira/browse/GEODE-3923 > Project: Geode > Issue Type: New Feature > Components: docs >Reporter: Bruce Schuchardt > Fix For: 1.4.0 > > > I would like to be able to restrict what classes of objects Geode will allow > to be deserialized via Java's ObjectInputStream in clients and servers. > Something similar to the mechanism recently added to the JRE > (http://openjdk.java.net/jeps/290) would be pretty cool. Geode would have to > whitelist its own stuff, of course, so I don't have to deal with it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp
[ https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279308#comment-16279308 ] ASF subversion and git services commented on GEODE-4042: Commit 279072f578c5ae12552d97164bbb8041b585cda1 in geode's branch refs/heads/develop from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=279072f ] GEODE-4042: Fixed additional tmp dir references (#1121) > Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of > hardcoding to /tmp > > > Key: GEODE-4042 > URL: https://issues.apache.org/jira/browse/GEODE-4042 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > Currently the Cargo Tests for the session state module are hard coded to run > off of /tmp. Instead it should probably be pointed towards using > java.io.tmpdir. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp
[ https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279307#comment-16279307 ] ASF GitHub Bot commented on GEODE-4042: --- nabarunnag closed pull request #1121: GEODE-4042: Removed additional tmp dir references URL: https://github.com/apache/geode/pull/1121 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java b/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java index fbd9593dbb..70a82c1429 100644 --- a/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java +++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java @@ -15,6 +15,7 @@ package org.apache.geode.session.tests; import static org.apache.geode.session.tests.ContainerInstall.GEODE_BUILD_HOME; +import static org.apache.geode.session.tests.ContainerInstall.TMP_DIR; import java.io.File; import java.io.IOException; @@ -41,7 +42,7 @@ private final File modifyWarScript; private final File modifyWarScriptLog; - private static final String DEFAULT_GENERIC_APPSERVER_WAR_DIR = "/tmp/cargo_wars/"; + private static final String DEFAULT_GENERIC_APPSERVER_WAR_DIR = TMP_DIR + "/cargo_wars/"; /** * Setup the generic appserver container diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java b/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java index a1b36fa664..71e5e73663 100644 --- a/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java +++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java @@ -14,6 +14,8 @@ */ package org.apache.geode.session.tests; +import static org.apache.geode.session.tests.ContainerInstall.TMP_DIR; + import java.io.File; import java.io.IOException; import java.util.Arrays; @@ -70,7 +72,7 @@ public static final String DEFAULT_LOGGING_LEVEL = LoggingLevel.LOW.getLevel(); public static final String DEFAULT_LOG_DIR = "cargo_logs/"; - public static final String DEFAULT_CONFIG_DIR = "/tmp/cargo_configs/"; + public static final String DEFAULT_CONFIG_DIR = TMP_DIR + "/cargo_configs/"; public static final Logger logger = LogService.getLogger(); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of > hardcoding to /tmp > > > Key: GEODE-4042 > URL: https://issues.apache.org/jira/browse/GEODE-4042 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > Currently the Cargo Tests for the session state module are hard coded to run > off of /tmp. Instead it should probably be pointed towards using > java.io.tmpdir. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4057) [CI Failure] PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution
nabarun created GEODE-4057: -- Summary: [CI Failure] PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution Key: GEODE-4057 URL: https://issues.apache.org/jira/browse/GEODE-4057 Project: Geode Issue Type: Bug Components: cq Reporter: nabarun *+Failure+*: Apache Geode Concourse CI Distributed Test RunID#7 *+More logs can be found in+* : http://files.apachegeode-ci.info/builds/1.4.0-build.150/test-results/distributedTest/ +*Stacktrace*+ : {noformat} org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest$10.run in VM 1 running on Host cf0c71b42eff with 4 VMs at org.apache.geode.test.dunit.VM.invoke(VM.java:393) at org.apache.geode.test.dunit.VM.invoke(VM.java:363) at org.apache.geode.test.dunit.VM.invoke(VM.java:308) at org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.createClient(PartitionedRegionCqQueryDUnitTest.java:1272) at org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.createClient(PartitionedRegionCqQueryDUnitTest.java:1234) at org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution(PartitionedRegionCqQueryOptimizedExecuteDUnitTest.java:79) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.j
[jira] [Updated] (GEODE-4056) [CI Failure] SerialWANPropagationDUnitTest. testPreloadedSerialPropagation
[ https://issues.apache.org/jira/browse/GEODE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun updated GEODE-4056: --- Description: *+Failure+* : Apache Geode Concourse CI Distributed Tests RunID # 6 *+More logs can be found in+* : http://files.apachegeode-ci.info/builds/1.4.0-build.149/test-results/distributedTest/ Stacktrace: {noformat} java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in log4j at line 1931 [fatal 2017/12/02 02:41:31.982 UTC tid=1063] Possible loss of quorum due to the loss of 1 cache processes: [172.17.0.2(153):32771] at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:394) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.cleanupAllVms(JUnit4DistributedTestCase.java:541) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.doTearDownDistributedTestCase(JUnit4DistributedTestCase.java:488) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.tearDownDistributedTestCase(JUnit4DistributedTestCase.java:475) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.remote.internal
[jira] [Created] (GEODE-4056) [CI Failure] SerialWANPropagationDUnitTest. testPreloadedSerialPropagation
nabarun created GEODE-4056: -- Summary: [CI Failure] SerialWANPropagationDUnitTest. testPreloadedSerialPropagation Key: GEODE-4056 URL: https://issues.apache.org/jira/browse/GEODE-4056 Project: Geode Issue Type: Bug Components: wan Reporter: nabarun *+Failure : +*Apache Geode Concourse CI Distributed Tests RunID # 6 *+More logs can be found in+* : http://files.apachegeode-ci.info/builds/1.4.0-build.149/test-results/distributedTest/ Stacktrace: {noformat} java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in log4j at line 1931 [fatal 2017/12/02 02:41:31.982 UTC tid=1063] Possible loss of quorum due to the loss of 1 cache processes: [172.17.0.2(153):32771] at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:394) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.cleanupAllVms(JUnit4DistributedTestCase.java:541) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.doTearDownDistributedTestCase(JUnit4DistributedTestCase.java:488) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.tearDownDistributedTestCase(JUnit4DistributedTestCase.java:475) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(
[jira] [Updated] (GEODE-4056) [CI Failure] SerialWANPropagationDUnitTest. testPreloadedSerialPropagation
[ https://issues.apache.org/jira/browse/GEODE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun updated GEODE-4056: --- Description: *+Failure :+*Apache Geode Concourse CI Distributed Tests RunID # 6 *+More logs can be found in+* : http://files.apachegeode-ci.info/builds/1.4.0-build.149/test-results/distributedTest/ Stacktrace: {noformat} java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in log4j at line 1931 [fatal 2017/12/02 02:41:31.982 UTC tid=1063] Possible loss of quorum due to the loss of 1 cache processes: [172.17.0.2(153):32771] at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:394) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.cleanupAllVms(JUnit4DistributedTestCase.java:541) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.doTearDownDistributedTestCase(JUnit4DistributedTestCase.java:488) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.tearDownDistributedTestCase(JUnit4DistributedTestCase.java:475) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.remote.internal.
[jira] [Updated] (GEODE-4055) [CI Failure ] SerialWANPropagationOffHeapDUnitTest. testReplicatedSerialPropagationWithoutRemoteSite_defect46595
[ https://issues.apache.org/jira/browse/GEODE-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun updated GEODE-4055: --- Description: *+Complete logs can be found in :+* http://files.apachegeode-ci.info/builds/1.4.0-build.149/test-results/distributedTest/ +*Failure :*+ apache geode concourse CI Distributed Test Run ID# 6 Stacktrace: {noformat} java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in log4j at line 3831 [fatal 2017/12/02 02:52:39.185 UTCtid=3254] Possible loss of quorum due to the loss of 1 cache processes: [172.17.0.6(171) :32776] at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:394) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.cleanupAllVms(JUnit4DistributedTestCase.java:541) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.doTearDownDistributedTestCase(JUnit4DistributedTestCase.java:488) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.tearDownDistributedTestCase(JUnit4DistributedTestCase.java:475) at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrap
[jira] [Created] (GEODE-4055) [CI Failure ] SerialWANPropagationOffHeapDUnitTest. testReplicatedSerialPropagationWithoutRemoteSite_defect46595
nabarun created GEODE-4055: -- Summary: [CI Failure ] SerialWANPropagationOffHeapDUnitTest. testReplicatedSerialPropagationWithoutRemoteSite_defect46595 Key: GEODE-4055 URL: https://issues.apache.org/jira/browse/GEODE-4055 Project: Geode Issue Type: Bug Components: wan Reporter: nabarun *+Complete logs can be found in :+* http://files.apachegeode-ci.info/builds/1.4.0-build.149/test-results/distributedTest/ +*Failure :*+ apache concourse Distributed Test Run ID# 6 Stacktrace: {noformat} java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in log4j at line 3831 [fatal 2017/12/02 02:52:39.185 UTCtid=3254] Possible loss of quorum due to the loss of 1 cache processes: [172.17.0.6(171) :32776] at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:394) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.cleanupAllVms(JUnit4DistributedTestCase.java:541) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.doTearDownDistributedTestCase(JUnit4DistributedTestCase.java:488) at org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.tearDownDistributedTestCase(JUnit4DistributedTestCase.java:475) at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.ja
[jira] [Commented] (GEODE-3964) Add another severe-alert option
[ https://issues.apache.org/jira/browse/GEODE-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279166#comment-16279166 ] ASF GitHub Bot commented on GEODE-3964: --- galen-pivotal commented on a change in pull request #1088: GEODE-3964: More logging for suspect processing. URL: https://github.com/apache/geode/pull/1088#discussion_r155071214 ## File path: geode-core/src/main/java/org/apache/geode/distributed/internal/ReplyProcessor21.java ## @@ -139,43 +140,35 @@ protected final DM dmgr; /** Start time for replyWait stat, in nanos */ - protected long statStart; + long statStart; /** Start time for ack-wait-threshold, in millis */ - protected long initTime; + private long initTime; /** * whether this reply processor should perform severe-alert processing for the message being ack'd */ - protected boolean severeAlertEnabled; + private boolean severeAlertEnabled; /** * whether the severe-alert timeout has been reset. This can happen if a member we're waiting for * is waiting on a suspect member, for instance. */ - protected volatile boolean severeAlertTimerReset; + private volatile boolean severeAlertTimerReset; /** * whether this reply processor should shorten severe-alert processing due to another vm waiting * on this one. This is a thread-local so that lower level comm layers can tell that the interval * should be shortened */ - public static final ThreadLocal SevereAlertShorten = new ThreadLocal() { -@Override -protected Object initialValue() { - return Boolean.FALSE; -} - }; + private static final ThreadLocal SevereAlertShorten = Review comment: Probably not. I didn't even know that was a word. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add another severe-alert option > --- > > Key: GEODE-3964 > URL: https://issues.apache.org/jira/browse/GEODE-3964 > Project: Geode > Issue Type: Bug > Components: messaging >Reporter: Bruce Schuchardt > > Since suspect processing only commences when the ack-severe-alert-threshold > is reached it would be nice to have yet another alert if that processing > failed to kick out the slow-to-respond member and a thread is stuck for a > long time waiting for a reply. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-4015) CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with AssertionError
[ https://issues.apache.org/jira/browse/GEODE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby resolved GEODE-4015. -- Resolution: Fixed Fix Version/s: 1.4.0 > CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with > AssertionError > -- > > Key: GEODE-4015 > URL: https://issues.apache.org/jira/browse/GEODE-4015 > Project: Geode > Issue Type: Bug > Components: client queues >Reporter: Barry Oglesby > Fix For: 1.4.0 > > > Both testTwoRegionsTwoWriters and testTwoRegionsOneWriter failed with the > same AssertionError: > {noformat} > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > > testTwoRegionsTwoWriters FAILED > java.lang.AssertionError: Test failed due to exception > at org.apache.geode.test.dunit.Assert.fail(Assert.java:66) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155) > Caused by: > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$193/1316585270.run > in VM 2 running on Host 6b07584084c4 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:393) > at org.apache.geode.test.dunit.VM.invoke(VM.java:363) > at org.apache.geode.test.dunit.VM.invoke(VM.java:308) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:153) > Caused by: > java.lang.AssertionError: Event never occurred after 6 ms: > null > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:506) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsTwoWriters$bb17a952$10(ConflationDUnitTest.java:153) > {noformat} > {noformat} > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > > testTwoRegionsOneWriter FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$221/1553950035.run > in VM 2 running on Host 6b07584084c4 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:393) > at org.apache.geode.test.dunit.VM.invoke(VM.java:363) > at org.apache.geode.test.dunit.VM.invoke(VM.java:308) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsOneWriter(ConflationDUnitTest.java:183) > Caused by: > java.lang.AssertionError: Event never occurred after 6 ms: null > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:506) > at > org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsOneWriter$bb17a952$10(ConflationDUnitTest.java:183) > {noformat} > ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:506) is > waiting for {{counterUpdate == 2}}. > I think this is a timing issue. The first line of the test sets > CacheClientProxy.isSlowStartForTesting to true. This causes the > MessageDispatcher to not send messages immediately. Instead, it waits for 5 > seconds before sending. This allows the queue to conflate the events. If I > remove the slow start setting, the test fails every time because conflation > doesn't happen. > Unfortunately, the description returns null (the null in the AssertionError > messages above), so we don't know anything about why the assertion is > failing. If it were changed to return the actual value of counterUpdate, that > would be helpful. > With that change and the boolean not set in the test, I see: > {noformat} > Caused by: java.lang.AssertionError: Event never occurred after 6 ms: > Expected counterUpdate to be 2. Instead it was 6 > {noformat} > My guess is that between the time the MessageDispatcher is told to wait and > the test actually runs, at least 5 seconds elapses, and the conflation > doesn't occur. I'll make these changes to the test so that next time it > happens, we can see if thats the case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4054) Create module for Protobuf message-based client
Michael Dodge created GEODE-4054: Summary: Create module for Protobuf message-based client Key: GEODE-4054 URL: https://issues.apache.org/jira/browse/GEODE-4054 Project: Geode Issue Type: Improvement Components: client/server Reporter: Michael Dodge Fix For: 1.4.0 Create a module, geode-protobuf-client, that contains a simple Java client that exercises the Protobuf messages and the new protocol. This client should allow the interaction with a locator and cache server based on command-line arguments, a file of commands, or an interactive shell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-4053) Create module for Protobuf messages
[ https://issues.apache.org/jira/browse/GEODE-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dodge updated GEODE-4053: - Component/s: client/server > Create module for Protobuf messages > --- > > Key: GEODE-4053 > URL: https://issues.apache.org/jira/browse/GEODE-4053 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Michael Dodge > Fix For: 1.4.0 > > > Currently, the Java classes generated from the Protobuf files for the new > protocol are packages inside geode-protobuf. As this module also implements > the client protocol using the Protobuf messages, it depends on > geode-client-protocol and geode-core. This results in unnecessary > dependencies for just using the Protobuf messages. Extract the Java classes > generated from the Protobuf files into their own module, > geode-protobuf-messages, on which geode-protobuf depends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4053) Create module for Protobuf messages
Michael Dodge created GEODE-4053: Summary: Create module for Protobuf messages Key: GEODE-4053 URL: https://issues.apache.org/jira/browse/GEODE-4053 Project: Geode Issue Type: Improvement Reporter: Michael Dodge Fix For: 1.4.0 Currently, the Java classes generated from the Protobuf files for the new protocol are packages inside geode-protobuf. As this module also implements the client protocol using the Protobuf messages, it depends on geode-client-protocol and geode-core. This results in unnecessary dependencies for just using the Protobuf messages. Extract the Java classes generated from the Protobuf files into their own module, geode-protobuf-messages, on which geode-protobuf depends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp
[ https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279115#comment-16279115 ] ASF GitHub Bot commented on GEODE-4042: --- jhuynh1 opened a new pull request #1121: GEODE-4042: Removed additional tmp dir references URL: https://github.com/apache/geode/pull/1121 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of > hardcoding to /tmp > > > Key: GEODE-4042 > URL: https://issues.apache.org/jira/browse/GEODE-4042 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > Currently the Cargo Tests for the session state module are hard coded to run > off of /tmp. Instead it should probably be pointed towards using > java.io.tmpdir. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp
[ https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279111#comment-16279111 ] ASF GitHub Bot commented on GEODE-4042: --- jhuynh1 closed pull request #1120: GEODE-4042: Removing additional references to /tmp URL: https://github.com/apache/geode/pull/1120 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java b/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java index 5064c22512..4409d17687 100644 --- a/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java +++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java @@ -63,10 +63,11 @@ private final String MODULE_PATH; private final String WAR_FILE_PATH; + public static final String TMP_DIR = System.getProperty("java.io.tmpdir", "/tmp"); public static final String GEODE_BUILD_HOME = System.getenv("GEODE_HOME"); - public static final String DEFAULT_INSTALL_DIR = "/tmp/cargo_containers/"; + public static final String DEFAULT_INSTALL_DIR = TMP_DIR + "/cargo_containers/"; protected static final String DEFAULT_MODULE_LOCATION = GEODE_BUILD_HOME + "/tools/Modules/"; - public static final String DEFAULT_MODULE_EXTRACTION_DIR = "/tmp/cargo_modules/"; + public static final String DEFAULT_MODULE_EXTRACTION_DIR = TMP_DIR + "/cargo_modules/"; /** * Represents the type of connection used in this installation @@ -137,7 +138,8 @@ public ContainerInstall(String installDir, String downloadURL, ConnectionType co logger.info("Installing container from URL " + downloadURL); // Optional step to install the container from a URL pointing to its distribution -Installer installer = new ZipURLInstaller(new URL(downloadURL), "/tmp/downloads", installDir); +Installer installer = +new ZipURLInstaller(new URL(downloadURL), TMP_DIR + "/downloads", installDir); installer.install(); // Set install home diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java b/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java index fbd9593dbb..70a82c1429 100644 --- a/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java +++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/GenericAppServerContainer.java @@ -15,6 +15,7 @@ package org.apache.geode.session.tests; import static org.apache.geode.session.tests.ContainerInstall.GEODE_BUILD_HOME; +import static org.apache.geode.session.tests.ContainerInstall.TMP_DIR; import java.io.File; import java.io.IOException; @@ -41,7 +42,7 @@ private final File modifyWarScript; private final File modifyWarScriptLog; - private static final String DEFAULT_GENERIC_APPSERVER_WAR_DIR = "/tmp/cargo_wars/"; + private static final String DEFAULT_GENERIC_APPSERVER_WAR_DIR = TMP_DIR + "/cargo_wars/"; /** * Setup the generic appserver container diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java b/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java index a1b36fa664..71e5e73663 100644 --- a/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java +++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java @@ -14,6 +14,8 @@ */ package org.apache.geode.session.tests; +import static org.apache.geode.session.tests.ContainerInstall.TMP_DIR; + import java.io.File; import java.io.IOException; import java.util.Arrays; @@ -70,7 +72,7 @@ public static final String DEFAULT_LOGGING_LEVEL = LoggingLevel.LOW.getLevel(); public static final String DEFAULT_LOG_DIR = "cargo_logs/"; - public static final String DEFAULT_CONFIG_DIR = "/tmp/cargo_configs/"; + public static final String DEFAULT_CONFIG_DIR = TMP_DIR + "/cargo_configs/"; public static final Logger logger = LogService.getLogger(); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of > hardcoding to /tmp > > > Key: GEODE-4042 > URL: https://issues.apache.org/jira/br
[jira] [Commented] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp
[ https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279109#comment-16279109 ] ASF GitHub Bot commented on GEODE-4042: --- jhuynh1 opened a new pull request #1120: GEODE-4042: Removing additional references to /tmp URL: https://github.com/apache/geode/pull/1120 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of > hardcoding to /tmp > > > Key: GEODE-4042 > URL: https://issues.apache.org/jira/browse/GEODE-4042 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > Currently the Cargo Tests for the session state module are hard coded to run > off of /tmp. Instead it should probably be pointed towards using > java.io.tmpdir. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
[ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg updated GEODE-4052: Description: Occasionally, the majority of this class's tests will fail due to being unable to start the cluster. Such a failure is beyond the scope of the test and should be reported quickly. This class should be divided into two classes, one containing those tests that require the cluster's server to be running and one that does not. The cluster start-up in both cases should be delegated to a {{@BeforeClass}} method so that failure occurs as the class level and is quickly recognizable. was: Occasionally, the majority of this class's tests will fail due to being unable to start the cluster. Such a failure is beyond the scope of the test and should be reported quickly. This class should be divided into two classes, one containing those tests that require the cluster to be running and one that does not. The cluster start-up should then be delegated to a {{@BeforeClass}} method so that failure occurs as the class level and is quickly recognizable. > Expand GfshExitCodeStatusCommandTest into multiple classes for more > meaningful failure reporting > > > Key: GEODE-4052 > URL: https://issues.apache.org/jira/browse/GEODE-4052 > Project: Geode > Issue Type: Test > Components: gfsh, tests >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg > > Occasionally, the majority of this class's tests will fail due to being > unable to start the cluster. Such a failure is beyond the scope of the test > and should be reported quickly. > This class should be divided into two classes, one containing those tests > that require the cluster's server to be running and one that does not. The > cluster start-up in both cases should be delegated to a {{@BeforeClass}} > method so that failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
Patrick Rhomberg created GEODE-4052: --- Summary: Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting Key: GEODE-4052 URL: https://issues.apache.org/jira/browse/GEODE-4052 Project: Geode Issue Type: Test Components: gfsh, tests Reporter: Patrick Rhomberg Occasionally, the majority of this class's tests will fail due to being unable to start the cluster. Such a failure is beyond the scope of the test and should be reported quickly. This class should be divided into two classes, one containing those tests that require the cluster to be running and one that does not. The cluster start-up should then be delegated to a {{@BeforeClass}} method so that failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
[ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg reassigned GEODE-4052: --- Assignee: Patrick Rhomberg > Expand GfshExitCodeStatusCommandTest into multiple classes for more > meaningful failure reporting > > > Key: GEODE-4052 > URL: https://issues.apache.org/jira/browse/GEODE-4052 > Project: Geode > Issue Type: Test > Components: gfsh, tests >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg > > Occasionally, the majority of this class's tests will fail due to being > unable to start the cluster. Such a failure is beyond the scope of the test > and should be reported quickly. > This class should be divided into two classes, one containing those tests > that require the cluster to be running and one that does not. The cluster > start-up should then be delegated to a {{@BeforeClass}} method so that > failure occurs as the class level and is quickly recognizable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3022) [JGRP00001] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_b
[ https://issues.apache.org/jira/browse/GEODE-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278973#comment-16278973 ] ASF GitHub Bot commented on GEODE-3022: --- pivotal-jbarrett closed pull request #164: GEODE-3022: Delete an unnecessary test. Already covered by NEW_CONFIG in this file. URL: https://github.com/apache/geode-native/pull/164 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/cppcache/integration-test/testSystemProperties.cpp b/cppcache/integration-test/testSystemProperties.cpp index f882a0bb..11ada78b 100644 --- a/cppcache/integration-test/testSystemProperties.cpp +++ b/cppcache/integration-test/testSystemProperties.cpp @@ -58,37 +58,6 @@ BEGIN_TEST(DEFAULT) } END_TEST(DEFAULT) -/* - * Commenting the last two tests because I need to know where to put - * the file which will be passed to the constructor. These two tests works. - * But for others it might fail so commenting them as of now. - */ -BEGIN_TEST(CONFIG) - { -// create a file for alternate properties... -// FILE* propFile = ACE_OS::fopen( "./test.properties", "a+" ); -// ACE_OS::fprintf( propFile, "gf.transport.config=./gfconfig\n" ); -/// ACE_OS::fprintf( propFile, "statistics.sample.interval=2000\n" ); -// ACE_OS::fprintf( propFile, "statistics.enabled=false\n" ); -// ACE_OS::fprintf( propFile, "statistics.archive.file=./stats.gfs\n" ); -// ACE_OS::fprintf( propFile, "log.level=error\n" ); -// ACE_OS::fclose( propFile ); - -// Make sure product can at least log to stdout. -Log::init(Log::Config, nullptr, 0); - -SystemProperties* sp = new SystemProperties(nullptr, "test.properties"); -ASSERT(sp->statisticsSampleInterval() == std::chrono::seconds(1), - "expected 1"); -ASSERT(sp->statisticsEnabled() == true, "expected true"); -auto&& safname = sp->statisticsArchiveFile(); -ASSERT_EQ("statArchive.gfs", safname); -Log::LogLevel ll = sp->logLevel(); -ASSERT(ll == Log::Config, "expected Log::Config"); -delete sp; - } -END_TEST(CONFIG) - BEGIN_TEST(NEW_CONFIG) { // When the tests are run from the build script the environment variable This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JGRP1] configuration error: the following properties in > org.apache.geode.distributed.internal.membership.gms.messenger.Transport are > not recognized: {ignore_dont_bundle=false} > > > Key: GEODE-3022 > URL: https://issues.apache.org/jira/browse/GEODE-3022 > Project: Geode > Issue Type: Bug >Reporter: Sumitra Chatterjee >Priority: Blocker > > Getting above exception when trying to start cache server. Further checked in > JGroupsMessenger.java and found below: > void setMessageFlags(DistributionMessage gfmsg, Message msg) { > // Bundling is mostly only useful if we're doing no-ack work, > // which is fairly rare > msg.setFlag(Flag.DONT_BUNDLE); > As per https://issues.jboss.org/browse/JGRP-1737, DONT_BUNDLE is probably not > to be used (correct me if I am misunderstanding). Any ideas how to get the > server start up would be very helpful. > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3022) [JGRP00001] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_b
[ https://issues.apache.org/jira/browse/GEODE-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278974#comment-16278974 ] ASF subversion and git services commented on GEODE-3022: Commit e3728b32e209dc9493c554b1622dea7f3682f263 in geode-native's branch refs/heads/develop from [~mmartell] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=e3728b3 ] GEODE-3022: Delete an unnecessary test > [JGRP1] configuration error: the following properties in > org.apache.geode.distributed.internal.membership.gms.messenger.Transport are > not recognized: {ignore_dont_bundle=false} > > > Key: GEODE-3022 > URL: https://issues.apache.org/jira/browse/GEODE-3022 > Project: Geode > Issue Type: Bug >Reporter: Sumitra Chatterjee >Priority: Blocker > > Getting above exception when trying to start cache server. Further checked in > JGroupsMessenger.java and found below: > void setMessageFlags(DistributionMessage gfmsg, Message msg) { > // Bundling is mostly only useful if we're doing no-ack work, > // which is fairly rare > msg.setFlag(Flag.DONT_BUNDLE); > As per https://issues.jboss.org/browse/JGRP-1737, DONT_BUNDLE is probably not > to be used (correct me if I am misunderstanding). Any ideas how to get the > server start up would be very helpful. > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3022) [JGRP00001] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_b
[ https://issues.apache.org/jira/browse/GEODE-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278959#comment-16278959 ] ASF GitHub Bot commented on GEODE-3022: --- mmartell opened a new pull request #164: GEODE-3022: Delete an unnecessary test. Already covered by NEW_CONFIG in this file. URL: https://github.com/apache/geode-native/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JGRP1] configuration error: the following properties in > org.apache.geode.distributed.internal.membership.gms.messenger.Transport are > not recognized: {ignore_dont_bundle=false} > > > Key: GEODE-3022 > URL: https://issues.apache.org/jira/browse/GEODE-3022 > Project: Geode > Issue Type: Bug >Reporter: Sumitra Chatterjee >Priority: Blocker > > Getting above exception when trying to start cache server. Further checked in > JGroupsMessenger.java and found below: > void setMessageFlags(DistributionMessage gfmsg, Message msg) { > // Bundling is mostly only useful if we're doing no-ack work, > // which is fairly rare > msg.setFlag(Flag.DONT_BUNDLE); > As per https://issues.jboss.org/browse/JGRP-1737, DONT_BUNDLE is probably not > to be used (correct me if I am misunderstanding). Any ideas how to get the > server start up would be very helpful. > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3955) The gfsh 'describe region' command doesn't include asyncEventQueueIds or gatewaySenderIds
[ https://issues.apache.org/jira/browse/GEODE-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278935#comment-16278935 ] ASF GitHub Bot commented on GEODE-3955: --- PurelyApplied commented on a change in pull request #1099: GEODE-3955: Add AEQ and Gateway Sender information to 'describe region' output. URL: https://github.com/apache/geode/pull/1099#discussion_r155023687 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/RegionAttributesInfo.java ## @@ -42,11 +42,8 @@ public class RegionAttributesInfo implements Serializable { - /** - * - */ - private static final long serialVersionUID = 1L; + private static final long serialVersionUID = 336184564012988487L; Review comment: I believe it's just a convention. It's not mentioned in any of the Google Java Style Guide that we've adopted as our own. It needs to be changed to correctly deserialize, but I think you're right -- it could be changed to any not-the-previous-value-`1` and be valid. Looking around online, there doesn't seem to be any consensus on increment vs rehash the value. The best I could find was that a big, long number catches the eye and reminds future developers of the importance of considering backwards incompatibility. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The gfsh 'describe region' command doesn't include asyncEventQueueIds or > gatewaySenderIds > - > > Key: GEODE-3955 > URL: https://issues.apache.org/jira/browse/GEODE-3955 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Barry Oglesby >Priority: Minor > Fix For: 1.4.0 > > Attachments: geode-3955.diff > > > The {{constructor}} and {{getNonDefaultAttributes}} methods in > {{org.apache.geode.management.internal.cli.domain.RegionAttributesInfo}} > class would have to be modified to include the {{asyncEventQueueIds}} and > {{gatewaySenderIds}}. > I did a quick modification of this class (attached). > With these changes, 'describe region' looks like: > {noformat} > gfsh>describe region --name=/data > .. > Name: data > Data Policy : partition > Hosting Members : ln-1 > Non-Default Attributes Shared By Hosting Members > Type| Name | Value > - | - | - > Region| data-policy | PARTITION > | async-event-queue-ids | db > | size | 0 > | gateway-sender-ids| ny > Partition | redundant-copies | 1 > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3022) [JGRP00001] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_b
[ https://issues.apache.org/jira/browse/GEODE-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278924#comment-16278924 ] ASF GitHub Bot commented on GEODE-3022: --- mmartell closed pull request #162: GEODE-3022: Removing a duplicate test URL: https://github.com/apache/geode-native/pull/162 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/cppcache/integration-test/testSystemProperties.cpp b/cppcache/integration-test/testSystemProperties.cpp index f882a0bb..11ada78b 100644 --- a/cppcache/integration-test/testSystemProperties.cpp +++ b/cppcache/integration-test/testSystemProperties.cpp @@ -58,37 +58,6 @@ BEGIN_TEST(DEFAULT) } END_TEST(DEFAULT) -/* - * Commenting the last two tests because I need to know where to put - * the file which will be passed to the constructor. These two tests works. - * But for others it might fail so commenting them as of now. - */ -BEGIN_TEST(CONFIG) - { -// create a file for alternate properties... -// FILE* propFile = ACE_OS::fopen( "./test.properties", "a+" ); -// ACE_OS::fprintf( propFile, "gf.transport.config=./gfconfig\n" ); -/// ACE_OS::fprintf( propFile, "statistics.sample.interval=2000\n" ); -// ACE_OS::fprintf( propFile, "statistics.enabled=false\n" ); -// ACE_OS::fprintf( propFile, "statistics.archive.file=./stats.gfs\n" ); -// ACE_OS::fprintf( propFile, "log.level=error\n" ); -// ACE_OS::fclose( propFile ); - -// Make sure product can at least log to stdout. -Log::init(Log::Config, nullptr, 0); - -SystemProperties* sp = new SystemProperties(nullptr, "test.properties"); -ASSERT(sp->statisticsSampleInterval() == std::chrono::seconds(1), - "expected 1"); -ASSERT(sp->statisticsEnabled() == true, "expected true"); -auto&& safname = sp->statisticsArchiveFile(); -ASSERT_EQ("statArchive.gfs", safname); -Log::LogLevel ll = sp->logLevel(); -ASSERT(ll == Log::Config, "expected Log::Config"); -delete sp; - } -END_TEST(CONFIG) - BEGIN_TEST(NEW_CONFIG) { // When the tests are run from the build script the environment variable This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JGRP1] configuration error: the following properties in > org.apache.geode.distributed.internal.membership.gms.messenger.Transport are > not recognized: {ignore_dont_bundle=false} > > > Key: GEODE-3022 > URL: https://issues.apache.org/jira/browse/GEODE-3022 > Project: Geode > Issue Type: Bug >Reporter: Sumitra Chatterjee >Priority: Blocker > > Getting above exception when trying to start cache server. Further checked in > JGroupsMessenger.java and found below: > void setMessageFlags(DistributionMessage gfmsg, Message msg) { > // Bundling is mostly only useful if we're doing no-ack work, > // which is fairly rare > msg.setFlag(Flag.DONT_BUNDLE); > As per https://issues.jboss.org/browse/JGRP-1737, DONT_BUNDLE is probably not > to be used (correct me if I am misunderstanding). Any ideas how to get the > server start up would be very helpful. > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278886#comment-16278886 ] ASF GitHub Bot commented on GEODE-4049: --- jinmeiliao closed pull request #1118: GEODE-4049: refactor CreateRegionCommand and DestoryRegionCommand status URL: https://github.com/apache/geode/pull/1118 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java b/geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java index b4a357f85a..733296dec2 100755 --- a/geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java +++ b/geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java @@ -14,7 +14,10 @@ */ package org.apache.geode.cache.execute; +import org.apache.logging.log4j.util.Strings; + import org.apache.geode.cache.Cache; +import org.apache.geode.distributed.DistributedMember; /** * Defines the execution context of a {@link Function}. It is required by the @@ -77,4 +80,22 @@ public boolean isPossibleDuplicate(); public Cache getCache(); + + /** + * a convenience method to get the name of the member this function executes on. call this + * function once in your function execution to avoid performance issues. + * + * @return member name or id if name is blank + */ + public default String getMemberName() { +DistributedMember member = getCache().getDistributedSystem().getDistributedMember(); + +// if this member has name, use it, otherwise, use the id +String memberName = member.getName(); +if (!Strings.isBlank(memberName)) { + return memberName; +} + +return member.getId(); + } } diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAsyncEventQueueCommand.java b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAsyncEventQueueCommand.java index 0b46c0b239..ea0a636387 100644 --- a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAsyncEventQueueCommand.java +++ b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAsyncEventQueueCommand.java @@ -24,8 +24,6 @@ import org.springframework.shell.core.annotation.CliOption; import org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueFactoryImpl; -import org.apache.geode.cache.execute.Function; -import org.apache.geode.cache.execute.ResultCollector; import org.apache.geode.distributed.DistributedMember; import org.apache.geode.management.cli.ConverterHint; import org.apache.geode.management.cli.Result; @@ -119,7 +117,7 @@ public Result createAsyncEventQueue( gatewaySubstitutionListener, listener, listenerProperties, forwardExpirationDestroy); CreateAsyncEventQueueFunction function = new CreateAsyncEventQueueFunction(); -List results = execute(function, aeqArgs, targetMembers); +List results = executeAndGetFunctionResult(function, aeqArgs, targetMembers); if (results.size() == 0) { throw new RuntimeException("No results received."); @@ -149,9 +147,4 @@ public Result createAsyncEventQueue( return commandResult; } - List execute(Function function, Object args, - Set targetMembers) { -ResultCollector rc = executeFunction(function, args, targetMembers); -return CliFunctionResult.cleanResults((List) rc.getResult()); - } } diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java index 5eeed3f637..732ca09210 100644 --- a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java +++ b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java @@ -344,35 +344,30 @@ public Result createRegion( } } -ResultCollector resultCollector = -executeFunction(RegionCreateFunction.INSTANCE, functionArgs, membersToCreateRegionOn); -@SuppressWarnings("unchecked") -List regionCreateResults = -(List) resultCollector.getResult(); +List regionCreateResults = executeAndGetFunctionResult( +RegionCreateFunction.INSTANCE, functionArgs, membersToCreateRegionOn); TabularResultData tabularResultData = ResultBuilder.createTabularResultData(); -final String errorPrefix = "ERROR: "; +boolean regionCreated = false; for (CliFunctionResult regionCreateResult : regionCreateResults) { - boolean success = regionCreateResult.isSuccessful();
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278887#comment-16278887 ] ASF subversion and git services commented on GEODE-4049: Commit b74de48ec90c4428cb4cdf18b0c3807c68e488f8 in geode's branch refs/heads/develop from [~jinmeiliao] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b74de48 ] GEODE-4049: add convenience methods for easy mocking and reduce code duplication. > Command that executes function on multiple members should report the status > of execution on each member > --- > > Key: GEODE-4049 > URL: https://issues.apache.org/jira/browse/GEODE-4049 > Project: Geode > Issue Type: Bug >Reporter: Jinmei Liao > > "destroy region", even though executes function on multiple members, do not > report the result as tabular results. Need to change that. > The tabular results of these commands should be successful if at least one > member executes successfully. Cluster config should be updated if one > function gets executed successfully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1627#comment-1627 ] ASF subversion and git services commented on GEODE-4049: Commit 23382e6d835e9d8673b7ed8956054c11d830c7bf in geode's branch refs/heads/develop from [~jinmeiliao] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=23382e6 ] GEODE-4049: refactor CreateRegionCommand and DestoryRegionCommand status * use tabular result display for destroy region command. * status to reflect at least one region is created/deleted and cluser config is updated. > Command that executes function on multiple members should report the status > of execution on each member > --- > > Key: GEODE-4049 > URL: https://issues.apache.org/jira/browse/GEODE-4049 > Project: Geode > Issue Type: Bug >Reporter: Jinmei Liao > > "destroy region", even though executes function on multiple members, do not > report the result as tabular results. Need to change that. > The tabular results of these commands should be successful if at least one > member executes successfully. Cluster config should be updated if one > function gets executed successfully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278851#comment-16278851 ] ASF GitHub Bot commented on GEODE-4049: --- jdeppe-pivotal commented on a change in pull request #1118: GEODE-4049: refactor CreateRegionCommand and DestoryRegionCommand status URL: https://github.com/apache/geode/pull/1118#discussion_r155009037 ## File path: geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java ## @@ -77,4 +80,22 @@ public boolean isPossibleDuplicate(); public Cache getCache(); + + /** + * a convenience method to get the name of the member this function executes on. call this + * function once in your function execution to avoid performance issues. + * + * @return member name or id if name is blank + */ + public default String getMemberName() { Review comment: I can see how it would help with mocking/testing, but it still smells a bit to me. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command that executes function on multiple members should report the status > of execution on each member > --- > > Key: GEODE-4049 > URL: https://issues.apache.org/jira/browse/GEODE-4049 > Project: Geode > Issue Type: Bug >Reporter: Jinmei Liao > > "destroy region", even though executes function on multiple members, do not > report the result as tabular results. Need to change that. > The tabular results of these commands should be successful if at least one > member executes successfully. Cluster config should be updated if one > function gets executed successfully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4051) Two server jvms crashed at same time and caused some primary and redundant buckets to be cleared. Causing some buckets to get locked and not able to recover also after bo
Igor Barchak created GEODE-4051: --- Summary: Two server jvms crashed at same time and caused some primary and redundant buckets to be cleared. Causing some buckets to get locked and not able to recover also after bouncing all servers Key: GEODE-4051 URL: https://issues.apache.org/jira/browse/GEODE-4051 Project: Geode Issue Type: Bug Components: core Reporter: Igor Barchak Fix For: 1.2.0 "Pooled Waiting Message Processor 5" tid=0x162 java.lang.Thread.State: TIMED_WAITING at sun.misc.Unsafe.park(Native Method) - waiting on java.util.concurrent.CountDownLatch$Sync@1993a5 at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037) at java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328) at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277) at org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:64) at org.apache.geode.distributed.internal.ReplyProcessor21.basicWait(ReplyProcessor21.java:715) at org.apache.geode.distributed.internal.ReplyProcessor21.waitForReplies(ReplyProcessor21.java:644) at org.apache.geode.distributed.internal.ReplyProcessor21.waitForReplies(ReplyProcessor21.java:624) at org.apache.geode.distributed.internal.ReplyProcessor21.waitForReplies(ReplyProcessor21.java:519) at org.apache.geode.internal.cache.StateFlushOperation.flush(StateFlushOperation.java:243) at org.apache.geode.internal.cache.InitialImageOperation.getFromOne(InitialImageOperation.java:349) at org.apache.geode.internal.cache.DistributedRegion.getInitialImageAndRecovery(DistributedRegion.java:1168) at org.apache.geode.internal.cache.DistributedRegion.initialize(DistributedRegion.java:1023) at org.apache.geode.internal.cache.BucketRegion.initialize(BucketRegion.java:253) at org.apache.geode.internal.cache.LocalRegion.createSubregion(LocalRegion.java:962) at org.apache.geode.internal.cache.PartitionedRegionDataStore.createBucketRegion(PartitionedRegionDataStore.java:726) at org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucket(PartitionedRegionDataStore.java:414) - locked org.apache.geode.internal.cache.ProxyBucketRegion@6820a0b6 at org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucketRecursively(PartitionedRegionDataStore.java:272) at org.apache.geode.internal.cache.PartitionedRegionDataStore.grabBucket(PartitionedRegionDataStore.java:2815) at org.apache.geode.internal.cache.partitioned.ManageBackupBucketMessage.operateOnPartitionedRegion(ManageBackupBucketMessage.java:148) at org.apache.geode.internal.cache.partitioned.PartitionMessage.process(PartitionMessage.java:332) Seems like it was introduced in this fix https://github.com/apache/geode/commit/3a1062e245b3ded52ea3f6b6de0aff94ce846fa3?diff=split See StateMarkerMessage.process The first if condition doesn't have a finally block. The else has a finally block. The first if condition didn't have a 'waitFor' operation earlier - it was introduced in this commit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278737#comment-16278737 ] ASF GitHub Bot commented on GEODE-4049: --- pdxrunner commented on a change in pull request #1118: GEODE-4049: refactor CreateRegionCommand and DestoryRegionCommand status URL: https://github.com/apache/geode/pull/1118#discussion_r154983359 ## File path: geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java ## @@ -77,4 +80,22 @@ public boolean isPossibleDuplicate(); public Cache getCache(); + + /** + * a convenience method to get the name of the member this function executes on. call this + * function once in your function execution to avoid performance issues. + * + * @return member name or id if name is blank + */ + public default String getMemberName() { Review comment: May feel like a utility method, but I think it's appropriate. This same bit of code is exists in other *Function classes so it makes sense to put the implementation here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command that executes function on multiple members should report the status > of execution on each member > --- > > Key: GEODE-4049 > URL: https://issues.apache.org/jira/browse/GEODE-4049 > Project: Geode > Issue Type: Bug >Reporter: Jinmei Liao > > "destroy region", even though executes function on multiple members, do not > report the result as tabular results. Need to change that. > The tabular results of these commands should be successful if at least one > member executes successfully. Cluster config should be updated if one > function gets executed successfully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
[ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278714#comment-16278714 ] ASF GitHub Bot commented on GEODE-4049: --- jdeppe-pivotal commented on a change in pull request #1118: GEODE-4049: refactor CreateRegionCommand and DestoryRegionCommand status URL: https://github.com/apache/geode/pull/1118#discussion_r154974710 ## File path: geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java ## @@ -77,4 +80,22 @@ public boolean isPossibleDuplicate(); public Cache getCache(); + + /** + * a convenience method to get the name of the member this function executes on. call this + * function once in your function execution to avoid performance issues. + * + * @return member name or id if name is blank + */ + public default String getMemberName() { Review comment: I don't think that this is the right place for this. It feels like it's just a utility method and would never actually be overridden by implementations of this interface. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command that executes function on multiple members should report the status > of execution on each member > --- > > Key: GEODE-4049 > URL: https://issues.apache.org/jira/browse/GEODE-4049 > Project: Geode > Issue Type: Bug >Reporter: Jinmei Liao > > "destroy region", even though executes function on multiple members, do not > report the result as tabular results. Need to change that. > The tabular results of these commands should be successful if at least one > member executes successfully. Cluster config should be updated if one > function gets executed successfully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3423) Provide support for running parallel docker builds in Jenkins
[ https://issues.apache.org/jira/browse/GEODE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-3423. --- Resolution: Fixed Fix Version/s: 1.3.0 > Provide support for running parallel docker builds in Jenkins > - > > Key: GEODE-3423 > URL: https://issues.apache.org/jira/browse/GEODE-3423 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Jens Deppe > Fix For: 1.3.0 > > > Provide the necessary Dockerfile components to build a docker container which > can be used for parallel dunit builds in a jenkins environment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3819) Refactor CreateRegionCommandDUnitTest to use gfsh rules
[ https://issues.apache.org/jira/browse/GEODE-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-3819. --- Resolution: Fixed Fix Version/s: 1.4.0 > Refactor CreateRegionCommandDUnitTest to use gfsh rules > --- > > Key: GEODE-3819 > URL: https://issues.apache.org/jira/browse/GEODE-3819 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-4044) Various Converters are not being used correctly
[ https://issues.apache.org/jira/browse/GEODE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe reassigned GEODE-4044: - Assignee: (was: Jens Deppe) > Various Converters are not being used correctly > --- > > Key: GEODE-4044 > URL: https://issues.apache.org/jira/browse/GEODE-4044 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jens Deppe > > We have several converters that are applied to both scalar as well as array > parameters. Specifically these are: > - MEMBERGROUP > - ALL_MEMBER_IDNAME > - MEMBERIDNAME > These converters only work on scalar values. > We should fix this, either by providing our own correct Converter or by > removing the converter where it is used inappropriately. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-4044) Various Converters are not being used correctly
[ https://issues.apache.org/jira/browse/GEODE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe reassigned GEODE-4044: - Assignee: Jens Deppe > Various Converters are not being used correctly > --- > > Key: GEODE-4044 > URL: https://issues.apache.org/jira/browse/GEODE-4044 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe > > We have several converters that are applied to both scalar as well as array > parameters. Specifically these are: > - MEMBERGROUP > - ALL_MEMBER_IDNAME > - MEMBERIDNAME > These converters only work on scalar values. > We should fix this, either by providing our own correct Converter or by > removing the converter where it is used inappropriately. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3814) RestAPIsWithSSLDUnitTest tests are incorrect
[ https://issues.apache.org/jira/browse/GEODE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe reassigned GEODE-3814: - Assignee: (was: Jens Deppe) > RestAPIsWithSSLDUnitTest tests are incorrect > > > Key: GEODE-3814 > URL: https://issues.apache.org/jira/browse/GEODE-3814 > Project: Geode > Issue Type: Bug > Components: rest (dev) >Reporter: Jens Deppe > > Various tests test different protocols but the actual code that sets up the > client ignores the passed protocol and always just ends up using TLSv1.2. > This test could also be refactored to use rules. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3941) Pulse throws NPE when SecurityManager is enabled
[ https://issues.apache.org/jira/browse/GEODE-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-3941. --- Resolution: Fixed Fix Version/s: 1.4.0 > Pulse throws NPE when SecurityManager is enabled > > > Key: GEODE-3941 > URL: https://issues.apache.org/jira/browse/GEODE-3941 > Project: Geode > Issue Type: Bug > Components: pulse >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Trivial > Fix For: 1.4.0 > > > When `SecurityManager` is enabled, Pulse produces the following errors in > `pulse.log`. > {noformat} > 2017-10-26 13:54:51,590 INFO o.a.g.t.p.i.d.Cluster > [PULSE-localhost:11099:gfadmin] Exception Occurred while updating cluster > data : > java.lang.NullPointerException: null > at > org.apache.geode.tools.pulse.internal.data.JMXDataUpdater.initializeMember(JMXDataUpdater.java:1374) > ~[classes/:?] > at > org.apache.geode.tools.pulse.internal.data.JMXDataUpdater.updateClusterMember(JMXDataUpdater.java:1415) > ~[classes/:?] > at > org.apache.geode.tools.pulse.internal.data.JMXDataUpdater.updateData(JMXDataUpdater.java:323) > ~[classes/:?] > at > org.apache.geode.tools.pulse.internal.data.Cluster.updateData(Cluster.java:2336) > ~[classes/:?] > at > org.apache.geode.tools.pulse.internal.data.Cluster.run(Cluster.java:2300) > [classes/:?] > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3970) Disable travis default _JAVA_OPTIONS
[ https://issues.apache.org/jira/browse/GEODE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-3970. --- Resolution: Fixed Fix Version/s: 1.4.0 > Disable travis default _JAVA_OPTIONS > > > Key: GEODE-3970 > URL: https://issues.apache.org/jira/browse/GEODE-3970 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Jens Deppe >Assignee: Jens Deppe > Fix For: 1.4.0 > > > Travis sets _JAVA_OPTIONS="-Xmx2048m -Xms512m" which is causing builds to > fail with exit code 137. If unset, the builds pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-4011) ConcurrentDeployDUnitTest is polluting test VMs
[ https://issues.apache.org/jira/browse/GEODE-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-4011. --- Resolution: Fixed Fix Version/s: 1.4.0 > ConcurrentDeployDUnitTest is polluting test VMs > --- > > Key: GEODE-4011 > URL: https://issues.apache.org/jira/browse/GEODE-4011 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe > Fix For: 1.4.0 > > > This test launches gfsh from within 3 separate VMs. gfsh does some logger > manipulation which results in stdout being redirected. Subsequent tests then > may fail if they produce 'scary' suspect messages in the logs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3341) Refactor DiskStoreCommandsDUnitTest to use test rules
[ https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-3341. --- Resolution: Fixed Fix Version/s: 1.4.0 > Refactor DiskStoreCommandsDUnitTest to use test rules > - > > Key: GEODE-3341 > URL: https://issues.apache.org/jira/browse/GEODE-3341 > Project: Geode > Issue Type: Sub-task > Components: tests >Affects Versions: 1.2.0 >Reporter: Emily Yeh >Assignee: Jens Deppe > Fix For: 1.4.0 > > > {{DiskStoreCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a > deprecated class. It should be refactored to use more current test rules. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-4029) Deployed jars may not be correct when multiple locators are in use
[ https://issues.apache.org/jira/browse/GEODE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-4029. --- Resolution: Fixed Fix Version/s: 1.4.0 > Deployed jars may not be correct when multiple locators are in use > -- > > Key: GEODE-4029 > URL: https://issues.apache.org/jira/browse/GEODE-4029 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe > Fix For: 1.4.0 > > > When we have more than one locator, if a jar is re-deployed it will not be > propagated correctly to the 'remote' locators. i.e. the locators which are > not directly executing the 'deploy' command. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-4035) All converters should disable the default Spring String converter
[ https://issues.apache.org/jira/browse/GEODE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-4035. --- Resolution: Fixed Fix Version/s: 1.4.0 > All converters should disable the default Spring String converter > - > > Key: GEODE-4035 > URL: https://issues.apache.org/jira/browse/GEODE-4035 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe > Fix For: 1.4.0 > > > There are various converters (see {{ConverterHint}}) that don't disable the > Spring StringConverter. This ultimately means that sometimes tab-completion > will work and sometimes not, depending which Converter is picked up first at > runtime. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3424) User can pass authorization instance to CacheFactory
[ https://issues.apache.org/jira/browse/GEODE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-3424. - Resolution: Fixed > User can pass authorization instance to CacheFactory > > > Key: GEODE-3424 > URL: https://issues.apache.org/jira/browse/GEODE-3424 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Addison > > Today, the loading of the native client authorization module is difficult, > especially with IIS. To load the auth assembly it must be located in the IIS > installation directory and this can vary from machine to machine. > A better approach is to allow users to pass in an instance of the auth class > into the CacheFactory. This will work well with app domains as well. > Something like this > {code} > var auth = new MyAuth(); > CacheFactory.setAuthHandler(auth); > var cache = cacheFactory.create(); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-3424) User can pass authorization instance to CacheFactory
[ https://issues.apache.org/jira/browse/GEODE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-3424. --- > User can pass authorization instance to CacheFactory > > > Key: GEODE-3424 > URL: https://issues.apache.org/jira/browse/GEODE-3424 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Addison > > Today, the loading of the native client authorization module is difficult, > especially with IIS. To load the auth assembly it must be located in the IIS > installation directory and this can vary from machine to machine. > A better approach is to allow users to pass in an instance of the auth class > into the CacheFactory. This will work well with app domains as well. > Something like this > {code} > var auth = new MyAuth(); > CacheFactory.setAuthHandler(auth); > var cache = cacheFactory.create(); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-3630) Change signature of Serializable::fromData
[ https://issues.apache.org/jira/browse/GEODE-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-3630. --- > Change signature of Serializable::fromData > --- > > Key: GEODE-3630 > URL: https://issues.apache.org/jira/browse/GEODE-3630 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt >Assignee: Jacob S. Barrett > > Serializable* Serializable::formData(DataInput& in) > to > void Serializable::formData(DataInput& in) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-2657) Execute Region Function sends incorrect message format
[ https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-2657. --- > Execute Region Function sends incorrect message format > -- > > Key: GEODE-2657 > URL: https://issues.apache.org/jira/browse/GEODE-2657 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: David Kimura >Assignee: Jacob S. Barrett > > `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. > This causes the message response to be parsed synchronously and not > asynchronously chunked. The synchronous parser does not support this message > type and it barfs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3806) Update Xerces-C to 3.2.0
[ https://issues.apache.org/jira/browse/GEODE-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278530#comment-16278530 ] ASF GitHub Bot commented on GEODE-3806: --- pivotal-jbarrett opened a new pull request #163: GEODE-3806: Updated to Xerces-C 3.2.0. URL: https://github.com/apache/geode-native/pull/163 - Convert to CMake build process. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xerces-C to 3.2.0 > > > Key: GEODE-3806 > URL: https://issues.apache.org/jira/browse/GEODE-3806 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Rolls up lots of fixes in the 3.1 branch and add CMake build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-4050) No way from gfsh list members, to find coordinator
Igor Barchak created GEODE-4050: --- Summary: No way from gfsh list members, to find coordinator Key: GEODE-4050 URL: https://issues.apache.org/jira/browse/GEODE-4050 Project: Geode Issue Type: Bug Components: core Reporter: Igor Barchak Fix For: 1.2.0 No way from gfsh list members, to find coordinator flag marks preferred coordinators( locators), and not actual current coordinator -- This message was sent by Atlassian JIRA (v6.4.14#64029)