[jira] [Commented] (GEODE-2542) LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode Nightly Build

[Galen O'Sullivan (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459352#comment-16459352
 ] 

Galen O'Sullivan commented on GEODE-2542:
-

[~PivotalSarge] Where is the 10-second wait you see in this test? I only see 
60-second waits.

> LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode 
> Nightly Build
> ---
>
> Key: GEODE-2542
> URL: https://issues.apache.org/jira/browse/GEODE-2542
> Project: Geode
>  Issue Type: Bug
>  Components: locator
>Reporter: Kirk Lund
>Assignee: Brian Baynes
>Priority: Major
>  Labels: Flaky
>
> testMultipleLocators:
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host 
> asf919.gq1.ygridcore.net with 5 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:280)
>   at 
> org.apache.geode.distributed.LocatorDUnitTest.testMultipleLocators(LocatorDUnitTest.java:1567)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> 

[jira] [Created] (GEODE-5160) Remove test hooks from o.a.g.d.i.membership.gms.interfaces.Service

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-5160:
---

 Summary: Remove test hooks from 
o.a.g.d.i.membership.gms.interfaces.Service
 Key: GEODE-5160
 URL: https://issues.apache.org/jira/browse/GEODE-5160
 Project: Geode
  Issue Type: Improvement
  Components: membership
Reporter: Galen O'Sullivan


Service has the following methods:
{code}
  /**
   * test method for simulating a sick/dead member
   */
  void beSick();

  /**
   * test method for simulating a sick/dead member
   */
  void playDead();

  /**
   * test method for simulating a sick/dead member
   */
  void beHealthy();
{code}

It doesn't make sense for all services to have to implement these, especially 
since most services make these a no-op. Let's cast where we know what we're 
looking for instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459301#comment-16459301
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 324717a277f14b1733e7ac7f5e90cea87f1d84e2 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=324717a ]

GEODE-1279: Rename Bug36269DUnitTest to 
ClientDestroyRegionNotificationRegressionTest

Rename test method in ClientDestroyRegionNotificationRegressionTest:
* testRegionDestroyNotReceivedBySender -> senderDoesNotReceiveRegionDestroy


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36269DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459308#comment-16459308
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 204f127d37ea595b750fae9f96e9dde031204372 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=204f127 ]

GEODE-1279: Rename Bug37805DUnitTest to 
RootRegionsExcludesHARegionsRegressionTest


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36269DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36457DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459306#comment-16459306
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 449945f35095c6e155edd60f5e750c30fe8956b3 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=449945f ]

GEODE-1279: Rename Bug36995DUnitTest to MessageTrackingTimeoutRegressionTest

Extract one test method to GetConnectedServerCountRegressionTest.

Rename test methods in MessageTrackingTimeoutRegressionTest:
* defaultMessageTrackingTimeout -> poolCreationUsesDefaultMessageTrackingTimeout
* userSpecifiedMessageTrackingTimeout ->
  poolCreationUsesSetSubscriptionMessageTrackingTimeoutIfSpecified


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459305#comment-16459305
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 70d2772943a56fe9405d79731c41b437b8b56b6e in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=70d2772 ]

GEODE-1279: Delete redundant Bug36829DUnitTest

This test duplicates RegisterInterestOnServerWithoutRegionRegressionTest.


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36269DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36457DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459303#comment-16459303
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 3968b947adca6e88b5edc3478d32b54432577941 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3968b94 ]

GEODE-1279: Rename Bug36457DUnitTest to 
ClientDestroyRegionUnregisterInterestRegressionTest

Rename test method in ClientDestroyRegionUnregisterInterestRegressionTest:
* destroyRegionShouldNotUnregisterInterest -> 
destroyRegionFromClientDoesNotUnregisterInterest


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459304#comment-16459304
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 4c724ef8ba1d0ad8660429917ce8a112a5348306 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4c724ef ]

GEODE-1279: Rename Bug36805DUnitTest to 
RegisterInterestOnServerWithoutRegionRegressionTest


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36269DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36457DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459307#comment-16459307
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 55ea8ac3baece4dfd91f852b83cf5e0bdbfa88ce in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=55ea8ac ]

GEODE-1279: Rename Bug37210DUnitTest to HARegionQueueStatsCloseRegressionTest

Rename test method in HARegionQueueStatsCloseRegressionTest:
* testHAStatsCleanup -> haRegionQueueClosesStatsWhenClientProxyIsClosed


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> Remaining:
> * 
> geode-core/src/test/java/org/apache/geode/cache/query/Bug32947ValueConstraintJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache/query/BugJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40255JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug40662JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug49856JUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/Bug51616JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33359DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug33726JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug34583JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37241DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37244JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug37500JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40299DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug40632DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41091DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41733DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug41957DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug42055DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45164DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug45934DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug47667DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/Bug48182JUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48879DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug43684DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug47388DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug51400DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/Bug40396DUnitTest.java
> * 
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36269DUnitTest.java
> * 
> 

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459300#comment-16459300
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit 67aab7c0b2cc4e0132ea8537b23011b992467f34 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=67aab7c ]

GEODE-5096: ValidateCacheServerProfileProcessor to validate
CacheServerProfiles at time upgrade.


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459297#comment-16459297
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit 2195eab726473281960041a112a830a33c8c21c6 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2195eab ]

GEODE-5096: ValidateCacheServerProfileProcessor to validate
CacheServerProfiles at time upgrade.


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459296#comment-16459296
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit 01786bc3537f40e2b913bfcbcc1be6ae4f7fedd8 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=01786bc ]

GEODE-5096: Reverting attempt to change tests to use DistributedTestRule


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4909) Add dunit test coverage for lucene reindex with security

[Shelley Lynn Hughes-Godfrey (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459295#comment-16459295
 ] 

Shelley Lynn Hughes-Godfrey commented on GEODE-4909:


commit a9c4a0a0115e0f1462276c4cbe509b6b51cc8e41
Author: Lynn Hughes-Godfrey 
Date:   Tue Mar 27 15:23:07 2018 -0700

GEODE-4909: Additional lucene reindex tests with security

* Extended existing tests with and without gfsh to create region prior to 
creating lucene index.



> Add dunit test coverage for lucene reindex with security
> 
>
> Key: GEODE-4909
> URL: https://issues.apache.org/jira/browse/GEODE-4909
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.6.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add new dunit tests:
> - LuceneClientSecurityWithRegionCreatedBeforeReindexDUnitTest 
> - LuceneCommandSecurityWithRegionCreatedBeforeReindexDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459290#comment-16459290
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-5096 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459291#comment-16459291
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-5096 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459292#comment-16459292
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-5096 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459294#comment-16459294
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit 090f1cf7f6f5e8dc70031f680f699c32a9dccfbf in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=090f1cf ]

GEODE-5096: ValidateCacheServerProfileProcessor to validate
CacheServerProfiles at time upgrade.


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4909) Add dunit test coverage for lucene reindex with security

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey resolved GEODE-4909.

   Resolution: Fixed
Fix Version/s: 1.6.0

> Add dunit test coverage for lucene reindex with security
> 
>
> Key: GEODE-4909
> URL: https://issues.apache.org/jira/browse/GEODE-4909
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.6.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add new dunit tests:
> - LuceneClientSecurityWithRegionCreatedBeforeReindexDUnitTest 
> - LuceneCommandSecurityWithRegionCreatedBeforeReindexDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4923) Add Geode extensions jars to Geode's classpath

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar resolved GEODE-4923.
-
Resolution: Fixed

> Add Geode extensions jars to Geode's classpath
> --
>
> Key: GEODE-4923
> URL: https://issues.apache.org/jira/browse/GEODE-4923
> Project: Geode
>  Issue Type: Improvement
>  Components: extensions
>Reporter: Jianxia Chen
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Geode extensions jars will be put in `extensions` directory. And the jars 
> in the `extensions` directory should be added to the classpath of Geode 
> locator/server and `gfsh`. So that Geode will pick up the extensions 
> automatically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5152) add unit test coverage for AbstractRegionMap.txApplyPut

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5152:
--
Labels: AbstractRegionMap pull-request-available  (was: AbstractRegionMap)

> add unit test coverage for AbstractRegionMap.txApplyPut
> ---
>
> Key: GEODE-5152
> URL: https://issues.apache.org/jira/browse/GEODE-5152
> Project: Geode
>  Issue Type: Sub-task
>  Components: transactions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
>
> AbstractRegionMapTest has some coverage for txApplyPut but a large section of 
> the method has no coverage. The while loop that handles a non-null "oldRe" is 
> never executed.
> Also, it is never called with an owner that 
> "isUsedForPartitionedRegionBucket()".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459226#comment-16459226
 ] 

ASF subversion and git services commented on GEODE-4987:


Commit 57f2079ed51b1563e02b750c7520f824be65f1c2 in geode's branch 
refs/heads/feature/GEODE-4987 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=57f2079 ]

GEODE-4987: Add rebalancing tests with colocated PRs and AEQ

* Added new tests for colocated PRs and AEQ


> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-369) CI failure: RedundancyLevelPart1DUnitTest.testRedundancySpecifiedNonPrimaryEPFailsDetectionByPut fails intermittently with assertion

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-369.
---
Resolution: Cannot Reproduce  (was: Fixed)

> CI failure: 
> RedundancyLevelPart1DUnitTest.testRedundancySpecifiedNonPrimaryEPFailsDetectionByPut
>  fails intermittently with assertion
> 
>
> Key: GEODE-369
> URL: https://issues.apache.org/jira/browse/GEODE-369
> Project: Geode
>  Issue Type: Bug
>  Components: client queues, client/server
>Reporter: Darrel Schneider
>Priority: Minor
>  Labels: CI
> Fix For: 1.0.0-incubating.M2
>
>
> failed on a private build of git rev :
> {code}
> junit.framework.AssertionFailedError: Event never occurred after 6 ms: 
> Redundant servers ([doomtwo.gemstone.com29009]) does not contain 
> doomtwo.gemstone.com27615
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.TestCase.fail(TestCase.java:227)
>   at 
> dunit.DistributedTestCase.waitForCriterion(DistributedTestCase.java:1162)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.RedundancyLevelTestBase.verifyRedundantServersContain(RedundancyLevelTestBase.java:267)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.RedundancyLevelPart1DUnitTest.testRedundancySpecifiedNonPrimaryEPFailsDetectionByPut(RedundancyLevelPart1DUnitTest.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-3418) Numerous CI failures on Ubuntu

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-3418.

Resolution: Not A Problem

> Numerous CI failures on Ubuntu
> --
>
> Key: GEODE-3418
> URL: https://issues.apache.org/jira/browse/GEODE-3418
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Bruce Schuchardt
>Priority: Major
>
> Jenkins runs on Apache servers running Ubuntu are failing with numerous 
> suspect strings such as this:
> {noformat}
> [error 2017/08/08 10:32:22.980 UTC  
> tid=0x13] failed setting interface to /127.0.1.1: java.net.SocketException: 
> bad argument for IP_MULTICAST_IF: address not bound to any interface
> java.net.SocketException: bad argument for IP_MULTICAST_IF: address not bound 
> to any interface
>   at java.net.PlainDatagramSocketImpl.socketSetOption0(Native Method)
>   at 
> java.net.PlainDatagramSocketImpl.socketSetOption(PlainDatagramSocketImpl.java:74)
>   at 
> java.net.AbstractPlainDatagramSocketImpl.setOption(AbstractPlainDatagramSocketImpl.java:309)
>   at java.net.MulticastSocket.setInterface(MulticastSocket.java:471)
>   at org.jgroups.protocols.UDP.setInterface(UDP.java:443)
>   at org.jgroups.protocols.UDP.createMulticastSocket(UDP.java:511)
>   at 
> org.jgroups.protocols.UDP.createMulticastSocketWithBindPort(UDP.java:494)
>   at org.jgroups.protocols.UDP.createSockets(UDP.java:348)
>   at org.jgroups.protocols.UDP.start(UDP.java:266)
>   at org.jgroups.stack.ProtocolStack.startStack(ProtocolStack.java:966)
>   at org.jgroups.JChannel.startStack(JChannel.java:889)
>   at org.jgroups.JChannel._preConnect(JChannel.java:553)
>   at org.jgroups.JChannel.connect(JChannel.java:288)
>   at org.jgroups.JChannel.connect(JChannel.java:279)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.start(JGroupsMessenger.java:344)
>   at 
> org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:156)
>   at 
> org.apache.geode.distributed.internal.membership.gms.GMSMemberFactory.newMembershipManager(GMSMemberFactory.java:107)
>   at 
> org.apache.geode.distributed.internal.membership.MemberFactory.newMembershipManager(MemberFactory.java:91)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1155)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1204)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.create(DistributionManager.java:573)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:740)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:350)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:336)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:330)
>   at 
> org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
>   at 
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:689)
>   at 
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:325)
>   at org.apache.geode.distributed.Locator.startLocator(Locator.java:253)
>   at 
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:202)
>   at 
> org.apache.geode.cache.client.internal.LocatorTestBase.startLocator(LocatorTestBase.java:131)
>   at 
> org.apache.geode.cache.client.internal.AutoConnectionSourceDUnitTest.lambda$testServerGroups$a837a6e6$1(AutoConnectionSourceDUnitTest.java:258)
>   at org.apache.geode.test.dunit.NamedRunnable.run(NamedRunnable.java:31)
>   at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at hydra.MethExecutor.executeObject(MethExecutor.java:245)
>   at 
> org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
>   at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
>   at sun.rmi.transport.Transport$1.run(Transport.java:200)
>   at sun.rmi.transport.Transport$1.run(Transport.java:197)
>   at 

[jira] [Commented] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459215#comment-16459215
 ] 

ASF subversion and git services commented on GEODE-4987:


Commit 1637975670a84496d3576740b3dad78963a9f36f in geode's branch 
refs/heads/feature/GEODE-4987 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1637975 ]

GEODE-4987: Add rebalancing tests with colocated PRs and AEQ

* Added new tests for colocated PRs and AEQ


> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-3405) Add support for PDX from clients

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-3405.

Resolution: Later

> Add support for PDX from clients
> 
>
> Key: GEODE-3405
> URL: https://issues.apache.org/jira/browse/GEODE-3405
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Priority: Major
>
> As a user of the client/server protocol, I need to be able to put my 
> PDX-serialized object and get it back out again (as a PDX instance if I've 
> set read-serialized=true, or as a domain object if I've set 
> read-serialized=false).
> Add support for accepting PDX-serialized types from clients and ensure we're 
> sending the right format back on reads.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459202#comment-16459202
 ] 

ASF subversion and git services commented on GEODE-4987:


Commit dbb97c2349f78a83be4941db124130f5016329bb in geode's branch 
refs/heads/feature/GEODE-4987 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=dbb97c2 ]

GEODE-4987: Add rebalancing tests with colocated PRs and AEQ

* Added new tests for colocated PRs and AEQ


> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459200#comment-16459200
 ] 

ASF subversion and git services commented on GEODE-4987:


Commit 005e0bb5e93555d616d5836483be23bd66d16673 in geode's branch 
refs/heads/feature/GEODE-4987 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=005e0bb ]

GEODE-4987: Add rebalancing tests with colocated PRs and AEQ

* Added new tests for colocated PRs and AEQ


> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459194#comment-16459194
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-4987 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459189#comment-16459189
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 929ce605a81a98d8c95f61edf825926481b053b2 in geode's branch 
refs/heads/feature/GEODE-4987 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=929ce60 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal.cache. (#1883)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459193#comment-16459193
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-4987 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459195#comment-16459195
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-4987 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459192#comment-16459192
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/feature/GEODE-4987 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459196#comment-16459196
 ] 

ASF subversion and git services commented on GEODE-4987:


Commit bee5ee0b8fe30d603a73e963cd112c62d701d1e5 in geode's branch 
refs/heads/feature/GEODE-4987 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bee5ee0 ]

GEODE-4987: Add rebalancing tests with colocated PRs and AEQ

* Added new tests for colocated PRs and AEQ


> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459188#comment-16459188
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/feature/GEODE-4987 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459182#comment-16459182
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 0ee42d11788fc923a8fd5fe2b006f048126e70d6 in geode's branch 
refs/heads/feature/GEODE-4987 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ee42d1 ]

 GEODE-2953: Expand wildcard imports in geode-core:internal. (#1874)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459187#comment-16459187
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/feature/GEODE-4987 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5059) AbstractRegionMap.basicPut should be refactored

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459184#comment-16459184
 ] 

ASF subversion and git services commented on GEODE-5059:


Commit 31240b810fe65ded17296d62445152aece245554 in geode's branch 
refs/heads/feature/GEODE-4987 from [~agingade]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=31240b8 ]

GEODE-5059: Move basicPut functionality to RegionMapPut (#1858)

* Move the methods to RegionMapPut
* Add tests to RegionMapPut


> AbstractRegionMap.basicPut should be refactored
> ---
>
> Key: GEODE-5059
> URL: https://issues.apache.org/jira/browse/GEODE-5059
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently the AbstractRegionMap.basicPut method was refactored into many 
> smaller methods that all take an instance of RegionMapPutContext.
> These methods should be moved to another class (it could be named 
> RegionMapPut) and the RegionMapPutContext could go away since the 
> RegionMapPut instance could keep all the state of the put operation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459185#comment-16459185
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 96307b99c1bfbb9552c29296efd4ebdc61434dcc in geode's branch 
refs/heads/feature/GEODE-4987 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=96307b9 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal and 
...management. (#1881)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459183#comment-16459183
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit f5e07fc473181703eb1e797c3901dfb80ddd5d50 in geode's branch 
refs/heads/feature/GEODE-4987 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f5e07fc ]

GEODE-2953: Expand wildcard imports in geode-core:internal.admin. (#1875)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5155) hang recovering transaction state for crashed server

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5155:
--
Labels: pull-request-available  (was: )

> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service, transactions
>Affects Versions: 1.7.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The problem is that the membership listener in TXCommitMessage is removing 
> itself from the transaction map in TXFarSideCMTracker without setting any 
> state that the recovery message can check.  The recovery method is waiting 
> like this:
> {code}
> synchronized 

[jira] [Assigned] (GEODE-4987) Add rebalancing tests with colocated PRs and AEQ (colocated region)

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey reassigned GEODE-4987:
--

Assignee: Shelley Lynn Hughes-Godfrey

> Add rebalancing tests with colocated PRs and AEQ (colocated region) 
> 
>
> Key: GEODE-4987
> URL: https://issues.apache.org/jira/browse/GEODE-4987
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Create tests to add colocated partitioned regions during rebalance to verify 
> co-located region does not hang.
> Create similar test with AEQ (which is a colocated region) to verify that 
> mutating region to add AEQ does not hang during rebalance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5155) hang recovering transaction state for crashed server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459170#comment-16459170
 ] 

ASF subversion and git services commented on GEODE-5155:


Commit e1688b6ab99fb4abca5be8e260eb0380eba33695 in geode's branch 
refs/heads/feature/GEODE-5155 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e1688b6 ]

GEODE-5155 hang recovering transaction state for crashed server

renaming variables to make the code more readable


> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service, transactions
>Affects Versions: 1.7.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The 

[jira] [Created] (GEODE-5159) Client can send over various supported data formats

[Addison (JIRA)]

Addison created GEODE-5159:
--

 Summary: Client can send over various supported data formats
 Key: GEODE-5159
 URL: https://issues.apache.org/jira/browse/GEODE-5159
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Addison


If I'm writing a client, I want to be able to have flexibility in the data 
object's serialization format.  Out of the gate, the new protocol should be 
able to support PDX, Protobuf Structs, and JSON.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5155) hang recovering transaction state for crashed server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459166#comment-16459166
 ] 

ASF subversion and git services commented on GEODE-5155:


Commit 1a9ee1f198877d6d715c9563f2d68cfb318ba88b in geode's branch 
refs/heads/feature/GEODE-5155 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1a9ee1f ]

GEODE-5155 hang recovering transaction state for crashed server

oops - missed a change


> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service, transactions
>Affects Versions: 1.7.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The problem is that the 

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459143#comment-16459143
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459144#comment-16459144
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459146#comment-16459146
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459145#comment-16459145
 ] 

ASF subversion and git services commented on GEODE-3881:


Commit 2334b1b9cc4dce107e035424abfb4c4751547082 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2334b1b ]

GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator. (#1880)

* GEODE-3881: Replace bespoke random string generation with extant three-phrase 
generator.
- Add unit test for three-phrase generator to ensure compatibility with region 
names.
- Rename parameter to improve clarity.
- Remove dead code.

* GEODE-3881: Why does the spotlessApply task not work consistently?!

* GEODE-3881: Change assertion messages to indicate failures.


> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-3881) [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge resolved GEODE-3881.
--
   Resolution: Fixed
Fix Version/s: (was: 1.6.0)
   1.7.0

> [CI Failure] org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> 
>
> Key: GEODE-3881
> URL: https://issues.apache.org/jira/browse/GEODE-3881
> Project: Geode
>  Issue Type: Bug
>  Components: ci, redis
>Reporter: Eric Shu
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.redis.SetsJUnitTest > testSDiffAndStore FAILED
> redis.clients.jedis.exceptions.JedisDataException: ERR This key could not 
> be created. Gemfire does not allow certain characters to used in keys
> at redis.clients.jedis.Protocol.processError(Protocol.java:127)
> at redis.clients.jedis.Protocol.process(Protocol.java:161)
> at redis.clients.jedis.Protocol.read(Protocol.java:215)
> at 
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
> at redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
> at redis.clients.jedis.Jedis.sdiffstore(Jedis.java:1341)
> at 
> org.apache.geode.redis.SetsJUnitTest.testSDiffAndStore(SetsJUnitTest.java:157)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5158) applyTxUpdateOnReplicateOrRedundantCopy txEntryState parameter is always null

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-5158:
---

 Summary: applyTxUpdateOnReplicateOrRedundantCopy txEntryState 
parameter is always null
 Key: GEODE-5158
 URL: https://issues.apache.org/jira/browse/GEODE-5158
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Darrel Schneider


applyTxUpdateOnReplicateOrRedundantCopy txEntryState parameter is always null. 
So the parameter should be removed. Other parameters on this method should also 
be reviewed.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459116#comment-16459116
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/feature/GEODE-5096 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459115#comment-16459115
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/feature/GEODE-5096 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5157) ClientHealthStats may not be propagated when system has a hostname

[Jens Deppe (JIRA)]

Jens Deppe created GEODE-5157:
-

 Summary: ClientHealthStats may not be propagated when system has a 
hostname
 Key: GEODE-5157
 URL: https://issues.apache.org/jira/browse/GEODE-5157
 Project: Geode
  Issue Type: Bug
  Components: cq, jmx
Reporter: Jens Deppe


For CQs, the client publishes stats from 
{{ClientStatsManager.publishClientStats}}. Here the client memberId is used as 
a key for putting the stats into an admin region. If the client has a valid 
hostname then the memberId contains the hostname. If there is no valid 
hostname, then the memberId is just the IP address.

On the server side, clientIDs are determined from {{CacheClientProxy}} objects 
- see {{CacheServerBridge.getUniqueClientIds}}. It appears that these IDs are 
always IP-address based.

Thus if there is this mismatch then ClientHealthStats are not published 
correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459118#comment-16459118
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 4fd83d7e73dd66674a82b34adeaeedbd024dde70 in geode's branch 
refs/heads/feature/GEODE-5096 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4fd83d7 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal.cache... 
subpackages. (#1884)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459113#comment-16459113
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 96307b99c1bfbb9552c29296efd4ebdc61434dcc in geode's branch 
refs/heads/feature/GEODE-5096 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=96307b9 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal and 
...management. (#1881)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459114#comment-16459114
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 3a9d9f341614b9020ae963766eafca7b8b956045 in geode's branch 
refs/heads/feature/GEODE-5096 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3a9d9f3 ]

 GEODE-2953: Expand wildcard imports in geode-core:test.internal... 
subpackages. (#1882)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459117#comment-16459117
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 929ce605a81a98d8c95f61edf825926481b053b2 in geode's branch 
refs/heads/feature/GEODE-5096 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=929ce60 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal.cache. (#1883)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459119#comment-16459119
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit e847ec093238a25b5b5d766d92a678072ec49e01 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e847ec0 ]

GEODE-5096: ValidateCacheServerProfileProcessor to validate
CacheServerProfiles at time upgrade.


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459109#comment-16459109
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit d75897eaf230b72d54fbf6ed9aa39eb9991e43e6 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d75897e ]

GEODE-5096: Reverting attempt to change tests to use DistributedTestRule


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2668) Add gfsh command to destroy gateway receiver

[Barbara Pruijn (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459110#comment-16459110
 ] 

Barbara Pruijn commented on GEODE-2668:
---

If the gateway receiver does not exist and we run the destroy gateway receiver 
command, we should get an error that the gateway receiver doesn't exist.
 We should *not* state:
{code:java}
gfsh>destroy gateway-receiver
This change is not persisted in the cluster configuration, either because the 
cluster configuration service is not running or the command is operating on 
targeted members.
Member | Status
-- | --
s1 | ERROR: Gateway receiver not found.{code}
We should state:
 {{Gateway receiver not found.}}

> Add gfsh command to destroy gateway receiver
> 
>
> Key: GEODE-2668
> URL: https://issues.apache.org/jira/browse/GEODE-2668
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently, there is a {{create gateway-receiver}} command, but no 
> corresponding destroy command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5096) AddCacheServerProfile should throw an error when conflicting Lucene indexes are concurrently created

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459106#comment-16459106
 ] 

ASF subversion and git services commented on GEODE-5096:


Commit f065976e99fd6f36910c05fbe3df4039363b3eb6 in geode's branch 
refs/heads/feature/GEODE-5096 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f065976 ]

GEODE-5096: Commit with Lucene testcases failing... Just to kickoff regression


> AddCacheServerProfile should throw an error when conflicting Lucene indexes 
> are concurrently created
> 
>
> Key: GEODE-5096
> URL: https://issues.apache.org/jira/browse/GEODE-5096
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>Priority: Major
>
> When two servers concurrently define a LuceneIndex, the addCacheServerProfile 
> should throw an error to avoid conflicting indexes being defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5059) AbstractRegionMap.basicPut should be refactored

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459105#comment-16459105
 ] 

ASF subversion and git services commented on GEODE-5059:


Commit 31240b810fe65ded17296d62445152aece245554 in geode's branch 
refs/heads/feature/GEODE-5096 from [~agingade]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=31240b8 ]

GEODE-5059: Move basicPut functionality to RegionMapPut (#1858)

* Move the methods to RegionMapPut
* Add tests to RegionMapPut


> AbstractRegionMap.basicPut should be refactored
> ---
>
> Key: GEODE-5059
> URL: https://issues.apache.org/jira/browse/GEODE-5059
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently the AbstractRegionMap.basicPut method was refactored into many 
> smaller methods that all take an instance of RegionMapPutContext.
> These methods should be moved to another class (it could be named 
> RegionMapPut) and the RegionMapPutContext could go away since the 
> RegionMapPut instance could keep all the state of the put operation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459104#comment-16459104
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit f5e07fc473181703eb1e797c3901dfb80ddd5d50 in geode's branch 
refs/heads/feature/GEODE-5096 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f5e07fc ]

GEODE-2953: Expand wildcard imports in geode-core:internal.admin. (#1875)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5156) Refactor InternalRegion to separate concerns into multiple interfaces or classes

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-5156:
-
Summary: Refactor InternalRegion to separate concerns into multiple 
interfaces or classes  (was: Refactor InternalRegion to separate concerns in 
multiple interfaces or classes)

> Refactor InternalRegion to separate concerns into multiple interfaces or 
> classes
> 
>
> Key: GEODE-5156
> URL: https://issues.apache.org/jira/browse/GEODE-5156
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Kirk Lund
>Priority: Major
>
> Next step after changing classes to depend on InternalRegion instead of 
> LocalRegion is to refactor InternalRegion and give better OOP form to what a 
> Region is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4721) Being invoked within JTA Region.values() (and all iteration related operations) does return empty collection

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459096#comment-16459096
 ] 

Kirk Lund commented on GEODE-4721:
--

User confirms that the bug was fixed in 1.5.

> Being invoked within JTA Region.values() (and all iteration related 
> operations) does return empty collection
> 
>
> Key: GEODE-4721
> URL: https://issues.apache.org/jira/browse/GEODE-4721
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Vadim Lotarev
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{Region.values()}} returns empty collection being invoked within JTA. Other 
> operations returns data, for example this workaround works (though less 
> efficient): {{region.getAll(region.keySet()).values()}}, also 
> {{Region.size()}} returns correct value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4721) Being invoked within JTA Region.values() (and all iteration related operations) does return empty collection

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4721:
-
Fix Version/s: 1.5.0

> Being invoked within JTA Region.values() (and all iteration related 
> operations) does return empty collection
> 
>
> Key: GEODE-4721
> URL: https://issues.apache.org/jira/browse/GEODE-4721
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Vadim Lotarev
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{Region.values()}} returns empty collection being invoked within JTA. Other 
> operations returns data, for example this workaround works (though less 
> efficient): {{region.getAll(region.keySet()).values()}}, also 
> {{Region.size()}} returns correct value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4721) Being invoked within JTA Region.values() (and all iteration related operations) does return empty collection

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-4721.
--
Resolution: Fixed

> Being invoked within JTA Region.values() (and all iteration related 
> operations) does return empty collection
> 
>
> Key: GEODE-4721
> URL: https://issues.apache.org/jira/browse/GEODE-4721
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Vadim Lotarev
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{Region.values()}} returns empty collection being invoked within JTA. Other 
> operations returns data, for example this workaround works (though less 
> efficient): {{region.getAll(region.keySet()).values()}}, also 
> {{Region.size()}} returns correct value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5059) AbstractRegionMap.basicPut should be refactored

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459070#comment-16459070
 ] 

Kirk Lund commented on GEODE-5059:
--

See GEODE-5156: Refactor InternalRegion to separate concerns in multiple 
interfaces or classes

> AbstractRegionMap.basicPut should be refactored
> ---
>
> Key: GEODE-5059
> URL: https://issues.apache.org/jira/browse/GEODE-5059
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently the AbstractRegionMap.basicPut method was refactored into many 
> smaller methods that all take an instance of RegionMapPutContext.
> These methods should be moved to another class (it could be named 
> RegionMapPut) and the RegionMapPutContext could go away since the 
> RegionMapPut instance could keep all the state of the put operation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5156) Refactor InternalRegion to separate concerns in multiple interfaces or classes

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-5156:


 Summary: Refactor InternalRegion to separate concerns in multiple 
interfaces or classes
 Key: GEODE-5156
 URL: https://issues.apache.org/jira/browse/GEODE-5156
 Project: Geode
  Issue Type: Improvement
  Components: regions
Reporter: Kirk Lund


Next step after changing classes to depend on InternalRegion instead of 
LocalRegion is to refactor InternalRegion and give better OOP form to what a 
Region is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-5059) AbstractRegionMap.basicPut should be refactored

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-5059.
--
Resolution: Fixed

This bug was reopened and I'm reclosing it. We will create a new ticket for the 
next step in refactoring Geode to not depend directly on implementations.

We're using InternalRegion as a stepping stone, refactoring all classes that 
use LocalRegion to instead use InternalRegion. Next step after that is to give 
InternalRegion form.

> AbstractRegionMap.basicPut should be refactored
> ---
>
> Key: GEODE-5059
> URL: https://issues.apache.org/jira/browse/GEODE-5059
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently the AbstractRegionMap.basicPut method was refactored into many 
> smaller methods that all take an instance of RegionMapPutContext.
> These methods should be moved to another class (it could be named 
> RegionMapPut) and the RegionMapPutContext could go away since the 
> RegionMapPut instance could keep all the state of the put operation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5135) Refactor the static method AbstractRegionMap.createCBEvent

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-5135:
-
Labels: AbstractRegionMap  (was: )

> Refactor the static method AbstractRegionMap.createCBEvent
> --
>
> Key: GEODE-5135
> URL: https://issues.apache.org/jira/browse/GEODE-5135
> Project: Geode
>  Issue Type: Improvement
>  Components: transactions
>Reporter: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap
>
> AbstractRegionMap.createCBEvent would make more sense as a factory method on 
> EntryEventImpl. Note that ProxyRegionMap currently calls static methods on 
> AbstractRegionMap.
> Since ProxyRegionMap and AbstractRegionMap both implement the RegionMap 
> interface it would be better to either have a common ancestor class for both 
> these classes that contains this common code they share or move this code to 
> methods on the RegionMap interface. It would be nice if ProxyRegionMap did 
> not depend on anything in AbstractRegionMap.
> One idea would be to rename AbstractRegionMap to StorageRegionMap and then 
> have the common ancestor class that both ProxyRegionMap and StorageRegionMap 
> extend by named AbstractRegionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5152) add unit test coverage for AbstractRegionMap.txApplyPut

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-5152:
-
Labels: AbstractRegionMap  (was: )

> add unit test coverage for AbstractRegionMap.txApplyPut
> ---
>
> Key: GEODE-5152
> URL: https://issues.apache.org/jira/browse/GEODE-5152
> Project: Geode
>  Issue Type: Sub-task
>  Components: transactions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap
>
> AbstractRegionMapTest has some coverage for txApplyPut but a large section of 
> the method has no coverage. The while loop that handles a non-null "oldRe" is 
> never executed.
> Also, it is never called with an owner that 
> "isUsedForPartitionedRegionBucket()".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5151) AbstractRegionMap.txApplyPut should be refactored

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-5151:
-
Labels: AbstractRegionMap  (was: )

> AbstractRegionMap.txApplyPut should be refactored
> -
>
> Key: GEODE-5151
> URL: https://issues.apache.org/jira/browse/GEODE-5151
> Project: Geode
>  Issue Type: Improvement
>  Components: transactions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: AbstractRegionMap
>
> With GEODE-5059 (AbstractRegionMap.basicPut) there is an opportunity to 
> refactor the code for txApplyPut.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5155) hang recovering transaction state for crashed server

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-5155:

Affects Version/s: 1.7.0

> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service, transactions
>Affects Versions: 1.7.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The problem is that the membership listener in TXCommitMessage is removing 
> itself from the transaction map in TXFarSideCMTracker without setting any 
> state that the recovery message can check.  The recovery method is waiting 
> like this:
> {code}
> synchronized (this.txInProgress) {
>   mess = (TXCommitMessage) 

[jira] [Updated] (GEODE-5155) hang recovering transaction state for crashed server

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-5155:

Issue Type: Bug  (was: New Feature)

> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service, transactions
>Affects Versions: 1.7.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The problem is that the membership listener in TXCommitMessage is removing 
> itself from the transaction map in TXFarSideCMTracker without setting any 
> state that the recovery message can check.  The recovery method is waiting 
> like this:
> {code}
> synchronized (this.txInProgress) {
>   mess = (TXCommitMessage) 

[jira] [Assigned] (GEODE-5155) hang recovering transaction state for crashed server

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-5155:
---

Assignee: Bruce Schuchardt

> hang recovering transaction state for crashed server
> 
>
> Key: GEODE-5155
> URL: https://issues.apache.org/jira/browse/GEODE-5155
> Project: Geode
>  Issue Type: New Feature
>  Components: distributed lock service, transactions
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> A concourse job failed in 
> DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
> two threads stuck in this state:
> {noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
> [vm2] java.lang.Thread.State: WAITING
> [vm2] at java.lang.Object.wait(Native Method)
> [vm2] -  waiting on 
> org.apache.geode.internal.cache.TXCommitMessage@2105ce6
> [vm2] at java.lang.Object.wait(Object.java:502)
> [vm2] at 
> org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
> [vm2] at 
> org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm2] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
> [vm2] at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
> [vm2] at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I modified the test to tighten up its forcedDisconnect and performOps methods 
> to get transaction recovery to happen more reliably.
> {code}
>   public void forceDisconnect() throws Exception {
> Cache existingCache = basicGetCache();
> synchronized(commitLock) {
>   committing = false;
>   while (!committing) {
> commitLock.wait();
>   }
> }
> if (existingCache != null && !existingCache.isClosed()) {
>   
> DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
> }
>   }
>   public void performOps() {
> Cache cache = getCache();
> Region region = cache.getRegion("TestRegion");
> DistributedLockService dlockService = 
> DistributedLockService.getServiceNamed("Bulldog");
> Random random = new Random();
> while (!cache.isClosed()) {
>   boolean locked = false;
>   try {
> locked = dlockService.lock("testDLock", 500, 60_000);
> if (!locked) {
>   // this could happen if we're starved out for 30sec by other VMs
>   continue;
> }
> cache.getCacheTransactionManager().begin();
> region.put("TestKey", "TestValue" + random.nextInt(10));
> TXManagerImpl mgr = (TXManagerImpl) 
> getCache().getCacheTransactionManager();
> TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
> TXState txState = (TXState) txProxy.getRealDeal(null, null);
> txState.setBeforeSend(() -> {
>   synchronized(commitLock) {
> committing = true;
> commitLock.notifyAll();
>   }});
> try {
>   cache.getCacheTransactionManager().commit();
> } catch (CommitConflictException e) {
>   throw new RuntimeException("dlock failed to prevent a transaction 
> conflict", e);
> }
> int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
> getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);
>   } catch (CancelException | IllegalStateException e) {
> // okay to ignore
>   } finally {
> if (locked) {
>   try {
> dlockService.unlock("testDLock");
>   } catch (CancelException | IllegalStateException e) {
> // shutting down
>   }
> }
>   }
> }
>   }
> {code}
> The problem is that the membership listener in TXCommitMessage is removing 
> itself from the transaction map in TXFarSideCMTracker without setting any 
> state that the recovery message can check.  The recovery method is waiting 
> like this:
> {code}
> synchronized (this.txInProgress) {
>   mess = (TXCommitMessage) this.txInProgress.get(lk);
> 

[jira] [Updated] (GEODE-5155) hang recovering transaction state for crashed server

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-5155:

Description: 
A concourse job failed in 
DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
two threads stuck in this state:

{noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
[vm2] java.lang.Thread.State: WAITING
[vm2]   at java.lang.Object.wait(Native Method)
[vm2]   -  waiting on org.apache.geode.internal.cache.TXCommitMessage@2105ce6
[vm2]   at java.lang.Object.wait(Object.java:502)
[vm2]   at 
org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
[vm2]   at 
org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
[vm2]   at 
org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
[vm2]   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[vm2]   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
[vm2]   at java.lang.Thread.run(Thread.java:748)
{noformat}

I modified the test to tighten up its forcedDisconnect and performOps methods 
to get transaction recovery to happen more reliably.

{code}
  public void forceDisconnect() throws Exception {
Cache existingCache = basicGetCache();
synchronized(commitLock) {
  committing = false;
  while (!committing) {
commitLock.wait();
  }
}
if (existingCache != null && !existingCache.isClosed()) {
  
DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
}
  }


  public void performOps() {
Cache cache = getCache();
Region region = cache.getRegion("TestRegion");
DistributedLockService dlockService = 
DistributedLockService.getServiceNamed("Bulldog");
Random random = new Random();

while (!cache.isClosed()) {
  boolean locked = false;
  try {
locked = dlockService.lock("testDLock", 500, 60_000);
if (!locked) {
  // this could happen if we're starved out for 30sec by other VMs
  continue;
}

cache.getCacheTransactionManager().begin();

region.put("TestKey", "TestValue" + random.nextInt(10));

TXManagerImpl mgr = (TXManagerImpl) 
getCache().getCacheTransactionManager();
TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
TXState txState = (TXState) txProxy.getRealDeal(null, null);
txState.setBeforeSend(() -> {
  synchronized(commitLock) {
committing = true;
commitLock.notifyAll();
  }});

try {
  cache.getCacheTransactionManager().commit();
} catch (CommitConflictException e) {
  throw new RuntimeException("dlock failed to prevent a transaction 
conflict", e);
}

int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);

  } catch (CancelException | IllegalStateException e) {
// okay to ignore
  } finally {
if (locked) {
  try {
dlockService.unlock("testDLock");
  } catch (CancelException | IllegalStateException e) {
// shutting down
  }
}
  }
}
  }
{code}

The problem is that the membership listener in TXCommitMessage is removing 
itself from the transaction map in TXFarSideCMTracker without setting any state 
that the recovery message can check.  The recovery method is waiting like this:

{code}
synchronized (this.txInProgress) {
  mess = (TXCommitMessage) this.txInProgress.get(lk);
}
if (mess != null) {
  synchronized (mess) {
// tx in progress, we must wait until its done
while (!mess.wasProcessed()) {
  try {
mess.wait();
  } catch (InterruptedException ie) {
Thread.currentThread().interrupt();
logger.error(LocalizedMessage.create(

LocalizedStrings.TxFarSideTracker_WAITING_TO_COMPLETE_ON_MESSAGE_0_CAUGHT_AN_INTERRUPTED_EXCEPTION,
mess), ie);
break;
  }
}
  }
{code}

We could probably change this method to make sure that the message is still in 
the map instead of only checking wasProcessed().


  was:
A concourse job failed in 

[jira] [Created] (GEODE-5155) hang recovering transaction state for crashed server

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-5155:
---

 Summary: hang recovering transaction state for crashed server
 Key: GEODE-5155
 URL: https://issues.apache.org/jira/browse/GEODE-5155
 Project: Geode
  Issue Type: New Feature
  Components: distributed lock service, transactions
Reporter: Bruce Schuchardt


A concourse job failed in 
DlockAndTxlockRegressionTest.testDLockProtectsAgainstTransactionConflict with 
two threads stuck in this state:

{noformat}[vm2] "Pooled Waiting Message Processor 2" tid=0x71
[vm2] java.lang.Thread.State: WAITING
[vm2]   at java.lang.Object.wait(Native Method)
[vm2]   -  waiting on org.apache.geode.internal.cache.TXCommitMessage@2105ce6
[vm2]   at java.lang.Object.wait(Object.java:502)
[vm2]   at 
org.apache.geode.internal.cache.TXFarSideCMTracker.waitToProcess(TXFarSideCMTracker.java:176)
[vm2]   at 
org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage.processTXOriginatorRecoveryMessage(TXOriginatorRecoveryProcessor.java:160)
[vm2]   at 
org.apache.geode.internal.cache.locks.TXOriginatorRecoveryProcessor$TXOriginatorRecoveryMessage$1.run(TXOriginatorRecoveryProcessor.java:144)
[vm2]   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[vm2]   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager.runUntilShutdown(ClusterDistributionManager.java:1121)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager.access$000(ClusterDistributionManager.java:109)
[vm2]   at 
org.apache.geode.distributed.internal.ClusterDistributionManager$6$1.run(ClusterDistributionManager.java:865)
[vm2]   at java.lang.Thread.run(Thread.java:748)
{noformat}

I modified the test to tighten up its forcedDisconnect and performOps methods 
to get transaction recovery to happen more reliably.

{code}
  public void forceDisconnect() throws Exception {
Cache existingCache = basicGetCache();
synchronized(commitLock) {
  committing = false;
  while (!committing) {
commitLock.wait();
  }
}
if (existingCache != null && !existingCache.isClosed()) {
  
DistributedTestUtils.crashDistributedSystem(getCache().getDistributedSystem());
}
  }


  public void performOps() {
Cache cache = getCache();
Region region = cache.getRegion("TestRegion");
DistributedLockService dlockService = 
DistributedLockService.getServiceNamed("Bulldog");
Random random = new Random();

while (!cache.isClosed()) {
  boolean locked = false;
  try {
locked = dlockService.lock("testDLock", 500, 60_000);
if (!locked) {
  // this could happen if we're starved out for 30sec by other VMs
  continue;
}

cache.getCacheTransactionManager().begin();

region.put("TestKey", "TestValue" + random.nextInt(10));

TXManagerImpl mgr = (TXManagerImpl) 
getCache().getCacheTransactionManager();
TXStateProxyImpl txProxy = (TXStateProxyImpl) mgr.getTXState();
TXState txState = (TXState) txProxy.getRealDeal(null, null);
txState.setBeforeSend(() -> {
  synchronized(commitLock) {
committing = true;
commitLock.notifyAll();
  }});

try {
  cache.getCacheTransactionManager().commit();
} catch (CommitConflictException e) {
  throw new RuntimeException("dlock failed to prevent a transaction 
conflict", e);
}

int txCount = getBlackboard().getMailbox(TRANSACTION_COUNT);
getBlackboard().setMailbox(TRANSACTION_COUNT, txCount + 1);

  } catch (CancelException | IllegalStateException e) {
// okay to ignore
  } finally {
if (locked) {
  try {
dlockService.unlock("testDLock");
  } catch (CancelException | IllegalStateException e) {
// shutting down
  }
}
  }
}
  }
{code}

The problem is that the membership listener in TXCommit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5154) null checks on callbackEvent are not needed in txApplyPut

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-5154:
---

 Summary: null checks on callbackEvent are not needed in txApplyPut
 Key: GEODE-5154
 URL: https://issues.apache.org/jira/browse/GEODE-5154
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Darrel Schneider


The txApplyPut code has a number of null checks on the "callbackEvent" which is 
a field that could be made final and always has a non-null value. In general 
this is true for all the txApply* methods on AbstractRegionMap. 
txApplyInvalidate and txApplyDestroy are more complicated would need some 
additional refactoring to make sure "callbackEvent" is never null.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458953#comment-16458953
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 929ce605a81a98d8c95f61edf825926481b053b2 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=929ce60 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal.cache. (#1883)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5153) Remove use of internal distributed system and log writer utils from IgnoredException

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5153:
--
Labels: pull-request-available  (was: )

> Remove use of internal distributed system and log writer utils from 
> IgnoredException
> 
>
> Key: GEODE-5153
> URL: https://issues.apache.org/jira/browse/GEODE-5153
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
>
> In {{IgnoredException}}, the internal distributed system's log writer and the 
> log writer utils' log writer are used to log add and remove messages. These 
> uses have comments that say {{TODO}} and indicate that the uses should be 
> removed. Since the log service's logger is already used to log add and remove 
> messages, remove the use of the internal distributed system's log writer and 
> the log writer utils' log writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-5153) Remove use of internal distributed system and log writer utils from IgnoredException

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge reassigned GEODE-5153:


Assignee: Michael Dodge

> Remove use of internal distributed system and log writer utils from 
> IgnoredException
> 
>
> Key: GEODE-5153
> URL: https://issues.apache.org/jira/browse/GEODE-5153
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>Priority: Major
>
> In {{IgnoredException}}, the internal distributed system's log writer and the 
> log writer utils' log writer are used to log add and remove messages. These 
> uses have comments that say {{TODO}} and indicate that the uses should be 
> removed. Since the log service's logger is already used to log add and remove 
> messages, remove the use of the internal distributed system's log writer and 
> the log writer utils' log writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5153) Remove use of internal distributed system and log writer utils from IgnoredException

[Michael Dodge (JIRA)]

Michael Dodge created GEODE-5153:


 Summary: Remove use of internal distributed system and log writer 
utils from IgnoredException
 Key: GEODE-5153
 URL: https://issues.apache.org/jira/browse/GEODE-5153
 Project: Geode
  Issue Type: Improvement
  Components: general
Reporter: Michael Dodge


In {{IgnoredException}}, the internal distributed system's log writer and the 
log writer utils' log writer are used to log add and remove messages. These 
uses have comments that say {{TODO}} and indicate that the uses should be 
removed. Since the log service's logger is already used to log add and remove 
messages, remove the use of the internal distributed system's log writer and 
the log writer utils' log writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-5152) add unit test coverage for AbstractRegionMap.txApplyPut

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-5152:
---

 Summary: add unit test coverage for AbstractRegionMap.txApplyPut
 Key: GEODE-5152
 URL: https://issues.apache.org/jira/browse/GEODE-5152
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Darrel Schneider


AbstractRegionMapTest has some coverage for txApplyPut but a large section of 
the method has no coverage. The while loop that handles a non-null "oldRe" is 
never executed.
Also, it is never called with an owner that 
"isUsedForPartitionedRegionBucket()".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (GEODE-5059) AbstractRegionMap.basicPut should be refactored

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reopened GEODE-5059:
--

I'm re-opening this ticket, because I feel that the changes made less correct 
than expected. I would avoid just adding more methods to the `InternalRegion` 
and trying to add them to a more logical location and potentially using 
composition to add functionality.

> AbstractRegionMap.basicPut should be refactored
> ---
>
> Key: GEODE-5059
> URL: https://issues.apache.org/jira/browse/GEODE-5059
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: AbstractRegionMap, pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently the AbstractRegionMap.basicPut method was refactored into many 
> smaller methods that all take an instance of RegionMapPutContext.
> These methods should be moved to another class (it could be named 
> RegionMapPut) and the RegionMapPutContext could go away since the 
> RegionMapPut instance could keep all the state of the put operation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458831#comment-16458831
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-5065) DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458830#comment-16458830
 ] 

ASF subversion and git services commented on GEODE-5065:


Commit 4b9dc96fe4771e31efd09398965f7eb496faeae5 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b9dc96 ]

GEODE-5065 Increase timeout for a flaky distributed test. And cleanup. (#1821)

GEODE-5065 Increase timeout for a flaky distributed test.

* remove duplicate/unneeded methods and fields
* make a lot of methods private
* Don't use the reflection-based `invoke` form
* Change some CacheSerializableRunnables with misleading description
  text to plain ol' lambdas.
* Simplify waiting logic.
* Merge all the registration methods into one.
* We don't need more than three registered DataSerializers per test;
  remove the others.
* Remove single data serializer test because it's redundant.

I'm not entirely sure this will fix all the issues but at least the code is 
more readable now.


> DataSerializerPropagationDUnitTest.testServerUpFirstClientLater is flaky
> 
>
> Key: GEODE-5065
> URL: https://issues.apache.org/jira/browse/GEODE-5065
> Project: Geode
>  Issue Type: Bug
>Reporter: Brian Rowe
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Test tests that value set on server is propagated to client, but doesn't wait 
> for queue to be processed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5148) CI Failure: InitializedDiskRegionWithIoExceptionRegressionTest.cacheServerPersistWithIOExceptionShouldShutdown

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-5148:

Component/s: (was: client/server)
 client queues

> CI Failure: 
> InitializedDiskRegionWithIoExceptionRegressionTest.cacheServerPersistWithIOExceptionShouldShutdown
> --
>
> Key: GEODE-5148
> URL: https://issues.apache.org/jira/browse/GEODE-5148
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Eric Shu
>Priority: Major
>
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest
>  > cacheServerPersistWithIOExceptionShouldShutdown FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest$$Lambda$23/1222369873.run
>  in VM 1 running on Host 0b1780a0efc9 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:436)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:405)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:348)
> at 
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest.cacheServerPersistWithIOExceptionShouldShutdown(InitializedDiskRegionWithIoExceptionRegressionTest.java:113)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:187)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:539)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:850)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:356)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3749)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3840)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3638)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3633)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3628)
> at 
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest.createClientCache(InitializedDiskRegionWithIoExceptionRegressionTest.java:172)
> at 
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest.lambda$cacheServerPersistWithIOExceptionShouldShutdown$2c6907a2$1(InitializedDiskRegionWithIoExceptionRegressionTest.java:113)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> Could not initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:585)
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:296)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:347)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:172)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:158)
> at 
> org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:346)
> at 
> org.apache.geode.internal.cache.InitializedDiskRegionWithIoExceptionRegressionTest.createClientCache(InitializedDiskRegionWithIoExceptionRegressionTest.java:164)
> ... 1 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4657) Geode Native receives timeouts in ms during client/server handshake

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-4657:
---
Description: Geode changed the protocol to use ms during the client/server 
handshake. Update Geode Native to support this change and bump the ordinal 
number of Geode Native.  (was: Geode changed the protocol to use ms during the 
client/server handshake. Update Geode Native to support this change and bump 
the ordinal number of Geode Native)

> Geode Native receives timeouts in ms during client/server handshake
> ---
>
> Key: GEODE-4657
> URL: https://issues.apache.org/jira/browse/GEODE-4657
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Addison
>Priority: Major
>
> Geode changed the protocol to use ms during the client/server handshake. 
> Update Geode Native to support this change and bump the ordinal number of 
> Geode Native.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4657) Geode Native receives timeouts in ms during client/server handshake

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-4657:
---
Description: Geode changed the protocol to use ms during the client/server 
handshake. Update Geode Native to support this change and bump the ordinal 
number of Geode Native  (was: Story also includes bumping the ordinal number of 
Geode Native)

> Geode Native receives timeouts in ms during client/server handshake
> ---
>
> Key: GEODE-4657
> URL: https://issues.apache.org/jira/browse/GEODE-4657
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Addison
>Priority: Major
>
> Geode changed the protocol to use ms during the client/server handshake. 
> Update Geode Native to support this change and bump the ordinal number of 
> Geode Native



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458749#comment-16458749
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 3a9d9f341614b9020ae963766eafca7b8b956045 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3a9d9f3 ]

 GEODE-2953: Expand wildcard imports in geode-core:test.internal... 
subpackages. (#1882)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2953) Code Cleanup: Replace wildcard imports with explicit imports

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458745#comment-16458745
 ] 

ASF subversion and git services commented on GEODE-2953:


Commit 96307b99c1bfbb9552c29296efd4ebdc61434dcc in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=96307b9 ]

GEODE-2953: Expand wildcard imports in geode-core:test.internal and 
...management. (#1881)



> Code Cleanup: Replace wildcard imports with explicit imports
> 
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
>  Issue Type: Sub-task
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> While optimal import order may be a matter of debate, all style guides seem 
> to agree that wildcard imports should be avoided for improved readability and 
> namespace cleanliness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)