[jira] [Assigned] (GEODE-7270) WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY

2019-10-10 Thread Xiaojian Zhou (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaojian Zhou reassigned GEODE-7270:


Assignee: Xiaojian Zhou

> WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY
> ---
>
> Key: GEODE-7270
> URL: https://issues.apache.org/jira/browse/GEODE-7270
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeCommons
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY failed with a Null 
> Pointer Exception.
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1138]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.11.0-SNAPSHOT.0174/test-results/distributedTest/1570043011/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.11.0-SNAPSHOT.0174/test-artifacts/1570043011/distributedtestfiles-OpenJDK8-1.11.0-SNAPSHOT.0174.tgz]
>  
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest$$Lambda$172/1647741944.run
>  in VM 0 running on Host 1cafba0ee536 with 8 VMs
>   at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:579)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:406)
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_TK_Recognises_LN_AND_NY(WanAutoDiscoveryDUnitTest.java:228)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>   at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Updated] (GEODE-7270) WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY

2019-10-10 Thread Xiaojian Zhou (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaojian Zhou updated GEODE-7270:
-
Labels: GeodeCommons  (was: )

> WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY
> ---
>
> Key: GEODE-7270
> URL: https://issues.apache.org/jira/browse/GEODE-7270
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Priority: Major
>  Labels: GeodeCommons
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> WanAutoDiscoveryDUnitTest. test_TK_Recognises_LN_AND_NY failed with a Null 
> Pointer Exception.
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1138]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.11.0-SNAPSHOT.0174/test-results/distributedTest/1570043011/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.11.0-SNAPSHOT.0174/test-artifacts/1570043011/distributedtestfiles-OpenJDK8-1.11.0-SNAPSHOT.0174.tgz]
>  
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest$$Lambda$172/1647741944.run
>  in VM 0 running on Host 1cafba0ee536 with 8 VMs
>   at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:579)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:406)
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_TK_Recognises_LN_AND_NY(WanAutoDiscoveryDUnitTest.java:228)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>   at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Commented] (GEODE-7286) When a durable client is killed for the second time, its socket is not closed properly

2019-10-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948996#comment-16948996
 ] 

ASF subversion and git services commented on GEODE-7286:


Commit 7fb8ed002ec3a486681323e60d2cdbe8cfc2475b in geode's branch 
refs/heads/feature/GEODE-7286 from Barry Oglesby
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7fb8ed0 ]

GEODE-7286: Reset _socketClosed AtomicBoolean when durable client reconnects


> When a durable client is killed for the second time, its socket is not closed 
> properly
> --
>
> Key: GEODE-7286
> URL: https://issues.apache.org/jira/browse/GEODE-7286
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barrett Oglesby
>Assignee: Barrett Oglesby
>Priority: Major
>
> The first time the durable client is killed, the socket is closed by 
> SocketCloser.inlineClose:
> {noformat}
> [warn 2019/10/10 12:26:07.025 PDT  
> tid=0x41] ClientHealthMonitor: Unregistering client with member id 
> identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]) due to: The connection has been reset while reading the header
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false; _socketClosed=false
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX SocketCloser.asyncClose 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false
> [info 2019/10/10 12:26:07.028 PDT  192.168.1.4(client:17910:loner):49501:cf8f22b7:client (client-1)> tid=0x42] 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
> processing
> [warn 2019/10/10 12:26:07.031 PDT  
> tid=0x46] XXX SocketCloser.inlineClose closed 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=true
> [info 2019/10/10 12:26:07.031 PDT  
> tid=0x41] CacheClientNotifier: Keeping proxy for durable client named 
> client-1 for 120 seconds 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0].
> {noformat}
> If the client rejoins and is killed again, the socket is not closed because 
> the _socketClosed AtomicBoolean is true from the last time the client closed, 
> so SocketCloser.asyncClose is not called:
> {noformat}
> [warn 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] ClientHealthMonitor: Unregistering client with member id 
> identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]) due to: The connection has been reset while reading the header
> [warn 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] XXX CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> [info 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] CacheClientNotifier: Keeping proxy for durable client named 
> client-1 for 120 seconds 
> CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49524; primary=true; version=GEODE 1.11.0].
> {noformat}
> Even when the durable client's expiration task fires, the socket is not 
> closed:
> {noformat}
> [warn 2019/10/10 12:28:27.708 PDT  tid=0x29] 
> CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49524; primary=true; version=GEODE 1.11.0] : The 
> expiration task has fired, so this proxy is being terminated.
> [warn 2019/10/10 12:28:27.710 PDT  tid=0x29] XXX 
> CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> [warn 2019/10/10 12:28:27.712 PDT  tid=0x29] XXX 
> CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> {noformat}
> The AtomicBoolean needs to be reset when the durable client rejoins.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7286) When a durable client is killed for the second time, its socket is not closed properly

2019-10-10 Thread Barrett Oglesby (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barrett Oglesby reassigned GEODE-7286:
--

Assignee: Barrett Oglesby

> When a durable client is killed for the second time, its socket is not closed 
> properly
> --
>
> Key: GEODE-7286
> URL: https://issues.apache.org/jira/browse/GEODE-7286
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barrett Oglesby
>Assignee: Barrett Oglesby
>Priority: Major
>
> The first time the durable client is killed, the socket is closed by 
> SocketCloser.inlineClose:
> {noformat}
> [warn 2019/10/10 12:26:07.025 PDT  
> tid=0x41] ClientHealthMonitor: Unregistering client with member id 
> identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]) due to: The connection has been reset while reading the header
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false; _socketClosed=false
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX SocketCloser.asyncClose 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false
> [info 2019/10/10 12:26:07.028 PDT  192.168.1.4(client:17910:loner):49501:cf8f22b7:client (client-1)> tid=0x42] 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
> processing
> [warn 2019/10/10 12:26:07.031 PDT  
> tid=0x46] XXX SocketCloser.inlineClose closed 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=true
> [info 2019/10/10 12:26:07.031 PDT  
> tid=0x41] CacheClientNotifier: Keeping proxy for durable client named 
> client-1 for 120 seconds 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0].
> {noformat}
> If the client rejoins and is killed again, the socket is not closed because 
> the _socketClosed AtomicBoolean is true from the last time the client closed, 
> so SocketCloser.asyncClose is not called:
> {noformat}
> [warn 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] ClientHealthMonitor: Unregistering client with member id 
> identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]) due to: The connection has been reset while reading the header
> [warn 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] XXX CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> [info 2019/10/10 12:26:27.706 PDT  
> tid=0x4a] CacheClientNotifier: Keeping proxy for durable client named 
> client-1 for 120 seconds 
> CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49524; primary=true; version=GEODE 1.11.0].
> {noformat}
> Even when the durable client's expiration task fires, the socket is not 
> closed:
> {noformat}
> [warn 2019/10/10 12:28:27.708 PDT  tid=0x29] 
> CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49524; primary=true; version=GEODE 1.11.0] : The 
> expiration task has fired, so this proxy is being terminated.
> [warn 2019/10/10 12:28:27.710 PDT  tid=0x29] XXX 
> CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> [warn 2019/10/10 12:28:27.712 PDT  tid=0x29] XXX 
> CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
> socketIsClosed=false; _socketClosed=true
> {noformat}
> The AtomicBoolean needs to be reset when the durable client rejoins.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7192) Update cluster config behavior in documentation

2019-10-10 Thread Karen Smoler Miller (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-7192:
--

Assignee: Karen Smoler Miller

> Update cluster config behavior in documentation
> ---
>
> Key: GEODE-7192
> URL: https://issues.apache.org/jira/browse/GEODE-7192
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The [Cluster Configuration Files and Troubleshooting 
> page|[https://geode.apache.org/docs/guide/19/configuring/cluster_config/gfsh_config_troubleshooting.html]]
>  currently describes older Geode behavior regarding the cluster.xml file. 
> According to [~jinmeiliao], now "the xml/properties files are kept in a 
> persisted region. It’s not in the file system anymore; only jar files are 
> saved in the file system. When using `export cluster-config` command, it can 
> print the content on the screen for you to look at."
> This page should be updated to reflect the current behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7286) When a durable client is killed for the second time, its socket is not closed properly

2019-10-10 Thread Barrett Oglesby (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948923#comment-16948923
 ] 

Barrett Oglesby commented on GEODE-7286:


CacheClientProxy.reinitialize is called when the durable client reconnects:
{noformat}
java.lang.Exception: Stack trace
at java.lang.Thread.dumpStack(Thread.java:1333)
at 
org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.reinitialize(CacheClientProxy.java:1830)
at 
org.apache.geode.internal.cache.tier.sockets.CacheClientNotifier.registerClientInternal(CacheClientNotifier.java:323)
at 
org.apache.geode.internal.cache.tier.sockets.CacheClientNotifier.registerClient(CacheClientNotifier.java:192)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$ClientQueueInitializerTask.run(AcceptorImpl.java:1895)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeClientQueueInitializerThreadPool$1(AcceptorImpl.java:663)
at 
org.apache.geode.internal.logging.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
at java.lang.Thread.run(Thread.java:745)
{noformat}
The _socketClosed AtomicBoolean can be reset in CacheClientProxy.reinitialize 
like:
{noformat}
this._socketClosed.compareAndSet(true, false);
{noformat}
Then when the durable client is killed the second time, its socket is closed:
{noformat}
[warn 2019/10/10 13:17:11.920 PDT  
tid=0x4b] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:21693:loner):49908:ef6751b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 13:17:11.921 PDT  
tid=0x4b] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49913,localport=49882]; 
socketIsClosed=false; _socketClosed=false

[warn 2019/10/10 13:17:11.921 PDT  
tid=0x4b] XXX SocketCloser.asyncClose 
socket=Socket[addr=/192.168.1.4,port=49913,localport=49882]; 
socketIsClosed=false

[warn 2019/10/10 13:17:11.922 PDT  tid=0x4d] 
XXX SocketCloser.inlineClose closed 
socket=Socket[addr=/192.168.1.4,port=49913,localport=49882]; socketIsClosed=true

[info 2019/10/10 13:17:11.922 PDT  
tid=0x4b] CacheClientNotifier: Keeping proxy for durable client named client-1 
for 120 seconds 
CacheClientProxy[identity(192.168.1.4(client:21693:loner):49908:ef6751b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49913; primary=true; version=GEODE 1.11.0].
{noformat}


> When a durable client is killed for the second time, its socket is not closed 
> properly
> --
>
> Key: GEODE-7286
> URL: https://issues.apache.org/jira/browse/GEODE-7286
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barrett Oglesby
>Priority: Major
>
> The first time the durable client is killed, the socket is closed by 
> SocketCloser.inlineClose:
> {noformat}
> [warn 2019/10/10 12:26:07.025 PDT  
> tid=0x41] ClientHealthMonitor: Unregistering client with member id 
> identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]) due to: The connection has been reset while reading the header
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX CacheClientProxy.closeSocket 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false; _socketClosed=false
> [warn 2019/10/10 12:26:07.026 PDT  
> tid=0x41] XXX SocketCloser.asyncClose 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=false
> [info 2019/10/10 12:26:07.028 PDT  192.168.1.4(client:17910:loner):49501:cf8f22b7:client (client-1)> tid=0x42] 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
> processing
> [warn 2019/10/10 12:26:07.031 PDT  
> tid=0x46] XXX SocketCloser.inlineClose closed 
> socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
> socketIsClosed=true
> [info 2019/10/10 12:26:07.031 PDT  
> tid=0x41] CacheClientNotifier: Keeping proxy for durable client named 
> client-1 for 120 seconds 
> CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
>  timeout=120]); port=49506; primary=true; version=GEODE 1.11.0].
> {noformat}
> If the client 

[jira] [Created] (GEODE-7286) When a durable client is killed for the second time, its socket is not closed properly

2019-10-10 Thread Barrett Oglesby (Jira)
Barrett Oglesby created GEODE-7286:
--

 Summary: When a durable client is killed for the second time, its 
socket is not closed properly
 Key: GEODE-7286
 URL: https://issues.apache.org/jira/browse/GEODE-7286
 Project: Geode
  Issue Type: Bug
  Components: client queues
Reporter: Barrett Oglesby


The first time the durable client is killed, the socket is closed by 
SocketCloser.inlineClose:
{noformat}
[warn 2019/10/10 12:26:07.025 PDT  
tid=0x41] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false; _socketClosed=false

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX SocketCloser.asyncClose 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false

[info 2019/10/10 12:26:07.028 PDT  tid=0x42] 
CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
processing

[warn 2019/10/10 12:26:07.031 PDT  tid=0x46] 
XXX SocketCloser.inlineClose closed 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; socketIsClosed=true

[info 2019/10/10 12:26:07.031 PDT  
tid=0x41] CacheClientNotifier: Keeping proxy for durable client named client-1 
for 120 seconds 
CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49506; primary=true; version=GEODE 1.11.0].
{noformat}
If the client rejoins and is killed again, the socket is not closed because the 
_socketClosed AtomicBoolean is true from the last time the client closed, so 
SocketCloser.asyncClose is not called:
{noformat}
[warn 2019/10/10 12:26:27.706 PDT  
tid=0x4a] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 12:26:27.706 PDT  
tid=0x4a] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true

[info 2019/10/10 12:26:27.706 PDT  
tid=0x4a] CacheClientNotifier: Keeping proxy for durable client named client-1 
for 120 seconds 
CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49524; primary=true; version=GEODE 1.11.0].
{noformat}
Even when the durable client's expiration task fires, the socket is not closed:
{noformat}
[warn 2019/10/10 12:28:27.708 PDT  tid=0x29] 
CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49524; primary=true; version=GEODE 1.11.0] : The 
expiration task has fired, so this proxy is being terminated.

[warn 2019/10/10 12:28:27.710 PDT  tid=0x29] XXX 
CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true

[warn 2019/10/10 12:28:27.712 PDT  tid=0x29] XXX 
CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true
{noformat}
The AtomicBoolean nees to be reset when the durable client rejoins.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-7286) When a durable client is killed for the second time, its socket is not closed properly

2019-10-10 Thread Barrett Oglesby (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barrett Oglesby updated GEODE-7286:
---
Description: 
The first time the durable client is killed, the socket is closed by 
SocketCloser.inlineClose:
{noformat}
[warn 2019/10/10 12:26:07.025 PDT  
tid=0x41] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false; _socketClosed=false

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX SocketCloser.asyncClose 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false

[info 2019/10/10 12:26:07.028 PDT  tid=0x42] 
CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
processing

[warn 2019/10/10 12:26:07.031 PDT  tid=0x46] 
XXX SocketCloser.inlineClose closed 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; socketIsClosed=true

[info 2019/10/10 12:26:07.031 PDT  
tid=0x41] CacheClientNotifier: Keeping proxy for durable client named client-1 
for 120 seconds 
CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49506; primary=true; version=GEODE 1.11.0].
{noformat}
If the client rejoins and is killed again, the socket is not closed because the 
_socketClosed AtomicBoolean is true from the last time the client closed, so 
SocketCloser.asyncClose is not called:
{noformat}
[warn 2019/10/10 12:26:27.706 PDT  
tid=0x4a] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 12:26:27.706 PDT  
tid=0x4a] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true

[info 2019/10/10 12:26:27.706 PDT  
tid=0x4a] CacheClientNotifier: Keeping proxy for durable client named client-1 
for 120 seconds 
CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49524; primary=true; version=GEODE 1.11.0].
{noformat}
Even when the durable client's expiration task fires, the socket is not closed:
{noformat}
[warn 2019/10/10 12:28:27.708 PDT  tid=0x29] 
CacheClientProxy[identity(192.168.1.4(client:17939:loner):49519:62f822b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49524; primary=true; version=GEODE 1.11.0] : The 
expiration task has fired, so this proxy is being terminated.

[warn 2019/10/10 12:28:27.710 PDT  tid=0x29] XXX 
CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true

[warn 2019/10/10 12:28:27.712 PDT  tid=0x29] XXX 
CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49524,localport=49494]; 
socketIsClosed=false; _socketClosed=true
{noformat}
The AtomicBoolean needs to be reset when the durable client rejoins.


  was:
The first time the durable client is killed, the socket is closed by 
SocketCloser.inlineClose:
{noformat}
[warn 2019/10/10 12:26:07.025 PDT  
tid=0x41] ClientHealthMonitor: Unregistering client with member id 
identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]) due to: The connection has been reset while reading the header

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX CacheClientProxy.closeSocket 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false; _socketClosed=false

[warn 2019/10/10 12:26:07.026 PDT  
tid=0x41] XXX SocketCloser.asyncClose 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; 
socketIsClosed=false

[info 2019/10/10 12:26:07.028 PDT  tid=0x42] 
CacheClientProxy[identity(192.168.1.4(client:17910:loner):49501:cf8f22b7:client,connection=2,durableAttributes=DurableClientAttributes[id=client-1;
 timeout=120]); port=49506; primary=true; version=GEODE 1.11.0] : Pausing 
processing

[warn 2019/10/10 12:26:07.031 PDT  tid=0x46] 
XXX SocketCloser.inlineClose closed 
socket=Socket[addr=/192.168.1.4,port=49506,localport=49494]; socketIsClosed=true

[info 2019/10/10 12:26:07.031 PDT  
tid=0x41] 

[jira] [Updated] (GEODE-7200) Geode should not try to prefill any declared Pool (e.g. DEFAULT, or otherwise) if a client is running in a local-only capacity

2019-10-10 Thread John Blum (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Blum updated GEODE-7200:
-
External issue URL: 
https://community.pivotal.io/s/article/Default-Pool-Is-Always-Created-While-Configuring-A-GemFire-Client-Cache-Using-Java-APIs

> Geode should not try to prefill any declared Pool (e.g. DEFAULT, or 
> otherwise) if a client is running in a local-only capacity
> --
>
> Key: GEODE-7200
> URL: https://issues.apache.org/jira/browse/GEODE-7200
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: John Blum
>Priority: Major
>  Labels: affects-spring
>
> See https://github.com/spring-projects/spring-boot-data-geode/issues/53 for 
> more details.
> This really client-only and not the traditional client/server topology, which 
> is a very valid and useful client arrangement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname

2019-10-10 Thread Aaron Lindsey (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948844#comment-16948844
 ] 

Aaron Lindsey commented on GEODE-7237:
--

Failed again: 
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1146

> CI failure: ConnectCommandAcceptanceTest.invalidHostname
> 
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
>  Issue Type: Bug
>  Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
>  > invalidHostname FAILED
> java.lang.AssertionError: 
> Expecting:
>  <"">
> to contain:
>  <"can't be reached. Hostname or IP address could not be found."> 
> at 
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-2184) Docs: Variable-ize Java version numbers

2019-10-10 Thread Dave Barnes (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948816#comment-16948816
 ] 

Dave Barnes commented on GEODE-2184:


Contributor [~alberto.bustamante.reyes] offers a good solution that addresses 
the initial problem by creatively reinterpreting the solution. When I filed the 
original ticket, my proposed solution was to replace version strings with 
generic placeholders. Instead, the proposal is to create a variable in the docs 
config file, config.yml, so the Java version will be kept current.

I like this solution, so have re-titled the ticket to reflect the improvement.

> Docs: Variable-ize Java version numbers
> ---
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>  Labels: pull-request-available
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-2184) Docs: Variable-ize Java version numbers

2019-10-10 Thread Dave Barnes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2184:
---
Summary: Docs: Variable-ize Java version numbers  (was: Docs: Genericize 
version numbers in example code)

> Docs: Variable-ize Java version numbers
> ---
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>  Labels: pull-request-available
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7177) Move membership's logging dependencies to its own module

2019-10-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948759#comment-16948759
 ] 

ASF subversion and git services commented on GEODE-7177:


Commit 5981a139a1acc078d2d3024ddcfaad35642d7684 in geode's branch 
refs/heads/develop from Ernie Burghardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5981a13 ]

GEODE-7177: Logging as a submodule (#4129)

* GEODE-7177: Extract LogService to a separate submodule

- Extracting LogService and it's dependencies to a separate geode-logging
submodule so that other modules not in geode-core can still use LogService to
get a Logger.

- Removing the use of the logging SPI from LogService
LogService had a dependency on the logging SPI in geode-core. However, this
dependency was unecessary - the LoggingProvider loaded statically in this class
never had `configure` called on it. In addition, the getLogger methods of this
class are merely creating FastLoggers which can live inside geode-logging and
do not need to be pluggable.

- Moved executors that are not dependent on geode-core to geode-logging and
renamed the remaining executors to be CoreLoggingExecutors.

- Refactor the marker interface from Loggable to EntriesCollection

- EntriesCollection put back into internal.cache and AbstractRegion now 
implements the marker
- Formerly known as Loggable renamed to LogWithToString

- Remove marker interface called EntriesCollection completely, replace with 
LogWithToString.


> Move membership's logging dependencies to its own module
> 
>
> Key: GEODE-7177
> URL: https://issues.apache.org/jira/browse/GEODE-7177
> Project: Geode
>  Issue Type: Improvement
>  Components: logging, membership
>Reporter: Ryan McMahon
>Assignee: Ryan McMahon
>Priority: Major
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> As part of eliminating membership's dependency on geode-core, we want to move 
> LogService and some other supporting classes to its own module which 
> membership can depend on.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7177) Move membership's logging dependencies to its own module

2019-10-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948758#comment-16948758
 ] 

ASF subversion and git services commented on GEODE-7177:


Commit 5981a139a1acc078d2d3024ddcfaad35642d7684 in geode's branch 
refs/heads/develop from Ernie Burghardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5981a13 ]

GEODE-7177: Logging as a submodule (#4129)

* GEODE-7177: Extract LogService to a separate submodule

- Extracting LogService and it's dependencies to a separate geode-logging
submodule so that other modules not in geode-core can still use LogService to
get a Logger.

- Removing the use of the logging SPI from LogService
LogService had a dependency on the logging SPI in geode-core. However, this
dependency was unecessary - the LoggingProvider loaded statically in this class
never had `configure` called on it. In addition, the getLogger methods of this
class are merely creating FastLoggers which can live inside geode-logging and
do not need to be pluggable.

- Moved executors that are not dependent on geode-core to geode-logging and
renamed the remaining executors to be CoreLoggingExecutors.

- Refactor the marker interface from Loggable to EntriesCollection

- EntriesCollection put back into internal.cache and AbstractRegion now 
implements the marker
- Formerly known as Loggable renamed to LogWithToString

- Remove marker interface called EntriesCollection completely, replace with 
LogWithToString.


> Move membership's logging dependencies to its own module
> 
>
> Key: GEODE-7177
> URL: https://issues.apache.org/jira/browse/GEODE-7177
> Project: Geode
>  Issue Type: Improvement
>  Components: logging, membership
>Reporter: Ryan McMahon
>Assignee: Ryan McMahon
>Priority: Major
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> As part of eliminating membership's dependency on geode-core, we want to move 
> LogService and some other supporting classes to its own module which 
> membership can depend on.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (GEODE-2184) Docs: Genericize version numbers in example code

2019-10-10 Thread Alberto Bustamante Reyes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alberto Bustamante Reyes updated GEODE-2184:

Comment: was deleted

(was: Pull request: https://github.com/apache/geode/pull/4142)

> Docs: Genericize version numbers in example code
> 
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>  Labels: pull-request-available
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-2035) document how to use G1GC with geode

2019-10-10 Thread Alberto Bustamante Reyes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alberto Bustamante Reyes updated GEODE-2035:

Labels: pull-request-available  (was: )

> document how to use G1GC with geode
> ---
>
> Key: GEODE-2035
> URL: https://issues.apache.org/jira/browse/GEODE-2035
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Darrel Schneider
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The geode docs should describe how to configure G1GC for geode.
> One issue is that if you use "gfsh start server --max-heap=SIZE" then it will 
> automatically configure CMS which does not work with G1GC.
> So instead of using the "--max-heap" option we should tell them to use 
> "--J-XmxSIZE".
> To configure G1GC use "--J-XX:+UseG1GC".
> If you find the geode resource manager does not detect crossing the eviction 
> or critical threshold quickly enough then try using this option to make it 
> more responsive: "--J-XX:MaxGCPauseMillis=VALUE" where VALUE should be a 
> number less than 200 (which is the current G1GC default). We have done some 
> limited testing with this value set to 1 and it does make the resource 
> manager more responsive when combined with G1GC but it also increases the 
> amount of time spent in gc.
> We also noticed that if the primary heap objects you allocate are large then 
> G1GC can cause the JVM to report out of heap memory when it has only used 50 
> percent of the heap. We saw this with tests in which all the geode region 
> values were larger than 50 percent of the G1 region size. Oracle calls these 
> "humongous" objects. The default G1 region size is 1m. You can increase it up 
> to 32m (it is always a power of 2) by using this: 
> "--J-XX:G1HeapRegionSize=32m". If you are using large values and want to use 
> G1GC without increasing its RegionSize (or if you large values are bigger 
> than 16m) then you could make your geode regions that will contain the large 
> values off-heap. But even if you do that the large off-heap values will 
> allocate temporary large heap values that G1GC will treat as humongous 
> allocations even though they will be short lived. So consider using CMS if 
> most of you values will result in humongous allocations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-7285) Several Examples Don't Work on Windows

2019-10-10 Thread Michael Martell (Jira)
Michael Martell created GEODE-7285:
--

 Summary: Several Examples Don't Work on Windows
 Key: GEODE-7285
 URL: https://issues.apache.org/jira/browse/GEODE-7285
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Michael Martell


The list of examples below do not work do to a mismatch between the server 
start/stop scripts and the code. Specifically, several scripts create/destroy a 
region of one name, but the example code tries to use a region of a different 
name.

Broken examples:
 * continuousquery (Windows)
 * dataserializable (Windows)
 * pdxserializable (Windows)
 * pdxserializer (Windows)
 * transaction (Windows)

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-2184) Docs: Genericize version numbers in example code

2019-10-10 Thread Alberto Bustamante Reyes (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948366#comment-16948366
 ] 

Alberto Bustamante Reyes commented on GEODE-2184:
-

Pull request: https://github.com/apache/geode/pull/4142

> Docs: Genericize version numbers in example code
> 
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-2184) Docs: Genericize version numbers in example code

2019-10-10 Thread Alberto Bustamante Reyes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alberto Bustamante Reyes updated GEODE-2184:

Labels: pull-request-available  (was: )

> Docs: Genericize version numbers in example code
> 
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>  Labels: pull-request-available
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-2184) Docs: Genericize version numbers in example code

2019-10-10 Thread Alberto Bustamante Reyes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alberto Bustamante Reyes reassigned GEODE-2184:
---

Assignee: Alberto Bustamante Reyes

> Docs: Genericize version numbers in example code
> 
>
> Key: GEODE-2184
> URL: https://issues.apache.org/jira/browse/GEODE-2184
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>
> Examples containing specific version strings, e.g. "Geode 1.0.0-incubating" 
> and "javac 1.8.0_92" must be updated with every doc release or they go out of 
> date. In most cases, the specific numbers are not meaningful to the example. 
> Updating with every related revision requires considerable, usually 
> unnecessary, effort. Replace such version strings with generic placeholders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7268) Make gfsh alter region command similar to the API behavior

2019-10-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948255#comment-16948255
 ] 

ASF subversion and git services commented on GEODE-7268:


Commit 0be31dd0c3df469ab906a183ad64aa965d9f1d08 in geode's branch 
refs/heads/develop from Naburun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0be31dd ]

GEODE-7268: Remove bucket assignment in alter region gfsh command while adding 
gateways

* Remove the assign buckets to the partition step in the alter region 
function to add gateway senders
* This step is not present in the API version of altering region using 
mutators.
* Keeping this also resulted in a soft hang while altering many regions 
by adding gateways senders.


> Make gfsh alter region command similar to the API behavior 
> ---
>
> Key: GEODE-7268
> URL: https://issues.apache.org/jira/browse/GEODE-7268
> Project: Geode
>  Issue Type: Bug
>Reporter: Nabarun Nag
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> * currently the gfsh command for alter region assigns the buckets to the 
> region, before starting with the PR update config.
>  * This is not what the API does while altering a region
>  * This was requirement from the Lucene reindex story but that feature 
> follows a different code path and will the be not affected if the assign 
> buckets command was removed from the gfsh command.
>  * This also results in soft hangs when there are a lot of regions and 
> gateway senders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)