[jira] [Created] (GEODE-8143) Redis Set and Hash commands that remove the data do not clear expiration
Darrel Schneider created GEODE-8143: --- Summary: Redis Set and Hash commands that remove the data do not clear expiration Key: GEODE-8143 URL: https://issues.apache.org/jira/browse/GEODE-8143 Project: Geode Issue Type: Bug Components: redis Reporter: Darrel Schneider Set and Hash commands that end up deleting the set/hash need to also clear any expiration that has been scheduled. But when we switched to using a single region, the code that clears expiration was lost. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8141) Move definition of Region separator character to geode-common and make usage consistent throughout the codebase
[ https://issues.apache.org/jira/browse/GEODE-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109697#comment-17109697 ] ASF GitHub Bot commented on GEODE-8141: --- DonalEvans opened a new pull request #5127: URL: https://github.com/apache/geode/pull/5127 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [N/A] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. As the changes touch a huge number of files, the PR has been broken up into chunks to allow easier reviewing. To verify that all changes are correct and that no instances of "/" in region names/paths have been missed, I replaced the character in GeodePublicGlossary with a "~", updated oql.g to allow queries to be correctly parsed using the new character, and ran all tests. All failing tests were either directly comparing the region separator to "/", creating caches from XML containing regions/indexes using "/" or involved older client/server versions which would not be compatible with the changed separator. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move definition of Region separator character to geode-common and make usage > consistent throughout the codebase > --- > > Key: GEODE-8141 > URL: https://issues.apache.org/jira/browse/GEODE-8141 > Project: Geode > Issue Type: Task >Reporter: Donal Evans >Priority: Major > > The separator character for region paths is currently defined in the Region > interface in geode-core. However, geode-management, which does not have a > dependency on geode-core, uses the separator in several classes. > * The definitions of the separator character and string should be moved to > the geode-common module. > * The currently existing definitions of the separator in the geode-core > Region interface should be deprecated. > * All instances of hardcoded '/' characters and strings should be replaced > with references to the constants in geode-common. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8142) Enhance the Delta interface to support callbackArgs
Darrel Schneider created GEODE-8142: --- Summary: Enhance the Delta interface to support callbackArgs Key: GEODE-8142 URL: https://issues.apache.org/jira/browse/GEODE-8142 Project: Geode Issue Type: Improvement Components: core Reporter: Darrel Schneider The Geode Delta interface allows for a subset of the actual data to distributed to redundant copies when storing data in a Geode region. It requires you to implement hasDelta, toDelta, and fromDelta on your domain class. In most cases when you implement these methods you find you need to add some additional instance variables to your domain class just for hasDelta and toDelta to read. So Delta saves you in how much data needs to be serialized for distribution, but it may hurt you in how much memory your domain object uses. Geode has another concept call a "callbackArg". It is an extra parameter that can be passed to the Region methods, that will in turn be given to various callbacks that the user has installed. I propose we enhance hasDelta and toDelta to have a form of the method that is given the callback argument. The default implementation of this method would just be to ignore the callback arg and call the old method. But this would allow users to to override the new methods and have all the delta information passed to them as a callback argument. Since the callback arg is garbage collected after the operation it was given to completes, this would allow Delta to be implemented without introducing extra long lived memory overhead. I have looked at the places Geode currently calls hasDelta and toDelta internally, and the callback argument is available in those contexts so this would be a rather easy feature to add. I know that the Geode Redis API project could benefit from it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8141) Move definition of Region separator character to geode-common and make usage consistent throughout the codebase
[ https://issues.apache.org/jira/browse/GEODE-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans updated GEODE-8141: --- Description: The separator character for region paths is currently defined in the Region interface in geode-core. However, geode-management, which does not have a dependency on geode-core, uses the separator in several classes. * The definitions of the separator character and string should be moved to the geode-common module. * The currently existing definitions of the separator in the geode-core Region interface should be deprecated. * All instances of hardcoded '/' characters and strings should be replaced with references to the constants in geode-common. was: The separator character for region paths is currently defined in the Region interface in geode-core. However, geode-management, which does not have a dependency on geode-core, uses the separator in several classes. * The definitions of the separator character and string should be moved to the geode-common module. * The currently existing definitions of the separator in the geode-core Region class should be deprecated. * All instances of hardcoded '/' characters and strings should be replaced with references to the constants in geode-common. > Move definition of Region separator character to geode-common and make usage > consistent throughout the codebase > --- > > Key: GEODE-8141 > URL: https://issues.apache.org/jira/browse/GEODE-8141 > Project: Geode > Issue Type: Task >Reporter: Donal Evans >Priority: Major > > The separator character for region paths is currently defined in the Region > interface in geode-core. However, geode-management, which does not have a > dependency on geode-core, uses the separator in several classes. > * The definitions of the separator character and string should be moved to > the geode-common module. > * The currently existing definitions of the separator in the geode-core > Region interface should be deprecated. > * All instances of hardcoded '/' characters and strings should be replaced > with references to the constants in geode-common. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8141) Move definition of Region separator character to geode-common and make usage consistent throughout the codebase
Donal Evans created GEODE-8141: -- Summary: Move definition of Region separator character to geode-common and make usage consistent throughout the codebase Key: GEODE-8141 URL: https://issues.apache.org/jira/browse/GEODE-8141 Project: Geode Issue Type: Task Reporter: Donal Evans The separator character for region paths is currently defined in the Region interface in geode-core. However, geode-management, which does not have a dependency on geode-core, uses the separator in several classes. * The definitions of the separator character and string should be moved to the geode-common module. * The currently existing definitions of the separator in the geode-core Region class should be deprecated. * All instances of hardcoded '/' characters and strings should be replaced with references to the constants in geode-common. -- This message was sent by Atlassian Jira (v8.3.4#803005)
