[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121472#comment-17121472 ] ASF GitHub Bot commented on GEODE-8173: --- agingade opened a new pull request #5194: URL: https://github.com/apache/geode/pull/5194 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [Y] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [Y] Is your initial contribution a single, squashed commit? - [Y] Does `gradlew build` run cleanly? - [Y] Have you written or updated unit tests to verify your changes? - [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-8211. - Fix Version/s: 1.14.0 Resolution: Fixed > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121442#comment-17121442 ] ASF subversion and git services commented on GEODE-8211: Commit 0fdcd5b05be49fe450771d249537b0c3f04df462 in geode's branch refs/heads/develop from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0fdcd5b ] GEODE-8211: fix flaky ShutdownIntegrationTest (#5193) test now creates a new client connection after calling the disabled shutdown > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121441#comment-17121441 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal merged pull request #5193: URL: https://github.com/apache/geode/pull/5193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121414#comment-17121414
]
ASF GitHub Bot commented on GEODE-8211:
---
gesterzhou commented on a change in pull request #5193:
URL: https://github.com/apache/geode/pull/5193#discussion_r433551229
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##
@@ -61,7 +61,11 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
-jedis.shutdown();
+try {
+ jedis.shutdown();
+} catch (JedisConnectionException ignore) {
+ // Sometimes it throws sometimes it does not.
+}
Review comment:
You might need to fix line 70 too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider updated GEODE-8211: Labels: flaky (was: ) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121407#comment-17121407 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal opened a new pull request #5193: URL: https://github.com/apache/geode/pull/5193 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou reassigned GEODE-8211: Assignee: Darrel Schneider > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8186) User Guide: add example for gfsh query --member option
[ https://issues.apache.org/jira/browse/GEODE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121400#comment-17121400 ] Dave Barnes commented on GEODE-8186: The Querying section is a bit of a tangle, and the FAQ is already too long. I think this could be added as a topic on the page "Writing and Executing a Query in Geode", [https://geode.apache.org/docs/guide/112/developing/querying_basics/running_a_query.html]. Just one person's opinion. The important thing is to publish the example somewhere. > User Guide: add example for gfsh query --member option > -- > > Key: GEODE-8186 > URL: https://issues.apache.org/jira/browse/GEODE-8186 > Project: Geode > Issue Type: Sub-task > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > > GEODE-8112 added a --member option to the gfsh query command. > Add a usage example to the User Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou updated GEODE-8211: - Component/s: redis > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Xiaojian Zhou >Priority: Major > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
Xiaojian Zhou created GEODE-8211: Summary: ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException Key: GEODE-8211 URL: https://issues.apache.org/jira/browse/GEODE-8211 Project: Geode Issue Type: Improvement Reporter: Xiaojian Zhou IntegrationTestOpenJDK11 #212. This will occasionally happen. org.apache.geode.redis.general.ShutdownIntegrationTest > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: Read timed out at redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) at redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) at redis.clients.jedis.Protocol.process(Protocol.java:155) at redis.clients.jedis.Protocol.read(Protocol.java:220) at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) at redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) at redis.clients.jedis.Jedis.keys(Jedis.java:280) at org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) Caused by: java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.socketRead(SocketInputStream.java:115) at java.net.SocketInputStream.read(SocketInputStream.java:168) at java.net.SocketInputStream.read(SocketInputStream.java:140) at java.net.SocketInputStream.read(SocketInputStream.java:126) at redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[
https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121386#comment-17121386
]
ASF GitHub Bot commented on GEODE-8198:
---
gesterzhou commented on a change in pull request #5191:
URL: https://github.com/apache/geode/pull/5191#discussion_r433531982
##
File path:
geode-docs/basic_config/data_entries_custom_classes/managing_data_entries.html.md.erb
##
@@ -60,36 +60,90 @@ You can also use the `gfsh put` command to add entries to a
region, and the `get
If you want only to create the entry (with a null value and with method
failure if the entry already exists), use `Region.create` instead.
-## Batch Operations (getAll, putAll, removeAll)
+## The getAll Operation
-<%=vars.product_name%> provides three APIs to perform batch operations on
multiple region entries:
+The batch operation `Region.getAll`
+takes a collection of keys and returns a `Map` of key-value pairs for
+the provided keys. If a given key does not exist in the region, then that
key's value in the returned map will be null.
-- `Region.getAll`
-- `Region.putAll`
-- `Region.removeAll`
+## The putAll Operation
-The `getAll` method takes a collection of keys and returns a `Map` of values
for the provided keys. If a given key does not exist in the region, then that
key's value in the returned map will be null.
+The batch operation `Region.putAll`
+takes a `Map` of key-value pairs, puts them into the cache,
+and distributes them in a single operation.
-The `putAll` method takes a `Map` of key-value pairs and puts them into the
cache and distributes them in a single operation.
-**Example:**
+The updates to the cache are done individually in the order in which
+they were placed in the `Map`.
+For partitioned regions,
+multiple events are sent as a single message to the primary buckets
+and then distributed to the secondary buckets.
+
+The design of a client application within a client-server design pattern
+faces the possibility that a partial operation can occur.
+Some, all, or none of the specified entries may be completed with `putAll`.
+If either `ServerOperationException` or `ServerConnectivityException` are
+thrown,
+it can indicate an incomplete operation.
``` pre
-void putAll(String command) throws CacheException
-{
-// Get Entry keys and values into Strings key1, ... keyN and value1, ...
valueN
- Map map = new LinkedHashMap();
- map.put(key1, value1));
- ...
- map.put(keyN, valueN));
- this.currRegion.putAll(map);
+int retry = 0;
+RuntimeException rte = null;
+while (retry < 3) {
+ try {
+region.putAll(map);
+ } catch (ServerOperationException e) {
+if (e.getCause() instanceof TimeoutException
+|| e.getCause() instanceof LowMemoryException) {
+ // Retry due to transient error.
+ retry++;
+} else {
+ rte = e;
+ break;
+}
+ } catch (ServerConnectivityException e) {
+// Retry due to transient error.
+retry++;
+ }
+}
+
+if (retry == 3) {
+ System.out.println("3 putAll operations tried, and all failed.");
+} else if (rte != null) {
+ System.out.println("putAll failed due to " + rte);
+ throw rte;
}
```
+A thrown exception of `ServerConnectivityException` with a cause of
+`TimeoutException` or `LowMemoryException` can be a transient error.
+A limited quantity of retries of the `putAll` may result in a completed
+operation.
+A repeated timeout may imply that the `read-timeout` value is not
+long enough to complete the bulk operation;
+use the `org.apache.geode.cache.client.PoolFactory.setReadTimeout`
+method to set the `read-timeout` value.
+
+Client applications that cannot tolerate partial completion of a `putAll`
+operation may embed the operation into a transaction.
+See [Transactions](../../developing/transactions/chapter_overview.html)
+for details.
+
+**Note:**
+The processing of a map with many entries and/or extra-large data values
Review comment:
could also cause LowMemoryException
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Revise docs to better specify putAll() behavior
> ---
>
> Key: GEODE-8198
> URL: https://issues.apache.org/jira/browse/GEODE-8198
> Project: Geode
> Issue Type: Improvement
> Components: docs
>Reporter: Karen Smoler Miller
>Priority: Major
>
> [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the
> Javadocs for the Region.putAll() method. Our user guide should also specify
> the behavior under exceptions and give readers more context such that they
> can
[jira] [Resolved] (GEODE-8205) Feature flag unsupported Redis commands
[
https://issues.apache.org/jira/browse/GEODE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darrel Schneider resolved GEODE-8205.
-
Fix Version/s: 1.14.0
Resolution: Fixed
> Feature flag unsupported Redis commands
> ---
>
> Key: GEODE-8205
> URL: https://issues.apache.org/jira/browse/GEODE-8205
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
> Fix For: 1.14.0
>
>
> Hide unsupported Redis commands behind system property
> {{enable-unsupported-redis-commands}}.
> This will be removed once all commands are supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8205) Feature flag unsupported Redis commands
[
https://issues.apache.org/jira/browse/GEODE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121383#comment-17121383
]
ASF subversion and git services commented on GEODE-8205:
Commit 2883e976c2dea72d92de1bd941f1ccd3fae45b9d in geode's branch
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2883e97 ]
GEODE-8205: feature flag unsupported Redis commands (#5185)
- In order to enable unsupported Redis commands, set the Java
system parameter `enable-unsupported-redis-commands=true`.
- The list of un/supported commands can be seen in `RedisCommandType`.
* Introduce RedisClusterStartupRule
Removes boiler plate code for starting a Redis server. By default starts
on an ephemeral port.
- Expose getRedisPort()
- Expose setEnableUnsupported()
Authored-by: Jens Deppe
Co-authored-by: john Hutchison
> Feature flag unsupported Redis commands
> ---
>
> Key: GEODE-8205
> URL: https://issues.apache.org/jira/browse/GEODE-8205
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
>
> Hide unsupported Redis commands behind system property
> {{enable-unsupported-redis-commands}}.
> This will be removed once all commands are supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8205) Feature flag unsupported Redis commands
[
https://issues.apache.org/jira/browse/GEODE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121382#comment-17121382
]
ASF GitHub Bot commented on GEODE-8205:
---
dschneider-pivotal merged pull request #5185:
URL: https://github.com/apache/geode/pull/5185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Feature flag unsupported Redis commands
> ---
>
> Key: GEODE-8205
> URL: https://issues.apache.org/jira/browse/GEODE-8205
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
>
> Hide unsupported Redis commands behind system property
> {{enable-unsupported-redis-commands}}.
> This will be removed once all commands are supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8206) CI Failure: ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
[
https://issues.apache.org/jira/browse/GEODE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121376#comment-17121376
]
ASF subversion and git services commented on GEODE-8206:
Commit bc6bc73c28d15d538c7ac1e23a0050b67c406e4c in geode's branch
refs/heads/feature/GEODE-8206 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc6bc73 ]
GEODE-8206: CI Failure:
ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
Modified the test to set the correct locator ports.
Modified the teardown code to tell the cache to stop
reconnecting.
Modified each run to use a temporary working directory so that runs
don't leave behind artifacts on disk that can taint subsequent runs.
> CI Failure:
> ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
> --
>
> Key: GEODE-8206
> URL: https://issues.apache.org/jira/browse/GEODE-8206
> Project: Geode
> Issue Type: Bug
> Components: ci, membership
>Reporter: Eric Shu
>Assignee: Bruce J Schuchardt
>Priority: Major
>
> This test hangs in:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/221#A
> {noformat}
> "RMI TCP Connection(1)-172.17.0.23" #32 daemon prio=5 os_prio=0
> tid=0x7fea58001800 nid=0x27d waiting on condition [0x7feb23bf7000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xe0e6cb10> (a
> java.util.concurrent.CountDownLatch$Sync)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4693)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4671)
> at
> org.apache.geode.internal.cache.LocalRegion.getSubregion(LocalRegion.java:4558)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3322)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3153)
> at
> org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.getConfigurationRegion(InternalConfigurationPersistenceService.java:792)
> at
> org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.destroySharedConfiguration(InternalConfigurationPersistenceService.java:639)
> at
> org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest.lambda$teardown$bb17a952$1(ReconnectWithClusterConfigurationDUnitTest.java:112)
> at
> org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest$$Lambda$339/1176989958.run(Unknown
> Source)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
> at
> org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
> at
>
[jira] [Created] (GEODE-8210) Geode-native C++ user guide: update serialization description
Dave Barnes created GEODE-8210: -- Summary: Geode-native C++ user guide: update serialization description Key: GEODE-8210 URL: https://issues.apache.org/jira/browse/GEODE-8210 Project: Geode Issue Type: Improvement Components: docs Reporter: Dave Barnes Update the Geode-native C++ user guide so its serialization description (almost) matches the one in the .NET guide. The primary difference is that C++ does not support auto-serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121343#comment-17121343 ] ASF GitHub Bot commented on GEODE-8198: --- gesterzhou commented on a change in pull request #5191: URL: https://github.com/apache/geode/pull/5191#discussion_r433495799 ## File path: geode-docs/basic_config/data_entries_custom_classes/managing_data_entries.html.md.erb ## @@ -60,36 +60,90 @@ You can also use the `gfsh put` command to add entries to a region, and the `get If you want only to create the entry (with a null value and with method failure if the entry already exists), use `Region.create` instead. -## Batch Operations (getAll, putAll, removeAll) +## The getAll Operation -<%=vars.product_name%> provides three APIs to perform batch operations on multiple region entries: +The batch operation `Region.getAll` +takes a collection of keys and returns a `Map` of key-value pairs for +the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. -- `Region.getAll` -- `Region.putAll` -- `Region.removeAll` +## The putAll Operation -The `getAll` method takes a collection of keys and returns a `Map` of values for the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. +The batch operation `Region.putAll` +takes a `Map` of key-value pairs, puts them into the cache, +and distributes them in a single operation. -The `putAll` method takes a `Map` of key-value pairs and puts them into the cache and distributes them in a single operation. -**Example:** +The updates to the cache are done individually in the order in which +they were placed in the `Map`. Review comment: Same for removeAll. It depends on what kind of map user is using. For example, if user is using LinkedHashMap, the order of keys will be maintained. But we did not enforce the user to have to use LinkedHashMap. Our API accepts any Map implementation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Priority: Major > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121345#comment-17121345 ] ASF GitHub Bot commented on GEODE-8198: --- gesterzhou commented on a change in pull request #5191: URL: https://github.com/apache/geode/pull/5191#discussion_r433496394 ## File path: geode-docs/basic_config/data_entries_custom_classes/managing_data_entries.html.md.erb ## @@ -60,36 +60,90 @@ You can also use the `gfsh put` command to add entries to a region, and the `get If you want only to create the entry (with a null value and with method failure if the entry already exists), use `Region.create` instead. -## Batch Operations (getAll, putAll, removeAll) +## The getAll Operation -<%=vars.product_name%> provides three APIs to perform batch operations on multiple region entries: +The batch operation `Region.getAll` +takes a collection of keys and returns a `Map` of key-value pairs for +the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. -- `Region.getAll` -- `Region.putAll` -- `Region.removeAll` +## The putAll Operation -The `getAll` method takes a collection of keys and returns a `Map` of values for the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. +The batch operation `Region.putAll` +takes a `Map` of key-value pairs, puts them into the cache, +and distributes them in a single operation. -The `putAll` method takes a `Map` of key-value pairs and puts them into the cache and distributes them in a single operation. -**Example:** +The updates to the cache are done individually in the order in which +they were placed in the `Map`. +For partitioned regions, Review comment: If you explicitly talking about PR's putAll here, you might have to also have a chapter to talk about DR's putAll. Their behavior are different. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Priority: Major > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121340#comment-17121340 ] ASF GitHub Bot commented on GEODE-8198: --- karensmolermiller commented on a change in pull request #5191: URL: https://github.com/apache/geode/pull/5191#discussion_r433493735 ## File path: geode-docs/basic_config/data_entries_custom_classes/managing_data_entries.html.md.erb ## @@ -60,36 +60,90 @@ You can also use the `gfsh put` command to add entries to a region, and the `get If you want only to create the entry (with a null value and with method failure if the entry already exists), use `Region.create` instead. -## Batch Operations (getAll, putAll, removeAll) +## The getAll Operation -<%=vars.product_name%> provides three APIs to perform batch operations on multiple region entries: +The batch operation `Region.getAll` +takes a collection of keys and returns a `Map` of key-value pairs for +the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. -- `Region.getAll` -- `Region.putAll` -- `Region.removeAll` +## The putAll Operation -The `getAll` method takes a collection of keys and returns a `Map` of values for the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. +The batch operation `Region.putAll` +takes a `Map` of key-value pairs, puts them into the cache, +and distributes them in a single operation. -The `putAll` method takes a `Map` of key-value pairs and puts them into the cache and distributes them in a single operation. -**Example:** +The updates to the cache are done individually in the order in which +they were placed in the `Map`. Review comment: Nice to know. That info was already in our docs. Must've been there and incorrect for a long time! Is the lack of an ordering guarantee also in effect for the other bulk operations? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Priority: Major > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121338#comment-17121338 ] ASF GitHub Bot commented on GEODE-8198: --- gesterzhou commented on a change in pull request #5191: URL: https://github.com/apache/geode/pull/5191#discussion_r433493081 ## File path: geode-docs/basic_config/data_entries_custom_classes/managing_data_entries.html.md.erb ## @@ -60,36 +60,90 @@ You can also use the `gfsh put` command to add entries to a region, and the `get If you want only to create the entry (with a null value and with method failure if the entry already exists), use `Region.create` instead. -## Batch Operations (getAll, putAll, removeAll) +## The getAll Operation -<%=vars.product_name%> provides three APIs to perform batch operations on multiple region entries: +The batch operation `Region.getAll` +takes a collection of keys and returns a `Map` of key-value pairs for +the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. -- `Region.getAll` -- `Region.putAll` -- `Region.removeAll` +## The putAll Operation -The `getAll` method takes a collection of keys and returns a `Map` of values for the provided keys. If a given key does not exist in the region, then that key's value in the returned map will be null. +The batch operation `Region.putAll` +takes a `Map` of key-value pairs, puts them into the cache, +and distributes them in a single operation. -The `putAll` method takes a `Map` of key-value pairs and puts them into the cache and distributes them in a single operation. -**Example:** +The updates to the cache are done individually in the order in which +they were placed in the `Map`. Review comment: Actually the order of processing for keys in the map is not guaranteed. But we don't have to mention it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Priority: Major > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121330#comment-17121330 ] ASF GitHub Bot commented on GEODE-8198: --- karensmolermiller opened a new pull request #5191: URL: https://github.com/apache/geode/pull/5191 This PR changes the user guide to go with the Javadocs update that was in GEODE-8171. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Priority: Major > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8209) GlobPattern package should not include org.apache.hadoop.fs
[ https://issues.apache.org/jira/browse/GEODE-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121326#comment-17121326 ] ASF GitHub Bot commented on GEODE-8209: --- dschneider-pivotal opened a new pull request #5190: URL: https://github.com/apache/geode/pull/5190 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > GlobPattern package should not include org.apache.hadoop.fs > --- > > Key: GEODE-8209 > URL: https://issues.apache.org/jira/browse/GEODE-8209 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > > The package of GlobPattern should be "org.apache.geode.redis.internal" > instead of "org.apache.geode.redis.internal.org.apache.hadoop.fs" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8209) GlobPattern package should not include org.apache.hadoop.fs
Darrel Schneider created GEODE-8209: --- Summary: GlobPattern package should not include org.apache.hadoop.fs Key: GEODE-8209 URL: https://issues.apache.org/jira/browse/GEODE-8209 Project: Geode Issue Type: Bug Components: redis Reporter: Darrel Schneider The package of GlobPattern should be "org.apache.geode.redis.internal" instead of "org.apache.geode.redis.internal.org.apache.hadoop.fs" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8209) GlobPattern package should not include org.apache.hadoop.fs
[ https://issues.apache.org/jira/browse/GEODE-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider reassigned GEODE-8209: --- Assignee: Darrel Schneider > GlobPattern package should not include org.apache.hadoop.fs > --- > > Key: GEODE-8209 > URL: https://issues.apache.org/jira/browse/GEODE-8209 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > > The package of GlobPattern should be "org.apache.geode.redis.internal" > instead of "org.apache.geode.redis.internal.org.apache.hadoop.fs" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121313#comment-17121313
]
ASF GitHub Bot commented on GEODE-7864:
---
pivotal-jbarrett commented on a change in pull request #4866:
URL: https://github.com/apache/geode/pull/4866#discussion_r433471017
##
File path:
geode-junit/src/main/java/org/apache/geode/pdx/TestObjectForJSONFormatter.java
##
@@ -992,6 +993,31 @@ boolean compareMaps(Map m1, Map m2) {
return true;
}
+ @Override
+ public int hashCode() {
+int result = Objects.hash(p_bool, p_byte, p_short, p_int, p_long, p_float,
p_double, w_bool,
Review comment:
What about:
```java
return Arrays.deepHashCode(new Object[] {p_pool, p_poolArray, ...});
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
>
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
>Reporter: Nabarun Nag
>Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies
[ https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121242#comment-17121242 ] ASF GitHub Bot commented on GEODE-2484: --- codecov-commenter edited a comment on pull request #607: URL: https://github.com/apache/geode-native/pull/607#issuecomment-635137877 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=h1) Report > Merging [#607](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/35b6d5260b2c04cf25e84b34d38bacbf56f0445e=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `85.53%`. [](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #607 +/- ## === - Coverage73.42% 73.36% -0.06% === Files 639 641 +2 Lines5092650984 +58 === + Hits 3739037402 +12 - Misses 1353613582 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=tree) | Coverage Δ | | |---|---|---| | [cppcache/include/geode/CacheableString.hpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9DYWNoZWFibGVTdHJpbmcuaHBw) | `96.07% <ø> (ø)` | | | [cppcache/src/AdminRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0FkbWluUmVnaW9uLmNwcA==) | `40.67% <0.00%> (-31.74%)` | :arrow_down: | | [cppcache/src/AdminRegion.hpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0FkbWluUmVnaW9uLmhwcA==) | `100.00% <ø> (ø)` | | | [cppcache/src/CacheImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlSW1wbC5jcHA=) | `77.98% <ø> (ø)` | | | [cppcache/src/CacheImpl.hpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlSW1wbC5ocHA=) | `97.56% <ø> (+2.43%)` | :arrow_up: | | [cppcache/src/ClientProxyMembershipID.hpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudFByb3h5TWVtYmVyc2hpcElELmhwcA==) | `82.60% <ø> (ø)` | | | [cppcache/src/ClientProxyMembershipIDFactory.hpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudFByb3h5TWVtYmVyc2hpcElERmFjdG9yeS5ocHA=) | `100.00% <ø> (ø)` | | | [cppcache/src/DistributedSystemImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0Rpc3RyaWJ1dGVkU3lzdGVtSW1wbC5jcHA=) | `66.66% <ø> (ø)` | | | [...che/src/InternalCacheTransactionManager2PCImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0ludGVybmFsQ2FjaGVUcmFuc2FjdGlvbk1hbmFnZXIyUENJbXBsLmNwcA==) | `32.18% <0.00%> (-0.76%)` | :arrow_down: | | [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.17% <ø> (ø)` | | | ... and [56 more](https://codecov.io/gh/apache/geode-native/pull/607/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=footer). Last update [35b6d52...e24fc1c](https://codecov.io/gh/apache/geode-native/pull/607?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE from native client dependencies > -- > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client >Reporter: David Kimura >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > >
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121238#comment-17121238 ] ASF GitHub Bot commented on GEODE-7956: --- mkevo commented on a change in pull request #5159: URL: https://github.com/apache/geode/pull/5159#discussion_r433411605 ## File path: geode-docs/basic_config/data_regions/region_naming.html.md.erb ## @@ -24,7 +24,7 @@ follow these region naming guidelines. - Characters permitted in region names are alphanumeric characters (`ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789`), -period (`.`), underscore (`_`), square brackets (`[, ]`) and hyphen (`-`). +period (`.`), underscore (`_`), square brackets (`[, ]`), hyphen (`-`), caret (`^`) and backqoute (```). Review comment: Done. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8131) alert service hangs, blocking cache operations
[
https://issues.apache.org/jira/browse/GEODE-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anilkumar Gingade updated GEODE-8131:
-
Labels: GeodeOperationAPI (was: )
> alert service hangs, blocking cache operations
> --
>
> Key: GEODE-8131
> URL: https://issues.apache.org/jira/browse/GEODE-8131
> Project: Geode
> Issue Type: Bug
> Components: logging
>Reporter: Bruce J Schuchardt
>Priority: Major
> Labels: GeodeOperationAPI
>
> This v1.8 TcpConduit reader thread was blocked in a production system. It
> had experienced a deserialization error and was trying to log the exception.
> A Manager was present in the cluster and had registered as an alert listener.
> Another thread was blocked sending something on the shared/unordered
> connection that this alert should be sent on. This persisted for over 6
> hours and we never saw the serialization exception in the log file.
> Consequently we had to recommend setting the alert level to None and have
> them run into the serialization problem again.
> This is a serious flaw in the alerting system and it's caused us grief many
> times. The alerting system should not block other threads. Maybe a
> background thread could consume and transmit alerts to alert-listeners?
>
> {noformat}
> "P2P message reader for 10.236.28.120(servername-removed):56152 shared
> unordered uid=9 port=41204" tid=0xd49 (in native) java.lang.Thread.State:
> RUNNABLE at sun.nio.ch.FileDispatcherImpl.write0(Native Method) at
> sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) at
> sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) at
> sun.nio.ch.IOUtil.write(IOUtil.java:51) at
> sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:471) - locked
> java.lang.Object@24528b9b at
> org.apache.geode.internal.tcp.Connection.nioWriteFully(Connection.java:3291)
> - locked java.lang.Object@42a1a79b at
> org.apache.geode.internal.tcp.Connection.sendPreserialized(Connection.java:2527)
> at org.apache.geode.internal.tcp.MsgStreamer.realFlush(MsgStreamer.java:319)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:244)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:393)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:250)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:615)
> at
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.directChannelSend(GMSMembershipManager.java:1717)
> at
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.send(GMSMembershipManager.java:1898)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2878)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:2798)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2837)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1531)
> at
> org.apache.geode.internal.alerting.AlertMessaging.sendAlert(AlertMessaging.java:75)
> at
> org.apache.geode.internal.logging.log4j.AlertAppender.sendAlertMessage(AlertAppender.java:188)
> at
> org.apache.geode.internal.logging.log4j.AlertAppender.doAppend(AlertAppender.java:163)
> at
> org.apache.geode.internal.logging.log4j.AlertAppender.lambda$append$0(AlertAppender.java:159)
> at
> org.apache.geode.internal.logging.log4j.AlertAppender$$Lambda$168/1102181662.run(Unknown
> Source) at
> org.apache.geode.internal.alerting.AlertingAction.execute(AlertingAction.java:29)
> at
> org.apache.geode.internal.logging.log4j.AlertAppender.append(AlertAppender.java:159)
> at
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:464)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:448)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:431)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.logParent(LoggerConfig.java:455)
> at
>
[jira] [Updated] (GEODE-7792) configure logging for geode-membership integration tests
[ https://issues.apache.org/jira/browse/GEODE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Burcham updated GEODE-7792: Component/s: tests > configure logging for geode-membership integration tests > > > Key: GEODE-7792 > URL: https://issues.apache.org/jira/browse/GEODE-7792 > Project: Geode > Issue Type: Improvement > Components: membership, tests >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Trivial > Fix For: 1.13.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Integration tests for geode-membership do not have a log4j configuration. The > subproject cannot depend on geode-log4j because that pulls in geode-core with > its Alert appender and other things. > Add a log4j configuration for tests in geode-membership so we can get proper > log output from tests to diagnose failures. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-7792) configure logging for geode-membership integration tests
[ https://issues.apache.org/jira/browse/GEODE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Burcham updated GEODE-7792: Priority: Trivial (was: Major) > configure logging for geode-membership integration tests > > > Key: GEODE-7792 > URL: https://issues.apache.org/jira/browse/GEODE-7792 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Trivial > Fix For: 1.13.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Integration tests for geode-membership do not have a log4j configuration. The > subproject cannot depend on geode-log4j because that pulls in geode-core with > its Alert appender and other things. > Add a log4j configuration for tests in geode-membership so we can get proper > log output from tests to diagnose failures. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies
[
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121147#comment-17121147
]
ASF GitHub Bot commented on GEODE-2484:
---
pdxcodemonkey commented on a change in pull request #607:
URL: https://github.com/apache/geode-native/pull/607#discussion_r433350995
##
File path: cppcache/src/CppCacheLibrary.hpp
##
@@ -31,17 +31,28 @@ namespace client {
// initialize GEODE runtime if it has not already been initialized.
class APACHE_GEODE_EXPORT CppCacheLibrary {
public:
- // Call to this to trigger initialization.
+ /**
+ * Call to this to trigger initialization.
+ */
static void initLib(void);
Review comment:
https://issues.apache.org/jira/browse/GEODE-8208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: David Kimura
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8206) CI Failure: ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
[
https://issues.apache.org/jira/browse/GEODE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce J Schuchardt reassigned GEODE-8206:
-
Assignee: Bruce J Schuchardt
> CI Failure:
> ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
> --
>
> Key: GEODE-8206
> URL: https://issues.apache.org/jira/browse/GEODE-8206
> Project: Geode
> Issue Type: Bug
> Components: ci, membership
>Reporter: Eric Shu
>Assignee: Bruce J Schuchardt
>Priority: Major
>
> This test hangs in:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/221#A
> {noformat}
> "RMI TCP Connection(1)-172.17.0.23" #32 daemon prio=5 os_prio=0
> tid=0x7fea58001800 nid=0x27d waiting on condition [0x7feb23bf7000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xe0e6cb10> (a
> java.util.concurrent.CountDownLatch$Sync)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4693)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4671)
> at
> org.apache.geode.internal.cache.LocalRegion.getSubregion(LocalRegion.java:4558)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3322)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3153)
> at
> org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.getConfigurationRegion(InternalConfigurationPersistenceService.java:792)
> at
> org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.destroySharedConfiguration(InternalConfigurationPersistenceService.java:639)
> at
> org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest.lambda$teardown$bb17a952$1(ReconnectWithClusterConfigurationDUnitTest.java:112)
> at
> org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest$$Lambda$339/1176989958.run(Unknown
> Source)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
> at
> org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:688)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler$$Lambda$15/2049270388.run(Unknown
> Source)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:687)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>Locked
[jira] [Created] (GEODE-8208) Remove global initLib/closeLib methods from CppCacheLibrary
Blake Bender created GEODE-8208: --- Summary: Remove global initLib/closeLib methods from CppCacheLibrary Key: GEODE-8208 URL: https://issues.apache.org/jira/browse/GEODE-8208 Project: Geode Issue Type: Task Components: native client Reporter: Blake Bender closeLib contains no code, just remove it. initLib is only one line of code, a call to ACE::init(). If there is to be any global initialization code for geode-native, and it currently doesn't appear that there is, it needs to be exposed in the public API and called explicitly by the application, where object lifetimes etc are known. Since CppCacheLibrary isn't public, and once we remove ACE (GEODE-2484) there will literally be no code in either of these methods, we should delete them and move on. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121132#comment-17121132 ] ASF GitHub Bot commented on GEODE-7956: --- dschneider-pivotal commented on a change in pull request #5159: URL: https://github.com/apache/geode/pull/5159#discussion_r47846 ## File path: geode-docs/basic_config/data_regions/region_naming.html.md.erb ## @@ -24,7 +24,7 @@ follow these region naming guidelines. - Characters permitted in region names are alphanumeric characters (`ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789`), -period (`.`), underscore (`_`), square brackets (`[, ]`) and hyphen (`-`). +period (`.`), underscore (`_`), square brackets (`[, ]`), hyphen (`-`), caret (`^`) and backqoute (```). Review comment: type: change qoute to quote This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8206) CI Failure: ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
[
https://issues.apache.org/jira/browse/GEODE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121124#comment-17121124
]
Bruce J Schuchardt commented on GEODE-8206:
---
The test hung trying to shut down the locators it started. The teardown thread
was stuck waiting on cache initialization:
{noformat}
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xe0e6cb10> (a
java.util.concurrent.CountDownLatch$Sync)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
at
org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
at
org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4693)
at
org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4671)
at
org.apache.geode.internal.cache.LocalRegion.getSubregion(LocalRegion.java:4558)
at
org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3322)
at
org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3153)
at
org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.getConfigurationRegion(InternalConfigurationPersistenceService.java:792)
at
org.apache.geode.distributed.internal.InternalConfigurationPersistenceService.destroySharedConfiguration(InternalConfigurationPersistenceService.java:639)
at
org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest.lambda$teardown$bb17a952$1(ReconnectWithClusterConfigurationDUnitTest.java:112)
at
org.apache.geode.cache30.ReconnectWithClusterConfigurationDUnitTest$$Lambda$339/1176989958.run(Unknown
Source)
{noformat}
One of the locators was in a loop trying to reconnect and failing over and over
again. I think this was due to misconfiguration of the locators. There are
two locators and they had this for their "locators" configuration:
{noformat}
locators=localHost[27228],localHost[27228]
{noformat}
This was due to faulty code in the test's getDistributedSystemProperties method
that only told the locators about the first locator's port.
{code}
StringBuilder stringBuilder = new StringBuilder();
stringBuilder.append("localHost[")
.append(locatorPorts[0])
.append(']');
for (int i = 1; i < NUM_LOCATORS; i++) {
stringBuilder.append(",localHost[")
.append(locatorPorts[0])
.append(']');
}
{code}
The loop should use "i", not "0" for an index into localPorts[].
> CI Failure:
> ReconnectWithClusterConfigurationDUnitTest.testReconnectAfterMeltdown hang
> --
>
> Key: GEODE-8206
> URL: https://issues.apache.org/jira/browse/GEODE-8206
> Project: Geode
> Issue Type: Bug
> Components: ci, membership
>Reporter: Eric Shu
>Priority: Major
>
> This test hangs in:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/221#A
> {noformat}
> "RMI TCP Connection(1)-172.17.0.23" #32 daemon prio=5 os_prio=0
> tid=0x7fea58001800 nid=0x27d waiting on condition [0x7feb23bf7000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xe0e6cb10> (a
> java.util.concurrent.CountDownLatch$Sync)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4693)
> at
> org.apache.geode.internal.cache.LocalRegion.waitOnInitialization(LocalRegion.java:4671)
> at
> org.apache.geode.internal.cache.LocalRegion.getSubregion(LocalRegion.java:4558)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.getRegion(GemFireCacheImpl.java:3322)
> at
>
[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies
[
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121092#comment-17121092
]
ASF GitHub Bot commented on GEODE-2484:
---
pivotal-jbarrett commented on a change in pull request #607:
URL: https://github.com/apache/geode-native/pull/607#discussion_r433298102
##
File path: cppcache/src/CppCacheLibrary.hpp
##
@@ -31,17 +31,28 @@ namespace client {
// initialize GEODE runtime if it has not already been initialized.
class APACHE_GEODE_EXPORT CppCacheLibrary {
public:
- // Call to this to trigger initialization.
+ /**
+ * Call to this to trigger initialization.
+ */
static void initLib(void);
Review comment:
This I didn't want to mess with! Many versions and compilers ago I tried
and the ordering changed and resulted in bad things. I don't even want to look
at this wrong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: David Kimura
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies
[ https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121085#comment-17121085 ] ASF GitHub Bot commented on GEODE-2484: --- pivotal-jbarrett commented on a change in pull request #607: URL: https://github.com/apache/geode-native/pull/607#discussion_r433296295 ## File path: cppcache/src/AdminRegion.hpp-a968f121 ## @@ -0,0 +1,84 @@ +/* Review comment: 臘 Whoops! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE from native client dependencies > -- > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client >Reporter: David Kimura >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 11h 20m > Remaining Estimate: 0h > > Remove ACE from native client dependencies. > Replace ACE usage with C++11 and/or Boost 1.63+ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies
[ https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121084#comment-17121084 ] ASF GitHub Bot commented on GEODE-2484: --- pivotal-jbarrett commented on a change in pull request #607: URL: https://github.com/apache/geode-native/pull/607#discussion_r433295688 ## File path: cppcache/include/geode/CacheableString.hpp ## @@ -25,8 +25,7 @@ #include "internal/DataSerializablePrimitive.hpp" #include "internal/geode_globals.hpp" -/** @file - */ +#undef max Review comment: C preprocessor rules suck. Something included above results in leaking a macro from a system header defined as `max`. This then collides with `std::max()` resulting gibberish that won't compile. I think I may have already corrected the issue by cleaning up headers. I will pull this and see what happens now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE from native client dependencies > -- > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client >Reporter: David Kimura >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 11h 20m > Remaining Estimate: 0h > > Remove ACE from native client dependencies. > Replace ACE usage with C++11 and/or Boost 1.63+ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7801) User Guide "Querying with OQL" page - sync with T of C
[ https://issues.apache.org/jira/browse/GEODE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120931#comment-17120931 ] Alberto Bustamante Reyes commented on GEODE-7801: - [~dbarnes] would you agree with these points? * Move the content of "Advantages of OQL" into "Querying with OQL" * Promote "Writing and Executing a Query in Geode" to the same level as "Querying with OQL * Move the subsections of "Querying with OQL" that are after "Writing and Executing a Query in Geode" to be subsections of the promoted "Writing and Executing a Query in Geode" (I think with this change the current order of the chapter will be kept) So the left menu will look as this: * Querying ** Geode Querying FAQ and Examples ** Querying wth OQL ** Writing and Executing a Query in Geode *** Building a Query String (and its subsections ) *** OQL Syntax and Semantics (and its subsections ) *** Query Language Restrictions and Unsupported Features > User Guide "Querying with OQL" page - sync with T of C > -- > > Key: GEODE-7801 > URL: https://issues.apache.org/jira/browse/GEODE-7801 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Minor > > The "Querying with OQL" page > ([https://geode.apache.org/docs/guide/111/developing/querying_basics/query_basics.html]) > has two subsidiary pages listed in the left-hand navigation pane, but > they're not referenced in the page text itself. > Given that the LH-nav is collapsed by default, it's (too) easy for the reader > to overlook the subtopics (Advantages of OQL and Writing and Executing a > Query in Geode). > One solution would be to place links in the Querying with OQL page. Another > would be to pull the subtopics into the Querying with OQL page and > eliminating the extra level in the nav. > A third possibility (perhaps the best) would be to elevate the Writing and > Executing subtopic to a more prominent spot in the hierarchy - it seems kinda > buried in its current position. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-7801) User Guide "Querying with OQL" page - sync with T of C
[ https://issues.apache.org/jira/browse/GEODE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Bustamante Reyes reassigned GEODE-7801: --- Assignee: Alberto Bustamante Reyes > User Guide "Querying with OQL" page - sync with T of C > -- > > Key: GEODE-7801 > URL: https://issues.apache.org/jira/browse/GEODE-7801 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Minor > > The "Querying with OQL" page > ([https://geode.apache.org/docs/guide/111/developing/querying_basics/query_basics.html]) > has two subsidiary pages listed in the left-hand navigation pane, but > they're not referenced in the page text itself. > Given that the LH-nav is collapsed by default, it's (too) easy for the reader > to overlook the subtopics (Advantages of OQL and Writing and Executing a > Query in Geode). > One solution would be to place links in the Querying with OQL page. Another > would be to pull the subtopics into the Querying with OQL page and > eliminating the extra level in the nav. > A third possibility (perhaps the best) would be to elevate the Writing and > Executing subtopic to a more prominent spot in the hierarchy - it seems kinda > buried in its current position. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8186) User Guide: add example for gfsh query --member option
[ https://issues.apache.org/jira/browse/GEODE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120920#comment-17120920 ] Alberto Bustamante Reyes commented on GEODE-8186: - [~dbarnes] Where do you think this example would fit? In the [command description|https://geode.apache.org/docs/guide/19/tools_modules/gfsh/command-pages/query.html]? In a new entry in the [querying FAQ|https://geode.apache.org/docs/guide/19/getting_started/querying_quick_reference.html]? > User Guide: add example for gfsh query --member option > -- > > Key: GEODE-8186 > URL: https://issues.apache.org/jira/browse/GEODE-8186 > Project: Geode > Issue Type: Sub-task > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > > GEODE-8112 added a --member option to the gfsh query command. > Add a usage example to the User Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7309) Upgrade Lucene from 6.6.2 to 8.2.0
[ https://issues.apache.org/jira/browse/GEODE-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120868#comment-17120868 ] ASF GitHub Bot commented on GEODE-7309: --- mkevo commented on pull request #4826: URL: https://github.com/apache/geode/pull/4826#issuecomment-636719646 Hi @nabarunnag , what is the status of this activity? Do you need some help? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Lucene from 6.6.2 to 8.2.0 > -- > > Key: GEODE-7309 > URL: https://issues.apache.org/jira/browse/GEODE-7309 > Project: Geode > Issue Type: Sub-task >Reporter: Mario Kevo >Assignee: Mario Kevo >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120850#comment-17120850 ] ASF GitHub Bot commented on GEODE-7956: --- mkevo commented on pull request #5159: URL: https://github.com/apache/geode/pull/5159#issuecomment-636708103 @davebarnes97, please review new document changes. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[
https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120836#comment-17120836
]
ASF GitHub Bot commented on GEODE-7956:
---
dschneider-pivotal commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r433111298
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
Sounds perfect!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Correct documentation of legal region names
> ---
>
> Key: GEODE-7956
> URL: https://issues.apache.org/jira/browse/GEODE-7956
> Project: Geode
> Issue Type: Bug
> Components: docs
>Reporter: Darrel Schneider
>Assignee: Mario Kevo
>Priority: Major
>
> According to this:
> https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html
> region names can only contain alphanumeric, dash, and underscore.
> But the product also supports a dot '.'.
> See RegionNameValidation and RegionNameValidationTest
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[
https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120807#comment-17120807
]
ASF GitHub Bot commented on GEODE-7956:
---
mkevo commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r433090252
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
Yes, I agree. I also think that aA-zZ is the same as a-zA-Z.
The new regex will be **[a-zA-Z0-9-_.^`\[\]\\]+**. Is it ok with you?
This more clear to see what is included. I will also add separate tests for
all of these characters.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Correct documentation of legal region names
> ---
>
> Key: GEODE-7956
> URL: https://issues.apache.org/jira/browse/GEODE-7956
> Project: Geode
> Issue Type: Bug
> Components: docs
>Reporter: Darrel Schneider
>Assignee: Mario Kevo
>Priority: Major
>
> According to this:
> https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html
> region names can only contain alphanumeric, dash, and underscore.
> But the product also supports a dot '.'.
> See RegionNameValidation and RegionNameValidationTest
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[
https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120798#comment-17120798
]
ASF GitHub Bot commented on GEODE-7956:
---
dschneider-pivotal commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r433083367
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
When I read aA-zZ I thought it was just a special regex pattern to match
a-zA-Z. I bet whoever wrote this thought that. But since the product was
already released with a pattern that allows those other characters it would be
safest to continue to allow those characters. To make a breaking change I think
we need an RFC. For now it is best to change the docs to describe the behavior
of the existing geode release. We could schedule removing these special
characters from region names in a future release. I think it would be good to
rewrite the regex to still match what it did before but to do it more
explicitly (something like a-zA-Z0-9-_.^`[]\\) or add comments to make clear
what A-z matches. I also think it would be good to have some explicit test
methods that show that these special characters are allowed in region names.
Thanks for figuring this out!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Correct documentation of legal region names
> ---
>
> Key: GEODE-7956
> URL: https://issues.apache.org/jira/browse/GEODE-7956
> Project: Geode
> Issue Type: Bug
> Components: docs
>Reporter: Darrel Schneider
>Assignee: Mario Kevo
>Priority: Major
>
> According to this:
> https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html
> region names can only contain alphanumeric, dash, and underscore.
> But the product also supports a dot '.'.
> See RegionNameValidation and RegionNameValidationTest
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[
https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120794#comment-17120794
]
ASF GitHub Bot commented on GEODE-7956:
---
mkevo commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r433077472
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
I didn't find RFC for this, but old pattern include this characters and
you can see it if you add logger for names in test
`startingWithMatchingCharactersAreOk` in RegionNameValidationTest where it
validates all characters which is allowed by this pattern.
From ASCII table A is 65 and z is 122, and this part **A-z** include all
characters between these two values, and this characters(^, `, [, ], and
backslash) are between 91 and 96.
Old pattern **[aA-zZ0-9-_.]+** is the same as **[A-z0-9-_.]+**.\
So we can go with change pattern to **[A-z0-9-_.]+** and be sure that if
someone is using it we don't break them. And also document all charactes which
is allowed.
Do you agree with that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Correct documentation of legal region names
> ---
>
> Key: GEODE-7956
> URL: https://issues.apache.org/jira/browse/GEODE-7956
> Project: Geode
> Issue Type: Bug
> Components: docs
>Reporter: Darrel Schneider
>Assignee: Mario Kevo
>Priority: Major
>
> According to this:
> https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html
> region names can only contain alphanumeric, dash, and underscore.
> But the product also supports a dot '.'.
> See RegionNameValidation and RegionNameValidationTest
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
