[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176662#comment-17176662
]
ASF GitHub Bot commented on GEODE-7846:
---
DonalEvans commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r469611803
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -378,8 +378,11 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
} finally {
releaseDistributedClearLock(lockName);
if (partitionedRegion.getCachePerfStats() != null) {
Review comment:
I think that the null check on `partitionedRegion.getCachePerfStats()`
is no longer necessary with this change, since it's not them we're updating.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
> Issue Type: Improvement
> Components: core
>Reporter: Xiaojian Zhou
>Assignee: Benjamin P Ross
>Priority: Major
> Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats:
> 1) clear operation executed.
> 2) clear operation failed
> 3) clear messages sends to buckets
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version
[
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176657#comment-17176657
]
ASF subversion and git services commented on GEODE-8337:
Commit 415e4402c01ff08df129d55ccc9d42d5000b320e in geode's branch
refs/heads/develop from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=415e440 ]
GEODE-8337: git mv VersionOrdinal.java->Version.java
(cherry picked from commit 2a3b609ceb2f9374cc847d0f367ab2d53f5392a0)
> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
> !screenshot-1.png!
> Before this change, the hierarchy was:
> !screenshot-2.png!
> As part of this story we'll also harmonize version access methods on
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version
[
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176656#comment-17176656
]
ASF subversion and git services commented on GEODE-8337:
Commit 068a467dee63db91cb8869fe70ea435c95a6526c in geode's branch
refs/heads/develop from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=068a467 ]
GEODE-8337: git mv Version.java->KnownVersion.java
(cherry picked from commit 17d6679125942f5f33ded4670dc9e0ca643e03da)
> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
> !screenshot-1.png!
> Before this change, the hierarchy was:
> !screenshot-2.png!
> As part of this story we'll also harmonize version access methods on
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version
[
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176659#comment-17176659
]
ASF subversion and git services commented on GEODE-8337:
Commit 52018fcf1da513c888092775295a121992abcec2 in geode's branch
refs/heads/develop from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=52018fc ]
GEODE-8337: fix support branch creation script to mod KnownVersion.java
> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
> !screenshot-1.png!
> Before this change, the hierarchy was:
> !screenshot-2.png!
> As part of this story we'll also harmonize version access methods on
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast
[
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176658#comment-17176658
]
ASF subversion and git services commented on GEODE-8298:
Commit b5e2b566c4574bb41db4ed588fd79674f084e813 in geode's branch
refs/heads/develop from Kamilla Aslami
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b5e2b56 ]
GEODE-8298: Fix multicast version detection (#5370)
Membership decides whether or not use multicast based on the versions
of view members and surprise members. Surprise member version comparison
was backward. Correct version comparison by unifying view and surprise
member processing.
Co-authored-by: Kamilla Aslami
Co-authored-by: Bill Burcham
(cherry picked from commit fd76cc0b7dbf97dfb84d11e67b37e33c0a9e7fb2)
> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bill Burcham
>Assignee: Kamilla Aslami
>Priority: Major
> Labels: pull-request-available, starter
> Fix For: 1.14.0
>
>
> Since about 2014 when we introduced the {{Version}} class to replace use of
> {{short}} s all over the place for serialization versions, these two loops in
> {{GMSMembership.processView()}} have used comparisons that disagree in sense:
> {code}
> // We perform the update under a global lock so that other
> // incoming events will not be lost in terms of our global view.
> latestViewWriteLock.lock();
> try {
> // first determine the version for multicast message serialization
> VersionOrdinal version = Version.CURRENT;
> for (final Entry internalIDLongEntry : surpriseMembers
> .entrySet()) {
> ID mbr = internalIDLongEntry.getKey();
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && version.compareTo(itsVersion) < 0) {
> version = itsVersion;
> }
> }
> for (ID mbr : newView.getMembers()) {
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && itsVersion.compareTo(version) < 0) {
> version = mbr.getVersionObject();
> }
> }
> disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
> {code}
> The goal here is to find the oldest version and if that version is older than
> our local version we disable multicast. So we want to put the minimum into
> {{version}}. So the first loop's comparison is wrong and the second one is
> right.
> While we are in here let's combine the two loops using
> {{Stream.concat(surpriseMembers.entrySet().stream().map(entry->entry.getKey()),
> newView.getMembers().stream()).forEach(member -> ...)}}.
> Alternatives are described here:
> https://www.baeldung.com/java-combine-multiple-collections
> Once we have the combined {{Iterable}} we can use something like
> {{Collections.min()}} to find the minimum in one swell foop and this whole
> thing collapses to one or two declarative expressions.
> When this story is complete, the functionality will be in a separate method
> and we'll have a unit test for it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version
[
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176655#comment-17176655
]
ASF GitHub Bot commented on GEODE-8337:
---
Bill merged pull request #5409:
URL: https://github.com/apache/geode/pull/5409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
> !screenshot-1.png!
> Before this change, the hierarchy was:
> !screenshot-2.png!
> As part of this story we'll also harmonize version access methods on
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176651#comment-17176651 ] ASF subversion and git services commented on GEODE-8422: Commit cf27a6a68f0ff89513e4c3a0c0a7a6235ab61e7f in geode's branch refs/heads/develop from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cf27a6a ] Changes to help reduce the occurence of GEODE-8422 (#5447) * Changes to help reduce the occurence of GEODE-8422 * Added a unit test for the case where we don't want to remove a tombstone with the region is not initialized. * fix the dunit tests' behavior Co-authored-by: agingade Co-authored-by: zhouxh < zho...@vmware.com> > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176649#comment-17176649 ] ASF subversion and git services commented on GEODE-8422: Commit cf27a6a68f0ff89513e4c3a0c0a7a6235ab61e7f in geode's branch refs/heads/develop from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cf27a6a ] Changes to help reduce the occurence of GEODE-8422 (#5447) * Changes to help reduce the occurence of GEODE-8422 * Added a unit test for the case where we don't want to remove a tombstone with the region is not initialized. * fix the dunit tests' behavior Co-authored-by: agingade Co-authored-by: zhouxh < zho...@vmware.com> > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176650#comment-17176650 ] ASF subversion and git services commented on GEODE-8422: Commit cf27a6a68f0ff89513e4c3a0c0a7a6235ab61e7f in geode's branch refs/heads/develop from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cf27a6a ] Changes to help reduce the occurence of GEODE-8422 (#5447) * Changes to help reduce the occurence of GEODE-8422 * Added a unit test for the case where we don't want to remove a tombstone with the region is not initialized. * fix the dunit tests' behavior Co-authored-by: agingade Co-authored-by: zhouxh < zho...@vmware.com> > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176652#comment-17176652 ] ASF subversion and git services commented on GEODE-8422: Commit cf27a6a68f0ff89513e4c3a0c0a7a6235ab61e7f in geode's branch refs/heads/develop from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cf27a6a ] Changes to help reduce the occurence of GEODE-8422 (#5447) * Changes to help reduce the occurence of GEODE-8422 * Added a unit test for the case where we don't want to remove a tombstone with the region is not initialized. * fix the dunit tests' behavior Co-authored-by: agingade Co-authored-by: zhouxh < zho...@vmware.com> > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176648#comment-17176648 ] ASF GitHub Bot commented on GEODE-8422: --- mhansonp merged pull request #5447: URL: https://github.com/apache/geode/pull/5447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8379) CI failure: TimeIntegrationTest.timeCommandRespondsWIthTwoValue
[
https://issues.apache.org/jira/browse/GEODE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176643#comment-17176643
]
Kirk Lund commented on GEODE-8379:
--
Reproduced for me too:
http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-5451/test-results/integrationTest/1597273036/
> CI failure: TimeIntegrationTest.timeCommandRespondsWIthTwoValue
> ---
>
> Key: GEODE-8379
> URL: https://issues.apache.org/jira/browse/GEODE-8379
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Bruce J Schuchardt
>Priority: Major
>
> This relatively new test failed in a Windows CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsIntegrationTestOpenJDK11/builds/339]
>
> {noformat}
> org.apache.geode.redis.internal.executor.server.TimeIntegrationTest >
> timeCommandRespondsWIthTwoValues FAILED
> 16:38:28java.lang.AssertionError:
> 16:38:28Expecting:
> 16:38:28 <0L>
> 16:38:28to be greater than:
> 16:38:28 <0L>
> 16:38:28at
> org.apache.geode.redis.internal.executor.server.TimeIntegrationTest.timeCommandRespondsWIthTwoValues(TimeIntegrationTest.java:57)
> 16:48:28 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[
https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176641#comment-17176641
]
ASF GitHub Bot commented on GEODE-8422:
---
jchen21 commented on a change in pull request #5447:
URL: https://github.com/apache/geode/pull/5447#discussion_r469584716
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##
@@ -497,7 +497,7 @@ public void run() {
// If fullGII, the key size in gii chunk is 3, i.e. key1,key3,key5. key2
is GCed.
// If delta GII, the key size should be 1 (key5(T) which is unfinished
operation)
-verifyDeltaSizeFromStats(R, 3, 0);
+verifyDeltaSizeFromStats(R, 1, 1);
Review comment:
Does the comment above have to be updated?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Regions get out of sync if destroys happening during shutdown
> -
>
> Key: GEODE-8422
> URL: https://issues.apache.org/jira/browse/GEODE-8422
> Project: Geode
> Issue Type: Bug
> Components: general
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0, 1.14.0
>
>
> When a cluster of servers are being shutdown, while destroy operations are
> happening, in a small case, it is possible for the regions to get out of sync
> when delta GII is used.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[
https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176632#comment-17176632
]
ASF GitHub Bot commented on GEODE-7672:
---
jinmeiliao commented on a change in pull request #5436:
URL: https://github.com/apache/geode/pull/5436#discussion_r469576684
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.cache.query.partitioned;
+
+import static
org.apache.geode.distributed.ConfigurationProperties.SERIALIZABLE_OBJECT_FILTER;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.concurrent.TimeUnit;
+import java.util.stream.IntStream;
+
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.query.Index;
+import org.apache.geode.cache.query.IndexStatistics;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+import org.apache.geode.cache.query.data.City;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.ClientCacheRule;
+
+public class PRClearQueryIndexDUnitTest {
+ public static final String MUMBAI_QUERY = "select * from /cities c where
c.name = 'MUMBAI'";
+ public static final String ID_10_QUERY = "select * from /cities c where c.id
= 10";
+ @ClassRule
+ public static ClusterStartupRule cluster = new ClusterStartupRule(2, true);
+
+ private static MemberVM server1;
+ private static MemberVM server2;
+
+ @Rule
+ public ClientCacheRule clientCacheRule = new ClientCacheRule();
+
+ private ClientCache clientCache;
+
+ // class test setup. set up the servers, regions and indexes on the servers
+ @BeforeClass
+ public static void beforeClass() {
+int locatorPort = ClusterStartupRule.getDUnitLocatorPort();
+server1 = cluster.startServerVM(0, s ->
s.withConnectionToLocator(locatorPort)
+.withProperty(SERIALIZABLE_OBJECT_FILTER,
"org.apache.geode.cache.query.data.*")
+.withRegion(RegionShortcut.PARTITION, "cities"));
+server2 = cluster.startServerVM(1, s ->
s.withConnectionToLocator(locatorPort)
+.withProperty(SERIALIZABLE_OBJECT_FILTER,
"org.apache.geode.cache.query.data.*")
+.withRegion(RegionShortcut.PARTITION, "cities"));
+
+server1.invoke(() -> {
+ Cache cache = ClusterStartupRule.getCache();
+ Region region = cache.getRegion("cities");
+ // create indexes
+ QueryService queryService = cache.getQueryService();
+ queryService.createKeyIndex("cityId", "c.id", "/cities c");
+ queryService.createIndex("cityName", "c.name", "/cities c");
+ assertThat(cache.getQueryService().getIndexes(region)).hasSize(2);
+});
+
+server2.invoke(() -> {
+ Cache cache = ClusterStartupRule.getCache();
+ Region region = cache.getRegion("cities");
+ assertThat(cache.getQueryService().getIndexes(region)).hasSize(2);
+});
+ }
+
+ // before every test method, create the client cache and region
+ @Before
+ public void before() throws Exception {
+int locatorPort = ClusterStartupRule.getDUnitLocatorPort();
+clientCache =
clientCacheRule.withLocatorConnection(locatorPort).createCache();
+ }
+
+ @Test
+ public void verifyQuerySucceedsAfterClear() throws Exception {
+Region cities = clientCacheRule.createProxyRegion("cities");
+// put in some data
+IntStream.range(0, 100).forEach(i -> cities.put(i, new City(i)));
+
+MemberVM.invokeInEveryMember(() -> {
+ InternalCache internalCache = ClusterStart
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[
https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176631#comment-17176631
]
ASF GitHub Bot commented on GEODE-7672:
---
jinmeiliao commented on a change in pull request #5436:
URL: https://github.com/apache/geode/pull/5436#discussion_r469576129
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.cache.query.partitioned;
+
+import static
org.apache.geode.distributed.ConfigurationProperties.SERIALIZABLE_OBJECT_FILTER;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.concurrent.TimeUnit;
+import java.util.stream.IntStream;
+
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.query.Index;
+import org.apache.geode.cache.query.IndexStatistics;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+import org.apache.geode.cache.query.data.City;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.ClientCacheRule;
+
+public class PRClearQueryIndexDUnitTest {
+ public static final String MUMBAI_QUERY = "select * from /cities c where
c.name = 'MUMBAI'";
+ public static final String ID_10_QUERY = "select * from /cities c where c.id
= 10";
+ @ClassRule
+ public static ClusterStartupRule cluster = new ClusterStartupRule(2, true);
+
+ private static MemberVM server1;
+ private static MemberVM server2;
+
+ @Rule
+ public ClientCacheRule clientCacheRule = new ClientCacheRule();
+
+ private ClientCache clientCache;
+
+ // class test setup. set up the servers, regions and indexes on the servers
+ @BeforeClass
+ public static void beforeClass() {
+int locatorPort = ClusterStartupRule.getDUnitLocatorPort();
+server1 = cluster.startServerVM(0, s ->
s.withConnectionToLocator(locatorPort)
+.withProperty(SERIALIZABLE_OBJECT_FILTER,
"org.apache.geode.cache.query.data.*")
+.withRegion(RegionShortcut.PARTITION, "cities"));
+server2 = cluster.startServerVM(1, s ->
s.withConnectionToLocator(locatorPort)
+.withProperty(SERIALIZABLE_OBJECT_FILTER,
"org.apache.geode.cache.query.data.*")
+.withRegion(RegionShortcut.PARTITION, "cities"));
+
+server1.invoke(() -> {
+ Cache cache = ClusterStartupRule.getCache();
+ Region region = cache.getRegion("cities");
+ // create indexes
+ QueryService queryService = cache.getQueryService();
+ queryService.createKeyIndex("cityId", "c.id", "/cities c");
+ queryService.createIndex("cityName", "c.name", "/cities c");
+ assertThat(cache.getQueryService().getIndexes(region)).hasSize(2);
+});
+
+server2.invoke(() -> {
+ Cache cache = ClusterStartupRule.getCache();
+ Region region = cache.getRegion("cities");
+ assertThat(cache.getQueryService().getIndexes(region)).hasSize(2);
+});
+ }
+
+ // before every test method, create the client cache and region
+ @Before
+ public void before() throws Exception {
+int locatorPort = ClusterStartupRule.getDUnitLocatorPort();
+clientCache =
clientCacheRule.withLocatorConnection(locatorPort).createCache();
+ }
+
+ @Test
+ public void verifyQuerySucceedsAfterClear() throws Exception {
+Region cities = clientCacheRule.createProxyRegion("cities");
+// put in some data
+IntStream.range(0, 100).forEach(i -> cities.put(i, new City(i)));
Review comment:
Yes, the PR is also to make sure this change won't break other tests.
[jira] [Commented] (GEODE-8368) Upgrade ClassGraph dependency from 4.8.52 to 4.8.87
[ https://issues.apache.org/jira/browse/GEODE-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176624#comment-17176624 ] ASF GitHub Bot commented on GEODE-8368: --- kirklund commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-673128651 I don't have time for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade ClassGraph dependency from 4.8.52 to 4.8.87 > --- > > Key: GEODE-8368 > URL: https://issues.apache.org/jira/browse/GEODE-8368 > Project: Geode > Issue Type: Wish > Components: build, management >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Upgrade ClassGraph dependency from 4.8.52 to 4.8.87. > See GEODE-8150. There were performance issues with 4.8.78 that caused us to > rollback to 4.8.52. We'll need to do extra testing as well as review of > ClassGraph release notes and bugs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8368) Upgrade ClassGraph dependency from 4.8.52 to 4.8.87
[ https://issues.apache.org/jira/browse/GEODE-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176625#comment-17176625 ] ASF GitHub Bot commented on GEODE-8368: --- kirklund closed pull request #5382: URL: https://github.com/apache/geode/pull/5382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade ClassGraph dependency from 4.8.52 to 4.8.87 > --- > > Key: GEODE-8368 > URL: https://issues.apache.org/jira/browse/GEODE-8368 > Project: Geode > Issue Type: Wish > Components: build, management >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Upgrade ClassGraph dependency from 4.8.52 to 4.8.87. > See GEODE-8150. There were performance issues with 4.8.78 that caused us to > rollback to 4.8.52. We'll need to do extra testing as well as review of > ClassGraph release notes and bugs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176622#comment-17176622 ] ASF GitHub Bot commented on GEODE-8422: --- mhansonp commented on pull request #5448: URL: https://github.com/apache/geode/pull/5448#issuecomment-673128283 Unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176623#comment-17176623 ] ASF GitHub Bot commented on GEODE-8425: --- kirklund opened a new pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > ** Total number of times handling a network search initiated by a remote > cache completed with success. > * handlingNetsearchesTime > ** Total time spent handling successful network searches for remote caches. > * handlingNetsearchesFailed > ** Total number of times handling a network search initiated by a remote > cache failed without success. > * handlingNetsearchesFailedTime > ** Total time spent handling failed network searches for remote caches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8425: -- Labels: GeodeOperationAPI pull-request-available (was: GeodeOperationAPI) > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > ** Total number of times handling a network search initiated by a remote > cache completed with success. > * handlingNetsearchesTime > ** Total time spent handling successful network searches for remote caches. > * handlingNetsearchesFailed > ** Total number of times handling a network search initiated by a remote > cache failed without success. > * handlingNetsearchesFailedTime > ** Total time spent handling failed network searches for remote caches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176621#comment-17176621 ] ASF GitHub Bot commented on GEODE-8422: --- mhansonp closed pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7948) LocatorUDPSecurityDUnitTest > testStartTwoLocatorsWithMultiKeystoreSSL FAILED
[
https://issues.apache.org/jira/browse/GEODE-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176617#comment-17176617
]
Jianxia Chen commented on GEODE-7948:
-
Failed in another test:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/DistributedTestOpenJDK11/builds/40
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0318/test-results/distributedTest/1595633409/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0318/test-artifacts/1595633409/distributedtestfiles-OpenJDK11-1.13.0-build.0318.tgz
> LocatorUDPSecurityDUnitTest > testStartTwoLocatorsWithMultiKeystoreSSL FAILED
> -
>
> Key: GEODE-7948
> URL: https://issues.apache.org/jira/browse/GEODE-7948
> Project: Geode
> Issue Type: Bug
> Components: ci
>Reporter: Ernest Burghardt
>Priority: Major
> Labels: flaky
>
>
> {code:java}
> java.io.EOFException: Locator at HostAndPort
> [socketInetAddress=2c3140cf3e20:29021] did not respond. This is normal if the
> locator was shutdown. If it wasn't check its log for exceptions.
> at
> org.apache.geode.distributed.internal.tcpserver.TcpClient.requestToServer(TcpClient.java:201)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.findCoordinator(GMSJoinLeave.java:1145)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.join(GMSJoinLeave.java:331)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.join(GMSMembership.java:573)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.access$1300(GMSMembership.java:71)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.joinDistributedSystem(GMSMembership.java:1972)
> at
> org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:242)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.start(GMSMembership.java:1851)
> at
> org.apache.geode.distributed.internal.DistributionImpl.start(DistributionImpl.java:171)
> at
> org.apache.geode.distributed.internal.DistributionImpl.createDistribution(DistributionImpl.java:222)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.(ClusterDistributionManager.java:464)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.(ClusterDistributionManager.java:497)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:326)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:779)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.access$200(InternalDistributedSystem.java:135)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem$Builder.build(InternalDistributedSystem.java:3033)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.connectInternal(InternalDistributedSystem.java:290)
> at
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:743)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:388)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:338)
> at org.apache.geode.distributed.Locator.startLocator(Locator.java:252)
> at
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:139)
> at
> org.apache.geode.distributed.LocatorDUnitTest.startLocatorWithPortAndProperties(LocatorDUnitTest.java:1507)
> at
> org.apache.geode.distributed.LocatorDUnitTest.lambda$startVerifyAndStopLocator$e21733f2$1(LocatorDUnitTest.java:1539)
> at
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run(IdentifiableRunnable.java:41)
> {code}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/9
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8429) CI failure: CQListGIIDUnitTest. testClientCQNotLostAtGIIReceiver
Jianxia Chen created GEODE-8429: --- Summary: CI failure: CQListGIIDUnitTest. testClientCQNotLostAtGIIReceiver Key: GEODE-8429 URL: https://issues.apache.org/jira/browse/GEODE-8429 Project: Geode Issue Type: Bug Reporter: Jianxia Chen https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/DistributedTestOpenJDK8/builds/52 org.apache.geode.internal.cache.ha.CQListGIIDUnitTest > testClientCQNotLostAtGIIReceiver FAILED org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.internal.cache.ha.CQListGIIDUnitTest$$Lambda$261/2063073488.run in VM 1 running on Host 9ddb94e9ce2a with 4 VMs at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610) at org.apache.geode.test.dunit.VM.invoke(VM.java:437) at org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.testClientCQNotLostAtGIIReceiver(CQListGIIDUnitTest.java:600) Caused by: java.lang.AssertionError: expected:<10> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.VerifyCUMCQList(CQListGIIDUnitTest.java:625) at org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.lambda$testClientCQNotLostAtGIIReceiver$efc18f56$2(CQListGIIDUnitTest.java:600) =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0323/test-results/distributedTest/1596479398/ =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test report artifacts from this job are available at: http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0323/test-artifacts/1596479398/distributedtestfiles-OpenJDK8-1.13.0-build.0323.tgz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8429) CI failure: CQListGIIDUnitTest. testClientCQNotLostAtGIIReceiver
[ https://issues.apache.org/jira/browse/GEODE-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianxia Chen updated GEODE-8429: Affects Version/s: 1.13.0 > CI failure: CQListGIIDUnitTest. testClientCQNotLostAtGIIReceiver > > > Key: GEODE-8429 > URL: https://issues.apache.org/jira/browse/GEODE-8429 > Project: Geode > Issue Type: Bug >Affects Versions: 1.13.0 >Reporter: Jianxia Chen >Priority: Major > > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/DistributedTestOpenJDK8/builds/52 > org.apache.geode.internal.cache.ha.CQListGIIDUnitTest > > testClientCQNotLostAtGIIReceiver FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ha.CQListGIIDUnitTest$$Lambda$261/2063073488.run > in VM 1 running on Host 9ddb94e9ce2a with 4 VMs > at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610) > at org.apache.geode.test.dunit.VM.invoke(VM.java:437) > at > org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.testClientCQNotLostAtGIIReceiver(CQListGIIDUnitTest.java:600) > Caused by: > java.lang.AssertionError: expected:<10> but was:<0> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:834) > at org.junit.Assert.assertEquals(Assert.java:645) > at org.junit.Assert.assertEquals(Assert.java:631) > at > org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.VerifyCUMCQList(CQListGIIDUnitTest.java:625) > at > org.apache.geode.internal.cache.ha.CQListGIIDUnitTest.lambda$testClientCQNotLostAtGIIReceiver$efc18f56$2(CQListGIIDUnitTest.java:600) > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0323/test-results/distributedTest/1596479398/ > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0323/test-artifacts/1596479398/distributedtestfiles-OpenJDK8-1.13.0-build.0323.tgz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176613#comment-17176613 ] ASF GitHub Bot commented on GEODE-8422: --- mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554888 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.cache; Review comment: done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[
https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176612#comment-17176612
]
ASF GitHub Bot commented on GEODE-8422:
---
mhansonp commented on a change in pull request #5447:
URL: https://github.com/apache/geode/pull/5447#discussion_r469554313
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java
##
@@ -0,0 +1,79 @@
+package org.apache.geode.internal.cache;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.concurrent.ExecutorService;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.distributed.internal.CacheTime;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionTag;
+
+public class TombstoneServiceTest {
+ CacheTime cacheTime = mock(CacheTime.class);
+ CachePerfStats stats = mock(CachePerfStats.class);
+ CancelCriterion cancelCriterion = mock(CancelCriterion.class);
+ ExecutorService executor = mock(ExecutorService.class);
+ RegionMap regionMap = mock(RegionMap.class);
+ RegionEntry entry = mock(RegionEntry.class);
+ DistributedRegion region = mock(DistributedRegion.class);
+ VersionTag destroyedVersion = mock(VersionTag.class);
+
+ @Before
+ public void setUp() throws Exception {}
+
+ @After
+ public void tearDown() throws Exception {}
+
+ @Test
+ public void
validateThatRemoveIsNotCalledOnTombstoneInRegionThatIsNotInitialized() {
+
+when(region.isInitialized()).thenReturn(false);
+when(region.getRegionMap()).thenReturn(regionMap);
+TombstoneService.ReplicateTombstoneSweeper replicateTombstoneSweeper =
+new TombstoneService.ReplicateTombstoneSweeper(cacheTime, stats,
+cancelCriterion, executor);
+TombstoneService.Tombstone tombstone =
+new TombstoneService.Tombstone(entry, region, destroyedVersion);
+tombstone.entry = entry;
+
+replicateTombstoneSweeper.expireTombstone(tombstone);
+replicateTombstoneSweeper.expireBatch();
+verify(regionMap, Mockito.never()).removeTombstone(tombstone.entry,
destroyedVersion, false,
+true);
+ }
+
+ @Test
+ public void validateThatRemoveIsCalledOnTombstoneInRegionThatIsInitialized()
{
+RegionVersionVector regionVersionVector = mock(RegionVersionVector.class);
+
+when(region.isInitialized()).thenReturn(true);
+when(region.getRegionMap()).thenReturn(regionMap);
+when(region.getVersionVector()).thenReturn(regionVersionVector);
+when(region.getDataPolicy()).thenReturn(DataPolicy.PERSISTENT_REPLICATE);
+when(region.getDiskRegion()).thenReturn(mock(DiskRegion.class));
+
+TombstoneService.ReplicateTombstoneSweeper replicateTombstoneSweeper =
+new TombstoneService.ReplicateTombstoneSweeper(cacheTime, stats,
+cancelCriterion, executor);
+TombstoneService.Tombstone tombstone =
+new TombstoneService.Tombstone(entry, region, destroyedVersion);
+tombstone.entry = entry;
+
+replicateTombstoneSweeper.expireTombstone(tombstone);
+replicateTombstoneSweeper.expireBatch();
+verify(region, Mockito.atLeastOnce()).getVersionVector();
+verify(regionVersionVector,
Mockito.atLeastOnce()).recordGCVersion(tombstone.getMemberID(),
Review comment:
changed the code to actually check a call to removeTombstone which is
what we really care about. Using times 1 now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Regions get out of sync if destroys happening during shutdown
> -
>
> Key: GEODE-8422
> URL: https://issues.apache.org/jira/browse/GEODE-8422
> Project: Geode
> Issue Type: Bug
> Components: general
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0, 1.14.0
>
>
> When a cluster of servers are being shutdown, while destroy operations are
> happening, in a small case, it is possible for the regions to get out of sync
> when delta GII is used.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8428) Update geode-redis README
[ https://issues.apache.org/jira/browse/GEODE-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176606#comment-17176606 ] ASF GitHub Bot commented on GEODE-8428: --- sabbeyPivotal opened a new pull request #5450: URL: https://github.com/apache/geode/pull/5450 Update geode-redis README with a short explanation of how to run a Geode server that accepts Redis commands. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update geode-redis README > -- > > Key: GEODE-8428 > URL: https://issues.apache.org/jira/browse/GEODE-8428 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Major > > Update geode-redis README with a short explanation of how to run a Geode > server that accepts Redis commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8428) Update geode-redis README
[ https://issues.apache.org/jira/browse/GEODE-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8428: -- Labels: pull-request-available (was: ) > Update geode-redis README > -- > > Key: GEODE-8428 > URL: https://issues.apache.org/jira/browse/GEODE-8428 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Update geode-redis README with a short explanation of how to run a Geode > server that accepts Redis commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8428) Update geode-redis README
Sarah Abbey created GEODE-8428: -- Summary: Update geode-redis README Key: GEODE-8428 URL: https://issues.apache.org/jira/browse/GEODE-8428 Project: Geode Issue Type: Improvement Components: redis Reporter: Sarah Abbey Update geode-redis README with a short explanation of how to run a Geode server that accepts Redis commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[
https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176600#comment-17176600
]
ASF GitHub Bot commented on GEODE-8422:
---
mhansonp commented on a change in pull request #5447:
URL: https://github.com/apache/geode/pull/5447#discussion_r469538956
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java
##
@@ -0,0 +1,79 @@
+package org.apache.geode.internal.cache;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.concurrent.ExecutorService;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.distributed.internal.CacheTime;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionTag;
+
+public class TombstoneServiceTest {
+ CacheTime cacheTime = mock(CacheTime.class);
+ CachePerfStats stats = mock(CachePerfStats.class);
+ CancelCriterion cancelCriterion = mock(CancelCriterion.class);
+ ExecutorService executor = mock(ExecutorService.class);
+ RegionMap regionMap = mock(RegionMap.class);
+ RegionEntry entry = mock(RegionEntry.class);
+ DistributedRegion region = mock(DistributedRegion.class);
+ VersionTag destroyedVersion = mock(VersionTag.class);
+
+ @Before
+ public void setUp() throws Exception {}
+
+ @After
+ public void tearDown() throws Exception {}
Review comment:
Done
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java
##
@@ -0,0 +1,79 @@
+package org.apache.geode.internal.cache;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.concurrent.ExecutorService;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.distributed.internal.CacheTime;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionTag;
+
+public class TombstoneServiceTest {
+ CacheTime cacheTime = mock(CacheTime.class);
+ CachePerfStats stats = mock(CachePerfStats.class);
+ CancelCriterion cancelCriterion = mock(CancelCriterion.class);
+ ExecutorService executor = mock(ExecutorService.class);
+ RegionMap regionMap = mock(RegionMap.class);
+ RegionEntry entry = mock(RegionEntry.class);
+ DistributedRegion region = mock(DistributedRegion.class);
+ VersionTag destroyedVersion = mock(VersionTag.class);
+
+ @Before
+ public void setUp() throws Exception {}
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Regions get out of sync if destroys happening during shutdown
> -
>
> Key: GEODE-8422
> URL: https://issues.apache.org/jira/browse/GEODE-8422
> Project: Geode
> Issue Type: Bug
> Components: general
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0, 1.14.0
>
>
> When a cluster of servers are being shutdown, while destroy operations are
> happening, in a small case, it is possible for the regions to get out of sync
> when delta GII is used.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[ https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176596#comment-17176596 ] ASF GitHub Bot commented on GEODE-8422: --- onichols-pivotal commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469534578 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.cache; Review comment: please include the standard apache copyright header This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Regions get out of sync if destroys happening during shutdown > - > > Key: GEODE-8422 > URL: https://issues.apache.org/jira/browse/GEODE-8422 > Project: Geode > Issue Type: Bug > Components: general >Affects Versions: 1.13.0, 1.14.0 >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > When a cluster of servers are being shutdown, while destroy operations are > happening, in a small case, it is possible for the regions to get out of sync > when delta GII is used. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8427) change redis to disconnect client instead of failing with memberDeparted
Darrel Schneider created GEODE-8427: --- Summary: change redis to disconnect client instead of failing with memberDeparted Key: GEODE-8427 URL: https://issues.apache.org/jira/browse/GEODE-8427 Project: Geode Issue Type: Improvement Components: redis Reporter: Darrel Schneider Currently when a redis operation fails because one of the servers departed while it was in progress an exception is thrown that contains "memberDeparted". Clients are required to handle this non-standard error message and decide if the operation should be retried or not. A better approach is to have the server close the client connection that the operation came in on. Some clients already handle this and support things like auto reconnect. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8331) allow GFSH to connect to newer and older locator/server
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Burcham updated GEODE-8331: Summary: allow GFSH to connect to newer and older locator/server (was: allow GFSH to connect to newer and older locator/server.) > allow GFSH to connect to newer and older locator/server > --- > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: docs, gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs
[
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176536#comment-17176536
]
Bill Burcham edited comment on GEODE-8267 at 8/12/20, 7:09 PM:
---
the failing test {{serverRestartHangsWaitingForStartupMessageResponse}} (not
the hung test) was added (by [~echobravo] and [~upthewaterspout]) as part of
this ticket a year ago (in July, 2019): GEODE-6904 _Reconnecting locator has
many hung threads, causing members to startup without cluster configuration_
was (Author: bburcham):
the test {{serverRestartHangsWaitingForStartupMessageResponse}} was added (by
[~echobravo] and [~upthewaterspout]) as part of this ticket a year ago (in
July, 2019): GEODE-6904 _Reconnecting locator has many hung threads, causing
members to startup without cluster configuration_
> serverRestartsAfterOneLocatorDies hangs
> ---
>
> Key: GEODE-8267
> URL: https://issues.apache.org/jira/browse/GEODE-8267
> Project: Geode
> Issue Type: Bug
> Components: configuration, locator, membership
>Reporter: Bill Burcham
>Priority: Major
>
> hang:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A]
>
> The test hung in serverRestartsAfterOneLocatorDies after another failure in
> the same test class.
> Here's the hung thread:
> {noformat}
> "Test worker" #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s
> tid=0x7f01c8ad4800 nid=0x18 runnable [0x7f019872c000]"Test worker"
> #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s tid=0x7f01c8ad4800
> nid=0x18 runnable [0x7f019872c000] java.lang.Thread.State: RUNNABLE at
> java.net.SocketInputStream.socketRead0(java.base@11.0.7/Native Method) at
> java.net.SocketInputStream.socketRead(java.base@11.0.7/SocketInputStream.java:115)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:168)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:140)
> at
> java.io.BufferedInputStream.fill(java.base@11.0.7/BufferedInputStream.java:252)
> at
> java.io.BufferedInputStream.read(java.base@11.0.7/BufferedInputStream.java:271)
> - locked <0xd08fe7a0> (a java.io.BufferedInputStream) at
> java.io.DataInputStream.readByte(java.base@11.0.7/DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(java.rmi@11.0.7/StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(java.rmi@11.0.7/UnicastRef.java:164) at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source) at
> org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607) at
> org.apache.geode.test.dunit.VM.invoke(VM.java:450) at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:268)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:261)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:256)
> at
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartsAfterOneLocatorDies(ClusterConfigLocatorRestartDUnitTest.java:114)
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.7/Native
> Method) {noformat}
> Here's the previous test failure, which may have affected the test that hung:
> {code:java}
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
> > serverRestartHangsWaitingForStartupMessageResponse FAILED
> org.junit.runners.model.TestTimedOutException: test timed out after
> 30 milliseconds
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at java.io.DataInputStream.readByte(DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.j
[jira] [Commented] (GEODE-8422) Regions get out of sync if destroys happening during shutdown
[
https://issues.apache.org/jira/browse/GEODE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176542#comment-17176542
]
ASF GitHub Bot commented on GEODE-8422:
---
DonalEvans commented on a change in pull request #5447:
URL: https://github.com/apache/geode/pull/5447#discussion_r469471781
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java
##
@@ -0,0 +1,79 @@
+package org.apache.geode.internal.cache;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.concurrent.ExecutorService;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.distributed.internal.CacheTime;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionTag;
+
+public class TombstoneServiceTest {
+ CacheTime cacheTime = mock(CacheTime.class);
+ CachePerfStats stats = mock(CachePerfStats.class);
+ CancelCriterion cancelCriterion = mock(CancelCriterion.class);
+ ExecutorService executor = mock(ExecutorService.class);
+ RegionMap regionMap = mock(RegionMap.class);
+ RegionEntry entry = mock(RegionEntry.class);
+ DistributedRegion region = mock(DistributedRegion.class);
+ VersionTag destroyedVersion = mock(VersionTag.class);
+
+ @Before
+ public void setUp() throws Exception {}
+
+ @After
+ public void tearDown() throws Exception {}
Review comment:
This method is empty and can be removed.
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java
##
@@ -0,0 +1,79 @@
+package org.apache.geode.internal.cache;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.concurrent.ExecutorService;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.distributed.internal.CacheTime;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionTag;
+
+public class TombstoneServiceTest {
+ CacheTime cacheTime = mock(CacheTime.class);
+ CachePerfStats stats = mock(CachePerfStats.class);
+ CancelCriterion cancelCriterion = mock(CancelCriterion.class);
+ ExecutorService executor = mock(ExecutorService.class);
+ RegionMap regionMap = mock(RegionMap.class);
+ RegionEntry entry = mock(RegionEntry.class);
+ DistributedRegion region = mock(DistributedRegion.class);
+ VersionTag destroyedVersion = mock(VersionTag.class);
+
+ @Before
+ public void setUp() throws Exception {}
+
+ @After
+ public void tearDown() throws Exception {}
+
+ @Test
+ public void
validateThatRemoveIsNotCalledOnTombstoneInRegionThatIsNotInitialized() {
+
+when(region.isInitialized()).thenReturn(false);
+when(region.getRegionMap()).thenReturn(regionMap);
+TombstoneService.ReplicateTombstoneSweeper replicateTombstoneSweeper =
+new TombstoneService.ReplicateTombstoneSweeper(cacheTime, stats,
+cancelCriterion, executor);
+TombstoneService.Tombstone tombstone =
+new TombstoneService.Tombstone(entry, region, destroyedVersion);
+tombstone.entry = entry;
+
+replicateTombstoneSweeper.expireTombstone(tombstone);
+replicateTombstoneSweeper.expireBatch();
+verify(regionMap, Mockito.never()).removeTombstone(tombstone.entry,
destroyedVersion, false,
+true);
+ }
+
+ @Test
+ public void validateThatRemoveIsCalledOnTombstoneInRegionThatIsInitialized()
{
+RegionVersionVector regionVersionVector = mock(RegionVersionVector.class);
+
+when(region.isInitialized()).thenReturn(true);
+when(region.getRegionMap()).thenReturn(regionMap);
+when(region.getVersionVector()).thenReturn(regionVersionVector);
+when(region.getDataPolicy()).thenReturn(DataPolicy.PERSISTENT_REPLICATE);
+when(region.getDiskRegion()).thenReturn(mock(DiskRegion.class));
+
+TombstoneService.ReplicateTombstoneSweeper replicateTombstoneSweeper =
+new TombstoneService.ReplicateTombstoneSweeper(cacheTime, stats,
+cancelCriterion, executor);
+TombstoneService.Tombstone tombstone =
+new TombstoneService.Tombstone(entry, region, destroyedVersion);
+tombstone.entry = entry;
+
+replicateTombstoneSweeper.expireTombstone(tombstone);
+replicateTombstoneSweeper.expireBatch();
+verify(region, Mockito.atLeastOnce()).getVersionVector();
+verify(regionVersionVector,
Mockito.atLeastOnce()).recordGCVersion(tombstone.getMemberID(),
Review
[jira] [Assigned] (GEODE-8426) Enforce warning no-shorten-64-to-32
[
https://issues.apache.org/jira/browse/GEODE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Oleske reassigned GEODE-8426:
-
Assignee: Michael Oleske
> Enforce warning no-shorten-64-to-32
> ---
>
> Key: GEODE-8426
> URL: https://issues.apache.org/jira/browse/GEODE-8426
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Oleske
>Assignee: Michael Oleske
>Priority: Major
>
> remove {{-Wno-shorten-64-to-32}} since it looks like it was already fixed by
> others
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs
[
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176536#comment-17176536
]
Bill Burcham edited comment on GEODE-8267 at 8/12/20, 6:47 PM:
---
the test {{serverRestartHangsWaitingForStartupMessageResponse}} was added (by
[~echobravo] and [~upthewaterspout]) as part of this ticket a year ago (in
July, 2019): GEODE-6904 _Reconnecting locator has many hung threads, causing
members to startup without cluster configuration_
was (Author: bburcham):
the test `serverRestartHangsWaitingForStartupMessageResponse` was added (by
[~echobravo] and [~upthewaterspout]) as part of this ticket a year ago (in
July, 2019): GEODE-6904 _Reconnecting locator has many hung threads, causing
members to startup without cluster configuration_
> serverRestartsAfterOneLocatorDies hangs
> ---
>
> Key: GEODE-8267
> URL: https://issues.apache.org/jira/browse/GEODE-8267
> Project: Geode
> Issue Type: Bug
> Components: configuration, locator, membership
>Reporter: Bill Burcham
>Priority: Major
>
> hang:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A]
>
> The test hung in serverRestartsAfterOneLocatorDies after another failure in
> the same test class.
> Here's the hung thread:
> {noformat}
> "Test worker" #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s
> tid=0x7f01c8ad4800 nid=0x18 runnable [0x7f019872c000]"Test worker"
> #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s tid=0x7f01c8ad4800
> nid=0x18 runnable [0x7f019872c000] java.lang.Thread.State: RUNNABLE at
> java.net.SocketInputStream.socketRead0(java.base@11.0.7/Native Method) at
> java.net.SocketInputStream.socketRead(java.base@11.0.7/SocketInputStream.java:115)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:168)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:140)
> at
> java.io.BufferedInputStream.fill(java.base@11.0.7/BufferedInputStream.java:252)
> at
> java.io.BufferedInputStream.read(java.base@11.0.7/BufferedInputStream.java:271)
> - locked <0xd08fe7a0> (a java.io.BufferedInputStream) at
> java.io.DataInputStream.readByte(java.base@11.0.7/DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(java.rmi@11.0.7/StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(java.rmi@11.0.7/UnicastRef.java:164) at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source) at
> org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607) at
> org.apache.geode.test.dunit.VM.invoke(VM.java:450) at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:268)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:261)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:256)
> at
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartsAfterOneLocatorDies(ClusterConfigLocatorRestartDUnitTest.java:114)
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.7/Native
> Method) {noformat}
> Here's the previous test failure, which may have affected the test that hung:
> {code:java}
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
> > serverRestartHangsWaitingForStartupMessageResponse FAILED
> org.junit.runners.model.TestTimedOutException: test timed out after
> 30 milliseconds
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at java.io.DataInputStream.readByte(DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)
> at com.sun.
[jira] [Commented] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs
[
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176536#comment-17176536
]
Bill Burcham commented on GEODE-8267:
-
the test `serverRestartHangsWaitingForStartupMessageResponse` was added (by
[~echobravo] and [~upthewaterspout]) as part of this ticket a year ago (in
July, 2019): GEODE-6904 _Reconnecting locator has many hung threads, causing
members to startup without cluster configuration_
> serverRestartsAfterOneLocatorDies hangs
> ---
>
> Key: GEODE-8267
> URL: https://issues.apache.org/jira/browse/GEODE-8267
> Project: Geode
> Issue Type: Bug
> Components: configuration, locator, membership
>Reporter: Bill Burcham
>Priority: Major
>
> hang:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A]
>
> The test hung in serverRestartsAfterOneLocatorDies after another failure in
> the same test class.
> Here's the hung thread:
> {noformat}
> "Test worker" #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s
> tid=0x7f01c8ad4800 nid=0x18 runnable [0x7f019872c000]"Test worker"
> #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s tid=0x7f01c8ad4800
> nid=0x18 runnable [0x7f019872c000] java.lang.Thread.State: RUNNABLE at
> java.net.SocketInputStream.socketRead0(java.base@11.0.7/Native Method) at
> java.net.SocketInputStream.socketRead(java.base@11.0.7/SocketInputStream.java:115)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:168)
> at
> java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:140)
> at
> java.io.BufferedInputStream.fill(java.base@11.0.7/BufferedInputStream.java:252)
> at
> java.io.BufferedInputStream.read(java.base@11.0.7/BufferedInputStream.java:271)
> - locked <0xd08fe7a0> (a java.io.BufferedInputStream) at
> java.io.DataInputStream.readByte(java.base@11.0.7/DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(java.rmi@11.0.7/StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(java.rmi@11.0.7/UnicastRef.java:164) at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source) at
> org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607) at
> org.apache.geode.test.dunit.VM.invoke(VM.java:450) at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:268)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:261)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:256)
> at
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartsAfterOneLocatorDies(ClusterConfigLocatorRestartDUnitTest.java:114)
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.7/Native
> Method) {noformat}
> Here's the previous test failure, which may have affected the test that hung:
> {code:java}
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
> > serverRestartHangsWaitingForStartupMessageResponse FAILED
> org.junit.runners.model.TestTimedOutException: test timed out after
> 30 milliseconds
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at java.io.DataInputStream.readByte(DataInputStream.java:270)
> at
> sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
> at
> java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source)
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:437)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:94)
> at
> org.apache.geode.management.internal.configuration.ClusterCon
[jira] [Created] (GEODE-8426) Enforce warning no-shorten-64-to-32
Michael Oleske created GEODE-8426:
-
Summary: Enforce warning no-shorten-64-to-32
Key: GEODE-8426
URL: https://issues.apache.org/jira/browse/GEODE-8426
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Michael Oleske
remove {{-Wno-shorten-64-to-32}} since it looks like it was already fixed by
others
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-8425: - Labels: GeodeOperationAPI (was: ) > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > ** Total number of times handling a network search initiated by a remote > cache completed with success. > * handlingNetsearchesTime > ** Total time spent handling successful network searches for remote caches. > * handlingNetsearchesFailed > ** Total number of times handling a network search initiated by a remote > cache failed without success. > * handlingNetsearchesFailedTime > ** Total time spent handling failed network searches for remote caches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-8425: Assignee: Kirk Lund > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > ** Total number of times handling a network search initiated by a remote > cache completed with success. > * handlingNetsearchesTime > ** Total time spent handling successful network searches for remote caches. > * handlingNetsearchesFailed > ** Total number of times handling a network search initiated by a remote > cache failed without success. > * handlingNetsearchesFailedTime > ** Total time spent handling failed network searches for remote caches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-8425: - Description: Add stats for handling netsearches to CachePerfStats: * handlingNetsearchesInProgress ** Current number of threads handling a network search initiated by a remote cache. * handlingNetsearchesCompleted ** Total number of times handling a network search initiated by a remote cache completed with success. * handlingNetsearchesTime ** Total time spent handling successful network searches for remote caches. * handlingNetsearchesFailed ** Total number of times handling a network search initiated by a remote cache failed without success. * handlingNetsearchesFailedTime ** Total time spent handling failed network searches for remote caches. was: Add stats for handling netsearches to CachePerfStats: * handlingNetsearchesInProgress ** Current number of threads handling a network search initiated by a remote cache. * handlingNetsearchesCompleted * handlingNetsearchesTime * handlingNetsearchesFailed * handlingNetsearchesFailedTime > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Priority: Major > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > ** Total number of times handling a network search initiated by a remote > cache completed with success. > * handlingNetsearchesTime > ** Total time spent handling successful network searches for remote caches. > * handlingNetsearchesFailed > ** Total number of times handling a network search initiated by a remote > cache failed without success. > * handlingNetsearchesFailedTime > ** Total time spent handling failed network searches for remote caches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
[ https://issues.apache.org/jira/browse/GEODE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-8425: - Description: Add stats for handling netsearches to CachePerfStats: * handlingNetsearchesInProgress ** Current number of threads handling a network search initiated by a remote cache. * handlingNetsearchesCompleted * handlingNetsearchesTime * handlingNetsearchesFailed * handlingNetsearchesFailedTime was: Add stats for handling netsearches to CachePerfStats: * handlingNetsearchesInProgress * handlingNetsearchesCompleted * handlingNetsearchesTime * handlingNetsearchesFailed * handlingNetsearchesFailedTime > Add stats for handling netsearches to CachePerfStats > > > Key: GEODE-8425 > URL: https://issues.apache.org/jira/browse/GEODE-8425 > Project: Geode > Issue Type: Wish > Components: regions, statistics >Reporter: Kirk Lund >Priority: Major > > Add stats for handling netsearches to CachePerfStats: > * handlingNetsearchesInProgress > ** Current number of threads handling a network search initiated by a remote > cache. > * handlingNetsearchesCompleted > * handlingNetsearchesTime > * handlingNetsearchesFailed > * handlingNetsearchesFailedTime -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8425) Add stats for handling netsearches to CachePerfStats
Kirk Lund created GEODE-8425: Summary: Add stats for handling netsearches to CachePerfStats Key: GEODE-8425 URL: https://issues.apache.org/jira/browse/GEODE-8425 Project: Geode Issue Type: Wish Components: regions, statistics Reporter: Kirk Lund Add stats for handling netsearches to CachePerfStats: * handlingNetsearchesInProgress * handlingNetsearchesCompleted * handlingNetsearchesTime * handlingNetsearchesFailed * handlingNetsearchesFailedTime -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8424) Updates Redis API for Geode docs 1.14
Darrel Schneider created GEODE-8424: --- Summary: Updates Redis API for Geode docs 1.14 Key: GEODE-8424 URL: https://issues.apache.org/jira/browse/GEODE-8424 Project: Geode Issue Type: Improvement Components: docs, redis Reporter: Darrel Schneider The docs should be updated to describe the Redis API for the upcoming 1.14 release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8424) Updates Redis API for Geode docs 1.14
[ https://issues.apache.org/jira/browse/GEODE-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider reassigned GEODE-8424: --- Assignee: Darrel Schneider > Updates Redis API for Geode docs 1.14 > - > > Key: GEODE-8424 > URL: https://issues.apache.org/jira/browse/GEODE-8424 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > > The docs should be updated to describe the Redis API for the upcoming 1.14 > release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider updated GEODE-8423: Comment: was deleted (was: This fix was cherry-picked to 1.13 here: cd0a8459ac3cde8b714788444f2913a6b0f6bbf0) > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176518#comment-17176518 ] Darrel Schneider commented on GEODE-8423: - This fix was cherry-picked to 1.13 here: cd0a8459ac3cde8b714788444f2913a6b0f6bbf0 > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176517#comment-17176517 ] ASF subversion and git services commented on GEODE-8423: Commit cd0a8459ac3cde8b714788444f2913a6b0f6bbf0 in geode's branch refs/heads/support/1.13 from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cd0a845 ] GEODE-8423: Updates Redis API for Geode docs 1.13 (#5449) (cherry picked from commit 140de5d28ba842c6d00c7226ac293d531feb7bfc) > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider updated GEODE-8423: Fix Version/s: 1.13.0 > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.14.0 > > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7960) CI: SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion FAILED on Windows
[
https://issues.apache.org/jira/browse/GEODE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176472#comment-17176472
]
Jianxia Chen commented on GEODE-7960:
-
Reproduced again:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK8/builds/389
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0274/test-results/test/1597248561/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0274/test-artifacts/1597248561/windows-unittestfiles-OpenJDK8-1.14.0-build.0274.tgz
> CI: SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion
> FAILED on Windows
>
>
> Key: GEODE-7960
> URL: https://issues.apache.org/jira/browse/GEODE-7960
> Project: Geode
> Issue Type: Bug
> Components: logging
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>Priority: Major
>
> Looks like a flaky test on windows:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/21
> {noformat}
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest
> > logsMissingChildRegionUntilCompletion FAILED
> org.mockito.exceptions.verification.NoInteractionsWanted:
> No interactions wanted here:
> -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion(SingleThreadColocationLoggerTest.java:180)
> But found this interaction on mock 'consumer':
> -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> ***
> For your reference, here is the list of all invocations ([?] - means
> unverified).
> 1. -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> 2. [?]-> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion(SingleThreadColocationLoggerTest.java:180)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8323) Need to correctly process QueueRemovalMessage during HARegionQueue initialization
[ https://issues.apache.org/jira/browse/GEODE-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8323: --- Fix Version/s: 1.13.0 > Need to correctly process QueueRemovalMessage during HARegionQueue > initialization > - > > Key: GEODE-8323 > URL: https://issues.apache.org/jira/browse/GEODE-8323 > Project: Geode > Issue Type: Bug > Components: client queues >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > Fix For: 1.13.0, 1.14.0 > > > Currently, these events in queue removal message are ignored as the idea is > that correct setting of messageTimeToLive and > subscriptionMessageTrackingTimeout should prevent a previous seen event > replayed on a client. > However, it failover scenario occurs, a restarted/newly joined member could > gii from a secondary HARegionQueue which has those events not removed by the > QRM. As the restarted member starts the timer for messageTimeToLive after it > restarted. The event could live longer than the messageTimeToLive setting if > starts from the original operation time. If this time is longer than the > subscriptionMessageTrackingTimeout setting on the client, the client will not > prevent the replay of the stray event. This could leads to data inconsistency > between client and server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-8423. - Fix Version/s: 1.14.0 Resolution: Fixed > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176435#comment-17176435 ] ASF subversion and git services commented on GEODE-8423: Commit 140de5d28ba842c6d00c7226ac293d531feb7bfc in geode's branch refs/heads/develop from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=140de5d ] GEODE-8423: Updates Redis API for Geode docs 1.13 (#5449) > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176434#comment-17176434 ] ASF subversion and git services commented on GEODE-8423: Commit 140de5d28ba842c6d00c7226ac293d531feb7bfc in geode's branch refs/heads/develop from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=140de5d ] GEODE-8423: Updates Redis API for Geode docs 1.13 (#5449) > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8423) Updates Redis API for Geode docs 1.13
[ https://issues.apache.org/jira/browse/GEODE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176433#comment-17176433 ] ASF GitHub Bot commented on GEODE-8423: --- dschneider-pivotal merged pull request #5449: URL: https://github.com/apache/geode/pull/5449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Updates Redis API for Geode docs 1.13 > - > > Key: GEODE-8423 > URL: https://issues.apache.org/jira/browse/GEODE-8423 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Documentation for Redis API for Geode that will currently be published for > 1.13 are not accurate and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
