[jira] [Updated] (GEODE-9386) google-windows-geode-builder image doesn't properly delete geode directory after dependency caching
[ https://issues.apache.org/jira/browse/GEODE-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-9386: Fix Version/s: (was: 1.13.3) 1.13.4 > google-windows-geode-builder image doesn't properly delete geode directory > after dependency caching > --- > > Key: GEODE-9386 > URL: https://issues.apache.org/jira/browse/GEODE-9386 > Project: Geode > Issue Type: Bug > Components: ci >Affects Versions: 1.15.0 >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.4, 1.14.0, 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9386) google-windows-geode-builder image doesn't properly delete geode directory after dependency caching
[ https://issues.apache.org/jira/browse/GEODE-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-9386: Fix Version/s: 1.13.3 1.14.0 > google-windows-geode-builder image doesn't properly delete geode directory > after dependency caching > --- > > Key: GEODE-9386 > URL: https://issues.apache.org/jira/browse/GEODE-9386 > Project: Geode > Issue Type: Bug > Components: ci >Affects Versions: 1.15.0 >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.3, 1.14.0, 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371812#comment-17371812
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r661131144
##
File path: netcore/NetCore/CacheFactory.cs
##
@@ -0,0 +1,129 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using System.Runtime.InteropServices;
+
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
Review comment:
Yes, C# supports a single line namespace.
```C#
namespace Apache.Geode.Client {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9405) Build fails on rhel-8 release
[
https://issues.apache.org/jira/browse/GEODE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371804#comment-17371804
]
ASF GitHub Bot commented on GEODE-9405:
---
pivotal-jbarrett commented on a change in pull request #826:
URL: https://github.com/apache/geode-native/pull/826#discussion_r661123304
##
File path: cppcache/integration-test/CMakeLists.txt
##
@@ -205,7 +205,7 @@ set_tests_properties(
testThinClientPoolAttrTest
testThinClientPoolLocator
testThinClientPoolRedundancy
-testThinClientSecurityAuthentication
+#testThinClientSecurityAuthentication
Review comment:
Delete?
##
File path: cppcache/integration-test/testThinClientSecurityAuthentication.cpp
##
@@ -138,7 +140,7 @@ DUNIT_TASK_DEFINITION(LOCATORSERVER, CreateServer1)
printf("Input to server cmd is --> %s",
cmdServerAuthenticator.c_str());
CacheHelper::initServer(
-1, nullptr, locHostPort,
+1, "cacheserver_notify_subscription.xml", locHostPort,
Review comment:
Wouldn't this change the intent of the test now that it starts with a
cache xml file?
##
File path: cppcache/integration-test/testThinClientSecurityAuthentication.cpp
##
@@ -138,7 +140,7 @@ DUNIT_TASK_DEFINITION(LOCATORSERVER, CreateServer1)
printf("Input to server cmd is --> %s",
cmdServerAuthenticator.c_str());
CacheHelper::initServer(
-1, nullptr, locHostPort,
+1, "cacheserver_notify_subscription.xml", locHostPort,
const_cast(cmdServerAuthenticator.c_str()));
Review comment:
This should be fixed too. Really bad to be taking stripping the `const`
off here. The funny thing is the method takes a `const`. The method should
really be change to take a `const std::string&`. I know this might feel out of
scope but it's right there!
##
File path: cppcache/integration-test/testThinClientSecurityAuthorization.cpp
##
@@ -54,13 +54,15 @@ const std::string locHostPort =
std::shared_ptr credentialGeneratorHandler;
std::string getXmlPath() {
- char xmlPath[1000] = {'\0'};
- const char *path = std::getenv("TESTSRC");
- ASSERT(path != nullptr,
+ std::string path = std::string(std::getenv("TESTSRC"));
Review comment:
Use `auto` on the lefthand side whenever you can. Almost all the new
code should be corrected to use auto for all these local variables.
##
File path: cppcache/integration-test/ThinClientSecurityHelper.hpp
##
@@ -59,13 +59,15 @@ const char* regionNamesAuth[] = {"DistRegionAck"};
std::shared_ptr credentialGeneratorHandler;
std::string getXmlPath() {
- char xmlPath[1000] = {'\0'};
- const char* path = std::getenv("TESTSRC");
- ASSERT(path != nullptr,
+ std::string path = std::string(std::getenv("TESTSRC"));
+
+ int indexOfCppcache = path.find("cppcache");
Review comment:
We use boost::filesystem elsewhere so using it here to make file path
operations safe would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build fails on rhel-8 release
> -
>
> Key: GEODE-9405
> URL: https://issues.apache.org/jira/browse/GEODE-9405
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Labels: pull-request-available
>
> Looks like a recent gcc compiler change on rhel-8 is causing build failures
> in the CI.
> Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9407) RegionDestroyedException while executing GetMemberInformationFunction
[
https://issues.apache.org/jira/browse/GEODE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Lindsey updated GEODE-9407:
-
Priority: Minor (was: Major)
> RegionDestroyedException while executing GetMemberInformationFunction
> -
>
> Key: GEODE-9407
> URL: https://issues.apache.org/jira/browse/GEODE-9407
> Project: Geode
> Issue Type: Bug
> Components: gfsh, management
>Reporter: Aaron Lindsey
>Priority: Minor
>
> GetMemberInformationFunction is used by the gfsh "describe member" command,
> the management REST API "/members" endpoint, and is also used internally
> within Geode. If this function is invoked while concurrently destroying a
> region, it may throw RegionDestroyedException while trying to gather
> information about the destroyed region's subregions.
>
> This bug manifests as a nasty error message in the logs of the member where
> the function was being executed (shown below). This confuses Geode
> users/developers/operators because it looks like a problem with the system
> while instead it's actually expected behavior. GetMemberInformationFunction
> should probably catch RegionDestroyedException and remove the destroyed
> region from the set of region names in ManagementUtils.getAllRegionNames.
>
> {code:java}
> [error 2021/06/29 23:01:38.640 GMT system-test-gemfire-server-0 Execution Processor3> tid=0x94] Unable to gather runtime information on this
> member.
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region @79f60edb
> [path='/region'; dataPolicy=PARTITION; prId=37; isDestroyed=true;
> isClosed=false; retryTimeout=360; serialNumber=4309; partition
> attributes=PartitionAttributes@1299510666[redundantCopies=2;localMaxMemory=594;totalMaxMemory=2147483647;totalNumBuckets=113;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on VM system-test-gemfire-server-0(system-test-gemfire-server-0:1):41000]
> at
> org.apache.geode.internal.cache.LocalRegion.checkRegionDestroyed(LocalRegion.java:7342)
> at
> org.apache.geode.internal.cache.LocalRegion.checkReadiness(LocalRegion.java:2757)
> at
> org.apache.geode.internal.cache.LocalRegion.subregions(LocalRegion.java:1908)
> at
> org.apache.geode.management.internal.util.ManagementUtils.getAllRegionNames(ManagementUtils.java:167)
> at
> org.apache.geode.management.internal.functions.GetMemberInformationFunction.getMemberInformation(GetMemberInformationFunction.java:131)
> at
> org.apache.geode.management.internal.configuration.realizers.MemberRealizer.get(MemberRealizer.java:52)
> at
> org.apache.geode.management.internal.configuration.realizers.MemberRealizer.get(MemberRealizer.java:35)
> at
> org.apache.geode.management.internal.functions.CacheRealizationFunction.executeGet(CacheRealizationFunction.java:136)
> at
> org.apache.geode.management.internal.functions.CacheRealizationFunction.execute(CacheRealizationFunction.java:92)
> at
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:201)
> at
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
> at
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:441)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:444)
> at
> org.apache.geode.distributed.internal.ClusterOperationExecutors.doFunctionExecutionThread(ClusterOperationExecutors.java:379)
> at
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:120)
> at java.base/java.lang.Thread.run(Thread.java:829){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9407) RegionDestroyedException while executing GetMemberInformationFunction
Aaron Lindsey created GEODE-9407:
Summary: RegionDestroyedException while executing
GetMemberInformationFunction
Key: GEODE-9407
URL: https://issues.apache.org/jira/browse/GEODE-9407
Project: Geode
Issue Type: Bug
Components: gfsh, management
Reporter: Aaron Lindsey
GetMemberInformationFunction is used by the gfsh "describe member" command, the
management REST API "/members" endpoint, and is also used internally within
Geode. If this function is invoked while concurrently destroying a region, it
may throw RegionDestroyedException while trying to gather information about the
destroyed region's subregions.
This bug manifests as a nasty error message in the logs of the member where the
function was being executed (shown below). This confuses Geode
users/developers/operators because it looks like a problem with the system
while instead it's actually expected behavior. GetMemberInformationFunction
should probably catch RegionDestroyedException and remove the destroyed region
from the set of region names in ManagementUtils.getAllRegionNames.
{code:java}
[error 2021/06/29 23:01:38.640 GMT system-test-gemfire-server-0 tid=0x94] Unable to gather runtime information on this
member.
org.apache.geode.cache.RegionDestroyedException: Partitioned Region @79f60edb
[path='/region'; dataPolicy=PARTITION; prId=37; isDestroyed=true;
isClosed=false; retryTimeout=360; serialNumber=4309; partition
attributes=PartitionAttributes@1299510666[redundantCopies=2;localMaxMemory=594;totalMaxMemory=2147483647;totalNumBuckets=113;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
on VM system-test-gemfire-server-0(system-test-gemfire-server-0:1):41000]
at
org.apache.geode.internal.cache.LocalRegion.checkRegionDestroyed(LocalRegion.java:7342)
at
org.apache.geode.internal.cache.LocalRegion.checkReadiness(LocalRegion.java:2757)
at
org.apache.geode.internal.cache.LocalRegion.subregions(LocalRegion.java:1908)
at
org.apache.geode.management.internal.util.ManagementUtils.getAllRegionNames(ManagementUtils.java:167)
at
org.apache.geode.management.internal.functions.GetMemberInformationFunction.getMemberInformation(GetMemberInformationFunction.java:131)
at
org.apache.geode.management.internal.configuration.realizers.MemberRealizer.get(MemberRealizer.java:52)
at
org.apache.geode.management.internal.configuration.realizers.MemberRealizer.get(MemberRealizer.java:35)
at
org.apache.geode.management.internal.functions.CacheRealizationFunction.executeGet(CacheRealizationFunction.java:136)
at
org.apache.geode.management.internal.functions.CacheRealizationFunction.execute(CacheRealizationFunction.java:92)
at
org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:201)
at
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:441)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:444)
at
org.apache.geode.distributed.internal.ClusterOperationExecutors.doFunctionExecutionThread(ClusterOperationExecutors.java:379)
at
org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:120)
at java.base/java.lang.Thread.run(Thread.java:829){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9006) MemoryStatsNativeRedisAcceptanceTest CI failure
[
https://issues.apache.org/jira/browse/GEODE-9006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371731#comment-17371731
]
Donal Evans commented on GEODE-9006:
There is currently a PR up to backport the fix for this to 1.14, so it should
be fixed on 1.14 as soon as that gets approved and merged:
https://github.com/apache/geode/pull/6568. It was originally marked as a 1.14
blocker but this label was removed as it was thought that the backport would be
too difficult. This turned out not to be the case, so a belated backport is now
ready to go.
> MemoryStatsNativeRedisAcceptanceTest CI failure
> ---
>
> Key: GEODE-9006
> URL: https://issues.apache.org/jira/browse/GEODE-9006
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Ray Ingles
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> CI failure:
> {{org.apache.geode.redis.internal.executor.server.MemoryStatsNativeRedisAcceptanceTest
> > usedMemory_shouldReflectActualMemoryUsage FAILED
> java.lang.AssertionError:
> Expecting:
> 854912L
> to be greater than:
> 855176L}}
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK11/builds/51]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9006) MemoryStatsNativeRedisAcceptanceTest CI failure
[
https://issues.apache.org/jira/browse/GEODE-9006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371693#comment-17371693
]
Alexander Murmann commented on GEODE-9006:
--
Removed release blocker as I understand that 1.14 will still ship with Redis as
experimental
> MemoryStatsNativeRedisAcceptanceTest CI failure
> ---
>
> Key: GEODE-9006
> URL: https://issues.apache.org/jira/browse/GEODE-9006
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Ray Ingles
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> CI failure:
> {{org.apache.geode.redis.internal.executor.server.MemoryStatsNativeRedisAcceptanceTest
> > usedMemory_shouldReflectActualMemoryUsage FAILED
> java.lang.AssertionError:
> Expecting:
> 854912L
> to be greater than:
> 855176L}}
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK11/builds/51]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9374) CI Failure: RestoreRedundancyOperationDUnitTest > statsAreUpdatedWhenRestoreRedundancyIsCalled
[
https://issues.apache.org/jira/browse/GEODE-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Murmann reassigned GEODE-9374:
Assignee: Donal Evans
> CI Failure: RestoreRedundancyOperationDUnitTest >
> statsAreUpdatedWhenRestoreRedundancyIsCalled
> --
>
> Key: GEODE-9374
> URL: https://issues.apache.org/jira/browse/GEODE-9374
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: blocks-1.14.0, flaky, pull-request-available
>
> {noformat}
> org.apache.geode.internal.cache.control.RestoreRedundancyOperationDUnitTest >
> statsAreUpdatedWhenRestoreRedundancyIsCalled FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.control.RestoreRedundancyOperationDUnitTest$$Lambda$87/347190495.run
> in VM 1 running on Host 72dc24287840 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:94)
> at
> org.apache.geode.internal.cache.control.RestoreRedundancyOperationDUnitTest.statsAreUpdatedWhenRestoreRedundancyIsCalled(RestoreRedundancyOperationDUnitTest.java:108)
> Caused by:
> java.lang.AssertionError:
> Expected: <0L>
> but: was <1L>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:964)
> at org.junit.Assert.assertThat(Assert.java:930)
> at
> org.apache.geode.internal.cache.control.RestoreRedundancyOperationDUnitTest.lambda$statsAreUpdatedWhenRestoreRedundancyIsCalled$bb17a952$1(RestoreRedundancyOperationDUnitTest.java:114)
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.0-build.0759/test-results/distributedTest/1618882514/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.0-build.0759/test-artifacts/1618882514/distributedtestfiles-OpenJDK8-1.14.0-build.0759.tgz
> Seen in the support/1.14 pipeline. This test has never been reported to fail
> before, so this is likely a flaky failure that could be fixed by using an
> await() for the stat to have the expected value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9006) MemoryStatsNativeRedisAcceptanceTest CI failure
[
https://issues.apache.org/jira/browse/GEODE-9006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Murmann updated GEODE-9006:
-
Labels: pull-request-available (was: blocks-1.14.0 pull-request-available)
> MemoryStatsNativeRedisAcceptanceTest CI failure
> ---
>
> Key: GEODE-9006
> URL: https://issues.apache.org/jira/browse/GEODE-9006
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Ray Ingles
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> CI failure:
> {{org.apache.geode.redis.internal.executor.server.MemoryStatsNativeRedisAcceptanceTest
> > usedMemory_shouldReflectActualMemoryUsage FAILED
> java.lang.AssertionError:
> Expecting:
> 854912L
> to be greater than:
> 855176L}}
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK11/builds/51]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7710) CI Failure: JMXMBeanReconnectDUnitTest aka JmxServerReconnectDistributedTest fails intermittently because one locator is missing the LockServiceMXBean
[
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371690#comment-17371690
]
Geode Integration commented on GEODE-7710:
--
Seen in [distributed-test-openjdk11
#60|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/distributed-test-openjdk11/builds/60]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0340/test-results/distributedTest/1624999580/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0340/test-artifacts/1624999580/distributedtestfiles-openjdk11-1.15.0-build.0340.tgz].
> CI Failure: JMXMBeanReconnectDUnitTest aka JmxServerReconnectDistributedTest
> fails intermittently because one locator is missing the LockServiceMXBean
> --
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, flaky, pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender closed GEODE-9406.
---
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-9406.
-
Resolution: Fixed
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371674#comment-17371674
]
ASF GitHub Bot commented on GEODE-9406:
---
pdxcodemonkey merged pull request #827:
URL: https://github.com/apache/geode-native/pull/827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371673#comment-17371673
]
ASF subversion and git services commented on GEODE-9406:
Commit f261b10877bcd4f09f1af373d005d400fd4e2c4b in geode-native's branch
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f261b10 ]
GEODE-9406: Report DSCode (type) for PDX values in gnmsg (#827)
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371627#comment-17371627
]
ASF GitHub Bot commented on GEODE-9406:
---
pdxcodemonkey opened a new pull request #827:
URL: https://github.com/apache/geode-native/pull/827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9406:
--
Labels: pull-request-available (was: )
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender reassigned GEODE-9406:
---
Assignee: Blake Bender
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender updated GEODE-9406:
Description:
The geode-native logger has a hard limit of 8KB for log strings, so for client
logs with large values (typically PUT messages with large objects like PDX
instances), the hex dump of the message in the log file will be truncated and
thus not fully decodable. The current version of `gnmsg` generically catches
exceptions due to truncated messages at top-level, and outputs JSON that looks
something like this:
{code:java}
"Value": {
"Size": 401767,
"IsObject": 1
},
"ERROR": "Exception reading message - probably incomplete"
} {code}
For `PUT` messages, at least, we can do slightly better, and at least dump the
type of the value in the message, which is probably of interest. Here's an
example:
{code:java}
"Value": {
"Size": 401767,
"IsObject": 1,
"Data": {
"DSCode": "PDX",
"Value": "<>"
}
},
"EventId": {
"Data": "Unavailable - message is too long"
}
} {code}
We should dump all of this info, if we can decode it.
was:
The geode-native logger has a hard limit of 8KB for log strings, so for client
logs with large values (typically PUT messages with large objects like PDX
instances), the hex dump of the message in the log file will be truncated and
thus not fully decodable. The current version of `gnmsg` generically catches
exceptions due to truncated messages at top-level, and outputs JSON that looks
something like this:
"Value":
{ "Size": 401767, "IsObject": 1 }
,
"ERROR": "Exception reading message - probably incomplete"
}
For `PUT` messages, at least, we can do slightly better, and at least dump the
type of the value in the message, which is probably of interest. Here's an
example:
```
"Value": {
"Size": 401767,
"IsObject": 1,
"Data":
{ "DSCode": "PDX", "Value": "<>" }
},
"EventId":
{ "Data": "Unavailable - message is too long" }
```
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1
> },
> "ERROR": "Exception reading message - probably incomplete"
> } {code}
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> {code:java}
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data": {
> "DSCode": "PDX",
> "Value": "<>"
> }
> },
> "EventId": {
> "Data": "Unavailable - message is too long"
> }
> } {code}
> We should dump all of this info, if we can decode it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
[
https://issues.apache.org/jira/browse/GEODE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender updated GEODE-9406:
Description:
The geode-native logger has a hard limit of 8KB for log strings, so for client
logs with large values (typically PUT messages with large objects like PDX
instances), the hex dump of the message in the log file will be truncated and
thus not fully decodable. The current version of `gnmsg` generically catches
exceptions due to truncated messages at top-level, and outputs JSON that looks
something like this:
"Value":
{ "Size": 401767, "IsObject": 1 }
,
"ERROR": "Exception reading message - probably incomplete"
}
For `PUT` messages, at least, we can do slightly better, and at least dump the
type of the value in the message, which is probably of interest. Here's an
example:
```
"Value": {
"Size": 401767,
"IsObject": 1,
"Data":
{ "DSCode": "PDX", "Value": "<>" }
},
"EventId":
{ "Data": "Unavailable - message is too long" }
```
was:
The geode-native logger has a hard limit of 8KB for log strings, so for client
logs with large values (typically PUT messages with large objects like PDX
instances), the hex dump of the message in the log file will be truncated and
thus not fully decodable. The current version of `gnmsg` generically catches
exceptions due to truncated messages at top-level, and outputs JSON that looks
something like this:
```
"Value": {
"Size": 401767,
"IsObject": 1
},
"ERROR": "Exception reading message - probably incomplete"
}
```
For `PUT` messages, at least, we can do slightly better, and at least dump the
type of the value in the message, which is probably of interest. Here's an
example:
```
"Value": {
"Size": 401767,
"IsObject": 1,
"Data": {
"DSCode": "PDX",
"Value": "<>"
}
},
"EventId": {
"Data": "Unavailable - message is too long"
}
```
> gnmsg should log type etc of long values, if it can decode them
> ---
>
> Key: GEODE-9406
> URL: https://issues.apache.org/jira/browse/GEODE-9406
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> The geode-native logger has a hard limit of 8KB for log strings, so for
> client logs with large values (typically PUT messages with large objects like
> PDX instances), the hex dump of the message in the log file will be truncated
> and thus not fully decodable. The current version of `gnmsg` generically
> catches exceptions due to truncated messages at top-level, and outputs JSON
> that looks something like this:
>
> "Value":
> { "Size": 401767, "IsObject": 1 }
> ,
> "ERROR": "Exception reading message - probably incomplete"
> }
>
> For `PUT` messages, at least, we can do slightly better, and at least dump
> the type of the value in the message, which is probably of interest. Here's
> an example:
> ```
> "Value": {
> "Size": 401767,
> "IsObject": 1,
> "Data":
> { "DSCode": "PDX", "Value": "< gnmsg>>" }
> },
> "EventId":
> { "Data": "Unavailable - message is too long" }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9406) gnmsg should log type etc of long values, if it can decode them
Blake Bender created GEODE-9406:
---
Summary: gnmsg should log type etc of long values, if it can
decode them
Key: GEODE-9406
URL: https://issues.apache.org/jira/browse/GEODE-9406
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
The geode-native logger has a hard limit of 8KB for log strings, so for client
logs with large values (typically PUT messages with large objects like PDX
instances), the hex dump of the message in the log file will be truncated and
thus not fully decodable. The current version of `gnmsg` generically catches
exceptions due to truncated messages at top-level, and outputs JSON that looks
something like this:
```
"Value": {
"Size": 401767,
"IsObject": 1
},
"ERROR": "Exception reading message - probably incomplete"
}
```
For `PUT` messages, at least, we can do slightly better, and at least dump the
type of the value in the message, which is probably of interest. Here's an
example:
```
"Value": {
"Size": 401767,
"IsObject": 1,
"Data": {
"DSCode": "PDX",
"Value": "<>"
}
},
"EventId": {
"Data": "Unavailable - message is too long"
}
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9303) Implement the DUMP and Restore Commands
[ https://issues.apache.org/jira/browse/GEODE-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371560#comment-17371560 ] ASF subversion and git services commented on GEODE-9303: Commit 5a75bf1a2420e3395c7bb31191d908a30d526c8d in geode's branch refs/heads/develop from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5a75bf1 ] GEODE-9303: Implement Radish DUMP/RESTORE commands (#6605) - Dump/restore using internal Geode serialization mechanisms meaning that dumps can only be used to/from Radish instances. - Enable relevant native tcl dump tests - Log exceptions the may occur when restoring - Test for hits/misses (dump should update these) - Create default restore method in RedisData interface for use by both NullRedisData and AbstractRedisData - The header consists of the string 'RADISH' followed by the ordinal version of Geode that created it. > Implement the DUMP and Restore Commands > --- > > Key: GEODE-9303 > URL: https://issues.apache.org/jira/browse/GEODE-9303 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Wayne >Priority: Major > Labels: pull-request-available, redis > > Implement the [DUMP|https://redis.io/commands/dump] and > [RESTORE|https://redis.io/commands/restore] commands as compatible with Redis. > > +Acceptance Criteria+ > The DUMP and RESTORE commands have been implemented as specified, with > adequate unit and integration tests. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9042) Geode User Guide: update dockerfile to use newer ruby & gems
[ https://issues.apache.org/jira/browse/GEODE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-9042: Fix Version/s: 1.13.3 1.14.0 1.12.4 > Geode User Guide: update dockerfile to use newer ruby & gems > > > Key: GEODE-9042 > URL: https://issues.apache.org/jira/browse/GEODE-9042 > Project: Geode > Issue Type: Improvement > Components: docs, tools >Affects Versions: 1.13.1 >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > Labels: pull-request-available > Fix For: 1.12.4, 1.13.3, 1.14.0, 1.15.0 > > > The scripts that build the user guide are pinned at Ruby 2.3.0 and Bookbinder > 1.10.14. > These need to be updated to Ruby 2.5.3 (or later) and Bookbinder 1.10.15 in > order to support current deployment infrastructure. > Path to the Bookbinder gem: > http://docs-wiki.cfapps.io/wiki/bookbinder/installing-bookbinder.html#v10 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371552#comment-17371552 ] ASF subversion and git services commented on GEODE-6588: Commit 1f679d419dbf98f7ee1b075e5adccfa9c560172d in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1f679d4 ] GEODE-6588: Cleanup DiskInitFile > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371554#comment-17371554 ] ASF subversion and git services commented on GEODE-6588: Commit 570ee1e0f7772007f34b96489ec201ffd4de4eec in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=570ee1e ] GEODE-6588: Cleanup OpLog > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371555#comment-17371555 ] ASF subversion and git services commented on GEODE-6588: Commit 459d405062b651be3eb7b7368217194f6f6ebfd6 in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=459d405 ] GEODE-6588: Cleanup TXCommitMessage > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371556#comment-17371556 ] ASF subversion and git services commented on GEODE-6588: Commit cc6f2c307d66eb37b44bc33ac2f8a7f1f517ce13 in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cc6f2c3 ] GEODE-6588: Cleanup DataSerializableJUnitTest > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371551#comment-17371551 ] ASF subversion and git services commented on GEODE-6588: Commit bf140d0b183399395022e9ba3aa204994ba9c77e in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf140d0 ] GEODE-6588: Cleanup ClientTombstoneMessage > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371553#comment-17371553 ] ASF subversion and git services commented on GEODE-6588: Commit 2bf77f4076da6ba818588b522fd153a92ad50d09 in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2bf77f4 ] GEODE-6588: Cleanup DiskStoreImpl > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6588) Cleanup internal use of generics and other static analyzer warnings
[ https://issues.apache.org/jira/browse/GEODE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371550#comment-17371550 ] ASF subversion and git services commented on GEODE-6588: Commit 02d89108200c54cc2e49abda02a3b1971d55016c in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02d8910 ] GEODE-6588: Cleanup CacheClientNotifier > Cleanup internal use of generics and other static analyzer warnings > --- > > Key: GEODE-6588 > URL: https://issues.apache.org/jira/browse/GEODE-6588 > Project: Geode > Issue Type: Task >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Use generics where possible. > Cleanup other static analyzer issues along the way. > Generally make the IntelliJ analyzer gutter less cluttered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8870) Remove obsolete version compatibility code
[ https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371549#comment-17371549 ] ASF subversion and git services commented on GEODE-8870: Commit 963ef6e3f6a1dee67871da916a682af33d621542 in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=963ef6e ] GEODE-8870: Removes GFE_70. > Remove obsolete version compatibility code > -- > > Key: GEODE-8870 > URL: https://issues.apache.org/jira/browse/GEODE-8870 > Project: Geode > Issue Type: Improvement >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > As a followup to GEODE-8837 remove all obsolete backwards compatibility code. > This ticket will catch all changes to remove the obsolete code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9042) Geode User Guide: update dockerfile to use newer ruby & gems
[ https://issues.apache.org/jira/browse/GEODE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371539#comment-17371539 ] ASF subversion and git services commented on GEODE-9042: Commit ad528780b55f834623e583b70ed19c8106f35925 in geode's branch refs/heads/support/1.12 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ad52878 ] GEODE-9042: Update docker-based scripts to build UG (#6528) > Geode User Guide: update dockerfile to use newer ruby & gems > > > Key: GEODE-9042 > URL: https://issues.apache.org/jira/browse/GEODE-9042 > Project: Geode > Issue Type: Improvement > Components: docs, tools >Affects Versions: 1.13.1 >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > The scripts that build the user guide are pinned at Ruby 2.3.0 and Bookbinder > 1.10.14. > These need to be updated to Ruby 2.5.3 (or later) and Bookbinder 1.10.15 in > order to support current deployment infrastructure. > Path to the Bookbinder gem: > http://docs-wiki.cfapps.io/wiki/bookbinder/installing-bookbinder.html#v10 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9405) Build fails on rhel-8 release
[ https://issues.apache.org/jira/browse/GEODE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9405: -- Labels: pull-request-available (was: ) > Build fails on rhel-8 release > - > > Key: GEODE-9405 > URL: https://issues.apache.org/jira/browse/GEODE-9405 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > Looks like a recent gcc compiler change on rhel-8 is causing build failures > in the CI. > Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9405) Build fails on rhel-8 release
[ https://issues.apache.org/jira/browse/GEODE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371527#comment-17371527 ] ASF GitHub Bot commented on GEODE-9405: --- mmartell opened a new pull request #826: URL: https://github.com/apache/geode-native/pull/826 Some of the legacy C++ tests use strncpy. This causes warnings in gcc when the length parameter depends on the length of the source parameter. To avoid such warnings, which we treat as errors, we can use memcpy in the test code where we know there is no buffer overrun issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Build fails on rhel-8 release > - > > Key: GEODE-9405 > URL: https://issues.apache.org/jira/browse/GEODE-9405 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > > Looks like a recent gcc compiler change on rhel-8 is causing build failures > in the CI. > Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371523#comment-17371523
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r660792414
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
I am cool with that. Of all the issues raised in this PR I think we only
need to address the namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371522#comment-17371522
]
ASF GitHub Bot commented on GEODE-9360:
---
echobravopapa commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r660788600
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
@pivotal-jbarrett would you be opposed to follow on ticket(s) to address
these examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9405) Build fails on rhel-8 release
Michael Martell created GEODE-9405: -- Summary: Build fails on rhel-8 release Key: GEODE-9405 URL: https://issues.apache.org/jira/browse/GEODE-9405 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell Looks like a recent gcc compiler change on rhel-8 is causing build failures in the CI. Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371378#comment-17371378
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659921472
##
File path: netcore/LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
Review comment:
This directory does not need to carry a separate license file. The root
of the repository has the appropriate license.
##
File path: netcore/NetCore/CacheFactory.cs
##
@@ -0,0 +1,129 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using System.Runtime.InteropServices;
+
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+public class CacheFactory : GeodeNativeObject, ICacheFactory
+{
+private string _version = String.Empty;
Review comment:
From this convention of `_` before a name it looks like you have derived
from
https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions.
Let's get this documented an enforced.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
In our contributing guide we should have a mention of the style guide
use for .NET Core sources. We never derived one for the old .NET Framework
C++/CLI sources because they were C++ based and loosely followed the C++ style
where it was even possible to apply it. No tooling completely supported C++/CLI
formatting so it is largely a mess. There is plenty of C# formatting tooling
out there including `clang-format`. Since `clang-format` is already a
requirement for C++ source formatting it make sense to extend it to C# sources
with the agreed apon style applied.
##
File path: netcore/NOTICE
##
@@ -0,0 +1,6 @@
+Apache Geode
Review comment:
Same as license, no need for notice here.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fact]
+
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371355#comment-17371355
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659917215
##
File path: netcore/NetCore/NetCore.csproj
##
@@ -0,0 +1,10 @@
+
+
+
+netcoreapp3.1
+Apache.Geode.NetCore
+Apache.Geode.NetCore
+AnyCPU;x64
Review comment:
Fixed.
##
File path: netcore/NetCore/Constants.cs
##
@@ -0,0 +1,30 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+
+public class Constants
+{
+public const string libPath = "apache-geode-c";
Review comment:
Handy (and probably necessary) feature :).
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
Review comment:
I've been leaning that way too. It will make porting ever-so-slightly
easier, if nothing else.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
Works for me, though it does lend more urgency to the task to find a
!@#$)*(&!@^$ version of `clang-format` that's consistent across platforms.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
