[jira] [Closed] (GEODE-10382) Windows build broken after image update
[ https://issues.apache.org/jira/browse/GEODE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10382. > Windows build broken after image update > --- > > Key: GEODE-10382 > URL: https://issues.apache.org/jira/browse/GEODE-10382 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.16.0 >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.16.0 > > > The Windows 2019 build is broken in CI due to a new version of cmake not > liking one of our config parameters, and a couple of new build warnings being > flagged as errors after a compiler update. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (GEODE-10382) Windows build broken after image update
[ https://issues.apache.org/jira/browse/GEODE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10382. -- Fix Version/s: 1.16.0 Resolution: Fixed > Windows build broken after image update > --- > > Key: GEODE-10382 > URL: https://issues.apache.org/jira/browse/GEODE-10382 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.16.0 >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.16.0 > > > The Windows 2019 build is broken in CI due to a new version of cmake not > liking one of our config parameters, and a couple of new build warnings being > flagged as errors after a compiler update. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GEODE-10382) Windows build broken after image update
Blake Bender created GEODE-10382: Summary: Windows build broken after image update Key: GEODE-10382 URL: https://issues.apache.org/jira/browse/GEODE-10382 Project: Geode Issue Type: Bug Components: native client Affects Versions: 1.16.0 Reporter: Blake Bender The Windows 2019 build is broken in CI due to a new version of cmake not liking one of our config parameters, and a couple of new build warnings being flagged as errors after a compiler update. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GEODE-10273) Rename .net to .net framework in native client docs
Blake Bender created GEODE-10273: Summary: Rename .net to .net framework in native client docs Key: GEODE-10273 URL: https://issues.apache.org/jira/browse/GEODE-10273 Project: Geode Issue Type: Task Components: native client Reporter: Blake Bender The .NET native client docs need to be renamed to .NET Framework to clarify that it is not .NET Core -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GEODE-10241) Need to temporarily disable "reAuthenticateWithDurable" test
Blake Bender created GEODE-10241: Summary: Need to temporarily disable "reAuthenticateWithDurable" test Key: GEODE-10241 URL: https://issues.apache.org/jira/browse/GEODE-10241 Project: Geode Issue Type: Bug Components: native client Reporter: Blake Bender This test is verifying geode-native works with a feature which is not yet released (forthcoming in Geode 1.15), and whose implementation has recently changed. The test is now failing, and needs to be implemented properly according to the spec for the token authentication feature. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10144) Regression in geode-native test CqPlusAuthInitializeTest.reAuthenticateWithDurable
[ https://issues.apache.org/jira/browse/GEODE-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521963#comment-17521963 ] Blake Bender commented on GEODE-10144: -- This has been regressed again as of build 1.15.0.1097. > Regression in geode-native test > CqPlusAuthInitializeTest.reAuthenticateWithDurable > -- > > Key: GEODE-10144 > URL: https://issues.apache.org/jira/browse/GEODE-10144 > Project: Geode > Issue Type: Bug > Components: client/server >Affects Versions: 1.15.0 >Reporter: Blake Bender >Assignee: Jinmei Liao >Priority: Major > Labels: blocks-1.15.0, needsTriage > Fix For: 1.15.0 > > > This test is failing across the board in the `geode-native` PR pipeline. > Main develop pipeline is green only because nothing can get through the PR > pipeline to clear checkin gates. We have green CI runs with 1.15. build 918, > then it started failing when we picked up build 924. > > [~moleske] tracked this back to this commit: > [https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db|https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db]. > See his notes in `geode-native` PR # 947 > ([https://github.com/apache/geode-native/pull/947]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10101) release 1.14.4
[ https://issues.apache.org/jira/browse/GEODE-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10101. > release 1.14.4 > -- > > Key: GEODE-10101 > URL: https://issues.apache.org/jira/browse/GEODE-10101 > Project: Geode > Issue Type: Task > Components: release >Reporter: Dick Cavender >Priority: Major > Labels: pull-request-available > Fix For: 1.14.5, 1.15.0 > > > Release to incorporate GEODE-10093 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10144) Regression in geode-native test CqPlusAuthInitializeTest.reAuthenticateWithDurable
[ https://issues.apache.org/jira/browse/GEODE-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510485#comment-17510485 ] Blake Bender commented on GEODE-10144: -- Notes from investigation 2022-03-21: * Description of test: Test creates a durable cache, provides an instrumented AuthInitialize implementation to the client and a SecurityManager to the server. Test registers a listener that counts events, then does: 5000 puts, 5000 updates, 5000 destroys, then checks that the listener got 5000 LOCAL_CREATE, 5000 LOCAL_UPDATE, and 5000 LOCAL_DESTROY messages. Next, test shuts down the cache and creates a 2nd durable cache with the same durable-client-id, registers CQ again, and expects all events to still be in the queue and to receive them all again. After conversation with Barry, the 2nd part of the test may or may not be valid, but is at the very least a strange thing to do. * Prior to the commit in question, we discovered that the first half of the test would always pass, but the 2nd half was a little flaky when running a debug build of geode-native. Due to performance of unoptimized code and debug-level logging, the test would sometimes overrun the default subscription ack interval (100 seconds), thus losing some events from the queue and failing the event count. * After the bad commit, we've observed that no LOCAL_DESTROY events are received in the first part of the test. We are looking into why this is the case. > Regression in geode-native test > CqPlusAuthInitializeTest.reAuthenticateWithDurable > -- > > Key: GEODE-10144 > URL: https://issues.apache.org/jira/browse/GEODE-10144 > Project: Geode > Issue Type: Bug > Components: client/server >Affects Versions: 1.15.0 >Reporter: Blake Bender >Assignee: Jinmei Liao >Priority: Major > Labels: blocks-1.15.0, needsTriage > > This test is failing across the board in the `geode-native` PR pipeline. > Main develop pipeline is green only because nothing can get through the PR > pipeline to clear checkin gates. We have green CI runs with 1.15. build 918, > then it started failing when we picked up build 924. > > [~moleske] tracked this back to this commit: > [https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db|https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db]. > See his notes in `geode-native` PR # 947 > ([https://github.com/apache/geode-native/pull/947]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10144) Regression in geode-native test CqPlusAuthInitializeTest.reAuthenticateWithDurable
[ https://issues.apache.org/jira/browse/GEODE-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510479#comment-17510479 ] Blake Bender commented on GEODE-10144: -- [~jinmeiliao] Be sure to check in with [~boglesby] before diving into this one, he and I have been working on it since yesterday. > Regression in geode-native test > CqPlusAuthInitializeTest.reAuthenticateWithDurable > -- > > Key: GEODE-10144 > URL: https://issues.apache.org/jira/browse/GEODE-10144 > Project: Geode > Issue Type: Bug > Components: client/server >Affects Versions: 1.15.0 >Reporter: Blake Bender >Assignee: Jinmei Liao >Priority: Major > Labels: blocks-1.15.0, needsTriage > > This test is failing across the board in the `geode-native` PR pipeline. > Main develop pipeline is green only because nothing can get through the PR > pipeline to clear checkin gates. We have green CI runs with 1.15. build 918, > then it started failing when we picked up build 924. > > [~moleske] tracked this back to this commit: > [https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db|https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db]. > See his notes in `geode-native` PR # 947 > ([https://github.com/apache/geode-native/pull/947]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10144) Regression in geode-native test CqPlusAuthInitializeTest.reAuthenticateWithDurable
Blake Bender created GEODE-10144: Summary: Regression in geode-native test CqPlusAuthInitializeTest.reAuthenticateWithDurable Key: GEODE-10144 URL: https://issues.apache.org/jira/browse/GEODE-10144 Project: Geode Issue Type: Bug Components: client/server Reporter: Blake Bender This test is failing across the board in the `geode-native` PR pipeline. Main develop pipeline is green only because nothing can get through the PR pipeline to clear checkin gates. We have green CI runs with 1.15. build 918, then it started failing when we picked up build 924. [~moleske] tracked this back to this commit: [https://github.com/apache/geode/commit/2554f42b925f2b9b8ca7eee14c7a887436b1d9db.] See his notes in `geode-native` PR # 947 (https://github.com/apache/geode-native/pull/947) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-4189) Optimize string serialization to/from Java Modified UTF-8
[ https://issues.apache.org/jira/browse/GEODE-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender reassigned GEODE-4189: --- Assignee: Blake Bender > Optimize string serialization to/from Java Modified UTF-8 > - > > Key: GEODE-4189 > URL: https://issues.apache.org/jira/browse/GEODE-4189 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Blake Bender >Priority: Major > > Current implementation takes the naive approach of converting all strings > through UTF-16 when converting to/from Java Modified UTF-8. Implement direct > conversion to/from UCS-4 and UTF-8. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-3852) Fix race condition causing intermittent test failure
[
https://issues.apache.org/jira/browse/GEODE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-3852.
-
Fix Version/s: 1.15.0
Resolution: Cannot Reproduce
Closing primordial native client bugs - after 5 years (!), this is either fixed
elsewhere or no longer relevant.
> Fix race condition causing intermittent test failure
>
>
> Key: GEODE-3852
> URL: https://issues.apache.org/jira/browse/GEODE-3852
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: David Kimura
>Priority: Major
> Fix For: 1.15.0
>
> Attachments: SampleFailureTest.cs
>
>
> ThinClientQueryTestsN fails intermittently. Hypothesis is garbage collection
> race-condition leading to access violations of deleted data.
> Here's an example stacktrace:
> {noformat}
> [Managed to Native Transition]
> Apache.Geode.dll!std::shared_ptr::`scalar
> deleting destructor' + 0x6b bytes
> >
> > Apache.Geode.dll!Apache::Geode::Client::native_shared_ptr::!native_shared_ptr()
> > Line 27 + 0x13 bytesC++
>
> Apache.Geode.dll!Apache::Geode::Client::native_shared_ptr::Dispose(bool
> A_0) + 0x1e bytes C++
> [Native to Managed Transition]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-10082) Duplicate values found in DSCode enums
[ https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10082. -- Fix Version/s: 1.15.0 Resolution: Fixed > Duplicate values found in DSCode enums > -- > > Key: GEODE-10082 > URL: https://issues.apache.org/jira/browse/GEODE-10082 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > The following snippet appears in DSCode.hpp: > ``` > CacheableEnum = 94, > ClientProxyMembershipId = 38, > CacheableUserData = 39, > CacheableUserData2 = 38, > CacheableUserData4 = 37, > PDX = 93, > PDX_ENUM = 94, > InterestResultPolicy = 37, > }; > ``` > `CacheableEnum` is the name of the class that geode-native uses for > `PDX_ENUM`, it should not exist as an enum value. `ClientProxyMembershipId`, > `InternalDistributedMember`, and `InterestResultPolicy` are > `DataSerializableFixedId` values, and belong in that enum rather than DSCode. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9440) Revert changes for GEODE-9431
[ https://issues.apache.org/jira/browse/GEODE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9440. - Resolution: Done > Revert changes for GEODE-9431 > - > > Key: GEODE-9440 > URL: https://issues.apache.org/jira/browse/GEODE-9440 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Priority: Major > > We encountered a problem with `std::regex` crashing on RHEL-8 in release > builds, and the first fix we found that worked was to switch to > `boost::regex`. We're filing bugs with RedHat and GNU, so if/when the issue > is resolved we will need to verify the fix and revert the workaround. We > should be using `std::` objects whenever possible, certainly for something as > mainstream as `regex`. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9440) Revert changes for GEODE-9431
[ https://issues.apache.org/jira/browse/GEODE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9440. --- > Revert changes for GEODE-9431 > - > > Key: GEODE-9440 > URL: https://issues.apache.org/jira/browse/GEODE-9440 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Priority: Major > > We encountered a problem with `std::regex` crashing on RHEL-8 in release > builds, and the first fix we found that worked was to switch to > `boost::regex`. We're filing bugs with RedHat and GNU, so if/when the issue > is resolved we will need to verify the fix and revert the workaround. We > should be using `std::` objects whenever possible, certainly for something as > mainstream as `regex`. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10014) Add support for building nativeclient against older geode releases
[ https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10014. > Add support for building nativeclient against older geode releases > -- > > Key: GEODE-10014 > URL: https://issues.apache.org/jira/browse/GEODE-10014 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Fix For: 1.15.0 > > > Currently, the nativeclient's java test module (javaobject.jar) depends on a > very recent version of geode (1.15.0-build.546 or higher). This ticket is to > add support for building this jar file against older versions of geode which > do not contain the new AuthenticationExpiredException. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10014) Add support for building nativeclient against older geode releases
[ https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10014. -- Fix Version/s: 1.15.0 Resolution: Fixed > Add support for building nativeclient against older geode releases > -- > > Key: GEODE-10014 > URL: https://issues.apache.org/jira/browse/GEODE-10014 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Fix For: 1.15.0 > > > Currently, the nativeclient's java test module (javaobject.jar) depends on a > very recent version of geode (1.15.0-build.546 or higher). This ticket is to > add support for building this jar file against older versions of geode which > do not contain the new AuthenticationExpiredException. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10014) Add support for building nativeclient against older geode releases
[ https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500889#comment-17500889 ] Blake Bender commented on GEODE-10014: -- https://github.com/apache/geode-native/pull/917 > Add support for building nativeclient against older geode releases > -- > > Key: GEODE-10014 > URL: https://issues.apache.org/jira/browse/GEODE-10014 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > > Currently, the nativeclient's java test module (javaobject.jar) depends on a > very recent version of geode (1.15.0-build.546 or higher). This ticket is to > add support for building this jar file against older versions of geode which > do not contain the new AuthenticationExpiredException. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10085) Multiple Locators Not Working in New .NET Test Framework
[ https://issues.apache.org/jira/browse/GEODE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10085. > Multiple Locators Not Working in New .NET Test Framework > > > Key: GEODE-10085 > URL: https://issues.apache.org/jira/browse/GEODE-10085 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > If a cluster with more than one locator is used in the new .NET test > framework, the test will fail. The failure results from trying to start > JmxManager when it is already running. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10085) Multiple Locators Not Working in New .NET Test Framework
[ https://issues.apache.org/jira/browse/GEODE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10085. -- Fix Version/s: 1.15.0 Resolution: Fixed > Multiple Locators Not Working in New .NET Test Framework > > > Key: GEODE-10085 > URL: https://issues.apache.org/jira/browse/GEODE-10085 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > If a cluster with more than one locator is used in the new .NET test > framework, the test will fail. The failure results from trying to start > JmxManager when it is already running. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10082) Duplicate values found in DSCode enums
[ https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10082. > Duplicate values found in DSCode enums > -- > > Key: GEODE-10082 > URL: https://issues.apache.org/jira/browse/GEODE-10082 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > The following snippet appears in DSCode.hpp: > ``` > CacheableEnum = 94, > ClientProxyMembershipId = 38, > CacheableUserData = 39, > CacheableUserData2 = 38, > CacheableUserData4 = 37, > PDX = 93, > PDX_ENUM = 94, > InterestResultPolicy = 37, > }; > ``` > `CacheableEnum` is the name of the class that geode-native uses for > `PDX_ENUM`, it should not exist as an enum value. `ClientProxyMembershipId`, > `InternalDistributedMember`, and `InterestResultPolicy` are > `DataSerializableFixedId` values, and belong in that enum rather than DSCode. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9868) geode-native docker build images should not have Geode installed
[ https://issues.apache.org/jira/browse/GEODE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500843#comment-17500843 ] Blake Bender commented on GEODE-9868: - We've actually added installation of latest "blessed" Geode build(s) to the CI pipeline, but haven't gotten around to removing it from the Docker images. Additionally, [PR 917|https://github.com/apache/geode-native/pull/917] fixed the native client build problem with older Geode versions. I'm editing the title to indicate we need to remove Geode from the Docker files. > geode-native docker build images should not have Geode installed > > > Key: GEODE-9868 > URL: https://issues.apache.org/jira/browse/GEODE-9868 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Priority: Major > > Given that currently Geode version specified in the docker build images for > geode-native is 1.13.2, and latest tests introduces an Authentication feature > only available in 1.15.0 (develop), current docker build images are failing > to compile the source. > The solution would require to have the latest version of geode included > within the generated images. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-9868) geode-native docker build images should not have Geode installed
[ https://issues.apache.org/jira/browse/GEODE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9868: Summary: geode-native docker build images should not have Geode installed (was: geode-native docker build images are not compiling correctly ) > geode-native docker build images should not have Geode installed > > > Key: GEODE-9868 > URL: https://issues.apache.org/jira/browse/GEODE-9868 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Priority: Major > > Given that currently Geode version specified in the docker build images for > geode-native is 1.13.2, and latest tests introduces an Authentication feature > only available in 1.15.0 (develop), current docker build images are failing > to compile the source. > The solution would require to have the latest version of geode included > within the generated images. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10098) TcrConnection::readMessage should not be explicitly allocating memory
Blake Bender created GEODE-10098: Summary: TcrConnection::readMessage should not be explicitly allocating memory Key: GEODE-10098 URL: https://issues.apache.org/jira/browse/GEODE-10098 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender This method calls new to read an array of bytes, then returns it to the caller, whose responsibility is to delete it (what the heck???). Even better, the memory is deleted in a call to TcrMessage::setData, so not even in the same class. If this memory was a std::vector, we could probably take advantage of move semantics and maybe even improve performance a bit, in addition to avoiding potential leaks and weirdness... -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10096) Handshake "acceptance codes" should be an enum class
[
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender updated GEODE-10096:
-
Description:
In the method TcrConnection::initTcrConnection, the following block of code
appears:
{code:java}
switch (acceptanceCode[0]) {
case REPLY_OK:
case SUCCESSFUL_SERVER_TO_CLIENT:
LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
serverQueueStatus[0], recvMsgLen2);
if (isClientNotification) readHandshakeInstantiatorMsg(connectTimeout);
break;
case REPLY_AUTHENTICATION_FAILED: {
AuthenticationFailedException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_AUTHENTICATION_REQUIRED: {
AuthenticationRequiredException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_DUPLICATE_DURABLE_CLIENT: {
DuplicateDurableClientException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_REFUSED:
case REPLY_INVALID:
case UNSUCCESSFUL_SERVER_TO_CLIENT: {
LOGERROR("Handshake rejected by server[%s]: %s",
m_endpointObj->name().c_str(),
reinterpret_cast(recvMessage.data()));
auto message = std::string("TcrConnection::TcrConnection: ") +
"Handshake rejected by server: " +
reinterpret_cast(recvMessage.data());
CacheServerException ex(message);
m_conn.reset();
throw ex;
}
{code}
These response codes are unique to the server handshake, and not used anywhere
else in the code. We need to remove the #definess for them and put them in a
proper enum class.
was:
In the method `TcrConnection::initTcrConnection`, the following block of code
appears:
```
switch (acceptanceCode[0]) {
case REPLY_OK:
case SUCCESSFUL_SERVER_TO_CLIENT:
LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
serverQueueStatus[0], recvMsgLen2);
if (isClientNotification) readHandshakeInstantiatorMsg(connectTimeout);
break;
case REPLY_AUTHENTICATION_FAILED: {
AuthenticationFailedException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_AUTHENTICATION_REQUIRED: {
AuthenticationRequiredException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_DUPLICATE_DURABLE_CLIENT: {
DuplicateDurableClientException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_REFUSED:
case REPLY_INVALID:
case UNSUCCESSFUL_SERVER_TO_CLIENT: {
LOGERROR("Handshake rejected by server[%s]: %s",
m_endpointObj->name().c_str(),
reinterpret_cast(recvMessage.data()));
auto message = std::string("TcrConnection::TcrConnection: ") +
"Handshake rejected by server: " +
reinterpret_cast(recvMessage.data());
CacheServerException ex(message);
m_conn.reset();
throw ex;
}
```
These response codes are unique to the server handshake, and not used anywhere
else in the code. We need to remove the `#define`s for them and put them in a
proper `enum class`.
> Handshake "acceptance codes" should be an enum class
>
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> In the method TcrConnection::initTcrConnection, the following block of code
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
> case REPLY_OK:
> case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
> serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification)
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
> case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
> }
> case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
> }
> case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
>
[jira] [Updated] (GEODE-10096) Handshake "acceptance codes" should be an enum class
[
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender updated GEODE-10096:
-
Description:
In the method TcrConnection::initTcrConnection, the following block of code
appears:
{code:java}
switch (acceptanceCode[0]) {
case REPLY_OK:
case SUCCESSFUL_SERVER_TO_CLIENT:
LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
serverQueueStatus[0], recvMsgLen2);
if (isClientNotification) readHandshakeInstantiatorMsg(connectTimeout);
break;
case REPLY_AUTHENTICATION_FAILED: {
AuthenticationFailedException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_AUTHENTICATION_REQUIRED: {
AuthenticationRequiredException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_DUPLICATE_DURABLE_CLIENT: {
DuplicateDurableClientException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_REFUSED:
case REPLY_INVALID:
case UNSUCCESSFUL_SERVER_TO_CLIENT: {
LOGERROR("Handshake rejected by server[%s]: %s",
m_endpointObj->name().c_str(),
reinterpret_cast(recvMessage.data()));
auto message = std::string("TcrConnection::TcrConnection: ") +
"Handshake rejected by server: " +
reinterpret_cast(recvMessage.data());
CacheServerException ex(message);
m_conn.reset();
throw ex;
}
{code}
These response codes are unique to the server handshake, and not used anywhere
else in the code. We need to remove the #defines for them and put them in a
proper enum class.
was:
In the method TcrConnection::initTcrConnection, the following block of code
appears:
{code:java}
switch (acceptanceCode[0]) {
case REPLY_OK:
case SUCCESSFUL_SERVER_TO_CLIENT:
LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
serverQueueStatus[0], recvMsgLen2);
if (isClientNotification) readHandshakeInstantiatorMsg(connectTimeout);
break;
case REPLY_AUTHENTICATION_FAILED: {
AuthenticationFailedException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_AUTHENTICATION_REQUIRED: {
AuthenticationRequiredException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_DUPLICATE_DURABLE_CLIENT: {
DuplicateDurableClientException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_REFUSED:
case REPLY_INVALID:
case UNSUCCESSFUL_SERVER_TO_CLIENT: {
LOGERROR("Handshake rejected by server[%s]: %s",
m_endpointObj->name().c_str(),
reinterpret_cast(recvMessage.data()));
auto message = std::string("TcrConnection::TcrConnection: ") +
"Handshake rejected by server: " +
reinterpret_cast(recvMessage.data());
CacheServerException ex(message);
m_conn.reset();
throw ex;
}
{code}
These response codes are unique to the server handshake, and not used anywhere
else in the code. We need to remove the #definess for them and put them in a
proper enum class.
> Handshake "acceptance codes" should be an enum class
>
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> In the method TcrConnection::initTcrConnection, the following block of code
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
> case REPLY_OK:
> case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
> serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification)
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
> case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
> }
> case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
> }
> case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
>
[jira] [Created] (GEODE-10096) Handshake "acceptance codes" should be an enum class
Blake Bender created GEODE-10096:
Summary: Handshake "acceptance codes" should be an enum class
Key: GEODE-10096
URL: https://issues.apache.org/jira/browse/GEODE-10096
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
In the method `TcrConnection::initTcrConnection`, the following block of code
appears:
```
switch (acceptanceCode[0]) {
case REPLY_OK:
case SUCCESSFUL_SERVER_TO_CLIENT:
LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
serverQueueStatus[0], recvMsgLen2);
if (isClientNotification) readHandshakeInstantiatorMsg(connectTimeout);
break;
case REPLY_AUTHENTICATION_FAILED: {
AuthenticationFailedException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_AUTHENTICATION_REQUIRED: {
AuthenticationRequiredException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_DUPLICATE_DURABLE_CLIENT: {
DuplicateDurableClientException ex(
reinterpret_cast(recvMessage.data()));
m_conn.reset();
throwException(ex);
}
case REPLY_REFUSED:
case REPLY_INVALID:
case UNSUCCESSFUL_SERVER_TO_CLIENT: {
LOGERROR("Handshake rejected by server[%s]: %s",
m_endpointObj->name().c_str(),
reinterpret_cast(recvMessage.data()));
auto message = std::string("TcrConnection::TcrConnection: ") +
"Handshake rejected by server: " +
reinterpret_cast(recvMessage.data());
CacheServerException ex(message);
m_conn.reset();
throw ex;
}
```
These response codes are unique to the server handshake, and not used anywhere
else in the code. We need to remove the `#define`s for them and put them in a
proper `enum class`.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-10095) TcrConnection::readHandshakeData reads too many bytes
[ https://issues.apache.org/jira/browse/GEODE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender reassigned GEODE-10095: Assignee: Matthew Reddington > TcrConnection::readHandshakeData reads too many bytes > - > > Key: GEODE-10095 > URL: https://issues.apache.org/jira/browse/GEODE-10095 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Assignee: Matthew Reddington >Priority: Major > Labels: needsTriage > > This method is called to read bytes from a socket, and return said data in a > `std::vector`. For some inexplicable (inexcusable?) reason, the > method always adds a 0 byte to the end of the vector, as if it were > null-terminating a string. So, `readHandshakeData(1)` returns 2 bytes, > `readHandshakeData(5)` returns 6 bytes, etc. > This is extremely misleading, given the name of the method and the fact that > the requested number of bytes is a parameter passed in. Also, in no > circumstance is this method used to actually read a string, i.e. something > that may require null-termination. Please remove the extra byte from the > returned vector, and if possible add a unit test to the suite that reads _n_ > bytes and asserts that the method always returns _n_ bytes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10095) TcrConnection::readHandshakeData reads too many bytes
Blake Bender created GEODE-10095: Summary: TcrConnection::readHandshakeData reads too many bytes Key: GEODE-10095 URL: https://issues.apache.org/jira/browse/GEODE-10095 Project: Geode Issue Type: Bug Components: native client Reporter: Blake Bender This method is called to read bytes from a socket, and return said data in a `std::vector`. For some inexplicable (inexcusable?) reason, the method always adds a 0 byte to the end of the vector, as if it were null-terminating a string. So, `readHandshakeData(1)` returns 2 bytes, `readHandshakeData(5)` returns 6 bytes, etc. This is extremely misleading, given the name of the method and the fact that the requested number of bytes is a parameter passed in. Also, in no circumstance is this method used to actually read a string, i.e. something that may require null-termination. Please remove the extra byte from the returned vector, and if possible add a unit test to the suite that reads _n_ bytes and asserts that the method always returns _n_ bytes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10082) Duplicate values found in DSCode enums
Blake Bender created GEODE-10082: Summary: Duplicate values found in DSCode enums Key: GEODE-10082 URL: https://issues.apache.org/jira/browse/GEODE-10082 Project: Geode Issue Type: Bug Components: native client Reporter: Blake Bender The following snippet appears in DSCode.hpp: ``` CacheableEnum = 94, ClientProxyMembershipId = 38, CacheableUserData = 39, CacheableUserData2 = 38, CacheableUserData4 = 37, PDX = 93, PDX_ENUM = 94, InterestResultPolicy = 37, }; ``` `CacheableEnum` is the name of the class that geode-native uses for `PDX_ENUM`, it should not exist as an enum value. `ClientProxyMembershipId`, `InternalDistributedMember`, and `InterestResultPolicy` are `DataSerializableFixedId` values, and belong in that enum rather than DSCode. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10073) Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at debug log level
[ https://issues.apache.org/jira/browse/GEODE-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10073. -- Resolution: Fixed > Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at > debug log level > > > Key: GEODE-10073 > URL: https://issues.apache.org/jira/browse/GEODE-10073 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > This will allow us to parse out the data with the gnmsg tool and see what's > going on. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10073) Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at debug log level
[ https://issues.apache.org/jira/browse/GEODE-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10073. > Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at > debug log level > > > Key: GEODE-10073 > URL: https://issues.apache.org/jira/browse/GEODE-10073 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > This will allow us to parse out the data with the gnmsg tool and see what's > going on. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9325) Remove ACE_Process references
[ https://issues.apache.org/jira/browse/GEODE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9325. --- > Remove ACE_Process references > - > > Key: GEODE-9325 > URL: https://issues.apache.org/jira/browse/GEODE-9325 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Process > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9325) Remove ACE_Process references
[ https://issues.apache.org/jira/browse/GEODE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9325. - Resolution: Fixed > Remove ACE_Process references > - > > Key: GEODE-9325 > URL: https://issues.apache.org/jira/browse/GEODE-9325 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Process > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10073) Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at debug log level
Blake Bender created GEODE-10073: Summary: Print bytes of ClientConnectionRequest, ClientConnectionResponse messages at debug log level Key: GEODE-10073 URL: https://issues.apache.org/jira/browse/GEODE-10073 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender This will allow us to parse out the data with the gnmsg tool and see what's going on. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9327) Remove all remaining references to ACE networking
[ https://issues.apache.org/jira/browse/GEODE-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9327. - Resolution: Fixed > Remove all remaining references to ACE networking > - > > Key: GEODE-9327 > URL: https://issues.apache.org/jira/browse/GEODE-9327 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE networking > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9327) Remove all remaining references to ACE networking
[ https://issues.apache.org/jira/browse/GEODE-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9327. --- > Remove all remaining references to ACE networking > - > > Key: GEODE-9327 > URL: https://issues.apache.org/jira/browse/GEODE-9327 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE networking > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9326) Remove ACE_Get_Opt references
[ https://issues.apache.org/jira/browse/GEODE-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9326. --- > Remove ACE_Get_Opt references > - > > Key: GEODE-9326 > URL: https://issues.apache.org/jira/browse/GEODE-9326 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Get_Opt > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9326) Remove ACE_Get_Opt references
[ https://issues.apache.org/jira/browse/GEODE-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9326. - Resolution: Fixed > Remove ACE_Get_Opt references > - > > Key: GEODE-9326 > URL: https://issues.apache.org/jira/browse/GEODE-9326 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Get_Opt > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9324) Remove ACE_Task references
[ https://issues.apache.org/jira/browse/GEODE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9324. --- > Remove ACE_Task references > -- > > Key: GEODE-9324 > URL: https://issues.apache.org/jira/browse/GEODE-9324 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > Fix For: 1.15.0 > > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Task > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9324) Remove ACE_Task references
[ https://issues.apache.org/jira/browse/GEODE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9324. - Fix Version/s: 1.15.0 Resolution: Fixed > Remove ACE_Task references > -- > > Key: GEODE-9324 > URL: https://issues.apache.org/jira/browse/GEODE-9324 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > Fix For: 1.15.0 > > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Task > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9268) Fix coredump whenever getFieldNames is called after a cluster restart
[
https://issues.apache.org/jira/browse/GEODE-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender closed GEODE-9268.
---
> Fix coredump whenever getFieldNames is called after a cluster restart
> -
>
> Key: GEODE-9268
> URL: https://issues.apache.org/jira/browse/GEODE-9268
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *WHEN* A PdxInstance is fetched from a region
> *AND* The whole cluster is restarted, triggering PdxTypeRegistry cleanup.
> *AND* getFieldNames is called on the PdxInstance created just before
> *THEN* a coredump happens.
> —
> *Additional information:*
> Callstack:
> {noformat}
> [ERROR 2021/05/05 12:57:12.781834 CEST main (139683590957120)] Segmentation
> fault happened
> 0# handler(int) at nc-pdx/main.cpp:225
> 1# 0x7F0A9F5F13C0 in /lib/x86_64-linux-gnu/libpthread.so.0
> 2# apache::geode::client::PdxType::getPdxFieldTypes() const at
> cppcache/src/PdxType.hpp:181
> 3# apache::geode::client::PdxInstanceImpl::getFieldNames() at
> cppcache/src/PdxInstanceImpl.cpp:1383
> 4# main at nc-pdx/main.cpp:374
> 5# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
> 6# _start in build/pdx{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9268) Fix coredump whenever getFieldNames is called after a cluster restart
[
https://issues.apache.org/jira/browse/GEODE-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-9268.
-
Resolution: Fixed
> Fix coredump whenever getFieldNames is called after a cluster restart
> -
>
> Key: GEODE-9268
> URL: https://issues.apache.org/jira/browse/GEODE-9268
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *WHEN* A PdxInstance is fetched from a region
> *AND* The whole cluster is restarted, triggering PdxTypeRegistry cleanup.
> *AND* getFieldNames is called on the PdxInstance created just before
> *THEN* a coredump happens.
> —
> *Additional information:*
> Callstack:
> {noformat}
> [ERROR 2021/05/05 12:57:12.781834 CEST main (139683590957120)] Segmentation
> fault happened
> 0# handler(int) at nc-pdx/main.cpp:225
> 1# 0x7F0A9F5F13C0 in /lib/x86_64-linux-gnu/libpthread.so.0
> 2# apache::geode::client::PdxType::getPdxFieldTypes() const at
> cppcache/src/PdxType.hpp:181
> 3# apache::geode::client::PdxInstanceImpl::getFieldNames() at
> cppcache/src/PdxInstanceImpl.cpp:1383
> 4# main at nc-pdx/main.cpp:374
> 5# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
> 6# _start in build/pdx{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9959) Add FQDN during SSL handshake error while reaching a locator
[ https://issues.apache.org/jira/browse/GEODE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9959. - Resolution: Fixed > Add FQDN during SSL handshake error while reaching a locator > > > Key: GEODE-9959 > URL: https://issues.apache.org/jira/browse/GEODE-9959 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *WHEN* a geode-native client tries to reach a locator > *AND* the locator being reached has SSL configured > *BUT* the geode-native client does not have SSL configured > *THEN* a log will be written indicating the issue > *AND* an AuthenticationRequiredException exception will be thrown, which > can't be catched > The improvement proposed here is to log the FQDN of the locator being reached > in order to have further information when troubleshooting this kind of issues. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9959) Add FQDN during SSL handshake error while reaching a locator
[ https://issues.apache.org/jira/browse/GEODE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9959. --- > Add FQDN during SSL handshake error while reaching a locator > > > Key: GEODE-9959 > URL: https://issues.apache.org/jira/browse/GEODE-9959 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *WHEN* a geode-native client tries to reach a locator > *AND* the locator being reached has SSL configured > *BUT* the geode-native client does not have SSL configured > *THEN* a log will be written indicating the issue > *AND* an AuthenticationRequiredException exception will be thrown, which > can't be catched > The improvement proposed here is to log the FQDN of the locator being reached > in order to have further information when troubleshooting this kind of issues. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10030) Remove obsolete cross-reference in geode-native user docs
[ https://issues.apache.org/jira/browse/GEODE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-10030. -- Resolution: Fixed > Remove obsolete cross-reference in geode-native user docs > - > > Key: GEODE-10030 > URL: https://issues.apache.org/jira/browse/GEODE-10030 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: needsTriage, pull-request-available > > The System Properties page contains a cross-reference to the System > Statistics page, which no longer exists. Just remove the link from both the > .NET and C++ versions of the user guide. It's in the System Archiving > Properties table. > .NET: > https://geode.apache.org/docs/geode-native/dotnet/114/configuring/sysprops.html#attributes-gfcpp__table_durable_client_props > C++: > https://geode.apache.org/docs/geode-native/cpp/114/configuring/sysprops.html -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10030) Remove obsolete cross-reference in geode-native user docs
[ https://issues.apache.org/jira/browse/GEODE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-10030. > Remove obsolete cross-reference in geode-native user docs > - > > Key: GEODE-10030 > URL: https://issues.apache.org/jira/browse/GEODE-10030 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: needsTriage, pull-request-available > > The System Properties page contains a cross-reference to the System > Statistics page, which no longer exists. Just remove the link from both the > .NET and C++ versions of the user guide. It's in the System Archiving > Properties table. > .NET: > https://geode.apache.org/docs/geode-native/dotnet/114/configuring/sysprops.html#attributes-gfcpp__table_durable_client_props > C++: > https://geode.apache.org/docs/geode-native/cpp/114/configuring/sysprops.html -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9323. - Resolution: Fixed > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9323. --- > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-9960) Remove support for strong name signing of assemblies
Blake Bender created GEODE-9960: --- Summary: Remove support for strong name signing of assemblies Key: GEODE-9960 URL: https://issues.apache.org/jira/browse/GEODE-9960 Project: Geode Issue Type: Task Components: native client Reporter: Blake Bender This has historically caused problems in builds and CI pipelines. Microsoft has recognized that it's not actually solving the problems originally intended, and has removed any code that uses it from .net 5 and .net core. We could continue to build with it, but literally nothing would use it, so let's get rid of another weird vestigial artifact from our Windows support. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc
[
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender closed GEODE-9553.
---
> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> From time to time, we will pick up a new version of a compiler on one or
> another platform we build on, and get new complaints about potential buffer
> overflows or other assorted badness around persistent use of sprintf. See
> the following pull request, e.g.:
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really
> just applying band-aids to the problem. *All* use of sprintf is bad,
> snprintf only slightly less so. Someone needs to just go through the code
> and rewrite all instances in modern C++ using std::string, std::stringstream,
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> tests\cpp\testobject\InvalidPdxUsage.cpp
> tests\cpp\testobject\NestedPdxObject.cpp
> tests\cpp\testobject\PdxClassV1.cpp
> tests\cpp\testobject\PdxClassV2.cpp
> tests\cpp\testobject\PdxType.cpp
> tests\cpp\testobject\Portfolio.cpp
> tests\cpp\testobject\PortfolioPdx.cpp
> tests\cpp\testobject\Position.cpp
> tests\cpp\testobject\PositionPdx.cpp
> tests\cpp\testobject\PSTObject.cpp
> tests\cpp\testobject\VariousPdxTypes.cpp
> {code}
> and snprintf:
>
[jira] [Resolved] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc
[
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-9553.
-
Fix Version/s: 1.15.0
Resolution: Fixed
Removed every instance of sprintf, snprintf, fprintf, and printf from code
base. Two instances of vsnprintf remain, in CacheXmlParser and the logging
code. The parser instance may be replacable, I haven't checked, but the
logging infrasructure would have to be completely rewritten (literally every
format string replaced), to get rid of the other one, so that's not practical.
> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> From time to time, we will pick up a new version of a compiler on one or
> another platform we build on, and get new complaints about potential buffer
> overflows or other assorted badness around persistent use of sprintf. See
> the following pull request, e.g.:
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really
> just applying band-aids to the problem. *All* use of sprintf is bad,
> snprintf only slightly less so. Someone needs to just go through the code
> and rewrite all instances in modern C++ using std::string, std::stringstream,
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
>
[jira] [Resolved] (GEODE-9591) Native client re-execute function even Function.isHA() is set to false and redundancy in not used on partition region
[ https://issues.apache.org/jira/browse/GEODE-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9591. - Fix Version/s: 1.15.0 Resolution: Fixed > Native client re-execute function even Function.isHA() is set to false and > redundancy in not used on partition region > - > > Key: GEODE-9591 > URL: https://issues.apache.org/jira/browse/GEODE-9591 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Jakov Varenina >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > This behavior of native client should be aligned with java client. Java > client in this case doesn't re-execute the function, but it trows the > exception that received > from the server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9591) Native client re-execute function even Function.isHA() is set to false and redundancy in not used on partition region
[ https://issues.apache.org/jira/browse/GEODE-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9591. --- > Native client re-execute function even Function.isHA() is set to false and > redundancy in not used on partition region > - > > Key: GEODE-9591 > URL: https://issues.apache.org/jira/browse/GEODE-9591 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Jakov Varenina >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > This behavior of native client should be aligned with java client. Java > client in this case doesn't re-execute the function, but it trows the > exception that received > from the server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9634) Wan replication between clusters on localhost broken by change to IP lookup
[ https://issues.apache.org/jira/browse/GEODE-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9634: Affects Version/s: 1.15.0 > Wan replication between clusters on localhost broken by change to IP lookup > --- > > Key: GEODE-9634 > URL: https://issues.apache.org/jira/browse/GEODE-9634 > Project: Geode > Issue Type: Bug > Components: wan >Affects Versions: 1.15.0 >Reporter: Blake Bender >Priority: Major > > This was the fix for GEODE-8955 (PR #6045). Here's a description from the > start of the Slack discussion thread: > "PR 6045 made on geode-wan LocatorHelper class seems to have broken WAN > replication between two clusters on localhost. I get the ridiculous nature of > WAN over localhost. Is it intentional that localhost is replaced with a local > interface IP by the changes made in the PR? The result is a test in the > geode-native pipeline does not work anymore since one site can’t see the > other since the locators are bound to localhost but trying to connection to > each other on a non-localhost IP address. Did we run into this same issue on > any of our Java based tests?" > Need to determine if this is desired behavior or not. If not, the old > behavior should be restored. If so, geode native team needs a JIRA ticket to > fix their Wan integration test(s) in CI, where this issue was detected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9634) Wan replication between clusters on localhost broken by change to IP lookup
[ https://issues.apache.org/jira/browse/GEODE-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9634: Priority: Blocker (was: Major) > Wan replication between clusters on localhost broken by change to IP lookup > --- > > Key: GEODE-9634 > URL: https://issues.apache.org/jira/browse/GEODE-9634 > Project: Geode > Issue Type: Bug > Components: wan >Affects Versions: 1.15.0 >Reporter: Blake Bender >Priority: Blocker > > This was the fix for GEODE-8955 (PR #6045). Here's a description from the > start of the Slack discussion thread: > "PR 6045 made on geode-wan LocatorHelper class seems to have broken WAN > replication between two clusters on localhost. I get the ridiculous nature of > WAN over localhost. Is it intentional that localhost is replaced with a local > interface IP by the changes made in the PR? The result is a test in the > geode-native pipeline does not work anymore since one site can’t see the > other since the locators are bound to localhost but trying to connection to > each other on a non-localhost IP address. Did we run into this same issue on > any of our Java based tests?" > Need to determine if this is desired behavior or not. If not, the old > behavior should be restored. If so, geode native team needs a JIRA ticket to > fix their Wan integration test(s) in CI, where this issue was detected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9637) Disable Wan serialization test pending fix from Geode
[ https://issues.apache.org/jira/browse/GEODE-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9637. - Resolution: Fixed > Disable Wan serialization test pending fix from Geode > - > > Key: GEODE-9637 > URL: https://issues.apache.org/jira/browse/GEODE-9637 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > GEODE-9634 is currently breaking our Wan serialization test. This test is > fairly obscure and does something no one would ever do in production, so > while we wait for a bug fix from Geode, it's a fairly safe thing to simply > disable our failing test. This will get the CI pipeline back to green until > Geode merges their change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9637) Disable Wan serialization test pending fix from Geode
[ https://issues.apache.org/jira/browse/GEODE-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9637. --- > Disable Wan serialization test pending fix from Geode > - > > Key: GEODE-9637 > URL: https://issues.apache.org/jira/browse/GEODE-9637 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > GEODE-9634 is currently breaking our Wan serialization test. This test is > fairly obscure and does something no one would ever do in production, so > while we wait for a bug fix from Geode, it's a fairly safe thing to simply > disable our failing test. This will get the CI pipeline back to green until > Geode merges their change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9637) Disable Wan serialization test pending fix from Geode
[ https://issues.apache.org/jira/browse/GEODE-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender reassigned GEODE-9637: --- Assignee: Blake Bender > Disable Wan serialization test pending fix from Geode > - > > Key: GEODE-9637 > URL: https://issues.apache.org/jira/browse/GEODE-9637 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > GEODE-9634 is currently breaking our Wan serialization test. This test is > fairly obscure and does something no one would ever do in production, so > while we wait for a bug fix from Geode, it's a fairly safe thing to simply > disable our failing test. This will get the CI pipeline back to green until > Geode merges their change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9637) Disable Wan serialization test pending fix from Geode
Blake Bender created GEODE-9637: --- Summary: Disable Wan serialization test pending fix from Geode Key: GEODE-9637 URL: https://issues.apache.org/jira/browse/GEODE-9637 Project: Geode Issue Type: Task Components: native client Reporter: Blake Bender GEODE-9634 is currently breaking our Wan serialization test. This test is fairly obscure and does something no one would ever do in production, so while we wait for a bug fix from Geode, it's a fairly safe thing to simply disable our failing test. This will get the CI pipeline back to green until Geode merges their change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9634) Wan replication between clusters on localhost broken by change to IP lookup
[ https://issues.apache.org/jira/browse/GEODE-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9634: Component/s: wan > Wan replication between clusters on localhost broken by change to IP lookup > --- > > Key: GEODE-9634 > URL: https://issues.apache.org/jira/browse/GEODE-9634 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Blake Bender >Priority: Major > > This was the fix for GEODE-8955 (PR #6045). Here's a description from the > start of the Slack discussion thread: > "PR 6045 made on geode-wan LocatorHelper class seems to have broken WAN > replication between two clusters on localhost. I get the ridiculous nature of > WAN over localhost. Is it intentional that localhost is replaced with a local > interface IP by the changes made in the PR? The result is a test in the > geode-native pipeline does not work anymore since one site can’t see the > other since the locators are bound to localhost but trying to connection to > each other on a non-localhost IP address. Did we run into this same issue on > any of our Java based tests?" > Need to determine if this is desired behavior or not. If not, the old > behavior should be restored. If so, geode native team needs a JIRA ticket to > fix their Wan integration test(s) in CI, where this issue was detected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9634) Wan replication between clusters on localhost broken by change to IP lookup
Blake Bender created GEODE-9634: --- Summary: Wan replication between clusters on localhost broken by change to IP lookup Key: GEODE-9634 URL: https://issues.apache.org/jira/browse/GEODE-9634 Project: Geode Issue Type: Bug Reporter: Blake Bender This was the fix for GEODE-8955 (PR #6045). Here's a description from the start of the Slack discussion thread: "PR 6045 made on geode-wan LocatorHelper class seems to have broken WAN replication between two clusters on localhost. I get the ridiculous nature of WAN over localhost. Is it intentional that localhost is replaced with a local interface IP by the changes made in the PR? The result is a test in the geode-native pipeline does not work anymore since one site can’t see the other since the locators are bound to localhost but trying to connection to each other on a non-localhost IP address. Did we run into this same issue on any of our Java based tests?" Need to determine if this is desired behavior or not. If not, the old behavior should be restored. If so, geode native team needs a JIRA ticket to fix their Wan integration test(s) in CI, where this issue was detected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9357) Create CI pipeline for net-core-session
[ https://issues.apache.org/jira/browse/GEODE-9357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9357. - Fix Version/s: 1.15.0 Resolution: Not A Problem Don't need this - we're already building/testing session in the main pipeline. > Create CI pipeline for net-core-session > --- > > Key: GEODE-9357 > URL: https://issues.apache.org/jira/browse/GEODE-9357 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Fix For: 1.15.0 > > > This pipeline will be hosted on the Apache publicly available Concourse and > publish to NuGet -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9189) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9189. --- > Upgrade dependencies > > > Key: GEODE-9189 > URL: https://issues.apache.org/jira/browse/GEODE-9189 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Upgrade Boost to 1.77. > Upgrade ACE to 7.0.3. > Upgrade GTest 1.11.0. > Upgrade Benchmark 1.5.6. > Upgrade SQLite to 3.36.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9594) Implement integer types for put/get in .net core
Blake Bender created GEODE-9594: --- Summary: Implement integer types for put/get in .net core Key: GEODE-9594 URL: https://issues.apache.org/jira/browse/GEODE-9594 Project: Geode Issue Type: New Feature Components: native client Reporter: Blake Bender There are several numeric types under the "cacheable built-ins" umbrella in the CLI code - Int16, Int32, Int64, double, and float, perhaps others. We can add put/get support for these types to the Region object, giving us a lot more flexibility and a blueprint for adding the remaining Geode-supported types. Feel free to implement these one at a time, if it makes for more reasonable PRs. Like add a CacheableInt32 class, implement toData/fromData/Equals/HashCode/whatever else is required to match features in the current .net API, then implement put/get for this type. Be sure to include appropriate unit & integration tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9551) New SNI proxy API does not conform to standards.
[
https://issues.apache.org/jira/browse/GEODE-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-9551.
-
Resolution: Fixed
> New SNI proxy API does not conform to standards.
>
>
> Key: GEODE-9551
> URL: https://issues.apache.org/jira/browse/GEODE-9551
> Project: Geode
> Issue Type: Bug
> Components: native client
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0, 1.15.0
>
>
> APIs should be consistent with other APIs:
> All class/struct properties should be returned {{const &}} in getters and
> copied in setters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9572) Ensure valid parameter combinations in test framework "Cluster" object
Blake Bender created GEODE-9572: --- Summary: Ensure valid parameter combinations in test framework "Cluster" object Key: GEODE-9572 URL: https://issues.apache.org/jira/browse/GEODE-9572 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender The current C++ test framework works well as far as it goes, but the Cluster object, which is just a wrapper around a call to gfsh, doesn't examine its parameters pretty much at all. This means it's easy to build and run code that attempts to launch gfsh with invalid or missing parameters. If we built this knowledge into the Cluster class, we could make this fail at build time, rather than run time, saving developers' time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc
Blake Bender created GEODE-9553:
---
Summary: Review and eliminate all remaining usage of sprintf,
snprintf, etc
Key: GEODE-9553
URL: https://issues.apache.org/jira/browse/GEODE-9553
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
>From time to time, we will pick up a new version of a compiler on one or
>another platform we build on, and get new complaints about potential buffer
>overflows or other assorted badness around persistent use of sprintf. See the
>following pull request, e.g.: https://github.com/apache/geode-native/pull/861
Fixing these when they come up is good as far as it goes, but we're really just
applying band-aids to the problem. *All* use of sprintf is bad, snprintf only
slightly less so. Someone needs to just go through the code and rewrite all
instances in modern C++ using std::string, std::stringstream, etc.
At a glance, here is the list of remaining files containing calls to sprintf:
{code}
c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
cppcache\integration\test\ThinClientConflation.cpp
cppcache\integration-test\fw_dunit.cpp
cppcache\integration-test\testCacheless.cpp
cppcache\integration-test\testOverflowPutGetSqLite.cpp
cppcache\integration-test\testRegionMap.cpp
cppcache\integration-test\testSerialization.cpp
cppcache\integration-test\testThinClientBigValue.cpp
cppcache\integration-test\testThinClientCacheablesLimits.cpp
cppcache\integration-test\testThinClientCacheableStringArray.cpp
cppcache\integration-test\testThinClientConflation.cpp
cppcache\integration-test\testThinClientCq.cpp
cppcache\integration-test\testThinClientCqDurable.cpp
cppcache\integration-test\testThinClientCqFailover.cpp
cppcache\integration-test\testThinClientCqHAFailover.cpp
cppcache\integration-test\testThinClientCqIR.cpp
cppcache\integration-test\testThinClientDeltaWithNotification.cpp
cppcache\integration-test\testThinClientGetInterests.cpp
cppcache\integration-test\testThinClientHADistOps.cpp
cppcache\integration-test\testThinClientHAEventIDMap.cpp
cppcache\integration-test\testThinClientHAFailover.cpp
cppcache\integration-test\testThinClientHAFailoverRegex.cpp
cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
cppcache\integration-test\testThinClientHAPeriodicAck.cpp
cppcache\integration-test\testThinClientHeapLRU.cpp
cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
cppcache\integration-test\testThinClientInterestNotify.cpp
cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
cppcache\integration-test\testThinClientLRUExpiration.cpp
cppcache\integration-test\testThinClientMultiDS.cpp
cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
cppcache\integration-test\testThinClientPdxInstance.cpp
cppcache\integration-test\testThinClientPoolAttrTest.cpp
cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
cppcache\integration-test\testThinClientPoolRedundancy.cpp
cppcache\integration-test\testThinClientPRPutAllFailover.cpp
cppcache\integration-test\testThinClientRemoteQueryRS.cpp
cppcache\integration-test\testThinClientRemoteQuerySS.cpp
cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
cppcache\integration-test\testThinClientRemoveOps.cpp
cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
cppcache\integration-test\testXmlCacheCreationWithPools.cpp
cppcache\integration-test\testXmlCacheInitialization.cpp
tests\cpp\security\PkcsCredentialGenerator.cpp
tests\cpp\security\XmlAuthzCredentialGenerator.cpp
tests\cpp\testobject\BatchObject.cpp
tests\cpp\testobject\DeltaPSTObject.cpp
tests\cpp\testobject\DeltaTestImpl.cpp
tests\cpp\testobject\EqStruct.cpp
tests\cpp\testobject\FastAssetAccount.cpp
tests\cpp\testobject\InvalidPdxUsage.cpp
tests\cpp\testobject\NestedPdxObject.cpp
tests\cpp\testobject\PdxClassV1.cpp
tests\cpp\testobject\PdxClassV2.cpp
tests\cpp\testobject\PdxType.cpp
tests\cpp\testobject\Portfolio.cpp
tests\cpp\testobject\PortfolioPdx.cpp
tests\cpp\testobject\Position.cpp
tests\cpp\testobject\PositionPdx.cpp
tests\cpp\testobject\PSTObject.cpp
tests\cpp\testobject\VariousPdxTypes.cpp
{code}
and snprintf:
{code}
c:\Users\bblake\src\geode-native>findstr /sm snprintf *.cpp
cppcache\src\CacheXmlParser.cpp
cppcache\src\CqEventImpl.cpp
cppcache\src\Log.cpp
cppcache\src\PdxFieldType.cpp
cppcache\src\PdxInstanceImpl.cpp
cppcache\src\RegionFactory.cpp
cppcache\src\RemoteQuery.cpp
cppcache\src\statistics\AtomicStatisticsImpl.cpp
cppcache\src\statistics\OsStatisticsImpl.cpp
cppcache\src\TcrMessage.cpp
cppcache\src\ThinClientRegion.cpp
[jira] [Created] (GEODE-9549) Enable .net core tests in CI
Blake Bender created GEODE-9549: --- Summary: Enable .net core tests in CI Key: GEODE-9549 URL: https://issues.apache.org/jira/browse/GEODE-9549 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender The .net core build and tests are integrated into the CI, but test running is currently disabled due to a few issues. These need to be cleaned up, and tests enabled in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9412) App crashes when translating string with certain Unicode characters (exception thrown across managed/native boundary)
[ https://issues.apache.org/jira/browse/GEODE-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9412. --- > App crashes when translating string with certain Unicode characters > (exception thrown across managed/native boundary) > - > > Key: GEODE-9412 > URL: https://issues.apache.org/jira/browse/GEODE-9412 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > tl;dr, we're not translating unicode correctly between .net and C++. > When a unicode string comes into the CLI layer, we use > `marshal_as` to translate, then assume this yields UTF-8. In > fact, what it yields is a string encoded in a) whatever the local code page > is for the system, or b) the default code page for the app, if one exists in > the manifest. In the C++ layer, we then assume the string is UTF-8, and for > a PUT, attempt to translate into Java-modified UTF-8, which ends up throwing > an uncaught exception when it encounters a character that is not a valid > UTF-8 start code. When this exception hits the native/managed boundary, the > app crashes. > To avoid this issue, we need to `marshal_as`, then use `std` > conversion functions to arrive at UTF-8, and pass that down to the C++ layer. > We also need to use the reverse process when sending strings back up to CLI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9412) App crashes when translating string with certain Unicode characters (exception thrown across managed/native boundary)
[ https://issues.apache.org/jira/browse/GEODE-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9412. - Resolution: Fixed > App crashes when translating string with certain Unicode characters > (exception thrown across managed/native boundary) > - > > Key: GEODE-9412 > URL: https://issues.apache.org/jira/browse/GEODE-9412 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > tl;dr, we're not translating unicode correctly between .net and C++. > When a unicode string comes into the CLI layer, we use > `marshal_as` to translate, then assume this yields UTF-8. In > fact, what it yields is a string encoded in a) whatever the local code page > is for the system, or b) the default code page for the app, if one exists in > the manifest. In the C++ layer, we then assume the string is UTF-8, and for > a PUT, attempt to translate into Java-modified UTF-8, which ends up throwing > an uncaught exception when it encounters a character that is not a valid > UTF-8 start code. When this exception hits the native/managed boundary, the > app crashes. > To avoid this issue, we need to `marshal_as`, then use `std` > conversion functions to arrive at UTF-8, and pass that down to the C++ layer. > We also need to use the reverse process when sending strings back up to CLI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9524) Make name of directory agree with library name for C bindings
[ https://issues.apache.org/jira/browse/GEODE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9524. --- > Make name of directory agree with library name for C bindings > - > > Key: GEODE-9524 > URL: https://issues.apache.org/jira/browse/GEODE-9524 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Path uses c_bindings with a '_', but the library is c-bindings with a "-". > Switch to "-" everywhere for consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9524) Make name of directory agree with library name for C bindings
[ https://issues.apache.org/jira/browse/GEODE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9524. - Fix Version/s: 1.15.0 Resolution: Fixed > Make name of directory agree with library name for C bindings > - > > Key: GEODE-9524 > URL: https://issues.apache.org/jira/browse/GEODE-9524 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Path uses c_bindings with a '_', but the library is c-bindings with a "-". > Switch to "-" everywhere for consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9524) Make name of directory agree with library name for C bindings
[ https://issues.apache.org/jira/browse/GEODE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9524: Description: Path uses c_bindings with a '_', but the library is c-bindings with a "-". Switch to "-" everywhere for consistency. (was: Path uses c_bindings with a '_', but the library is c-bindings with a '-'. Switch to '-' everywhere for consistency.) > Make name of directory agree with library name for C bindings > - > > Key: GEODE-9524 > URL: https://issues.apache.org/jira/browse/GEODE-9524 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > > Path uses c_bindings with a '_', but the library is c-bindings with a "-". > Switch to "-" everywhere for consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9524) Make name of directory agree with library name for C bindings
[ https://issues.apache.org/jira/browse/GEODE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9524: Description: Path uses c_bindings with a '_', but the library is c-bindings with a '-'. Switch to '-' everywhere for consistency. (was: Path uses c_bindings with a `_`, but the library is c-bindings with a `-`. Switch to `-` everywhere for consistency.) > Make name of directory agree with library name for C bindings > - > > Key: GEODE-9524 > URL: https://issues.apache.org/jira/browse/GEODE-9524 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > > Path uses c_bindings with a '_', but the library is c-bindings with a '-'. > Switch to '-' everywhere for consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9524) Make name of directory agree with library name for C bindings
Blake Bender created GEODE-9524: --- Summary: Make name of directory agree with library name for C bindings Key: GEODE-9524 URL: https://issues.apache.org/jira/browse/GEODE-9524 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender Path uses c_bindings with a `_`, but the library is c-bindings with a `-`. Switch to `-` everywhere for consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9502) Eliminate templates used to work around now-obsolete MSVC compiler warning
Blake Bender created GEODE-9502: --- Summary: Eliminate templates used to work around now-obsolete MSVC compiler warning Key: GEODE-9502 URL: https://issues.apache.org/jira/browse/GEODE-9502 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender CacheableBuiltins.hpp contains the following comment, followed by a bunch of very strange template definitions: // The following are defined as classes to avoid the issues with MSVC++ // warning/erroring on C4503 According to Microsoft (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4503?view=msvc-160), this warning was obsolete as of VS2017. We no longer support any pre-VS2017 compilers, so it should be safe to remove all this nonsense and replace it with the template(s) originally intended. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9359) add net-core-session to geode-native
[ https://issues.apache.org/jira/browse/GEODE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9359. - Fix Version/s: 1.15.0 Resolution: Fixed > add net-core-session to geode-native > > > Key: GEODE-9359 > URL: https://issues.apache.org/jira/browse/GEODE-9359 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > net-core-session shall be added to the top level of geode-native repo and > will produce a separate binary that will be publishable to NuGet > https://docs.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9359) add net-core-session to geode-native
[ https://issues.apache.org/jira/browse/GEODE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9359. --- > add net-core-session to geode-native > > > Key: GEODE-9359 > URL: https://issues.apache.org/jira/browse/GEODE-9359 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > net-core-session shall be added to the top level of geode-native repo and > will produce a separate binary that will be publishable to NuGet > https://docs.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9487) Timezone is potentially invalid string in log files for non-English locales
[ https://issues.apache.org/jira/browse/GEODE-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9487. - Fix Version/s: 1.15.0 Resolution: Fixed > Timezone is potentially invalid string in log files for non-English locales > > > Key: GEODE-9487 > URL: https://issues.apache.org/jira/browse/GEODE-9487 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > The native client logger was rewritten several months ago to use, among other > things, `std::put_time` when formatting log strings, specifically using the > "%Z" formatting for timezone. The documentation for this formatting says > "writes locale-dependent time zone name or abbreviation, or no characters if > the time zone information is not available," and indeed it does. We just > received a log file from a customer machine in APJ region, i.e. locale is set > to something like Traditional Chinese. These strings are dumped into the log > file as is, in some unknown MBCS encoding, and contain invalid utf-8 start > codes, throwing off our Python-based parsing tool. > We should probably just drop time zone from our logs, or normalize everything > somehow. In any case, we need to write valid utf-8, just to play well with > others. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9487) Timezone is potentially invalid string in log files for non-English locales
[ https://issues.apache.org/jira/browse/GEODE-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9487. --- > Timezone is potentially invalid string in log files for non-English locales > > > Key: GEODE-9487 > URL: https://issues.apache.org/jira/browse/GEODE-9487 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > The native client logger was rewritten several months ago to use, among other > things, `std::put_time` when formatting log strings, specifically using the > "%Z" formatting for timezone. The documentation for this formatting says > "writes locale-dependent time zone name or abbreviation, or no characters if > the time zone information is not available," and indeed it does. We just > received a log file from a customer machine in APJ region, i.e. locale is set > to something like Traditional Chinese. These strings are dumped into the log > file as is, in some unknown MBCS encoding, and contain invalid utf-8 start > codes, throwing off our Python-based parsing tool. > We should probably just drop time zone from our logs, or normalize everything > somehow. In any case, we need to write valid utf-8, just to play well with > others. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9472) Improve Test Stability of VerifyNoLeakedThreads
[ https://issues.apache.org/jira/browse/GEODE-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender updated GEODE-9472: Fix Version/s: 1.15.0 > Improve Test Stability of VerifyNoLeakedThreads > --- > > Key: GEODE-9472 > URL: https://issues.apache.org/jira/browse/GEODE-9472 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > This test fails occasionally in the CI due to the heuristic being a little > too stringent for such a dynamic environment. Just need to broaden the > acceptable range for the ratio process threads before and after a cache > operation and cache close. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9472) Improve Test Stability of VerifyNoLeakedThreads
[ https://issues.apache.org/jira/browse/GEODE-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9472. - Resolution: Fixed > Improve Test Stability of VerifyNoLeakedThreads > --- > > Key: GEODE-9472 > URL: https://issues.apache.org/jira/browse/GEODE-9472 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > This test fails occasionally in the CI due to the heuristic being a little > too stringent for such a dynamic environment. Just need to broaden the > acceptable range for the ratio process threads before and after a cache > operation and cache close. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9472) Improve Test Stability of VerifyNoLeakedThreads
[ https://issues.apache.org/jira/browse/GEODE-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9472. --- > Improve Test Stability of VerifyNoLeakedThreads > --- > > Key: GEODE-9472 > URL: https://issues.apache.org/jira/browse/GEODE-9472 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > This test fails occasionally in the CI due to the heuristic being a little > too stringent for such a dynamic environment. Just need to broaden the > acceptable range for the ratio process threads before and after a cache > operation and cache close. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9487) Timezone is potentially invalid string in log files for non-English locales
[ https://issues.apache.org/jira/browse/GEODE-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender reassigned GEODE-9487: --- Assignee: Blake Bender > Timezone is potentially invalid string in log files for non-English locales > > > Key: GEODE-9487 > URL: https://issues.apache.org/jira/browse/GEODE-9487 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > The native client logger was rewritten several months ago to use, among other > things, `std::put_time` when formatting log strings, specifically using the > "%Z" formatting for timezone. The documentation for this formatting says > "writes locale-dependent time zone name or abbreviation, or no characters if > the time zone information is not available," and indeed it does. We just > received a log file from a customer machine in APJ region, i.e. locale is set > to something like Traditional Chinese. These strings are dumped into the log > file as is, in some unknown MBCS encoding, and contain invalid utf-8 start > codes, throwing off our Python-based parsing tool. > We should probably just drop time zone from our logs, or normalize everything > somehow. In any case, we need to write valid utf-8, just to play well with > others. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7222) Add CMake support for building only the static library of cppcache
[ https://issues.apache.org/jira/browse/GEODE-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-7222. - Resolution: Fixed This may never have been an issue, since the `apache-geode-static` cmake has been there as long as I can remember, so probably since we switched the build to cmake. At any rate, for sure you can build that target now, and there are two PRs attached to this bug that must've fixed _something_, so I'm closing the bug. > Add CMake support for building only the static library of cppcache > -- > > Key: GEODE-7222 > URL: https://issues.apache.org/jira/browse/GEODE-7222 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ivan Godwin >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We would like to have the ability to build only the static library of > cppcache, along with its dependencies. This would make it easier for external > projects that have Apache Geode Native Client as a dependency, and only want > the static library. > Note: This is required because we don't ship the static version of Apache > Geode Native Client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7222) Add CMake support for building only the static library of cppcache
[ https://issues.apache.org/jira/browse/GEODE-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396792#comment-17396792 ] Blake Bender edited comment on GEODE-7222 at 8/10/21, 5:09 PM: --- This may never have been an issue, since the `apache-geode-static` cmake target has been there as long as I can remember, so probably since we switched the build to cmake. At any rate, for sure you can build that target now, and there are two PRs attached to this bug that must've fixed _something_, so I'm closing the bug. was (Author: bbender): This may never have been an issue, since the `apache-geode-static` cmake has been there as long as I can remember, so probably since we switched the build to cmake. At any rate, for sure you can build that target now, and there are two PRs attached to this bug that must've fixed _something_, so I'm closing the bug. > Add CMake support for building only the static library of cppcache > -- > > Key: GEODE-7222 > URL: https://issues.apache.org/jira/browse/GEODE-7222 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ivan Godwin >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We would like to have the ability to build only the static library of > cppcache, along with its dependencies. This would make it easier for external > projects that have Apache Geode Native Client as a dependency, and only want > the static library. > Note: This is required because we don't ship the static version of Apache > Geode Native Client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-7222) Add CMake support for building only the static library of cppcache
[ https://issues.apache.org/jira/browse/GEODE-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-7222. --- > Add CMake support for building only the static library of cppcache > -- > > Key: GEODE-7222 > URL: https://issues.apache.org/jira/browse/GEODE-7222 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ivan Godwin >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We would like to have the ability to build only the static library of > cppcache, along with its dependencies. This would make it easier for external > projects that have Apache Geode Native Client as a dependency, and only want > the static library. > Note: This is required because we don't ship the static version of Apache > Geode Native Client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7324) FIx invalid encoding in log files
[ https://issues.apache.org/jira/browse/GEODE-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-7324. - Resolution: Won't Fix This was fixed in a PR for another bug, closing it out. > FIx invalid encoding in log files > - > > Key: GEODE-7324 > URL: https://issues.apache.org/jira/browse/GEODE-7324 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > > As a developer, I wish to be able to write log parsing utilities for the > native client if need be. To do this, I need to be able to read the text in > the log files via standard languages like Python, C#, etc. Unfortunately, > recent changes to some log statements in the native client code will cause > invalid utf-8 bytes to be written to the log in some circumstances, making > reading the log very difficult. > > repro steps: > i. Enable debug-level logging in NC integration tests, and set log-file to a > known filename > ii. Run a test case, to generate the log file > iii. Attempt to parse the file as utf-8 in Python > > Expected result: > * File parses correctly > Actual result: > * Python throws an exception, saying it has encountered an invalid start byte > > This is known to happen when using the '%zu' format specifier to log a value > of type std::chrono::Rep on MacOS. Other compilers/OSes/types may or may not > display this behavior. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-7324) FIx invalid encoding in log files
[ https://issues.apache.org/jira/browse/GEODE-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-7324. --- > FIx invalid encoding in log files > - > > Key: GEODE-7324 > URL: https://issues.apache.org/jira/browse/GEODE-7324 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > > As a developer, I wish to be able to write log parsing utilities for the > native client if need be. To do this, I need to be able to read the text in > the log files via standard languages like Python, C#, etc. Unfortunately, > recent changes to some log statements in the native client code will cause > invalid utf-8 bytes to be written to the log in some circumstances, making > reading the log very difficult. > > repro steps: > i. Enable debug-level logging in NC integration tests, and set log-file to a > known filename > ii. Run a test case, to generate the log file > iii. Attempt to parse the file as utf-8 in Python > > Expected result: > * File parses correctly > Actual result: > * Python throws an exception, saying it has encountered an invalid start byte > > This is known to happen when using the '%zu' format specifier to log a value > of type std::chrono::Rep on MacOS. Other compilers/OSes/types may or may not > display this behavior. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8160) Migrate old integration test testThinClientConflation to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8160. --- Getting rid of all the individual "port integration text *" bugs. We're not actively working on these, and they're clogging up the works so it's hard to tell what we are doing. > Migrate old integration test testThinClientConflation to new test framework > --- > > Key: GEODE-8160 > URL: https://issues.apache.org/jira/browse/GEODE-8160 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7433) Need to upgrade clang-format to v8 on all platforms
[ https://issues.apache.org/jira/browse/GEODE-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-7433. - Fix Version/s: 1.15.0 Resolution: Fixed We're now on v12 on CI for all platforms. > Need to upgrade clang-format to v8 on all platforms > --- > > Key: GEODE-7433 > URL: https://issues.apache.org/jira/browse/GEODE-7433 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Priority: Major > Fix For: 1.15.0 > > > As a developer, I would like to build the native client on the most standard > setup I can achieve with respect to toolchains etc. Travis CI and our Ubuntu > machines are on clang-format v6, which is out-of-date and has a couple of key > incompatibilities preventing us from using something current on build > machines. It's possible to upgrade to clang-format v8 on our Ubuntu machines > by using the LLVM apt repo. Once we've achieved this, we will need to also > upgrade clang-format on the Docker image we use for Travis CI, on our RHEL7 > images, and on our Windows images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-7433) Need to upgrade clang-format to v8 on all platforms
[ https://issues.apache.org/jira/browse/GEODE-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-7433. --- > Need to upgrade clang-format to v8 on all platforms > --- > > Key: GEODE-7433 > URL: https://issues.apache.org/jira/browse/GEODE-7433 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Blake Bender >Priority: Major > Fix For: 1.15.0 > > > As a developer, I would like to build the native client on the most standard > setup I can achieve with respect to toolchains etc. Travis CI and our Ubuntu > machines are on clang-format v6, which is out-of-date and has a couple of key > incompatibilities preventing us from using something current on build > machines. It's possible to upgrade to clang-format v8 on our Ubuntu machines > by using the LLVM apt repo. Once we've achieved this, we will need to also > upgrade clang-format on the Docker image we use for Travis CI, on our RHEL7 > images, and on our Windows images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8160) Migrate old integration test testThinClientConflation to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8160. - Resolution: Won't Fix > Migrate old integration test testThinClientConflation to new test framework > --- > > Key: GEODE-8160 > URL: https://issues.apache.org/jira/browse/GEODE-8160 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8161) Migrate old integration test testThinClientCqIR to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8161. - Resolution: Won't Fix Getting rid of all the individual "port integration text *" bugs. We're not actively working on these, and they're clogging up the works so it's hard to tell what we are doing. > Migrate old integration test testThinClientCqIR to new test framework > - > > Key: GEODE-8161 > URL: https://issues.apache.org/jira/browse/GEODE-8161 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8164) Migrate old integration test testThinClientFailoverInterestAllWithCache to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8164. --- > Migrate old integration test testThinClientFailoverInterestAllWithCache to > new test framework > - > > Key: GEODE-8164 > URL: https://issues.apache.org/jira/browse/GEODE-8164 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8163) Migrate old integration test testThinClientDisconnectionListioner to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8163. --- > Migrate old integration test testThinClientDisconnectionListioner to new > test framework > > > Key: GEODE-8163 > URL: https://issues.apache.org/jira/browse/GEODE-8163 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8163) Migrate old integration test testThinClientDisconnectionListioner to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8163. - Resolution: Won't Fix Getting rid of all the individual "port integration text *" bugs. We're not actively working on these, and they're clogging up the works so it's hard to tell what we are doing. > Migrate old integration test testThinClientDisconnectionListioner to new > test framework > > > Key: GEODE-8163 > URL: https://issues.apache.org/jira/browse/GEODE-8163 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8161) Migrate old integration test testThinClientCqIR to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8161. --- > Migrate old integration test testThinClientCqIR to new test framework > - > > Key: GEODE-8161 > URL: https://issues.apache.org/jira/browse/GEODE-8161 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8164) Migrate old integration test testThinClientFailoverInterestAllWithCache to new test framework
[ https://issues.apache.org/jira/browse/GEODE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8164. - Resolution: Won't Fix Getting rid of all the individual "port integration text *" bugs. We're not actively working on these, and they're clogging up the works so it's hard to tell what we are doing. > Migrate old integration test testThinClientFailoverInterestAllWithCache to > new test framework > - > > Key: GEODE-8164 > URL: https://issues.apache.org/jira/browse/GEODE-8164 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
