[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738494#comment-16738494 ] ASF subversion and git services commented on GEODE-3967: Commit 7f2950c2098437902c86b3b5309d8de0c831aa6c in geode's branch refs/heads/develop from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7f2950c ] GEODE-3967: fix the offheap memory leak in serial gateway sender's unprocessedEvents. When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue Let event with CME only enqueue to primary, but not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. We should not dispatch the CME event, otherwise it will cause remote site data inconsistency since these CME events are misordered. So we should enqueue it, but not to dispatch. Also add rollingUpgradeTests > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 2h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738495#comment-16738495 ] ASF subversion and git services commented on GEODE-3967: Commit ea46d007bd2259edbc674d9a2636dedab10e2842 in geode's branch refs/heads/develop from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ea46d00 ] Merge pull request #3044 from gesterzhou/feature/GEODE-3967 GEODE-3967: fix the offheap memory leak in serial gateway sender's un… > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 2h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738496#comment-16738496 ] ASF subversion and git services commented on GEODE-3967: Commit ea46d007bd2259edbc674d9a2636dedab10e2842 in geode's branch refs/heads/develop from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ea46d00 ] Merge pull request #3044 from gesterzhou/feature/GEODE-3967 GEODE-3967: fix the offheap memory leak in serial gateway sender's un… > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 2h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737642#comment-16737642 ] xiaojian zhou commented on GEODE-3967: -- Add back the fix to resolve entry leak in unprocessedKeys. When dispatching, filtered out the event with CME. Introduced boolean in GatewaySenderEventImpl. Also fixed the hard-coded VERSION=0x11, i.e. GFE_662_ORDINAL for all the versions. Add unit tests specified in GEODE-4886. Add junit test for fix in AbstractUpdateOperation for doPutOrCreate's 3 retries. Add junit test for SerialGatewaySenderEventProcessor's put it into the map of unprocessed events, except 2 Special cases:1) UPDATE_VERSION_STAMP: only enqueue to primary 2) CME && !originRemote: only enqueue to primary. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637521#comment-16637521 ] ASF subversion and git services commented on GEODE-3967: Commit dd78494ec4caf952065d289ed0f9ddef0c9854ee in geode's branch refs/heads/master from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=dd78494 ] GEODE-3967: Cleaning up of revert issues (#2523) * The revert of previous code was missing test changes due to geode test structure changes. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637520#comment-16637520 ] ASF subversion and git services commented on GEODE-3967: Commit 38dd00103913b40a6f4f395f1e4daa79834b0195 in geode's branch refs/heads/master from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=38dd001 ] Revert "GEODE-3967: There're following 9 problems fixed here:" This reverts commit de7c6d8b4a9b3e2c1c0ebd4ce1835aff0007f9e1. This commit seems to increase the likelihood of causing an WAN inconsistency > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630962#comment-16630962 ] ASF subversion and git services commented on GEODE-3967: Commit dd78494ec4caf952065d289ed0f9ddef0c9854ee in geode's branch refs/heads/release/1.7.0 from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=dd78494 ] GEODE-3967: Cleaning up of revert issues (#2523) * The revert of previous code was missing test changes due to geode test structure changes. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630846#comment-16630846 ] ASF subversion and git services commented on GEODE-3967: Commit 7ec2cb081c2f29cbc154688af8a016c719fa5f5a in geode's branch refs/heads/develop from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ec2cb0 ] GEODE-3967: Cleaning up of revert issues (#2523) * The revert of previous code was missing test changes due to geode test structure changes. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629719#comment-16629719 ] ASF subversion and git services commented on GEODE-3967: Commit 38dd00103913b40a6f4f395f1e4daa79834b0195 in geode's branch refs/heads/release/1.7.0 from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=38dd001 ] Revert "GEODE-3967: There're following 9 problems fixed here:" This reverts commit de7c6d8b4a9b3e2c1c0ebd4ce1835aff0007f9e1. This commit seems to increase the likelihood of causing an WAN inconsistency > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629577#comment-16629577 ] ASF subversion and git services commented on GEODE-3967: Commit a1bed426f0606f158d54047205e1cdfe18383920 in geode's branch refs/heads/develop from [~huynhja] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a1bed42 ] Revert "GEODE-3967: There're following 9 problems fixed here:" This reverts commit de7c6d8b4a9b3e2c1c0ebd4ce1835aff0007f9e1. This commit seems to increase the likelihood of causing an WAN inconsistency > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629451#comment-16629451 ] ASF subversion and git services commented on GEODE-3967: Commit 9cb0131de13bc6a4987875f5a5efbbb05e73d988 in geode's branch refs/heads/feature/GEM-2228-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9cb0131 ] GEM-2228-883: The previous fix for GEODE-3967 caused an event with CME is dispatched. This has a side effect of data inconsistency of WAN. The enhanced fix is to enqueue the CME event but not to dispatch it. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364503#comment-16364503 ] ASF subversion and git services commented on GEODE-3967: Commit de7c6d8b4a9b3e2c1c0ebd4ce1835aff0007f9e1 in geode's branch refs/heads/develop from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=de7c6d8 ] GEODE-3967: There're following 9 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. However, not to fix it for now. Leave it in GEODE-4659. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. 9) CME && !originRemote: only enqueue to primary This closes #1317 > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364481#comment-16364481 ] ASF subversion and git services commented on GEODE-3967: Commit 5717053d08cdaa7ece96cb6c23905e444627dee3 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5717053 ] GEODE-3967: There're following 9 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. However, not to fix it for now. Leave it in GEODE-4659. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. 9) CME && !originRemote: only enqueue to primary > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363510#comment-16363510 ] ASF subversion and git services commented on GEODE-3967: Commit 974497c1da530e51569ed7965f2368e051894b98 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=974497c ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. However, not to fix it for now. Leave it in GEODE-4659. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. 9) CME && !originRemote: only enqueue to primary > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362754#comment-16362754 ] ASF subversion and git services commented on GEODE-3967: Commit 69c8eb8b1d10963e211943e558b48b0e705b9b0b in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=69c8eb8 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. However, not to fix it for now. Leave it in GEODE-4659. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. 9) CME && !originRemote: only enqueue to primary > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362448#comment-16362448 ] ASF subversion and git services commented on GEODE-3967: Commit 5d1c2657612bdb931724893f4e29dbd6056dfbae in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5d1c265 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. 9) CME && !originRemote: only enqueue to primary > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361382#comment-16361382 ] ASF subversion and git services commented on GEODE-3967: Commit 54eb3c56db8a28dc7549a045dde4c00f5d37e87c in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=54eb3c5 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. 7) change version to 150 8) CME event should not retry in AUO.doPutOrCreate, because retry will end up with CME too. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359755#comment-16359755 ] ASF subversion and git services commented on GEODE-3967: Commit 7d47d2a4cd19fe4a69a3a471a1ac7458466c9fd7 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d47d2a ] GEODE-3967: change version to 150 > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359754#comment-16359754 ] ASF subversion and git services commented on GEODE-3967: Commit 08755b7f10539ee96ed0b24eefc88ae4a534406a in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=08755b7 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354721#comment-16354721 ] ASF subversion and git services commented on GEODE-3967: Commit d6332e064b296df7d18225586fdb4b29422185cf in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d6332e0 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354399#comment-16354399 ] ASF subversion and git services commented on GEODE-3967: Commit eb48af8bc7f662c1e0a2ced536a0bcb47430a855 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eb48af8 ] GEODE-3967: There're following 5 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353469#comment-16353469 ] ASF subversion and git services commented on GEODE-3967: Commit c67d100feb2a2106866f42cbdc143ca887b48050 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c67d100 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. make event with CME to be ignored by dispatcher > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349167#comment-16349167 ] ASF subversion and git services commented on GEODE-3967: Commit fd25a6760e8db0f0e928d5e268f3380101eae3ca in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fd25a67 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. make event with CME to be ignored by dispatcher > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338907#comment-16338907 ] ASF subversion and git services commented on GEODE-3967: Commit 291b1c12154e7f58bd7a3a63e6981b0c405ebd80 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=291b1c1 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. make event with CME to be ignored by dispatcher > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336745#comment-16336745 ] ASF subversion and git services commented on GEODE-3967: Commit 15c3600c4c5799086fa36b26fa235bc57d473d26 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=15c3600 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. make event with CME to be ignored by dispatcher > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336535#comment-16336535 ] ASF subversion and git services commented on GEODE-3967: Commit fbcba952f788b2bfbd0c74684305d5eedfbf3096 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fbcba95 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. make event with CME to be ignored by dispatcher > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335283#comment-16335283 ] ASF subversion and git services commented on GEODE-3967: Commit ece79d0bdda2dc221f5d8a5de00bf637c8c89ca2 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ece79d0 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[
https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334986#comment-16334986
]
xiaojian zhou commented on GEODE-3967:
--
{noformat}
There are following race conditions contribute together to the bug:
1) When ConcurrentModificationException happened:
* if tag's timestamp is higher, then notifyGateSender with
UPDATE_VERSION_STAMP, which is creating a new event id.
* if tag's timestamp is lower, then do nothing.
In either way, the event for original event id not sent to the Gateway queue.
If this member happened to host the primary queue, the event in second queue
will not get a chance to cleanup. We should notify gatewaySender for event with
CME
2) UPDATE_VERSION_STAMP will have new event id. If this member happened to be a
secondary queue, then the event will stay there long or forever. We should
check if queue's primary, only enqueue UPDATE_VERSION_STAMP event when queue is
primary.
3) AUO.doPutOrCreate() will call basicUpdate() 3 times, or 3 tries: create,
update, create.
There's race that between update(2nd try) and create (3rd try), other thread
delete the entry caused the 2nd try failed, then before 3rd try, a create jump
in cause the 3rd try failed silently (no log and no exception, not to
notifyGatewaySender).
As the last try, it should use ifNew=false, ifOld=false to apply the put()
anyway.
{noformat}
> if put hits concurrent modification exception should still notify serial
> gateway sender
> ---
>
> Key: GEODE-3967
> URL: https://issues.apache.org/jira/browse/GEODE-3967
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>Priority: Major
> Labels: pull-request-available
>
> In serial gateway sender, the event arrives at secondary will be put into
> unprocessedMap and wait for event from primary queue to distribute over, then
> remove it from the unprocessedMap.
> If the put at primary member (member with primary queue) failed with CME, the
> event in unprocessedMap will never be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333424#comment-16333424 ] ASF subversion and git services commented on GEODE-3967: Commit 1bd019f430d6bc5c02f4da5434a3d81cd1f21496 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1bd019f ] GEODE-3967: event with CME should be distribued to parallel gateway sender > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1675#comment-1675 ] ASF subversion and git services commented on GEODE-3967: Commit 68054778c8030a88281cada6a693e72b935c9144 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=6805477 ] GEODE-3967: when ConcurrentCacheModificationException happened. GatewaySenderEventImpl should save the status and notify gatewaysender anyway. SerialGatewaySender will handle it. In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create and update. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1655#comment-1655 ] ASF subversion and git services commented on GEODE-3967: Commit 87672fa4ee3b7e130174f950d1e3f10e74d0f7a1 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=87672fa ] GEODE-3967: fix with isOld=false ifNew=false for the 3rd try > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332476#comment-16332476 ] ASF subversion and git services commented on GEODE-3967: Commit c1fd7c6ff1b7656d8b1e62e85f08060290576e89 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c1fd7c6 ] GEODE-3967: reduce some log > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331771#comment-16331771 ] ASF subversion and git services commented on GEODE-3967: Commit b2061392860bf28033072aa3304a9c77aba965d3 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b206139 ] GEODE-3967: trace into basicPut > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331555#comment-16331555 ] ASF subversion and git services commented on GEODE-3967: Commit 95549933eb13de9fd0c219b41ae071c67a4ecd2e in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9554993 ] GEODE-3967: add trace for exception > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331479#comment-16331479 ] ASF subversion and git services commented on GEODE-3967: Commit df66c915b925fb0719a8ac0abbbe718ed569bb06 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=df66c91 ] GEODE-3967: add more trace arround doPutOrCreate > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331432#comment-16331432 ] ASF GitHub Bot commented on GEODE-3967: --- gesterzhou closed pull request #1044: GEODE-3967: if put hits concurrent modification exception should stil… URL: https://github.com/apache/geode/pull/1044 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331407#comment-16331407 ] ASF subversion and git services commented on GEODE-3967: Commit 39ecfa9b5f7018c6c29ec6a8d1861f896bea6b58 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=39ecfa9 ] GEODE-3967: update the log > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323585#comment-16323585 ] ASF subversion and git services commented on GEODE-3967: Commit 5fa6ca55288c4efb83b07fdd77b80941bc74de47 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5fa6ca5 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender GEODE-3967: notifyTimestampsToGateways should inherit isConcurrencyConflict GEODE-3967: add to secondary event isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291429#comment-16291429 ] ASF subversion and git services commented on GEODE-3967: Commit 33b01b76ba952324a3974deac762eeb4d0d721cf in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=33b01b7 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender GEODE-3967: notifyTimestampsToGateways should inherit isConcurrencyConflict GEODE-3967: add to secondary event isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291430#comment-16291430 ] ASF subversion and git services commented on GEODE-3967: Commit 33b01b76ba952324a3974deac762eeb4d0d721cf in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=33b01b7 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender GEODE-3967: notifyTimestampsToGateways should inherit isConcurrencyConflict GEODE-3967: add to secondary event isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291431#comment-16291431 ] ASF subversion and git services commented on GEODE-3967: Commit 33b01b76ba952324a3974deac762eeb4d0d721cf in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=33b01b7 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender GEODE-3967: notifyTimestampsToGateways should inherit isConcurrencyConflict GEODE-3967: add to secondary event isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273962#comment-16273962 ] ASF subversion and git services commented on GEODE-3967: Commit 4bbe301f2285834321e828069d3691bbc7f22e5e in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bbe301 ] GEODE-3967: fix 3 > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273346#comment-16273346 ] ASF subversion and git services commented on GEODE-3967: Commit f619e36a79e276707a941072b1a47f0aa0ebd76d in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f619e36 ] GEODE-3967: fix 2 > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262091#comment-16262091 ] ASF subversion and git services commented on GEODE-3967: Commit e0bbd415763842b6621866e359b7d106838b2323 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e0bbd41 ] GEODE-3967: add to secondary event isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260154#comment-16260154 ] ASF subversion and git services commented on GEODE-3967: Commit fa343e1138f7468e1d63cc58621cd7cdd9b1bae1 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fa343e1 ] GEODE-3967: notifyTimestampsToGateways should inherit isConcurrencyConflict > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257319#comment-16257319 ] ASF subversion and git services commented on GEODE-3967: Commit 30185338b67b3954eac1c2ca46021a86efb71b89 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3018533 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257318#comment-16257318 ] ASF subversion and git services commented on GEODE-3967: Commit 13e02d10e3bc46755b6273042840afecf9deb588 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=13e02d1 ] GEODE-3967: change to use logger > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256558#comment-16256558 ] ASF subversion and git services commented on GEODE-3967: Commit 0ef35790a07b937d76f19acd2fd907ec98686b0e in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ef3579 ] GEODE-3967: isConcurrencyConflict is set for 3 notifyTimestampsToGateways > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256508#comment-16256508 ] ASF subversion and git services commented on GEODE-3967: Commit 744c74dbaf2a348d67e06ee34b7d4c2ad9b01da2 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=744c74d ] GEODE-3967: add more trace > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256306#comment-16256306 ] ASF subversion and git services commented on GEODE-3967: Commit 42aec6af306ce00836d3f38eeb22e0c504259a19 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=42aec6a ] GEODE-3967: add a case for invalidate > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252056#comment-16252056 ] ASF subversion and git services commented on GEODE-3967: Commit 2a7e453c110c33a43f18b88c7fbd77c12ecb1e06 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a7e453 ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251922#comment-16251922 ] ASF subversion and git services commented on GEODE-3967: Commit 9c29ebef3e3bce807bcb80d8c34cce076c1af0bc in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9c29ebe ] GEODE-3967: if put hits concurrent modification exception should still notify serial gateway sender > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247135#comment-16247135 ] ASF GitHub Bot commented on GEODE-3967: --- gesterzhou opened a new pull request #1044: GEODE-3967: if put hits concurrent modification exception should stil… URL: https://github.com/apache/geode/pull/1044 …l notify serial gateway sender @boglesby Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
