[jira] [Commented] (GEODE-4867) Query execution time expiration must stop all query execution
[ https://issues.apache.org/jira/browse/GEODE-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424390#comment-16424390 ] ASF subversion and git services commented on GEODE-4867: Commit 132dfc8950fe85f70c71eb0563eefb9f8dcb5f7f in geode's branch refs/heads/develop from nabarun [ https://gitbox.apache.org/repos/asf?p=geode.git;h=132dfc8 ] GEODE-4867: Unused imports * Removed unused imports from the previous commit. > Query execution time expiration must stop all query execution > - > > Key: GEODE-4867 > URL: https://issues.apache.org/jira/browse/GEODE-4867 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun >Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > *+Current behavior+* : > When the query execution time expires in the QueryMonitor, the isCancelled > boolean is set. But this is used in only once in the > executeQueryOnRemoteAndLocalNodes in DefaultQuery but this is checked at the > end after the entire query is executed. > This results in entire query being executed even though the time for query > execution had expired. > *+Solution+* : > The time expiration flag needs to be checked in a similar fashion as > isLowMemory, which is checked in nearly every step of execution of the query > hence the query is stopped when the execution time had expired. > [no checks needed in the index module] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4867) Query execution time expiration must stop all query execution
[ https://issues.apache.org/jira/browse/GEODE-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422787#comment-16422787 ] ASF subversion and git services commented on GEODE-4867: Commit 750417f7b8213e23dc70823256754df3698ad1c6 in geode's branch refs/heads/develop from [~nabarunnag] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=750417f ] GEODE-4867: Added query time expiration checks. (#1624) * Along with low memory checks, the query execution time limit is also checked. > Query execution time expiration must stop all query execution > - > > Key: GEODE-4867 > URL: https://issues.apache.org/jira/browse/GEODE-4867 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > *+Current behavior+* : > When the query execution time expires in the QueryMonitor, the isCancelled > boolean is set. But this is used in only once in the > executeQueryOnRemoteAndLocalNodes in DefaultQuery but this is checked at the > end after the entire query is executed. > This results in entire query being executed even though the time for query > execution had expired. > *+Solution+* : > The time expiration flag needs to be checked in a similar fashion as > isLowMemory, which is checked in nearly every step of execution of the query > hence the query is stopped when the execution time had expired. > [no checks needed in the index module] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
