[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase
[
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984024#comment-16984024
]
ASF subversion and git services commented on GEODE-5175:
Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]
GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest
Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
hang
Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently
Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest
Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService
Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances
Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender
> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
> Issue Type: Improvement
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase
[
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984008#comment-16984008
]
ASF subversion and git services commented on GEODE-5175:
Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]
GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest
Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
hang
Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently
Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest
Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService
Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances
Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender
> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
> Issue Type: Improvement
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase
[
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983946#comment-16983946
]
ASF subversion and git services commented on GEODE-5175:
Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]
GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest
Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
hang
Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently
Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest
Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService
Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances
Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender
> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
> Issue Type: Improvement
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase
[
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489717#comment-16489717
]
ASF subversion and git services commented on GEODE-5175:
Commit d6d97aaea4c5fef060ff918c8d85a85f3a7f123a in geode's branch
refs/heads/feature/GEODE-5145 from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d6d97aa ]
GEODE-974: Fix PersistentPartitionedRegionDistributedTest
* Rename PersistentPartitionedRegionDUnitTest ->
PersistentPartitionedRegionDistributedTest
* Remove dependency on PersistentPartitionedRegionTestBase (GEODE-5175)
* Rename all test methods
* Overhaul test to use JUnit Rules, Awaitility and AssertJ
Fix all flaky issues in this test:
* GEODE-974: testRevokeBeforeStartup
* GEODE-1047: testMissingMemberRedundancy1
* GEODE-1208: testBug42226
* GEODE-1582: testCleanStop
* GEODE-1738: testCrashDuringBucketCreation
* GEODE-4418: testCleanupAfterConflict
> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
> Issue Type: Improvement
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase
[
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479821#comment-16479821
]
ASF subversion and git services commented on GEODE-5175:
Commit d6d97aaea4c5fef060ff918c8d85a85f3a7f123a in geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d6d97aa ]
GEODE-974: Fix PersistentPartitionedRegionDistributedTest
* Rename PersistentPartitionedRegionDUnitTest ->
PersistentPartitionedRegionDistributedTest
* Remove dependency on PersistentPartitionedRegionTestBase (GEODE-5175)
* Rename all test methods
* Overhaul test to use JUnit Rules, Awaitility and AssertJ
Fix all flaky issues in this test:
* GEODE-974: testRevokeBeforeStartup
* GEODE-1047: testMissingMemberRedundancy1
* GEODE-1208: testBug42226
* GEODE-1582: testCleanStop
* GEODE-1738: testCrashDuringBucketCreation
* GEODE-4418: testCleanupAfterConflict
> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
> Issue Type: Improvement
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
