[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547205#comment-16547205 ] ASF subversion and git services commented on GEODE-5292: Commit f6c26f0a30b27d2636c9f8d43c089332ccd50150 in geode's branch refs/heads/feature/GEODE-5376 from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f6c26f0 ] GEODE-5292: Flushing to disk in test before introducing spy in test (#2140) This test was modifying the concurrent region map to introduce a spy, but there was a concurrent thread overflowing entries to disk at the same time. An interaction between the spy and the async flush caused the ref count to go to 0, and the test to fail before it even got to the point of clearing the region. Flushing the disk before introducing the spy. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Assignee: Dan Smith >Priority: Major > Labels: pull-request-available, swat > Fix For: 1.8.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545630#comment-16545630 ] ASF subversion and git services commented on GEODE-5292: Commit f6c26f0a30b27d2636c9f8d43c089332ccd50150 in geode's branch refs/heads/develop from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f6c26f0 ] GEODE-5292: Flushing to disk in test before introducing spy in test (#2140) This test was modifying the concurrent region map to introduce a spy, but there was a concurrent thread overflowing entries to disk at the same time. An interaction between the spy and the async flush caused the ref count to go to 0, and the test to fail before it even got to the point of clearing the region. Flushing the disk before introducing the spy. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Assignee: Dan Smith >Priority: Major > Labels: pull-request-available, swat > Fix For: 1.8.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542295#comment-16542295 ] ASF subversion and git services commented on GEODE-5292: Commit e4bd46d71d0a8166868fc1505284e31972e1e842 in geode's branch refs/heads/feature/GEODE-5145 from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e4bd46d ] Revert "[GEODE-5292] Actually destroy the region instead of pretending to." This reverts commit 9037d42bf291b504fea98bff4c851aac15e0625c. This commit is causing IntegrationTest to fail in the CI pipeline. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Assignee: Dan Smith >Priority: Major > Labels: pull-request-available, swat > Fix For: 1.8.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539356#comment-16539356 ] ASF subversion and git services commented on GEODE-5292: Commit e4bd46d71d0a8166868fc1505284e31972e1e842 in geode's branch refs/heads/develop from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e4bd46d ] Revert "[GEODE-5292] Actually destroy the region instead of pretending to." This reverts commit 9037d42bf291b504fea98bff4c851aac15e0625c. This commit is causing IntegrationTest to fail in the CI pipeline. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Assignee: Dan Smith >Priority: Major > Labels: pull-request-available, swat > Fix For: 1.8.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537788#comment-16537788 ] ASF subversion and git services commented on GEODE-5292: Commit 9037d42bf291b504fea98bff4c851aac15e0625c in geode's branch refs/heads/develop from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9037d42 ] [GEODE-5292] Actually destroy the region instead of pretending to. Signed-off-by: Dan Smith > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Assignee: Dan Smith >Priority: Major > Labels: pull-request-available, swat > Fix For: 1.8.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508460#comment-16508460 ] ASF subversion and git services commented on GEODE-5292: Commit 2d97c22e3bab7fe0b7d25efb2fb842969dfde5fb in geode's branch refs/heads/GEM-1722-1629 from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d97c22 ] GEODE-5292: Ignoring flaky ConcurrentRegion... test until we can fix it This test has failed twice in CI for different reasons. Disabling it until we can fix it. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506264#comment-16506264 ] ASF subversion and git services commented on GEODE-5292: Commit 2d97c22e3bab7fe0b7d25efb2fb842969dfde5fb in geode's branch refs/heads/develop from Dan Smith [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d97c22 ] GEODE-5292: Ignoring flaky ConcurrentRegion... test until we can fix it This test has failed twice in CI for different reasons. Disabling it until we can fix it. > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > Time Spent: 50m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory
[ https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504818#comment-16504818 ] ASF subversion and git services commented on GEODE-5292: Commit 69c871091d570312264c4e7e5060109cab4c8d64 in geode's branch refs/heads/develop from Bradford Boyle [ https://gitbox.apache.org/repos/asf?p=geode.git;h=69c8710 ] GEODE-5292: Fix memory leak for off heap regions with overflow For a region that has been configured with off-heap storage and overflow to disk, memory can be leaked if - region clear - region destroy - region replace all happen concurrently. The root cause appears to be region clear modifying entries for values stored on disk without synchronizing the entries. This prevents replace from freeing the off-heap memory for the new value when the replace fails because the region is being destroyed. This commit adds an integration test that uses spies on a region entry to trigger the concurrent events during a replace operation and checks for orphaned off-heap memory. The proposed fix is to not modify the region entries on disk while performing a clear operation. Signed-off-by: Dan Smith > Replace with concurrent clear and destroy leaks off heap memory > --- > > Key: GEODE-5292 > URL: https://issues.apache.org/jira/browse/GEODE-5292 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > For a region that has been configured with off-heap storage and overflow to > disk, memory can be leaked if > * region clear > * region destroy > * region replace > all happen concurrently. The root cause appears to be region clear modifying > entries for values stored on disk without synchronizing the entries. This > prevents replace from freeing the off-heap memory for the new value when the > replace fails because the region is being destroyed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
