[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988166#comment-16988166 ] ASF subversion and git services commented on GEODE-7507: Commit 0c1b33f586fff12ae8c3c9fef1635cac792eee09 in geode's branch refs/heads/develop from Bruce Schuchardt [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0c1b33f ] GEODE-7507 remove GMSMembership's dependency on DistributionMessage (#4384) * GEODE-7507 remove GMSMembership's dependency on DistributionMessage Prior to this change-set the membership module wrapped all messages in a GMSMessageAdapter. This is no longer necessary and I've deleted that class. Instead, our messages now implement GMSMessage (now renamed DistributionMessage) and the geode-core abstract DistributionMessage class (now renamed ClusterMessage) implements the membership module's API. Most of the files in the diff are only affected by the renaming of GMSMessage and DistributionMessage. The primary changes are in GMSManager and DistributionMessage (now named ClusterMessage). * rebase on develop, rename DistributionMessageObserver * making pmdMain happy * revert renaming message class/interface * fix serialization test * rename GMSMessage to Message * fixes for Dan's comments * addressing pmdMain issue * removing DistributionMessage from another arch unit test > remove GMSMembership's dependency on DistributionMessage > > > Key: GEODE-7507 > URL: https://issues.apache.org/jira/browse/GEODE-7507 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > GMSMembership should not refer to DistributionMessage, a geode-core class. > This is preventing membership from being moved to a separate sub-project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988165#comment-16988165 ] ASF subversion and git services commented on GEODE-7507: Commit 0c1b33f586fff12ae8c3c9fef1635cac792eee09 in geode's branch refs/heads/develop from Bruce Schuchardt [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0c1b33f ] GEODE-7507 remove GMSMembership's dependency on DistributionMessage (#4384) * GEODE-7507 remove GMSMembership's dependency on DistributionMessage Prior to this change-set the membership module wrapped all messages in a GMSMessageAdapter. This is no longer necessary and I've deleted that class. Instead, our messages now implement GMSMessage (now renamed DistributionMessage) and the geode-core abstract DistributionMessage class (now renamed ClusterMessage) implements the membership module's API. Most of the files in the diff are only affected by the renaming of GMSMessage and DistributionMessage. The primary changes are in GMSManager and DistributionMessage (now named ClusterMessage). * rebase on develop, rename DistributionMessageObserver * making pmdMain happy * revert renaming message class/interface * fix serialization test * rename GMSMessage to Message * fixes for Dan's comments * addressing pmdMain issue * removing DistributionMessage from another arch unit test > remove GMSMembership's dependency on DistributionMessage > > > Key: GEODE-7507 > URL: https://issues.apache.org/jira/browse/GEODE-7507 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > GMSMembership should not refer to DistributionMessage, a geode-core class. > This is preventing membership from being moved to a separate sub-project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984029#comment-16984029 ] ASF subversion and git services commented on GEODE-7507: Commit 8c42458f71a6ab4853be3971bae5fed756cd009a in geode's branch refs/heads/feature/GEODE-7507 from Bruce Schuchardt [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8c42458 ] GEODE-7507 remove GMSMembership's dependency on DistributionMessage Prior to this change-set the membership module wrapped all messages in a GMSMessageAdapter. This is no longer necessary and I've deleted that class. Instead, our messages now implement GMSMessage (now renamed DistributionMessage) and the geode-core abstract DistributionMessage class (now renamed ClusterMessage) implements the membership module's API. Most of the files in the diff are only affected by the renaming of GMSMessage and DistributionMessage. The primary changes are in GMSManager and DistributionMessage (now named ClusterMessage). > remove GMSMembership's dependency on DistributionMessage > > > Key: GEODE-7507 > URL: https://issues.apache.org/jira/browse/GEODE-7507 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > GMSMembership should not refer to DistributionMessage, a geode-core class. > This is preventing membership from being moved to a separate sub-project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984014#comment-16984014 ] ASF subversion and git services commented on GEODE-7507: Commit 8c42458f71a6ab4853be3971bae5fed756cd009a in geode's branch refs/heads/feature/GEODE-7507 from Bruce Schuchardt [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8c42458 ] GEODE-7507 remove GMSMembership's dependency on DistributionMessage Prior to this change-set the membership module wrapped all messages in a GMSMessageAdapter. This is no longer necessary and I've deleted that class. Instead, our messages now implement GMSMessage (now renamed DistributionMessage) and the geode-core abstract DistributionMessage class (now renamed ClusterMessage) implements the membership module's API. Most of the files in the diff are only affected by the renaming of GMSMessage and DistributionMessage. The primary changes are in GMSManager and DistributionMessage (now named ClusterMessage). > remove GMSMembership's dependency on DistributionMessage > > > Key: GEODE-7507 > URL: https://issues.apache.org/jira/browse/GEODE-7507 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > GMSMembership should not refer to DistributionMessage, a geode-core class. > This is preventing membership from being moved to a separate sub-project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983986#comment-16983986 ] ASF subversion and git services commented on GEODE-7507: Commit 9e65bd9bc4d5945acfbc0028eac8c43a0c0a32d5 in geode's branch refs/heads/feature/GEODE-7507 from Bruce Schuchardt [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9e65bd9 ] GEODE-7507 remove GMSMembership's dependency on DistributionMessage Prior to this change-set the membership module wrapped all messages in a GMSMessageAdapter. This is no longer necessary and I've deleted that class. Instead, our messages now implement GMSMessage (now renamed DistributionMessage) and the geode-core abstract DistributionMessage class (now renamed ClusterMessage) implements the membership module's API. Most of the files in the diff are only affected by the renaming of GMSMessage and DistributionMessage. The primary changes are in GMSManager and DistributionMessage (now named ClusterMessage). > remove GMSMembership's dependency on DistributionMessage > > > Key: GEODE-7507 > URL: https://issues.apache.org/jira/browse/GEODE-7507 > Project: Geode > Issue Type: Improvement > Components: membership >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > > GMSMembership should not refer to DistributionMessage, a geode-core class. > This is preventing membership from being moved to a separate sub-project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
